[dev-servo] CSC 517 OSS Project

2019-03-07 Thread Niveditha Shankar
Hello, I am Niveditha Shankar doing my masters at NC State. As a part of the CSC 517 OSS project, I have been assigned 'Refactor Bluetooth Support Student Project'. I am working with Sruthi Kannan and Shanmukha Jaya Harsha Alluri for the same. Just wanted to introduce the team. Is ther

Re: [dev-servo] CSC 517 OSS Project

2019-03-22 Thread Niveditha Shankar
brief us more on this - "Modify Servo's integration to use this new trait" And also, is there any other similar implementation for this conversion that we can refer to? Thank you Niveditha Shankar On Fri, Mar 8, 2019 at 10:39 PM Josh Bowman-Matthews wrote: > > Welcome! On

Re: [dev-servo] CSC 517 OSS Project

2019-03-23 Thread Niveditha Shankar
check our code with. Thank you! Niveditha Shankar On Sat, Mar 23, 2019 at 12:34 AM Niveditha Shankar wrote: > > Hello > Just wanted to make sure that we are working with the correct part of the > code, > To convert the BluetoothAdapter from enum to trait, are we right in > ass

Re: [dev-servo] CSC 517 OSS Project

2019-03-23 Thread Niveditha Shankar
issue for mac. We can then go ahead run the automated tests for bluetooth and check the existing output. Thank you! Niveditha Shankar On Sat, Mar 23, 2019 at 11:57 AM Josh Bowman-Matthews wrote: > These are all good questions! You are correct about the reference to the > code that you w

Re: [dev-servo] CSC 517 OSS Project

2019-03-25 Thread Niveditha Shankar
ifying all the doubts! Niveditha Shankar On Sun, Mar 24, 2019 at 2:19 PM Josh Bowman-Matthews wrote: > If you are building on macOS, then you are probably hitting the problem > described in https://github.com/servo/servo/issues/21792. The solution > is to install the XCode 10.2 beta &g

Re: [dev-servo] CSC 517 OSS Project

2019-03-25 Thread Niveditha Shankar
Hi I tried to build the project in windows and got the following error `link.exe` failed: exit code: 1181 ' I have attached the log file below Niveditha Shankar On Mon, Mar 25, 2019 at 1:31 PM Josh Bowman-Matthews wrote: > On 3/25/19 12:49 PM, Niveditha Shankar wrote: > > T

Re: [dev-servo] CSC 517 OSS Project

2019-03-25 Thread Niveditha Shankar
And now it just comes out of the build without displaying any success/error message(doesnt run anything either) On Mon, Mar 25, 2019 at 8:23 PM Niveditha Shankar wrote: > Hi > I tried to build the project in windows and got the following error > `link.exe` failed: exit code: 1181 &#x

Re: [dev-servo] CSC 517 OSS Project

2019-03-25 Thread Niveditha Shankar
issues/22011> is > related, if yes, you might be able to refer to the last comment from > learning > <https://github.com/servo/servo/issues/22011#issuecomment-457434408> to > see > if it helps. > > Cheers, > CYBAI > > On Tue, Mar 26, 2019 at 9:23 AM Nived

Re: [dev-servo] CSC 517 OSS Project

2019-03-27 Thread Niveditha Shankar
Hi I dont face that issue anymore. I deleted the servo repo and cloned it again and tried again. Now I face 'error: linking with `link.exe` failed: exit code: 1181' error. I have attached the log file below Niveditha Shankar On Tue, Mar 26, 2019 at 12:48 PM Josh Bowman-Matthews w

Re: [dev-servo] CSC 517 OSS Project

2019-03-27 Thread Niveditha Shankar
gt; > On 3/27/19 9:50 PM, Niveditha Shankar wrote: > > Hi > > I dont face that issue anymore. I deleted the servo repo and cloned it > > again and tried again. > > > > Now I face 'error: linking with `link.exe` failed: exit code: 1181' > error. >

Re: [dev-servo] CSC 517 OSS Project

2019-03-28 Thread Niveditha Shankar
e terminal window to ensure that the changes are picked up. > > On 3/28/19 1:47 AM, Niveditha Shankar wrote: > > > https://gist.github.com/NivedithaShankar/6850daeb74eede93e560f20bf3566573 > > > > On Thu, Mar 28, 2019 at 1:25 AM Josh Bowman-Matthews < > j...@joshmatthew

Re: [dev-servo] CSC 517 OSS Project

2019-03-28 Thread Niveditha Shankar
gt; Josh > > On 3/28/19 1:00 PM, Niveditha Shankar wrote: > > Hello Josh > > I added the path to LIB variable and checked if the changes were > reflected. > > But I am still getting the same link error. > > > > > https://gist.github.com/NivedithaShankar/47f

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-30 Thread Niveditha Shankar
. Sincerely Niveditha Shankar On Sat, Mar 30, 2019 at 12:26 AM Josh Bowman-Matthews wrote: > That sounds like the right idea. I'm not quite sure what this question > is asking, however: > > > Are we right in assuming that the current BluetoothAdapter function > has to > >

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-30 Thread Niveditha Shankar
ahead and do something similar for the rest of the enum values. It would be really helpful if there is a way to check that. Niveditha Shankar On Sat, Mar 30, 2019, 12:25 PM Josh Bowman-Matthews The init functions are actually a bit special, because they can't be > turned into static me

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-30 Thread Niveditha Shankar
/Similarly for Mac/Android/Empty/BluetoothTest -Niveditha Shankar On Sat, Mar 30, 2019 at 11:40 AM Niveditha Shankar wrote: > Thank you! > We meant to ask if code in > https://github.com/servo/devices/blob/d6c62e0873b2ec9a68c97a3370667e8b9a879cf4/src/bluetooth.rs#L276-L305 > sho

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Niveditha Shankar
dapter::Empty(Arc::new(adapter))) 159 | | } | |_^ doesn't have a size known at compile-time -Niveditha Shankar On Sat, Mar 30, 2019 at 1:09 PM Josh Bowman-Matthews wrote: > Yes - use a Cargo override to build Servo with your local modified > version of the devices cr

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Niveditha Shankar
sers/jayaharsha/Desktop/devices" } -Niveditha Shankar On Sun, Mar 31, 2019 at 5:27 PM Josh Bowman-Matthews wrote: > Those errors are difficult to diagnose without seeing the rest of the > code. However, given that BluetoothAdapter is supposed to be a trait > now, the second f

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Niveditha Shankar
t would be helpful if I had a better understanding of Bluez(Arc). Thank you! Niveditha Shankar On Sun, Mar 31, 2019 at 8:32 PM Josh Bowman-Matthews wrote: > The devices crate is a crates.io dependency rather than a github one, > since we publish new changes to crates.io. That means adding a

Re: [dev-servo] Regarding CSC 517 OSS project

2019-04-01 Thread Niveditha Shankar
Thanks for clarifying the doubt! We were doing exactly this but did not know how to access the respective properties under BluetoothAdapter. Now we get it! -Niveditha Shankar On Mon, Apr 1, 2019 at 10:23 AM Josh Bowman-Matthews wrote: > Previously we had an enum > (https://doc.rust-la

Re: [dev-servo] Regarding CSC 517 OSS project

2019-04-26 Thread Niveditha Shankar
eplace Option with Option which only gave out more errors. -Niveditha Shankar On Thu, Apr 25, 2019 at 4:53 PM Niveditha Shankar wrote: > Hi Josh, > > We tried to run servo with our modified devices crate. > > Now we are getting the following errors, > > *error