[GitHub] [httpcomponents-client] arturobernalg commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
arturobernalg commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974766813 > Oh wow yes it's quite a bit more involved; looked into it just now, but the whole hierarchy down from

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Oleg Kalnichevski
On Sat, 2021-11-20 at 12:25 -0500, Karl Wright wrote: > These protocols are, unfortunately, still used. > > However, the projects I know that use them have not yet moved to 5.x > of > httpcomponents. Other projects I know of that used to use > httpcomponents > have since upgraded to different

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Michael Osipov
Am 2021-11-20 um 18:25 schrieb Karl Wright: These protocols are, unfortunately, still used. ManifoldCF, which does much integration with windows systems, supports Kerberos but only in the most hacky way, because there wasn't anything more seamless available. I would therefore counter-propose

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Tim te Beek (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446879#comment-17446879 ] Tim te Beek commented on HTTPCLIENT-2187: - Could be; I had looked through the changes but

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Karl Wright
These protocols are, unfortunately, still used. However, the projects I know that use them have not yet moved to 5.x of httpcomponents. Other projects I know of that used to use httpcomponents have since upgraded to different http libraries that supported http 2.0 early on. The hint that all it

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Michael Osipov
Am 2021-11-20 um 19:35 schrieb Oleg Kalnichevski: On Sat, 2021-11-20 at 12:25 -0500, Karl Wright wrote: These protocols are, unfortunately, still used. However, the projects I know that use them have not yet moved to 5.x of httpcomponents. Other projects I know of that used to use

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread larry mccay
Hi - I am the Apache Knox PMC chair and a committer on Hadoop and other ecosystem projects. FYI, Apache Knox is indeed dependent on SPNEGO in httpclient. Knox is a Hadoop ecosystem gateway and as part of the trusted proxy or proxyuser pattern within Hadoop it requires all proxies that dispatch

[jira] [Updated] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Tim te Beek (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim te Beek updated HTTPCLIENT-2187: Description: Classic proxy handling for HTTPS seems to have broken as of 5.1.1+, as

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446878#comment-17446878 ] Oleg Kalnichevski commented on HTTPCLIENT-2187: --- [~timtebeek] All our integration

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Michael Osipov
Am 2021-11-20 um 20:46 schrieb larry mccay: Hi - I am the Apache Knox PMC chair and a committer on Hadoop and other ecosystem projects. FYI, Apache Knox is indeed dependent on SPNEGO in httpclient. Knox is a Hadoop ecosystem gateway and as part of the trusted proxy or proxyuser pattern within

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Tim te Beek (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446909#comment-17446909 ] Tim te Beek commented on HTTPCLIENT-2187: - Was able to find this place in the codebase where

[GitHub] [httpcomponents-client] timtebeek commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
timtebeek commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974708950 Noticed you're using `@EnableRuleMigrationSupport` to retain `@RunWith(Parameterized.class)`. Are you aware of [this automated JUnit Jupiter migration for

[GitHub] [httpcomponents-client] ok2c commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
ok2c commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974716993 > Noticed you're using `@EnableRuleMigrationSupport` to retain `@RunWith(Parameterized.class)`. Are you aware of [this automated JUnit Jupiter migration for

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446885#comment-17446885 ] Oleg Kalnichevski commented on HTTPCLIENT-2187: --- [~timtebeek]  Request execution via

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread larry mccay
This is a concerning statement and I need some additional information to determine what sort of risk is inherent in the current implementation. Perhaps we should take those details off list if this is a security issue. I'll need to determine whether there are any workarounds or usage patterns

Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Oleg Kalnichevski
Folks Presently NTLM & SPNEGO are stated as supported authentication schemes, by the project which is, quite frankly, not the case. There are partial implementations in various state of decay contributed some while ago by contributors long gone with no one on the project both capable and willing

[jira] [Created] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Tim te Beek (Jira)
Tim te Beek created HTTPCLIENT-2187: --- Summary: Classic proxy handling for HTTPS seems broken as of 5.1.1+ Key: HTTPCLIENT-2187 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2187 Project:

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Karl Wright
This is not a security issue. The implementation of NTLM is just as secure as the Microsoft implementation. That's not terribly secure but that's inherent in their design. Karl On Sat, Nov 20, 2021 at 7:02 PM larry mccay wrote: > This is a concerning statement and I need some additional

Re: Gradual deprecation and removal of NTLM and SPNEGO support

2021-11-20 Thread Michael Osipov
Am 2021-11-20 um 17:41 schrieb Oleg Kalnichevski: Folks Presently NTLM & SPNEGO are stated as supported authentication schemes, by the project which is, quite frankly, not the case. There are partial implementations in various state of decay contributed some while ago by contributors long gone

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446873#comment-17446873 ] Michael Osipov commented on HTTPCLIENT-2187: This means that {{CONNECT}} does not work?

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Tim te Beek (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446880#comment-17446880 ] Tim te Beek commented on HTTPCLIENT-2187: - So I ran

[jira] [Commented] (HTTPCLIENT-2187) Classic proxy handling for HTTPS seems broken as of 5.1.1+

2021-11-20 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446884#comment-17446884 ] Oleg Kalnichevski commented on HTTPCLIENT-2187: --- [~timtebeek] I see neither an

[GitHub] [httpcomponents-client] timtebeek commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
timtebeek commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974721351 Oh wow yes it's quite a bit more involved; looked into it just now, but the whole hierarchy down from

[jira] [Created] (HTTPCORE-700) HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread Arturo Bernal (Jira)
Arturo Bernal created HTTPCORE-700: -- Summary: HttpHost genetic constructor NamedEndpoint Key: HTTPCORE-700 URL: https://issues.apache.org/jira/browse/HTTPCORE-700 Project: HttpComponents HttpCore

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-20 Thread GitBox
arturobernalg commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974617494 https://docs.oracle.com/javase/tutorial/essential/exceptions/runtime.html "Having to add runtime exceptions in every method declaration would reduce a

[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
arturobernalg commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753675344 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {

[GitHub] [httpcomponents-core] arturobernalg closed pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
arturobernalg closed pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [httpcomponents-core] ok2c commented on pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
ok2c commented on pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#issuecomment-974651675 @arturobernalg Please also close the associated JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Closed] (HTTPCORE-700) HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed HTTPCORE-700. -- Resolution: Won't Do Won't do. it can lead to incorrect / unpredictable results. > HttpHost

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
arturobernalg commented on pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#issuecomment-974652486 > @arturobernalg Please also close the associated JIRA. done. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [httpcomponents-core] ok2c commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
ok2c commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974652865 @arturobernalg Looks good to me. > Guys, I am still not sure whether this is the right decision for now since we are likely going to maintain 5.1.x on Java 7 for

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
arturobernalg commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974653321 > @arturobernalg Looks good to me. > > > Guys, I am still not sure whether this is the right decision for now since we are likely going to maintain 5.1.x

[GitHub] [httpcomponents-core] michael-o commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
michael-o commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974653459 > @arturobernalg Looks good to me. > > > Guys, I am still not sure whether this is the right decision for now since we are likely going to maintain 5.1.x on

[GitHub] [httpcomponents-core] ok2c merged pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
ok2c merged pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [httpcomponents-core] ok2c commented on pull request #331: HTTPCORE-698 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
ok2c commented on pull request #331: URL: https://github.com/apache/httpcomponents-core/pull/331#issuecomment-974657699 > can I help you? @arturobernalg No immediate help is needed. But if you really want to help, please spend less time changing code style based on personal taste

[jira] [Commented] (HTTPCORE-698) Migrate Test to Unit 5

2021-11-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17446831#comment-17446831 ] ASF subversion and git services commented on HTTPCORE-698: -- Commit

[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-20 Thread GitBox
ok2c commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974627983 I can and I do because I find explicit declaration of exceptions more useful than javadocs. The above statement from Oracle is silly. -- This is an automated message

[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
arturobernalg commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753672231 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {

[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
arturobernalg commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753672231 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
ok2c commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753662822 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {

[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
arturobernalg commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753672231 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
ok2c commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753673296 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

2021-11-20 Thread GitBox
ok2c commented on a change in pull request #333: URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753674363 ## File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java ## @@ -69,6 +73,27 @@ public void testConstructor() {