[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: EFI Redfish Discover Protocol

EDK2 EFI Redfish Discover Protocol implementation. Refer to UEFI spec 2.9 section 31.1. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Fan Wang Cc: Jiewen Yao --- RedfishPkg/RedfishComponents.dsc.inc |3 +- RedfishPkg/Redfish.fdf.inc

Re: [edk2-devel] [edk2-test][Patch 1/1] ImageIndex need be corrected to range 1 ~ DescriptorCount.

Reviewed-by: Barton Gao > On 2021/3/22 14:12, Eric Jin wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3272 The goal of the Support Routine: CheckForSupportGetImage is to detect the current FMP instance's capability for supporting GetImage(). In current

Re: [edk2-devel] [patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg

Thanks Mike. I will submit a new version to address that. Thanks, Dandan > -Original Message- > From: Kinney, Michael D > Sent: Friday, March 26, 2021 8:49 AM > To: Bi, Dandan ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Liming Gao ; Liu, Zhiguang > ; Laszlo Ersek > Subject: RE:

回复: [edk2-devel] [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gao, Zhichao > 发送时间: 2021年3月26日 8:50 > 收件人: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > 抄送: Ni, Ray ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) ; > Liming Gao > 主题: Re: [edk2-devel] [PATCH v4

Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, March 26, 2021 8:42 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 ; > Kun Qin > Subject: [edk2-devel] [PATCH v1 1/1]

Re: [edk2-devel] [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

You can push with the correction and add my R-B. No need to send V5 if there is no more comment for your patch set. Thanks, Zhichao > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, March 25, 2021 7:36 PM > To: Gao, Zhichao ; devel@edk2.groups.io >

Re: [edk2-devel] [patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg

Dandan, I have a concern about the context of the dsc.inc file. You assume that the MdeLibs.dsc.inc file will be included from the common [LibraryClasses] section. This means that this dsc.inc file can not be extended to support CPU arch specific lib mappings. I recommend this dsc.inc file

[edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3277 Initializes the Status variable in TcgMmReadyToLock(). Fixes a Clang build failure: Tcg2Smm.c - SecurityPkg\Tcg\Tcg2Smm\Tcg2Smm.c:254:7: error: variable 'Status' is used uninitialized whenever 'if' condition is false

Re: [edk2-devel] [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, March 22, 2021 4:10 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1 Subject: [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib REF:

Re: [edk2-devel] [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: devel@edk2.groups.io on behalf of Laszlo Ersek Sent: Tuesday, March 23, 2021 2:32:02 AM To: Bi, Dandan ; devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul1 Subject: Re:

Re: [edk2-devel] [edk2-platforms] [patch V2 26/35] Silicon/IntelSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: devel@edk2.groups.io on behalf of Dandan Bi Sent: Monday, March 22, 2021 4:53:52 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-devel] [edk2-platforms]

Re: [edk2-devel] [edk2-platforms] [patch V2 03/35] Drivers/OptionRomPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: Bi, Dandan Sent: Monday, March 22, 2021 4:20:08 PM To: devel@edk2.groups.io Cc: Ni, Ray Subject: [edk2-platforms] [patch V2 03/35] Drivers/OptionRomPkg: Consume MdeLibs.dsc.inc for

Re: [edk2-devel] [edk2-platforms] [patch V2 26/35] Silicon/IntelSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: Bi, Dandan Sent: Monday, March 22, 2021 4:20:31 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms] [patch V2 26/35] Silicon/IntelSiliconPkg: Consume

Re: [edk2-devel] [patch V2 18/29] PcAtChipsetPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: Bi, Dandan Sent: Monday, March 22, 2021 4:09:30 PM To: devel@edk2.groups.io Cc: Ni, Ray Subject: [patch V2 18/29] PcAtChipsetPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib REF:

Re: [edk2-devel] [patch V2 10/29] FatPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: Bi, Dandan Sent: Monday, March 22, 2021 4:09:22 PM To: devel@edk2.groups.io Cc: Ni, Ray Subject: [patch V2 10/29] FatPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib REF:

Re: [edk2-devel] [patch V2 09/29] EmulatorPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: ray...@intel.com thanks, ray From: Bi, Dandan Sent: Monday, March 22, 2021 4:09:21 PM To: devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray Subject: [patch V2 09/29] EmulatorPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib REF:

Re: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock

Yes, this is expected behavior. The messages are to encourage code owners to move from using the VariableLockRequestToLock() interface to the VariablePolicy interface so that the RTL interface may be removed in the future. The correct solution is to find the offending code and submit a patch

Re: [edk2-devel] [PATCH v2] OvmfPkg: strip build paths in release builds

> On Mar 25, 2021, at 10:19 AM, Laszlo Ersek wrote: > > On 03/25/21 00:25, Andrew Fish wrote: >> This breaks some usage we have have in our fork. We have symbols turned on >> for Release builds, so this change would break that. >> >> It looks to me that the root cause of this issue might be

Re: [edk2-devel] [PATCH] RISC-V/PlatformPkg: Fix compilation breakage in OpenSBI

On Thu, Mar 25, 2021 at 01:46 AM, Abner Chang wrote: > > Hi Loic, > The current edk2 RISC-V is incorporated with opensbi v0.8, please check > below link > https://github.com/riscv/riscv-uefi-edk2-docs Yes, I think this is the version I used. In fact I followed

Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock

Hi Bret, can you help Marcin please? Thanks Laszlo On 03/25/21 10:19, Marcin Wojtas wrote: > Hi, > > When booting the latest edk2 on Marvell SoCs I get a number of prints as > below: > > !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon! > !!! DEPRECATED INTERFACE !!!

Re: [edk2-devel] [EXTERNAL] [patch V2 27/29] UnitTestFrameworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Thanks, Dandan! Apologies if this has already been asked, but is this necessary because C doesn’t have any options for symbol namespacing? In other words, would it be just as easy to do this with a new implementation of IoLib if we didn’t have to worry about the symbol collisions? - Bret

Re: [edk2-devel] [PATCH v2 0/7] OvmfXen: Set PcdFSBClock at runtime

On 03/25/21 16:47, Anthony PERARD wrote: > Patch series available in this git branch: > git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v2 I'll get to this sometime in April, possibly after the SEV-SNP series. That shouldn't discourage others from reviewing sooner, of course.

Re: 回复: [edk2-devel] 回复: [RESEND v2] MdePkg: use CpuPause() in CpuDeadLoop()

On 2021-03-24 8:15 p.m., gaoliming wrote: Create PR https://github.com/tianocore/edk2/pull/1515 Thanks Liming. Ankur Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 gaoliming 发送时间: 2021年3月22日 9:40 收件人: 'Ankur Arora' ; devel@edk2.groups.io 抄送: 'Michael D Kinney' ; 'Laszlo Ersek'

Re: [edk2-devel] SR-IOV setup in edk2

Hi Jon. On 03/25/21 09:02, Jon Nettleton wrote: > I have now implemented a driver connected to gEfiPciPlatformProtocolGuid > and I can get events passed in for the platform setup hooks, is this where > we should be doing the bus specific setup, rather than catching > gEfiPciIoProtocolGuid?

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

On 03/25/21 04:55, Andrew Fish wrote: > Ray, > > The other option would be to define a Library Class for the AcpiTableDxe > driver to consume and have a NULL version of it in the MdeModulePkg. That > would allow more flexibility? It kind of depends if you want to make the > implementation

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

On 03/25/21 02:10, Ni, Ray wrote: > Ben, > I understand your point. > The purpose of changing the AcpiTableDxe to directly consume the HOB is to > reduce the overall system complexity. > The complexity I see with your option is: > 1. platform needs to include that driver to consume the ACPI table

Re: [edk2-devel] [edk2-platforms] [patch V2 15/35] Platform/QuarkPlatformPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: Kelly Steele > -Original Message- > From: Bi, Dandan > Sent: Monday, March 22, 2021 1:54 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Steele, Kelly > > Subject: [edk2-platforms] [patch V2 15/35] Platform/QuarkPlatformPkg: > Consume MdeLibs.dsc.inc for

Re: [edk2-devel] [edk2-platforms] [patch V2 28/35] Silicon/QuarkSocPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: Kelly Steele > -Original Message- > From: Bi, Dandan > Sent: Monday, March 22, 2021 1:54 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Steele, Kelly > > Subject: [edk2-platforms] [patch V2 28/35] Silicon/QuarkSocPkg: Consume > MdeLibs.dsc.inc for

Re: [edk2-devel] [PATCH v2] OvmfPkg: strip build paths in release builds

On 03/25/21 04:47, Andrew Fish wrote: > While we are talking about what toolchain targets should do I don’t > understand this [1]? Why does OVMF need to turn on —keepexceptiontable? If > these toolchains require it why don’t they turn it on? I see Mike fixed > it[2]. Is this another case of a

Re: [edk2-devel] [PATCH v2] OvmfPkg: strip build paths in release builds

On 03/25/21 00:25, Andrew Fish wrote: > This breaks some usage we have have in our fork. We have symbols turned on > for Release builds, so this change would break that. > > It looks to me that the root cause of this issue might be that the GenFw is > blindly writing the debug directory entry

[edk2-devel] [PATCH v2 5/7] OvmfPkg/XenPlatformPei: Map extra physical address

Some information available in a Xen guest can be mapped anywhere in the physical address space and they don't need to be backed by RAM. For example, the shared info page. While it's easier to put those pages anywhere, it is better to avoid mapping it where the RAM is. It might split a nice 1G

[edk2-devel] [PATCH v2 6/7] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency

Calculate the frequency of the APIC timer that Xen provides. Even though the frequency is currently hard-coded, it isn't part of the public ABI that Xen provides and thus may change at any time. OVMF needs to determine the frequency by an other mean. Fortunately, Xen provides a way to determines

[edk2-devel] [PATCH v2 7/7] OvmfPkg/OvmfXen: Set PcdFSBClock

Update gEfiMdePkgTokenSpaceGuid.PcdFSBClock so it can have the correct value when SecPeiDxeTimerLibCpu start to use it for the APIC timer. Currently, nothing appear to use the value in PcdFSBClock before XenPlatformPei had a chance to set it even though TimerLib is included in modules runned

[edk2-devel] [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

We are going to use the page table structure in yet another place, collect the types and macro that can be used from another module rather that making yet another copy. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD --- CC: Tom Lendacky CC: Brijesh Singh

[edk2-devel] [PATCH v2 1/7] OvmfPkg/XenResetVector: Silent a warning from nasm

To avoid nasm generating a warning, replace the macro by the value expected to be stored in eax. Ia32/XenPVHMain.asm:76: warning: dword data exceeds bounds Reported-by: Laszlo Ersek Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm | 2 +-

[edk2-devel] [PATCH v2 3/7] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO

We are going to use new fields from the Xen headers. Apply the EDK2 coding style so that the code that is going to use it doesn't look out of place. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- Notes: v2: - fix

[edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

We are going to want to change the value of PcdFSBClock at run time in OvmfXen, so move it to the PcdsDynamic section. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao --- CC: Bob Feng CC: Michael D Kinney

[edk2-devel] [PATCH v2 0/7] OvmfXen: Set PcdFSBClock at runtime

Patch series available in this git branch: git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v2 Changes in v2: - main change is to allow mapping of Xen pages outside of the RAM see patch: "OvmfPkg/XenPlatformPei: Map extra physical address" - that new function allows to map the

Re: [edk2-devel] [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

Hi Zhichao, I resend v4 patch, in which your R-B to the previous patch is removed and Liming is added to CC list. No others changes were made in this patches. I will send v5 with the correction on copyright. Or can I just push to master with the correction and your R-B? Thanks Abner >

[edk2-devel] [PATCH v4 RESEND 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

Add handle parsing for EFI Redfish Discover protocol. Add handle parsing for EFI RestEx protocol. Signed-off-by: Abner Chang Cc: Ray Ni Cc: Zhichao Gao Cc: Nickle Wang Cc: Peter O'Hanley Cc: Liming Gao --- .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-

[edk2-devel] [PATCH v4 RESEND 1/2] MdePkg/Include: EFI Redfish Discover protocol

Move GUID definition of EFI Redfish Discover protocol to under MdePkg. With this we don't have dependency of RedfishPkg in ShellPkg. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang Cc: Peter O'Hanley Reviewed-by: Liming Gao ---

[edk2-devel] [PATCH v4 RESEND 0/2] Support EFI Redfish protocols

In v4: In UefiHandleParsingLib.c, move the changes for UEFI 2.8 to below UEFI 2.7 section In v3: Correct the mismatched definitions in both RedfishDiscover.h and UEFI spec 2.8 (Refer to v2.9). In v2: Address comments given by Liming on patch 1/2. Add handle parsing for EFI Redfish

Re: 回复: [edk2-devel] [RFC PATCH 09/19] MdePkg: Add AsmPvalidate() support

On 3/24/21 9:49 PM, gaoliming wrote: > Is this API X64 only? Or IA32 and X64 both? Theoretically the instruction is available on both IA32 and X64 but its used only in X64. AMD SEV, SEV-ES and SEV-SNP support is available for X64 arch only. I was not sure if the EDK2 community is okay with the

[edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock

Hi, When booting the latest edk2 on Marvell SoCs I get a number of prints as below: !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon! !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy! !!! DEPRECATED INTERFACE !!! Variable:

Re: [edk2-devel] [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

First, thanks Liming's catch. Abner, The patch has been updated, you should remove my R-B for the V4 version. Otherwise the reviewers/maintainers may treated it as reviewed one. And please add the one who already gave the comment for your patch to the Cc list. They care about the about the

[edk2-devel] [PATCH] [edk2-staging] BaseTools/Fmmt: Fix rebuild FFS lost dependency section.

https://bugzilla.tianocore.org/show_bug.cgi?id=3261 Dependency section data lost when rebuild FFS. Add pei dxe smm dependency section to FFS and Encap_INFO_DATA structure. Restore dependency section when build FFS. Cc: Bob Feng Cc: Liming Gao Signed-off-by: GregX Yeh ---

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.

Hi Star, sorry for my late response. Yes, HOB search time is related to the sequence of HOB generation. Some data collected on the test platform: 1. The time range required to search for the specified HOB: 20ns ~ 2700ns Search for the 1st HOB(PHIT HOB): 20ns Search for the last HOB: about 2700ns

Re: [edk2-devel] SR-IOV setup in edk2

On Mon, Mar 22, 2021 at 8:04 PM Laszlo Ersek wrote: > > On 03/21/21 13:46, Jon Nettleton wrote: > > I am looking for some example code, or direction in how SR-IOV > > functions are expected to be picked up by the platform pcie host > > library so it can setup required bits like LUTs. Currently

Re: [edk2-devel] [patch V2 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access

Thank you Liming. If no more comments, I plan to submit following 2 patches firstly tomorrow. [patch V2 01/29] MdePkg: Add RegisterFilterLib class and NULL instance (https://edk2.groups.io/g/devel/message/73072) [patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg