Re: [edk2-devel] [PATCH 1/1] ArmPkg: Implement PlatformBootManagerLib for LinuxBoot

2021-09-06 Thread Nhi Pham via groups.io
Hi Ard, On 04/09/2021 00:50, Ard Biesheuvel wrote: On Fri, 3 Sept 2021 at 18:07, Nhi Pham wrote: LinuxBoot is a firmware that replaces specific firmware functionality like the UEFI DXE phase with a Linux kernel and runtime. It is built-in UEFI image like an application as it will be executed

[edk2-devel] [PATCH v2 1/1] ArmPkg: Implement PlatformBootManagerLib for LinuxBoot

2021-09-06 Thread Nhi Pham via groups.io
LinuxBoot is a firmware that replaces specific firmware functionality like the UEFI DXE phase with a Linux kernel and runtime. It is built-in UEFI image like an application, which is executed at the end of DXE phase. To achieve the LinuxBoot boot flow "SEC->PEI->DXE->BDS->LinuxBoot", today we use

Re: [edk2-devel] [PATCH V1 1/1] RedfishPkg:Fix various typos

2021-09-06 Thread Nickle Wang
Thanks for catching these typos. Reviewed-by: Nickle Wang Nickle -Original Message- From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: Tuesday, September 7, 2021 10:41 AM To: zhoucheng ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH V1 1/1] RedfishPkg:Fix various typos

Re: [edk2-devel] [PATCH V1 1/1] RedfishPkg:Fix various typos

2021-09-06 Thread Abner Chang
Thanks for the corrections. Reviewed-by: Abner Chang > -Original Message- > From: zhoucheng [mailto:zhouch...@phytium.com.cn] > Sent: Tuesday, September 7, 2021 10:18 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) > Subject: [PATCH V1 1/1] RedfishPkg:Fix

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Abner Chang
> -Original Message- > From: gaoliming [mailto:gaolim...@byosoft.com.cn] > Sent: Tuesday, September 7, 2021 9:09 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > ; 'Gerd Hoffmann' ; 'Ard > Biesheuvel' > Cc: 'Yao, Jiewen' ; 'Ard Biesheuvel' > ; 'Kinney, Michael D' >

Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support

2021-09-06 Thread Yao, Jiewen
Thank you Brijesh It took me a while to review this series. Here is my feedback. I am not sure what you prefer, to put all comment together? Or reply 29 email separately? Let me put them together in this version. If you prefer a different way, please let me know. My strategy is same as

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/07/2021 #cal-reminder

2021-09-06 Thread gaoliming
Hi, all The following new issues will be reviewed this week. 3264 EDK2 Pla Placehol thomas.abra...@arm.com UNCO Make use of Edk2 Packages Path so that module INFs in Platform/ARM are more portable.

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 09/07/2021 #cal-reminder

2021-09-06 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

回复: [edk2-devel] Python2.7 is not working with the EDK2 build system

2021-09-06 Thread gaoliming
Bob: Yes. Python3 is the formal support. We recommend user to use Python3. But, if user meets the issue in Python2, user can still report the issue in BaseTools. Its priority may be low. For this case, it is the regression issue caused by the recent change. The patch owner is also identified.

回复: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread gaoliming
Abner: I prefer to use git mv command to move those modules from ArmVirtPkg to OvmfPkg. This way can still keep git history for those modules. You can create the second patch to update ArmVirtPkg DSC/FDF, or combine this change into the first patch. Thanks Liming > -邮件原件- > 发件人:

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: Introduce 16MiB flash size for (primarily) Linuxboot

2021-09-06 Thread Devon Bautista
> So DXEFV needs more space then. I'm wondering that the size doesn't > change according to the commit message. Looking at the fdf files it > seems PEIFV and DXEFV don't have a fixed size, seems everything is > fine as long as the compressed image fits into FVMAIN_COMPACT. > > take care, >

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-06 Thread Yao, Jiewen
For 3, I don’t understand your problem. But I don’t think we need link NULL lib instance for Tcg2Dxe. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Monday, September 6, 2021 11:05 PM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-06 Thread Yao, Jiewen
For 2, https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Tcg The edk2-platform solution is to let Tcg2PlatformDxe and Tcg2PlatformPei link Library/PeiDxeTpmPlatformHierarchyLib. The DSC/FDF can include Tcg2PlatformDxe and Tcg2PlatformPei. No BDS change is

Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix build with QemuKernelLoaderFsDxe

2021-09-06 Thread Ard Biesheuvel
On Mon, 6 Sept 2021 at 16:03, Anthony PERARD wrote: > > From: Anthony PERARD > > VerifyBlob() has been added recently to QemuKernelLoaderFsDxe, also > QemuKernelLoaderFsDxe has also been added recently to OvmfXen but > without an implementation of VerifyBlob(). > > Fix this by adding the same

[edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix build with QemuKernelLoaderFsDxe

2021-09-06 Thread Anthony PERARD via groups.io
From: Anthony PERARD VerifyBlob() has been added recently to QemuKernelLoaderFsDxe, also QemuKernelLoaderFsDxe has also been added recently to OvmfXen but without an implementation of VerifyBlob(). Fix this by adding the same runes that has been addde to OvmfPkgX64.dsc. Fixes: 9f3eda177a4b

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-06 Thread Stefan Berger
On 9/6/21 8:34 AM, Yao, Jiewen wrote: Hi Stefan Thank you very much for the work. I would like to double confirm with you on several things: 1) S3 resume - According to security guideline, we can randomize platform hiearachy if S3 start state fail. REF:

Re: [edk2-devel] [PATCH v6 06/29] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

2021-09-06 Thread Min Xu
On September 6, 2021 8:17 PM, Gerd Hoffman wrote: > Hi, > > > > > sevSnpBootBlockStart: > > > > +DD SNP_HV_VALIDATED_START > > > > +DD SNP_HV_VALIDATED_END > > > We pack all the Tdx information into a blob (TdxMetadata). These tdx > > information Includes the BFV(i.e.

Re: [edk2-devel] Python2.7 is not working with the EDK2 build system

2021-09-06 Thread Sunny Wang
Thanks for checking this, Bob and Liming. Hi Bob, Yeah, I was aware of that as well. It makes sense to switch Python2 to Python3. However, Python 2 was discontinued for a while, but there seems no announcement in the mailing list or code change for cleaning up Python 2 stuff in edk2

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Abner Chang
Ok thanks, do we need the two steps to migrate FDT modules under OvmfPkg/? 1. One patch set to clone those modules under OvmfPkg/ 2. One patch set of ArmVirtPkg change to use those modules and deletes the ones under ArmVirtPkg/. Or we just do all at once? I prefer to have two steps. How do you

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-06 Thread Yao, Jiewen
Hi Stefan Thank you very much for the work. I would like to double confirm with you on several things: 1) S3 resume - According to security guideline, we can randomize platform hiearachy if S3 start state fail. REF:

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Gerd Hoffmann
Hi, On Mon, Sep 06, 2021 at 02:04:48PM +0200, Ard Biesheuvel wrote: > On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen wrote: > > > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and > > put all things there. > > > > I also think we define Fdt feature in > >

Re: [edk2-devel] [PATCH v6 06/29] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

2021-09-06 Thread Gerd Hoffmann
Hi, > > > sevSnpBootBlockStart: > > > +DD SNP_HV_VALIDATED_START > > > +DD SNP_HV_VALIDATED_END > We pack all the Tdx information into a blob (TdxMetadata). These tdx > information > Includes the BFV(i.e. OVMF_CODE.fd), the CFV(i.e. OVMF_VARS.fd), TdMailbox, > etc. > The

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Ard Biesheuvel
On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen wrote: > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and put > all things there. > > > > I also think we define Fdt feature in > https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add reviewer > there to help

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Yao, Jiewen
I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and put all things there. I also think we define Fdt feature in https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add reviewer there to help review the code. Thank you Yao Jiewen From: Chang, Abner (HPS

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Abner Chang
Hi Jiewen, We currently only use below modules from ArmVirtPkg, - ArmVirtPkg/Library o FdtPciPcdProducerLib o FdtPciHostBridgeLib - ArmVirtPkg/ o VirtioFdtDxe o FdtClientDxe o HighMemDxe Above modules are related to the extraction of the platform configuration

Re: [edk2-devel] Python2.7 is not working with the EDK2 build system

2021-09-06 Thread Bob Feng
Hi Sunny, EDK II only formally supports Python 3 now because Python 2 is EOL with no support. So I’d suggest BaseTools users switch Python2 to Python3. Thanks, Bob From: gaoliming Sent: Monday, September 6, 2021 9:10 AM To: devel@edk2.groups.io; sunny.w...@arm.com; Feng, Bob C ; Chen,

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib: Fix byte shift

2021-09-06 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Benjamin Doron > Sent: Monday, September 6, 2021 10:56 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 2/2] > KabylakeOpenBoardPkg/AspireVn7Dash572G/DxeBoardInitLib:

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/BoardEcLib: Check for NULL

2021-09-06 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Benjamin Doron > Sent: Monday, September 6, 2021 10:55 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 1/2] > KabylakeOpenBoardPkg/AspireVn7Dash572G/BoardEcLib: Check

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: Introduce 16MiB flash size for (primarily) Linuxboot

2021-09-06 Thread Gerd Hoffmann
> >> FVMAIN_COMPACT uncompressed3360 -> 15648 (+12288) > >> DXEFV uncompressed 12288 -> 12288 (+0) > > How you are going to use the extra space you got? > > Do you add kernel + initrd as ffs files to FVMAIN_COMPACT? > The kernel + initrd are

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-06 Thread Yao, Jiewen
Do you have a list of which module you want to move to Ovmf? I think we can discuss case by case. From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: Monday, September 6, 2021 12:16 PM To: gaoliming ; devel@edk2.groups.io Cc: 'Ard Biesheuvel' ; Kinney, Michael D ; 'Leif Lindholm' ; Ni,