Merged.
-Original Message-
From: Huang, Jenny
Sent: Tuesday, January 11, 2022 3:54 PM
To: Sheng, W ; devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Kowalewski, Robert
Subject: RE: [PATCH] IntelSiliconPkg/IntelVTdDxe: Reduce Debug Level
Reviewed-by: Jenny Huang
-Origi
This enables Whitley as a test vehicle for features.
These are not expected to be fully functional at this time.
Specifically UserAuthentication causes a boot failure and the others
have only been verified to be built and dispatched, not ported to
the Whitley reference platform hardware.
Cc: Nate
Also added feature enable flag
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDeviceLib.h
| 2 +-
Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf
| 13
Features/Inte
This include file allows for elimination of a lot of duplicate code
and makes FDF files more readable.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
Platform/Intel/MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf | 24
Use the MinPlatformPkg version of CommonSpiFvHeaderInfo.fdf.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf | 24
--
Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.fdf | 48
Remove build of common libraries. Boards will already have those.
Modified Usb3DebugFeature.dsc to treat libraries like libraries.
Usb3DebugFeaturePkg.dsc uses the component trick for standalone build
testing of the libraries.
Added a PCD to allow board to select between NULL, regular, and IO MM
Fix build issues with standalone build.
Switch to using MinPlatformPkg common core include for common modules.
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 54
Features/Intel/Ou
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/Advanc
Add feature enable PCD.
Use MinPlatformPkg build include files.
Fix PEI_COR typo in PEI handler lib.
Build StatusCodeHandler components with unique filename GUID.
Add PreMemory.fdf and PostMemory.fdf include files.
Improve Readme formatting and feature enabling checklist.
Cc: Eric Dong
Cc: Liming
This produces three FV and no FD.
FvAdvancedPreMemory.fv contains PEIM for pre-memory use.
FvAdvancedUncompressed.fv contains post memory PEIM and drivers for DXE
and SMM.
FvAdvanced.fv contains the compressed FvAdvancedUncompressed.fv in an
FV file format as is common practice.
These FV are not e
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 69
Features/Intel/UserInterface/LogoFeaturePkg/Logo
The AdvancedFeaturePkg is supposed to include all features.
Add Beep Debug feature to include DSC and FDF.
Order features based on their domains.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 66
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc | 21
++
Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/Acp
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Isaac Oram
---
Features/Intel/UserInter
VirtualKeyboard missing feature enable PCD.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/PostMemory.fdf
| 2 +-
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeaturePkg.dec
| 7 +
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Isaac Oram
---
Features/Intel/UserInter
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyboardFeature.dsc
| 62 +++-
Features/Intel/UserInter
Standalong build was not working due to missing libraries.
Leverage MinPlatformPkg common includes for core libraries.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 89
++--
Features/Intel/N
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf |
6 +-
Features/Intel/UserInterface/UserAuthFeaturePkg/Include/Us
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf|
2 +-
Features/Intel/SystemInformation/SmbiosFeaturePkg/Inclu
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/System
Use the MinPlatformPkg common core build files to build libraries
needed by this feature.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf | 2 +-
Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/PowerM
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Sai Chaganty
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
Featur
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Liming Gao
Cc: Nate DeSimone
Signed-off-by: Isaac Oram
---
Features/Intel/OutOf
Packages should be at the root of a PACKAGES_PATH entry.
At some point, paths were relative to edk2-platforms/Features/Intel
which was functional, but interferes with the proper functioning
of packaging tools.
Cc: Sai Chaganty
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
Featur
Extend the template to leverage common library build files.
Cc: Sai Chaganty
Cc: Liming Gao
Signed-off-by: Isaac Oram
---
Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc | 2 +-
Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc | 18
++
2 files chan
The BeepDebugFeaturePkg was malformed and did not build anything
and thus wasn't testable in standalone build.
Added gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable
to properly control the advanced feature inclusion.
Use the standard MinPlatform includes for core libraries. This
incr
This series addresses inconsistencies in feature implementation and use. Some
inconsistencies are just
conventions of the feature design/template/convention. Some are inconsistency
with feature design intent
that negatively affect the usability of the features and the amount of work
required fr
Hi
> > > +VOID
> > > +Split2MPageTo4K (
> >
> > Yet another copy of this. Please don't.
> I will figure out a Page walker lib so that these duplicated code can be
> avoided. Thanks for reminder.
After I implemented a PoC of PageTable library, I realized that there has
already been a same feature
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sunny Wang
> 发送时间: 2022年1月12日 5:37
> 收件人: devel@edk2.groups.io
> 抄送: Sunny Wang ; Liming Gao
> ; Heinrich Schuchardt
> ; G Edhaya Chandran
> ; Samer El-Haj-Mahmoud
> ; Sunny Wang
> 主题: [edk2-devel] [PATCH] MdeModulePkg/Vari
Hi Bob,
My patch includes the other brotli submodule as well, per Liming's request.
I saw the PR's CI failed before Christmas but I completely forgot about it,
sorry about that!
I can take a look again and submit a v2 patch set tomorrow. It's all
trivial stuff and I believe it's best that both b
wt., 11 sty 2022 o 22:46 Sunny Wang napisał(a):
>
> The SMBIOS data is based on v3.3.0, but its version is set to v3.2.0.
> Since PcdSmbiosVersion in MdeModulePkg.dec is v3.3.0, so just remove
> the platform overridden value in .dsc file to fix this issue.
>
> This also fixed the FWTS failure belo
BTW, regarding 3) below, it looks like this is expected behavior from Clang/
LLVM. Dereferencing a NULL pointer is technically undefined in C, and by
default the Clang optimizer will cause a trap to occur if you try to do it
(because it assumes it's not safe for programs to do that).
The flag -f
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3738
The SimpleTestOut test cases don't allow SetMode to return
EFI_UNSUPPORTED, which doesn't comply with UEFI spec.
UEFI spec allows EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetMode function to
return EFI_UNSUPPORTED for the condition below:
if the outpu
The SMBIOS data is based on v3.3.0, but its version is set to v3.2.0.
Since PcdSmbiosVersion in MdeModulePkg.dec is v3.3.0, so just remove
the platform overridden value in .dsc file to fix this issue.
This also fixed the FWTS failure below:
dmicheck: Type 17 expects length of 0x54, has incorrect
Only EFI_VARIABLE_NON_VOLATILE attribute is an invalid combination
of attribute bits, so update the variable driver to return
EFI_INVALID_PARAMETER so that we can prevent the invalid variable
being created.
This change also fixes the SCT failure below:
- RT.QueryVariableInfo - With being an inval
Add AmlCodeGenMethodRetInteger function to generate AML code for
a Method returning an Integer.
Signed-off-by: Rebecca Cran
Reviewed-by: Pierre Gondois
---
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h| 47 ++
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 156
In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to
AmlSetFixedArgument is redundant because ReturnNode is already a
AML_NODE_HEADER* .
Signed-off-by: Rebecca Cran
Reviewed-by: Pierre Gondois
---
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +-
1 file changed, 1
Add functions to generate code for the Memory32Fixed ASL macro and a
method returning an Integer.
Remove a redundant cast from AmlCodeGenReturn.
Changes from v1 to v2:
o Fixed indentation of doxygen comments.
o Switched to using BIT0 for bitfield.
o Switched to using EFI_ACPI_32_BIT_MEMORY_RANG
Add a Memory32Fixed function to generate code for the corresponding
Memory32Fixed macro in AML.
Signed-off-by: Rebecca Cran
---
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h| 33
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 57
Thanks. I've fixed these issues in the v2 patch which I'll send out soon.
--
Rebecca Cran
On 1/11/22 04:34, Pierre Gondois wrote:
Hello Rebecca,
On 1/8/22 10:57 PM, Rebecca Cran via groups.io wrote:
Add a Memory32Fixed function to generate code for the corresponding
Memory32Fixed macro in
From: Sami Mujawar
Acpiview is a command line tool allowing to display, dump, or check
installed ACPI tables. Add a 'ACPIVIEW_ENABLE' switch to enable it
on an ArmVirt platform.
The switch is set for the ArmVirtKvmTool platform.
Signed-off-by: Sami Mujawar
Signed-off-by: Pierre Gondois
Acked-
From: Sami Mujawar
A Configuration Manager that uses the Dynamic Tables framework
to generate ACPI tables for Kvmtool Guests has been provided.
This Configuration Manager uses the FdtHwInfoParser module to
parse the Kvmtool Device Tree and generate the required
Configuration Manager objects for g
From: Sami Mujawar
Add Configuration Manager to enable ACPI tables for Kvmtool
firmware. The Configuration Manager for Kvmtool uses the DT
Hardware Information Parser module (FdtHwInfoParser) to parse
the DT provided by Kvmtool. The FdtHwInfoParser parses the DT
and invokes the callback function
From: Sami Mujawar
Most ACPI tables for Kvmtool firmware are dynamically
generated. The AML code is also generated at runtime
for most components in appropriate SSDTs.
Although there may not be much to describe in the DSDT,
the DSDT table is mandatory.
Therefore, add an empty stub for DSDT.
Si
From: Pierre Gondois
The cpsell tool checks for unknown words in the upstream CI.
Add some new words to the list of exceptions.
Signed-off-by: Pierre Gondois
---
Notes:
v2:
- Adding 'acpiview'. Since the patch change, Laszlo's
Reviewed-by is not added. [Pierre]
ArmVirtPkg/ArmVi
From: Pierre Gondois
Add a macro that specifies the format for printing CM_OBJECT_ID.
This allows to print the CM_OBJECT_ID is a consistent way in the
output logs.
Signed-off-by: Pierre Gondois
---
Notes:
v2:
- New patch, requested by Laszlo.
DynamicTablesPkg/Include/ConfigurationMan
From: Pierre Gondois
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3742
V1: https://edk2.groups.io/g/devel/message/76990
V2:
- New patch: "DynamicTablesPkg: Print specifier macro for
CM_OBJECT_ID" [Laszlo]
- Only add AcpiView for ArmVirtKvmTool instead of all ArmVirt
platforms. This is
Hi Sean,
The auto promotion of memory was only intended as a dev/debug feature to
maximize
platform boot without having to tune what memory is tested in PEI phase.
In my opinion, a production platform should never trigger any auto promotions of
untested to tested memory, and part of production v
Hi,
I was thinking about running a simple test with Cloud Hypervisor (VMM
relying on KVM) to validate the associated Ovmf target can be properly
booted. Unfortunately I get an error about /dev/kvm not being
available.
Is there a way to let the Azure Pipelines know that we need a machine
that supp
Actually https://github.com/google/brotli/pull/893 this PR just fixed the GCC
11 build issue. It was merged at
https://github.com/google/brotli/commit/0a3944c8c99b8d10cc4325f721b7c273d2b41f7b.
Both of Pedro's patch and Ross's patch include that fix.
I think the difference between the Pedro's pa
Reviewed-by: Robert Kowalewski
-Original Message-
From: Sheng, W
Sent: Tuesday, January 11, 2022 2:27 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Huang, Jenny ;
Kowalewski, Robert
Subject: [PATCH] IntelSiliconPkg/IntelVTdDxe: Reduce Debug Level
Reduce the debug l
Is the CI only relying on QEMU using TCG? I have some patches to run
the CI with Cloud Hypervisor but I got an error about /dev/kvm not
being available :/
Is there a certain type of machine used by the AzurePipelines that
would support nested virtualization?
Thanks,
Sebastien
On Fri, 2022-01-07
From: Sebastien Boeuf
Acked-by: Gerd Hoffmann
Reviewed-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 71c42bddae..3bda97ef25 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@
From: Sebastien Boeuf
Cloud Hypervisor doesn't need the support for legacy BIOS, therefore the
CSM support can be removed.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 20
OvmfPkg/CloudHv/CloudHvX64.fdf
From: Sebastien Boeuf
Adding the newly created target for Cloud Hypervisor to the CI,
validating it can be properly built.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
.../.azurepipelines/Ubuntu-GCC5.yml | 9 +
OvmfPkg/PlatformCI/CloudHvBuild
From: Sebastien Boeuf
Cloud Hypervisor doesn't emulate any USB controller or device, therefore
the support can be removed.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 11 ---
OvmfPkg/CloudHv/CloudHvX64.fdf | 10
From: Sebastien Boeuf
No need for video or virtio-gpu support since Cloud Hypervisor doesn't
emulate any of these.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 16
OvmfPkg/CloudHv/CloudHvX64.fdf | 4
2
From: Sebastien Boeuf
Since Cloud Hypervisor doesn't rely on the FwCfg mechanism, remove the
libraries imports when possible.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/Ov
From: Sebastien Boeuf
Anything specific to the QEMU Q35 platform is not relevant for the
CloudHv target.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 10 --
1 file changed, 10 deletions(-)
diff --git a/OvmfPkg/Cloud
From: Sebastien Boeuf
Cloud Hypervisor does not emulate any 8259 PIC, therefore there's no
reason to load the corresponding driver for it.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 4
OvmfPkg/CloudHv/CloudHvX64.fdf |
From: Sebastien Boeuf
Cloud Hypervisor doesn't emulate any LPC bridge, therefore we simply
need to rely on the serial I/O port to be connected as a console.
It reuses the code from Xen since it's very generic.
Acked-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
Ov
From: Sebastien Boeuf
Cloud Hypervisor doesn't emulate the legacy 8254 PIT, which is why
instead of relying on it as the timer UEFI services, rely on the
XenTimerDxe implementation. This is not Xen specific, as it simply uses
the local APIC timer triggering interrupts on the vector 32.
Acked-by:
From: Sebastien Boeuf
Adding the new target CloudHvX64, copied directly from OvmfPkgX64. The
point is to create a target dedicated for Cloud Hypervisor rather than
trying to support both QEMU and Cloud Hypervisor on the same target.
Improvements and cleanups will be performed in follow up patche
From: Sebastien Boeuf
Since Cloud Hypervisor and QEMU pc/q35 are quite different, it makes
more sense to create a dedicated OVMF target for Cloud Hypervisor rather
than trying to support both VMMs from the same OvmfPkgX64 target.
That's the reason why this series introduces a new target called
C
On Tue, Jan 11, 2022 at 11:20:42AM +0100, sebastien.bo...@intel.com wrote:
> From: Sebastien Boeuf
>
> Since Cloud Hypervisor and QEMU pc/q35 are quite different, it makes
> more sense to create a dedicated OVMF target for Cloud Hypervisor rather
> than trying to support both VMMs from the same O
DevicePathLib utilities are useful in PEI to locate the devices which need
an opal unlock on S3 resume. This commit reuses the implementation done
to support Standalone MM for PEI.
Signed-off-by: Mateusz Albecki
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
---
...iesStandaloneMm.c =>
This patch adds support for PEIMs in UefiDevicePathLib. Although this library
and DEVICE_PATH_PROTOCOL
itself was initially intended for DXE the use case of unlocking opal-locked
storage devices during S3
resume makes it useful in PEI.
As it is the change will break the users who will need to ch
Hello Rebecca,
This patch looks good to me:
Reviewed-by: Pierre Gondois
On 1/8/22 10:57 PM, Rebecca Cran via groups.io wrote:
> Add AmlCodeGenMethodRetInteger function to generate AML code for
> a Method returning an Integer.
>
> Signed-off-by: Rebecca Cran
> ---
> DynamicTablesPkg/Include/L
Hello Rebecca,
The patch looks good to me,
Reviewed-by: Pierre Gondois
On 1/8/22 10:57 PM, Rebecca Cran via groups.io wrote:
> In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to
> AmlSetFixedArgument is redundant because ReturnNode is already a
> AML_NODE_HEADER* .
>
> Signed-off
Hello Rebecca,
On 1/8/22 10:57 PM, Rebecca Cran via groups.io wrote:
> Add a Memory32Fixed function to generate code for the corresponding
> Memory32Fixed macro in AML.
>
> Signed-off-by: Rebecca Cran
> ---
> DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h| 33
> +++
Acked-by: Jiewen Yao
> -Original Message-
> From: Boeuf, Sebastien
> Sent: Tuesday, January 11, 2022 6:21 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Justen, Jordan L
> ; kra...@redhat.com; Boeuf, Sebastien
>
> Subject: [PATCH v3 11/11] OvmfPkg: Add CloudHvX64 to the CI
>
> From:
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Boeuf,
> Sebastien
> Sent: Tuesday, January 11, 2022 6:21 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Justen, Jordan L
> ; kra...@redhat.com; Boeuf, Sebastien
>
> Subject: [edk2-devel] [PATCH v3
Acked-by: Jiewen Yao
> -Original Message-
> From: Boeuf, Sebastien
> Sent: Tuesday, January 11, 2022 6:21 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Justen, Jordan L
> ; kra...@redhat.com; Boeuf, Sebastien
>
> Subject: [PATCH v3 03/11] OvmfPkg/CloudHv: Connect serial console
>
>
From: Sebastien Boeuf
Adding the newly created target for Cloud Hypervisor to the CI,
validating it can be properly built.
Signed-off-by: Sebastien Boeuf
---
.../.azurepipelines/Ubuntu-GCC5.yml | 9 +
OvmfPkg/PlatformCI/CloudHvBuild.py| 37 +++
2 file
From: Sebastien Boeuf
Cloud Hypervisor doesn't need the support for legacy BIOS, therefore the
CSM support can be removed.
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 20
OvmfPkg/CloudHv/CloudHvX64.fdf | 6 --
2 files chan
From: Sebastien Boeuf
Signed-off-by: Sebastien Boeuf
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 71c42bddae..3bda97ef25 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -440,6 +440,11 @@ F:
OvmfPkg/Library/ResetSyste
From: Sebastien Boeuf
Cloud Hypervisor doesn't emulate any USB controller or device, therefore
the support can be removed.
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 11 ---
OvmfPkg/CloudHv/CloudHvX64.fdf | 10 --
2 files changed,
From: Sebastien Boeuf
No need for video or virtio-gpu support since Cloud Hypervisor doesn't
emulate any of these.
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 16
OvmfPkg/CloudHv/CloudHvX64.fdf | 4
2 files changed, 20 deleti
From: Sebastien Boeuf
Since Cloud Hypervisor doesn't rely on the FwCfg mechanism, remove the
libraries imports when possible.
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/OvmfPkg/CloudHv/CloudHvX64.
From: Sebastien Boeuf
Anything specific to the QEMU Q35 platform is not relevant for the
CloudHv target.
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 10 --
1 file changed, 10 deletions(-)
diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfP
From: Sebastien Boeuf
Cloud Hypervisor does not emulate any 8259 PIC, therefore there's no
reason to load the corresponding driver for it.
Acked-by: Jiewen Yao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 4
OvmfPkg/CloudHv/CloudHvX64.fdf | 1 -
2 files changed, 5
From: Sebastien Boeuf
Cloud Hypervisor doesn't emulate any LPC bridge, therefore we simply
need to rely on the serial I/O port to be connected as a console.
It reuses the code from Xen since it's very generic.
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/CloudHv/CloudHvX64.dsc
From: Sebastien Boeuf
Cloud Hypervisor doesn't emulate the legacy 8254 PIT, which is why
instead of relying on it as the timer UEFI services, rely on the
XenTimerDxe implementation. This is not Xen specific, as it simply uses
the local APIC timer triggering interrupts on the vector 32.
Acked-by:
From: Sebastien Boeuf
Adding the new target CloudHvX64, copied directly from OvmfPkgX64. The
point is to create a target dedicated for Cloud Hypervisor rather than
trying to support both QEMU and Cloud Hypervisor on the same target.
Improvements and cleanups will be performed in follow up patche
From: Sebastien Boeuf
Since Cloud Hypervisor and QEMU pc/q35 are quite different, it makes
more sense to create a dedicated OVMF target for Cloud Hypervisor rather
than trying to support both VMMs from the same OvmfPkgX64 target.
That's the reason why this series introduces a new target called
C
On Mon, Jan 10, 2022 at 06:47:22PM +0100, sebastien.bo...@intel.com wrote:
> From: Sebastien Boeuf
>
> Cloud Hypervisor doesn't emulate the legacy 8254 PIT, which is why
> instead of relying on it as the timer UEFI services, rely on the
> XenTimerDxe implementation. This is not Xen specific, as i
Hi,
> > Well, if you want avoid the refactoring because of the risk there is still
> > the
> > option to have tdx config-b use the normal PEI boot flow.
> > Then revisit refactoring and adding support for PEI-less boot later.
> >
> I think it still makes sense (Adding a basic PlatformInitLib w
89 matches
Mail list logo
