Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf

On 30/03/2022 8:14, Gerd Hoffmann wrote: > On Tue, Mar 29, 2022 at 03:32:36PM +0300, Dov Murik wrote: >> Thanks Gerd for reviewing. >> >> On 29/03/2022 14:36, Gerd Hoffmann wrote: >>> On Mon, Mar 28, 2022 at 06:45:29PM +, Dov Murik wrote: Reorder the pages in the MEMFD section of

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

Hi, > Check if that page is defined; if it is, skip it in the metadata list. > In such case, VMM should fill the page with the hashes content, or > explicitly update it as a zero page (if kernel hashes are not used). Is it an option to just skip the page unconditionally? I think in the

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf

On Tue, Mar 29, 2022 at 03:32:36PM +0300, Dov Murik wrote: > Thanks Gerd for reviewing. > > On 29/03/2022 14:36, Gerd Hoffmann wrote: > > On Mon, Mar 28, 2022 at 06:45:29PM +, Dov Murik wrote: > >> Reorder the pages in the MEMFD section of AmdSevX64.fdf so that it > >> matches the same order

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 03/29/2022 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220317T223602Z

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

I'd like to re-use something like this one. I'm still reviewing it but so far I've only seen a couple of changes. https://github.com/jwang36/edk2-staging/tree/ProtectedVariable/libsv2#readme I can also send out of the cover letter patch. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

[edk2-devel] [PATCH V12 39/47] OvmfPkg: Update PlatformPei to support Tdx guest

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 OvmfPkg/PlatformPei is updated to support Tdx guest. There are below major changes. - Set Tdx related PCDs - Publish Tdx RamRegions In this patch there is another new function BuildPlatformInfoHob (). This function builds

[edk2-devel] [PATCH V12 38/47] OvmfPkg: Update PlatformInitLib for Tdx guest

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 There are below changes in PlatformInitLib for Tdx guest: 1. Publish ram regions In Tdx guest, the system memory is passed in TdHob by host VMM. So the major task of PlatformTdxPublishRamRegions is to walk thru the TdHob list and transfer

[edk2-devel] [PATCH V12 37/47] UefiCpuPkg: Update AddressEncMask in CpuPageTable

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 MMIO region in Tdx guest is set with PcdTdxSharedBitMask in TdxDxe's entry point. In SEV guest the page table entries is set with PcdPteMemoryEncryptionAddressOrMask when creating 1:1 identity table. So the AddressEncMask in

[edk2-devel] [PATCH V12 36/47] MdeModulePkg: Add PcdTdxSharedBitMask

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Guest Physical Address (GPA) space in Td guest is divided into private and shared sub-spaces, determined by the SHARED bit of GPA. This PCD holds the shared bit mask. Its default value is 0 and it will be set in PlatformPei driver if it is

[edk2-devel] [PATCH V12 35/47] MdeModulePkg: Skip setting IA32_ERER.NXE if it has already been set

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 If IA32_ERER.NXE has already been set, skip setting it again. Cc: Jian J Wang Cc: Hao A Wu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann

[edk2-devel] [PATCH V12 34/47] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 If TDX is enabled then we do not support DMA operation in PEI phase. This is mainly because DMA in TDX guest requires using bounce buffer (which need to allocate dynamic memory and allocating a PAGE size'd buffer can be challenge in PEI

[edk2-devel] [PATCH V12 33/47] OvmfPkg: Update Sec to support Tdx

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 There are below major changes in this commit. 1. SecEntry.nasm In TDX BSP and APs goes to the same entry point in SecEntry.nasm. BSP initialize the temporary stack and then jumps to SecMain, just as legacy Ovmf does. APs spin in a

[edk2-devel] [PATCH V12 32/47] OvmfPkg/Sec: Declare local variable as volatile in SecCoreStartupWithStack

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Declare the local variables in SecCoreStartupWithStack that actually move the data elements as volatile to prevent the optimizer from replacing this function with the intrinsic memcpy(). Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh

[edk2-devel] [PATCH V12 31/47] OvmfPkg: Update PlatformInitLib to process Tdx hoblist

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 When host VMM create the Td guest, the system memory informations are stored in TdHob, which is a memory region described in Tdx metadata. The system memory region in TdHob should be accepted before it can be accessed. So the newly added

[edk2-devel] [PATCH V12 30/47] OvmfPkg/PlatformInitLib: Move functions to Platform.c

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Move functions in PlatformPei/Platform.c to PlatformInitLib/Platform.c. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Cc: Sebastien Boeuf

[edk2-devel] [PATCH V12 29/47] OvmfPkg/PlatformInitLib: Create MemDetect.c

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Move functions in PlatformPei\MemDetect.c to PlatformInitLib\MemDetect.c. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Cc: Sebastien

[edk2-devel] [PATCH V12 27/47] OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 NoexecDxeInitialization is split into 2 functions: - PlatformNoexecDxeInitialization is for PlatformInitLib - NoexecDxeInitialization calls PlatformNoexecDxeInitialization and then sets PCD. Cc: Ard Biesheuvel Cc: Jordan Justen Cc:

[edk2-devel] [PATCH V12 28/47] OvmfPkg/PlatformPei: Refactor MiscInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 MiscInitialization is split into 2 functions: - PlatformMiscInitialization is for PlatformInitLib. - MiscInitialization calls PlatformMiscInitialization and then sets PCD. It is for PlatformPei. Cc: Ard Biesheuvel Cc: Jordan Justen

[edk2-devel] [PATCH V12 26/47] OvmfPkg/PlatformPei: Refactor MemMapInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 MemMapInitialization is split into 2 functions: - PlatformMemMapInitialization is for PlatformInfoLib - MemMapInitialization calls PlatformMemMapInitialization and then sets PCDs. It is for PlatformPei. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [PATCH V12 25/47] OvmfPkg/PlatformPei: Refactor InitializeRamRegions

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 InitializeRamRegions is refactored into 3 calls: - PlatformQemuInitializeRam - SevInitializeRam - PlatformQemuInitializeRamForS3 SevInitializeRam is not in PlatformInitLib. Because in the first stage PlatformInitLib only support the

[edk2-devel] [PATCH V12 24/47] OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Rename QemuUc32BaseInitialization to PlatformQemuUc32BaseInitialization. This function is for PlatformInitLib. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH V12 23/47] OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 MaxCpuCountInitialization is splitted into two: - PlatformMaxCpuCountInitialization is for PlatformInitLib - MaxCpuCountInitialization is for PlatformPei. It calls PlatformMaxCpuCountInitialization then sets PCDs. Cc: Ard Biesheuvel

[edk2-devel] [PATCH V12 22/47] OvmfPkg/PlatformPei: Refactor AddressWidthInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 >From this patch we start to restruct the functions which set PCDs into two, one for PlatformInitLib, one for PlatformPei. AddressWidthInitialization is the first one. It is splitted into two: - PlatformAddressWidthInitialization is for

[edk2-devel] [PATCH V12 21/47] OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 Refactor MiscInitialization for CloudHV to set PCD as other platforms do. Because in the following patch we will split the functions which set PCDs into two, one for PlatformInitLib, one for PlatformPei. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [PATCH V12 20/47] OvmfPkg/PlatformPei: Refactor MiscInitialization

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 In MiscInitialization Microvm looks a little weird. Other platforms call PcdSet16S to set the PcdOvmfHostBridgePciDevId with the value same as PlatformInfoHob->HostBridgeDevId. But Microvm doesn't follow this way. In switch-case 0x is

[edk2-devel] [PATCH V12 19/47] OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 The intention of PlatformInitLib is to extract the common function used in OvmfPkg/PlatformPei. This lib will be used not only in PEI phase but also in SEC phase. SEC phase cannot use global variables between different functions. So

[edk2-devel] [PATCH V12 18/47] OvmfPkg/PlatformInitLib: Add hob functions

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 In this patch of PlatformInitLib, below hob functions are introduced: - PlatformAddIoMemoryBaseSizeHob - PlatformAddIoMemoryRangeHob - PlatformAddMemoryBaseSizeHob - PlatformAddMemoryRangeHob - PlatformAddReservedMemoryBaseSizeHob They

[edk2-devel] [PATCH V12 17/47] OvmfPkg: Create initial version of PlatformInitLib

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863 There are 3 variants of PlatformPei in OvmfPkg: - OvmfPkg/PlatformPei - OvmfPkg/XenPlatformPei - OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf These PlatformPeis can share many common codes, such as Cmos / Hob / Memory / Platform related

[edk2-devel] [PATCH V12 15/47] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 IntelTdx.h defines the defition used by TDX in OvmfPkg: - Mailbox related defitions,such as the data structure, command code, AP relocation defitions. See Table 5.44 Multiprocessor Wakeup Mailbox Structure in below link.

[edk2-devel] [PATCH V12 16/47] OvmfPkg: Add TdxMailboxLib

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In Tdx BSP may issues commands to APs for some task, for example, to accept pages paralelly. BSP also need to wait until all the APs have done the task. TdxMailboxLib wraps these common funtions for BSP. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [PATCH V12 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others are treated as APs. So MP intialization is rather simple. ApWorker is not supported, BSP is always the working processor, while the APs are just in a

[edk2-devel] [PATCH V12 13/47] MdePkg: Add macro to check SEV / TDX guest

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Add macros CC_GUEST_IS_SEV / CC_GUEST_IS_TDX to check SEV / TDX guest. Cc: Michael Roth Cc: Ray Ni Cc: Rahul Kumar Cc: Eric Dong Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel

[edk2-devel] [PATCH V12 12/47] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed directly from/to CPU. Some should be accessed via explicit requests from the host VMM using TDCALL(TDG.VP.VMCALL). This is done by the help of TdxLib. Please refer to

[edk2-devel] [PATCH V12 11/47] MdePkg: Support IoRead/IoWrite for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 This commit supports IoRead/IoWrite for SEV/TDX/Legacy guest in one binary. It checks the guest type in runtime and then call corresponding functions. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Brijesh Singh Cc: Erdem

[edk2-devel] [PATCH V12 10/47] MdePkg: Support IoFifo for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Previously IoFifo functions are in X64/IoFifoSev.nasm which supports both SEV guest and Legacy guest. IoLibFifo.c is introduced to support SEV/TDX/Legacy guest in one binary. It checks the guest type in runtime and call corresponding

[edk2-devel] [PATCH V12 09/47] MdePkg: Support mmio for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TDVF access MMIO with TDG.VP.VMCALL to invoke VMM provided emulation functions. If the access to MMIO fails, it fall backs to the direct access. BaseIoLibIntrinsic.inf is the IoLib used by other packages. It will not support I/O in Td

[edk2-devel] [PATCH V12 08/47] MdePkg: Add helper functions for Tdx guest in BaseIoLibIntrinsic

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel TDX architecture does not prescribe a specific software convention to perform I/O from the guest TD. Guest TD providers have many choices to provide I/O to the guest. The common I/O models are emulated devices, para-virtualized

[edk2-devel] [PATCH V12 07/47] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Add base support to handle #VE exceptions. Update the common exception handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib library when a #VE is encountered. A non-zero return code will propagate to the targeted exception

[edk2-devel] [PATCH V12 06/47] OvmfPkg: Extend VmgExitLib to handle #VE exception

RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 The base VmgExitLib library provides a default limited interface to handle #VE exception. To provide full support, the OVMF version of VmgExitLib is extended to provide full support of #VE handler. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc:

[edk2-devel] [PATCH V12 05/47] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception

RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 VmgExitLib performs the necessary processing to handle a #VC exception. VmgExitLibNull is a NULL instance of VmgExitLib which provides a default limited interface. In this commit VmgExitLibNull is extended to handle a #VE exception with a

[edk2-devel] [PATCH V12 04/47] MdePkg: Add TdxLib to wrap Tdx operations

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TdxLib is created with functions to perform the related Tdx operation. This includes functions for: - TdAcceptPages : Accept pending private pages and initialize the pages to all-0 using the TD ephemeral private key.

[edk2-devel] [PATCH V12 03/47] MdePkg: Introduce basic Tdx functions in BaseLib

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Introduce basic Tdx functions in BaseLib: - TdCall () - TdVmCall () - TdIsEnabled () Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc:

[edk2-devel] [PATCH V12 02/47] MdePkg: Update Cpuid.h for Tdx

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Guest software can be designed to run either as a TD, as a legacy virtual machine, or directly on the CPU, based on enumeration of its run-time environment. [TDX-Module] Chap 10.2 defines the flow and the new CPUID leaf 0x21. [TDX-Module]

[edk2-devel] [PATCH V12 01/47] MdePkg: Add Tdx.h

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx.h includes the Intel Trust Domain Extension definitions. Detailed information can be found in below document: https://software.intel.com/content/dam/develop/external/us/en/ documents/tdx-module-1eas-v0.85.039.pdf Cc: Michael D Kinney

[edk2-devel] [PATCH V12 00/47] Enable Intel TDX in OvmfPkg (Config-A)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3249 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

Re: [edk2-devel] CryptoPkg build broken using XCODE5 (Availability.h not found)

Rebecca, I got it to compile by doing this diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf index cdeed0d073eb..72dbeb2795e8 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf +++

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

> On Mar 29, 2022, at 2:38 PM, Andrew Fish via groups.io > wrote: > > > >> On Mar 29, 2022, at 11:14 AM, gr...@grantlmul.xyz >> wrote: >> >> While I can't test this myself, the following does appear to result in a >> successful build using the same clang

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

> On Mar 29, 2022, at 11:14 AM, gr...@grantlmul.xyz wrote: > > While I can't test this myself, the following does appear to result in a > successful build using the same clang version: > > > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile

[edk2-devel] [PATCH 2/3] UefiPayloadPkg: Fix build on IA32

Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UniversalPayloadBuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py index ac965766c7..1b99eeff34 100644 ---

[edk2-devel] [PATCH 3/3] UefiPayloadPkg: Add --quiet argument to Universal Payload build script

Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UniversalPayloadBuild.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py index 1b99eeff34..61423e5908 100644 ---

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

While I can't test this myself, the following does appear to result in a successful build using the same clang version: diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa..81aa35aa31 100644 ---

[edk2-devel] [PATCH v1 15/15] UefiCpuLib: Remove UefiCpuLib.

Step 4 to merge UefiCpuLib to CpuLib. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yu Pu --- UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLibNull.c | 16 - UefiCpuPkg/Include/Library/UefiCpuLib.h| 4 --- UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf

[edk2-devel] [PATCH v1 06/15] UefiPayloadPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

Step 1 to merge UefiCpuLib to CpuLib. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Yu Pu --- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h| 1 + UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 +

[edk2-devel] [PATCH v1 14/15] UefiPayloadPkg: Remove UefiCpuLib from module INFs.

Step 3 to merge UefiCpuLib to CpuLib. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Yu Pu --- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h| 1 - UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 1 -

[edk2-devel] [PATCH v1 10/15] OvmfPkg: Remove UefiCpuLib from module INFs.

Step 3 to merge UefiCpuLib to CpuLib. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Yu Pu --- OvmfPkg/Sec/SecMain.c | 1 - OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - OvmfPkg/Bhyve/BhyveX64.dsc | 1 - OvmfPkg/CloudHv/CloudHvX64.dsc | 1 -

[edk2-devel] [PATCH v1 11/15] PcAtChipsetPkg: Remove UefiCpuLib from module INFs.

Step 3 to merge UefiCpuLib to CpuLib. Cc: Ray Ni Signed-off-by: Yu Pu --- PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc b/PcAtChipsetPkg/PcAtChipsetPkg.dsc index 451e60ddc857..2f02ecf6fd11 100644 ---

[edk2-devel] [PATCH v1 12/15] SourceLevelDebugPkg: Remove UefiCpuLib from module INFs.

Step 3 to merge UefiCpuLib to CpuLib. Cc: Hao A Wu Signed-off-by: Yu Pu --- SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc index eba64a7b7877..986dd5a769d3

[edk2-devel] [PATCH v1 13/15] UefiCpuPkg: Remove UefiCpuLib from module INFs.

Step 3 to merge UefiCpuLib to CpuLib. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yu Pu --- UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 - UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 - UefiCpuPkg/CpuDxe/CpuDxe.h

[edk2-devel] [PATCH v1 09/15] IntelFsp2Pkg: Remove UefiCpuLib from module INFs.

Step 3 to merge UefiCpuLib to CpuLib. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Yu Pu --- IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 - IntelFsp2Pkg/FspSecCore/SecMain.h | 1 - IntelFsp2Pkg/IntelFsp2Pkg.dsc

[edk2-devel] [PATCH v1 07/15] MdePkg: Move API and implementation from UefiCpuLib to CpuLib

Step 2 to merge UefiCpuLib to CpuLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Yu Pu --- MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c | 122 MdePkg/Include/Library/CpuLib.h | 65 +++

[edk2-devel] [PATCH v1 08/15] UefiCpuPkg: Move API and implementation from UefiCpuLib to CpuLib

Step 2 to merge UefiCpuLib to CpuLib. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yu Pu --- UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c| 81 UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLibNull.c| 16

[edk2-devel] [PATCH v1 05/15] UefiCpuPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

Step 1 to merge UefiCpuLib to CpuLib. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Yu Pu --- UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 + UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 1 + UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf

[edk2-devel] [PATCH v1 04/15] OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

Step 1 to merge UefiCpuLib to CpuLib. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Yu Pu --- OvmfPkg/Sec/SecMain.c | 1 + OvmfPkg/Sec/SecMain.inf | 1 + 2 files changed, 2 insertions(+) diff --git a/OvmfPkg/Sec/SecMain.c b/OvmfPkg/Sec/SecMain.c

[edk2-devel] [PATCH v1 00/15] Merge UefiCpuLib to CpuLib

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Today lots of duplicated code call CPUID and calculates the address mask. Adding an API named GetPhysicalAddressBits in UefiCpuLib can solve this problem, but at the same time cause MdeModulePkg depend on UefiCpuPkg which does not meet

[edk2-devel] [PATCH v1 01/15] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib

Step 1 to merge UefiCpuLib to CpuLib. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Yu Pu --- IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 + IntelFsp2Pkg/FspSecCore/SecMain.h | 1 + 2 files changed, 2 insertions(+) diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf

[edk2-devel] [PATCH v1 02/15] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

Step 1 to merge UefiCpuLib to CpuLib. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Yu Pu --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf | 1 + IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf | 1 + 2 files changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v1 03/15] MdePkg: Add CpuLib to module INFs that depend on UefiCpuLib.

Step 1 to merge UefiCpuLib to CpuLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Yu Pu --- MdePkg/MdeLibs.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc index 3c70daf87a0c..322575090239 100644 ---

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

It was merged. From: Sean Rhodes Sent: Tuesday, March 29, 2022 11:05 AM To: Dong, Guo Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hi Guo Merge conflict is resolved Thanks Sean On Tue, 29 Mar

[edk2-devel] [PATCH] UefiPayloadPkg: Add --quiet argument to Universal Payload build script

Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UniversalPayloadBuild.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py index e624ec5874..61fe3f79f5 100644 ---

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

Hi Guo Merge conflict is resolved Thanks Sean On Tue, 29 Mar 2022 at 19:01, Dong, Guo wrote: > > > Hi Sean, > > > > I would help solve merge conflict and then merge > https://github.com/tianocore/edk2/pull/2654. > > For another patch, please contact MdeModulePkg maintainer to help merge it.

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

Hi Sean, I would help solve merge conflict and then merge https://github.com/tianocore/edk2/pull/2654. For another patch, please contact MdeModulePkg maintainer to help merge it. Thanks, Guo From: Sean Rhodes Sent: Tuesday, March 29, 2022 10:35 AM To: Dong, Guo Cc: devel@edk2.groups.io

Re: [edk2-devel][PATCH] UefiPayloadPkg: Support IA32 Build

Reviewed-by: Sean Rhodes On Tue, 29 Mar 2022 at 18:41, wrote: > From: Guo Dong > > The payload entry module should support to build as IA32 image > beside X64 image so that it could work with 32bit bootloaders. > > This patch adds a option build parameter for arch selection. > > Cc: Ray Ni

[edk2-devel][PATCH] UefiPayloadPkg: Support IA32 Build

From: Guo Dong The payload entry module should support to build as IA32 image beside X64 image so that it could work with 32bit bootloaders. This patch adds a option build parameter for arch selection. Cc: Ray Ni Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Guo Dong ---

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

Hey No problem and thank you. That have been reviewed, it's just these two: https://github.com/tianocore/edk2/pull/2654 https://github.com/tianocore/edk2/pull/2485 Thanks Sean On Tue, 29 Mar 2022 at 18:32, Dong, Guo wrote: > > > Hi Sean, > > > > Sorry for late response. I merged several

[edk2-devel] CryptoPkg build broken using XCODE5 (Availability.h not found)

A build of CryptoPkg with XCODE5 on macOS is now trying to include Availability.h, which isn't found: In file included from /Users/bcran/src/uefi/edk2/CryptoPkg/Library/OpensslLib/openssl/crypto/init.c:13:

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

Hi Sean, Sorry for late response. I merged several UEFI payload packages yesterday including this one. Please let me know if you have other patches pending to merge (The patches passed code review). Thanks, Guo From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Monday, March 21, 2022

Re: [edk2-devel] [PATCH v1 00/41] Add PrmPkg

Reviewed-by: Ankit Sinha > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Tuesday, March 22, 2022 9:19 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Gao, Kang ; > Kinney, Michael D ; Kubacki, Michael > ; Leif Lindholm ; You, > Benjamin ; Liu,

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

Hi Yuanhao, The suggestion looks good to me. Thanks, Guo -Original Message- From: Xie, Yuanhao Sent: Monday, March 28, 2022 11:54 PM To: Dong, Guo ; Ni, Ray Cc: You, Benjamin ; Rhodes, Sean ; devel@edk2.groups.io Subject: RE: [PATCH 1/2] UefiPayloadPkg: Add a new

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

Hi, > Personally, I would like to use plain OVMF without any bhyve specific patches > as firmware for bhyve. So, I want to go the qemu route but there's some more > work to do. I already took a look at how qemu creates ACPI tables but don't > understand it yet. Would be very grateful if you or

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf

Thanks Gerd for reviewing. On 29/03/2022 14:36, Gerd Hoffmann wrote: > On Mon, Mar 28, 2022 at 06:45:29PM +, Dov Murik wrote: >> Reorder the pages in the MEMFD section of AmdSevX64.fdf so that it >> matches the same order used in OvmfPkgX64.fdf. > > Makes sense. > > Acked-by: Gerd Hoffmann

Re: [edk2-devel] [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

On March 28, 2022 4:25 PM, Ni Ray wrote: > > + CopyMem (ProcessorInfoBuffer, , sizeof > + (EFI_PROCESSOR_INFORMATION)); > > Min, > You may not directly copy the whole structure to ProcessorInfoBuffer. > > Because per the structure definition(below), ExtendedInformation is only > filled > when

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

Yes, MPX is dead. Thank you to remove the MPX suggestion. And we could focus on PEI/DXE firstly. Thanks Steven Shi From: Pedro Falcato Sent: Tuesday, March 29, 2022 12:31 AM To: edk2-devel-groups-io ; Shi, Steven Cc: Andrew Fish ; vit9...@protonmail.com; Marvin Häuser ; Kinney, Michael D ;

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

Hi Gerd, > But I think I'd tend to keep the bhyve-specific behavior nevertheless, > so you don't have to worry about qemu quirks. Ok. I will leave it as is. > Or go the qemu route and generate the acpi tables on the host instead. > When you generate the acpi tables in the guest firmware you

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf

On Mon, Mar 28, 2022 at 06:45:29PM +, Dov Murik wrote: > Reorder the pages in the MEMFD section of AmdSevX64.fdf so that it > matches the same order used in OvmfPkgX64.fdf. Makes sense. Acked-by: Gerd Hoffmann Maybe also move this to a common include file, so it is less likely that they

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

On Tue, Mar 29, 2022 at 09:57:40AM +, Corvin Köhne wrote: > Hi Gerd, > > > There is FW_CFG_NB_CPUS + FW_CFG_MAX_CPUS. ovmf uses different names, > > see OvmfPkg/Include/IndustryStandard/QemuFwCfg.h > > > > PlatformPei for qemu uses QemuFwCfgItemSmpCpuCount aka FW_CFG_NB_CPUS, > > which is

[edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

From: Corvin Köhne QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl decided to use the same IO ports as QemuFwCfg. It's not possible to use both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl. Signed-off-by: Corvin Köhne Acked-by: Gerd Hoffmann CC: Ard

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

Hi Gerd, > Hmm, so QemuFwCfg and BhyveFwCtl are incompatible but use the same > ports? I guess the signature used is different then so the guest > has a chance to figure which one is active? Yes, BhyveFwCtl uses another signature. Best regards Corvin Beckhoff Automation GmbH & Co. KG |

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

Hi Gerd, > There is FW_CFG_NB_CPUS + FW_CFG_MAX_CPUS. ovmf uses different names, > see OvmfPkg/Include/IndustryStandard/QemuFwCfg.h > > PlatformPei for qemu uses QemuFwCfgItemSmpCpuCount aka FW_CFG_NB_CPUS, > which is the number of cpus which are online. > > I think FW_CFG_MAX_CPUS is basically

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

On Tue, Mar 29, 2022 at 08:54:37AM +0200, Corvin Köhne wrote: > From: Corvin Köhne > > QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl > decided to use the same IO ports as QemuFwCfg. It's not possible to use > both interfaces simultaneously. So, prefer QemuFwCfg over

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

On Tue, Mar 29, 2022 at 08:54:36AM +0200, Corvin Köhne wrote: > Hi, > > I'm going to add QemuFwCfg support to bhyve. See > https://reviews.freebsd.org/D31578. Therefore, this patch for OVMF is > neccessary to work properly. > > There's one open point on that patch and hopefully one of you has

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg: Add dependency of VariableSmm driver to make it work normally.

On Tue, Mar 29, 2022 at 02:37:38PM +0800, Li, Zhihao wrote: > REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3861 > > UefiCpuPkg define a new Protocol with the new services > SmmWaitForAllProcessor(), which can be used by SMI handler > to optionally wait for other APs to complete SMM

[edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround

Apply the workaround only in case the compiler is gcc. Fixes builds with clang. Fixes: 22130dcd98b4 ("Basetools: turn off gcc12 warning") Reported-by: Rebecca Cran Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/DevicePath/GNUmakefile | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Add dependency of VariableSmm driver.

REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3882 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need use

[edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

From: Corvin Köhne QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl decided to use the same IO ports as QemuFwCfg. It's not possible to use both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl. Signed-off-by: Corvin Köhne CC: Ard Biesheuvel CC: Jiewen Yao

[edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

Hi, I'm going to add QemuFwCfg support to bhyve. See https://reviews.freebsd.org/D31578. Therefore, this patch for OVMF is neccessary to work properly. There's one open point on that patch and hopefully one of you has more insights. Qemu has an item called FW_CFG_MAX_CPUS. It looks very similar

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a new DebugPrintErrorLevelLib instance

Hi Guo, Sorry for the late response. Just as we discussed today, and also from the suggestions by Ray, in the new patch I will 1. changed "UNIVERSAL_PAYLOAD_ DEBUG_PRINT_ERROR_LEVEL" to "UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL", and 2. add a comment referencing Debuglib.h to declare bits for

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Add dependency of VariableSmm driver.

REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3882 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need use

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Add dependency of VariableSmm driver.

REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3882 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need use

[edk2-devel] [PATCH v1 1/1] OvmfPkg: Add dependency of VariableSmm driver to make it work normally.

REF： https://bugzilla.tianocore.org/show_bug.cgi?id=3861 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need use

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

Agree with Jian. I don’t understand this patch set and the feature. I request a design review in EDKII. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian > J > Sent: Tuesday, March 29, 2022 2:12 PM > To: devel@edk2.groups.io; Gao, Liming ;

  1   2   >