Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/UsbBusDxe: Reset the device on error

2022-09-20 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > Sent: Tuesday, September 20, 2022 9:14 PM > To: devel@edk2.groups.io > Cc: Rhodes, Sean ; Wu, Hao A > ; Ni, Ray > Subject: [edk2-devel] [PATCH 2/2] MdeModulePkg/UsbBusDxe: Reset the > device on error > > Try

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-20 Thread Wu, Hao A
Sorry, could you help to share more information on what issue is met for this proposed patch? It seems to me that the change made below is to handle the case where: Status = HubApi->GetPortStatus (HubIf, Port, ); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: failed

Re: [edk2-devel] [PATCH V3 0/3] CryptoPkg: Add EC support

2022-09-20 Thread yi1 li
Resend patch sets because of typos in comment message. -Original Message- From: Li, Yi1 Sent: Wednesday, September 21, 2022 1:27 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Subject: [PATCH V3 0/3] CryptoPkg: Add EC support REF:

[edk2-devel] [PATCH 1/2] OvmfPkg/QemuBootOrderLib: allow slash in rom filenames

2022-09-20 Thread Gerd Hoffmann
See comment for details. Needed to avoid the parser abort, so we can continue parsing the bootorder fw_cfg file. Signed-off-by: Gerd Hoffmann --- .../QemuBootOrderLib/QemuBootOrderLib.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 0/2] OvmfPkg/QemuBootOrderLib: StoreQemuBootOrder bugfix

2022-09-20 Thread Gerd Hoffmann
Gerd Hoffmann (2): OvmfPkg/QemuBootOrderLib: allow slash in rom filenames OvmfPkg/QemuBootOrderLib: skip over unsupported entries in StoreQemuBootOrder .../QemuBootOrderLib/QemuBootOrderLib.c | 75 --- 1 file changed, 48 insertions(+), 27 deletions(-) -- 2.37.3

[edk2-devel] [PATCH 2/2] OvmfPkg/QemuBootOrderLib: skip over unsupported entries in StoreQemuBootOrder

2022-09-20 Thread Gerd Hoffmann
When finding an unsupported entry just skip over and continue with the next entry instead of stop processing altogether. Signed-off-by: Gerd Hoffmann --- .../QemuBootOrderLib/QemuBootOrderLib.c | 56 ++- 1 file changed, 30 insertions(+), 26 deletions(-) diff --git

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide a wrapper for UniversalPayloadBuild.py

2022-09-20 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Hsu, VictorX Sent: Tuesday, September 20, 2022 7:19 PM To: devel@edk2.groups.io Cc: Hsu, VictorX ; Dong, Guo ; Lu, James Subject: [PATCH] UefiPayloadPkg: Provide a wrapper for UniversalPayloadBuild.py From: VictorX Hsu REF:

Re: [edk2-devel] [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib

2022-09-20 Thread yi1 li
Hi Jiewen, Thanks for review, changes done. Since both BN and EC extend many structures, splitting them will cause git conflicts, I've adjusted the order of patches: Ec commits are based on Bn commits. Just convenient for merge. Thanks, Yi -Original Message- From: Yao, Jiewen Sent:

[edk2-devel] [PATCH V2 3/3] CryptoPkg/Test: Add unit test for CryptoEc

2022-09-20 Thread yi1 li
Add unit test for CryptoEc. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 + CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 + .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +

[edk2-devel] [PATCH V2 2/3] CryptoPkg: Add EC APIs to DXE and protocol

2022-09-20 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 The implementation provides CryptEc library functions for EFI Driveer and EFI BaseCrypt Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- CryptoPkg/CryptoPkg.dsc |

[edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support

2022-09-20 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 This patch is used to add CryptEc library, which is wrapped over OpenSSL. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- CryptoPkg/Include/Library/BaseCryptLib.h | 424 ++

[edk2-devel] [PATCH V2 3/3] CryptoPkg/Test: Add unit test for CryptoBn

2022-09-20 Thread yi1 li
Add unit test for CryptoBn. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 1 + .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 + .../UnitTest/Library/BaseCryptLib/BnTests.c | 266

[edk2-devel] [PATCH V2 2/3] CryptoPkg: Add BigNum API to DXE and protocol

2022-09-20 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 The implementation provides CryptBn library functions for EFI Driver and EFI BaseCrypt Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- CryptoPkg/CryptoPkg.dsc |

[edk2-devel] [PATCH V2 1/3] CryptoPkg: Add BigNum support

2022-09-20 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 This patch is used to add CryptBn library, which is wrapped over OpenSSL. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- CryptoPkg/Include/Library/BaseCryptLib.h | 418 +

[edk2-devel] [PATCH V2 0/3] CryptoPkg: Add BigNum support

2022-09-20 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828 Review PR: https://github.com/tianocore/edk2/pull/3309 This patch sequence is used to add CryptBn library, which are wrapped over OpenSSL. The implementation provides library functions for EFI BaseCrypt protocol and EFI BaseCrypt

[edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4074

2022-09-20 Thread Jiading Zhang
Update XhcEvaluateContext/XhcEvaluateContext64 to properly initialize the input context for Evaluate Context command. Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c

[edk2-devel] [PATCH] MdeModulePkg: Add new reviewer for Device and Peripheral modules

2022-09-20 Thread Ni, Ray
Signed-off-by: Ray Ni Cc: Hao A Wu Cc: Foster Nong --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index c641414109..aad36074ef 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -321,6 +321,7 @@ F:

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-20 Thread RichardHo [何明忠] via groups . io
Hi Abner, For #4, To see below code. RNDIS driver provide the RndisUndiStart routine. It could execute RndisUndiStart in UndiStart routine end. The upper layer driver not need to know the USB CDC driver interface class. It only provide the

回复: 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line

2022-09-20 Thread gaoliming via groups.io
Sivaparvathi: I use Hexedit command and use F3 to exit it. But, I don’t find the redundant symbol on the screen. How do you reproduce this issue? Thanks Liming 发件人: devel@edk2.groups.io 代表 sivaparvathi C via groups.io 发送时间: 2022年9月15日 12:45 收件人: gaoliming ; devel@edk2.groups.io 主题: Re:

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-20 Thread Michael D Kinney
Tera Term works. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming via > groups.io > Sent: Tuesday, September 20, 2022 6:26 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > aladyshe...@gmail.com > Cc: Wang, Jian J ; Ni, Ray > Subject: 回复: [edk2-devel]

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-20 Thread Wu, Hao A
Hello, I created the a Bugzilla tracker for this issue at: https://bugzilla.tianocore.org/show_bug.cgi?id=4074. I have attached the tracker mail and please help to check if the issue report looks good to you. If needed I can help to update the tracker before you got the Bugzilla access. Also,

回复: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-20 Thread gaoliming via groups.io
Konstantin: Do you try the terminal software (such as Putty) to display the text mode 160, 42 or 240, 56? I try Putty in my desktop. It can't display 240 * 56 in one screen. Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2022年9月20日 5:02 > 收件人: devel@edk2.groups.io;

[edk2-devel] 回复: [PATCH v2] BaseTools/VolInfo: Show encapsulation sections

2022-09-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Konstantin Aladyshev > 发送时间: 2022年7月19日 20:29 > 收件人: devel@edk2.groups.io > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; > yuwei.c...@intel.com; Konstantin Aladyshev > 主题: [PATCH v2] BaseTools/VolInfo: Show encapsulation sections > >

回复: [edk2-devel] [PATCH] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

2022-09-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Konstantin > Aladyshev > 发送时间: 2022年7月19日 17:50 > 收件人: devel@edk2.groups.io > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; > yuwei.c...@intel.com; Konstantin Aladyshev > 主题: [edk2-devel] [PATCH] BaseTools/VolInfo:

回复: [edk2-devel] [PATCH v2] BaseTools: Add missing spaces for PCD expression values in AutoGenC

2022-09-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Konstantin > Aladyshev > 发送时间: 2022年8月30日 18:20 > 收件人: devel@edk2.groups.io > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; > yuwei.c...@intel.com; Konstantin Aladyshev > 主题: [edk2-devel] [PATCH v2] BaseTools: Add

回复: [edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo

2022-09-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Konstantin > Aladyshev > 发送时间: 2022年9月1日 23:54 > 收件人: devel@edk2.groups.io > 抄送: dandan...@intel.com; eric.d...@intel.com; Konstantin Aladyshev > > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo > > Fix typo

[edk2-devel] 回复: [PATCH] BaseTools: Correct BPDG tool error prints

2022-09-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Konstantin Aladyshev > 发送时间: 2022年9月5日 17:19 > 收件人: devel@edk2.groups.io > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; > yuwei.c...@intel.com; Konstantin Aladyshev > 主题: [PATCH] BaseTools: Correct BPDG tool error prints > > Popen

Re: [edk2-devel] EDKII CI Failure

2022-09-20 Thread Yao, Jiewen
Thank you Sean and Mike! > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Sent: Wednesday, September 21, 2022 8:01 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; Yao, Jiewen ; > Kubacki, Michael ; Sean Brogan > > Subject: Re: [edk2-devel] EDKII CI Failure > >

Re: [edk2-devel] EDKII CI Failure

2022-09-20 Thread Sean
Looking at it. The vm image for VS2019 did change between working and failing build. Will update once we figure something out. Thanks Sean On 9/20/2022 4:36 PM, Michael D Kinney wrote: Hi Jiewen, Looks like it is not limited to that one PR. I see this PR has similar failure. The

Re: [edk2-devel] EDKII CI Failure

2022-09-20 Thread Michael D Kinney
Hi Jiewen, Looks like it is not limited to that one PR. I see this PR has similar failure. The artifacts show a more detailed log with nmake.exe not found. That does not make sense for a windows/VS2019 build after vswhere is used to find path to VS2019 tools. Perhaps Michael or Sean can help

[edk2-devel] EDKII CI Failure

2022-09-20 Thread Yao, Jiewen
Hi I notice that EDKII CI failed on step "Build Base Tools from source" for https://github.com/DMTF/libspdm/pull/1218 https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62090=logs=c0929384-5a08-5c0f-b36d-6f51b6b81732=dc6c8514-4845-5cff-3ead-20e6776e3d52 Anyone knows what is

Re: [edk2-devel] [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

2022-09-20 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Wenyi Xie > Sent: Thursday, September 15, 2022 5:26 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian > J ; Lu, Xiaoyu1 ; Jiang, > Guomin > Cc: songdongku...@huawei.com; xiewen...@huawei.com > Subject: [PATCH EDK2 v1 1/1]

Re: [edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

2022-09-20 Thread Jeff Brasen via groups.io
Thanks will fix those in v5. Will see if Sami has any other comments before pushing these. -Jeff > -Original Message- > From: Pierre Gondois > Sent: Tuesday, September 20, 2022 8:54 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; alexei.fedo...@arm.com;

[edk2-devel] [edk2-staging/HttpProxy] Introduction of new branch

2022-09-20 Thread Maciej Rabeda
Hello EDK2 Community, The "HttpProxy" branch was created in edk2-staging repository. Role of this branch is to cover changes necessary for HTTP proxy support (mainly for booting) that also affect UEFI specification (device path). Link to branch:

[edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2022-09-20 Thread Vijayenthiran Subramaniam
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in SgiPlatformMm.dsc.inc to resolve this

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Lu, Ken
> > So there are two types loaders: > > 1. QemuKernelLoaderFsDxe - this way just put kernel/initrd blob into a FS > for any future's usage, may be continue boot or not. > > 2. QemuLoadKernelImage,-this is consumed by TryRunningQemuKernel() > - standard Qemu direct boot path > > Nope.

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Lu, Ken
> > Hi Ard, I think it better let creator to measure instead of consumer to > > measure > like today's implementation in grub[1]. The creator here means who load/create > it. In direct boot, it is OVMF read kernel command line and initrd image. In > grub > boot, it is grub2. Because the number

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Lu, Ken
> > > > Not fundamentally, no. But between the measurement of the image itself (which > the firmware should do) and the measurement of the initrd and command line > (which the EFI stub will do), I'm not sure there is that much left. > In general, I think the combinatorial explosion of CC

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Lu, Ken
> > Hi Ard, I think it better let creator to measure instead of consumer > > to measure like today's implementation in grub[1]. The creator here > > means who load/create it. In direct boot, it is OVMF read kernel > > command line and initrd image. > > Nope. OVMF just places kernel, initrd and

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Lu, Ken
> -Original Message- > From: Ard Biesheuvel > Sent: Monday, September 19, 2022 2:59 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Aktas, > Erdem ; James Bottomley ; > Yao, Jiewen ; Gerd Hoffmann ; Lu, > Ken > Subject: Re: [edk2-devel] measurement to command-line/initrd

Re: [edk2-devel] [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib

2022-09-20 Thread Yao, Jiewen
Thanks for the patch. Please: 1) Separate BN and EC. Please submit 2 different patch sets. One for EC, the other for BN. 2) Please squash uncrustify tool update into previous patch. No need to submit a standalone one. 3) Please increase EDKII_CRYPTO_VERSION. With that change, reviewed-by:

Re: [edk2-devel] [PATCH 0/4] CryptoPkg: add AeadAesGcm support.

2022-09-20 Thread Yao, Jiewen
Thanks for the patch. Please 1) Update the EDKII_CRYPTO_VERSION to higher version With that change, reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Monday, August 29, 2022 4:43 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen > ; Wang, Jian J ; Lu,

Re: [edk2-devel] [PATCH 0/4] CryptoPkg: Add Hkdf SHA384 support

2022-09-20 Thread Yao, Jiewen
Thanks for the patch. Please 1) Update the EDKII_CRYPTO_VERSION to higher version 2) Update always append new API to the end of _EDKII_CRYPTO_PROTOCOL (don't insert in the middle) With that change, reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August

Re: [edk2-devel] [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-09-20 Thread Yao, Jiewen
Thanks for the patch. Please 1) Update the EDKII_CRYPTO_VERSION to higher version 2) Update always append new API to the end of _EDKII_CRYPTO_PROTOCOL (don't insert in the middle) With that change, reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August

Re: [edk2-devel] [PATCH v4 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

2022-09-20 Thread PierreGondois
Hello Jeff, Just 2 minors comments. Maybe Sami will have more. Otherwise, for the 3 patches: Reviewed-by: Pierre Gondois Regards, Pierre On 9/20/22 00:01, Jeff Brasen wrote: _CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Ard Biesheuvel
On Tue, 20 Sept 2022 at 15:24, Lu, Ken wrote: > > > > Hi Ard, I think it better let creator to measure instead of consumer to > > > measure > > like today's implementation in grub[1]. The creator here means who > > load/create > > it. In direct boot, it is OVMF read kernel command line and

[edk2-devel] [PATCH v5 4/4] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-09-20 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

[edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)

2022-09-20 Thread Oliver Steffen
Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not

[edk2-devel] [PATCH v5 2/4] CI: add ~/.local/bin to PATH (Linux only)

2022-09-20 Thread Oliver Steffen
Fix pip install. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-build-run-steps.yml

[edk2-devel] [PATCH v5 1/4] CI: don't force python verison (Linux only)

2022-09-20 Thread Oliver Steffen
Use the Python supplied by the container image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 1 + .azurepipelines/templates/pr-gate-steps.yml| 1 + 2 files changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v5 0/4] CI: Use Fedora 35 container for Linux jobs

2022-09-20 Thread Oliver Steffen
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom containers. The container image provides the required compiler toolchains and Qemu for the supported architectures. These are then no longer downloaded at runtime, avoiding CI failures due to download errors. This approach also makes

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Ard Biesheuvel
On Tue, 20 Sept 2022 at 15:44, James Bottomley wrote: > > [pjones added because he's done a huge amount of work to get shim to > measure stuff correctly] > On Tue, 2022-09-20 at 13:24 +, Lu, Ken wrote: > > > > Hi Ard, I think it better let creator to measure instead of > > > > consumer to

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Gerd Hoffmann
On Tue, Sep 20, 2022 at 01:38:05PM +, Lu, Ken wrote: > > > Hi Ard, I think it better let creator to measure instead of consumer > > > to measure like today's implementation in grub[1]. The creator here > > > means who load/create it. In direct boot, it is OVMF read kernel > > > command line

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread James Bottomley
[pjones added because he's done a huge amount of work to get shim to measure stuff correctly] On Tue, 2022-09-20 at 13:24 +, Lu, Ken wrote: > > > Hi Ard, I think it better let creator to measure instead of > > > consumer to measure > > like today's implementation in grub[1]. The creator here

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Gerd Hoffmann
Hi, > Hi Ard, I think it better let creator to measure instead of consumer > to measure like today's implementation in grub[1]. The creator here > means who load/create it. In direct boot, it is OVMF read kernel > command line and initrd image. Nope. OVMF just places kernel, initrd and

[edk2-devel] [PATCH 2/2] MdeModulePkg/UsbBusDxe: Reset the device on error

2022-09-20 Thread Sean Rhodes
Try a port reset if GetPortStatus returns and error. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Sean Rhodes --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c

[edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-20 Thread Sean Rhodes
Zero out the PortState in case GetPortStatus didn't set it, to avoid continuing with EFI_DEVICE_ERROR. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Sean Rhodes --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Ard Biesheuvel
On Tue, 20 Sept 2022 at 14:56, Lu, Ken wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, September 19, 2022 2:59 PM > > To: Xu, Min M > > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Aktas, > > Erdem ; James Bottomley ; > > Yao, Jiewen ; Gerd Hoffmann ; Lu, > >

Re: [edk2-devel] measurement to command-line/initrd for loading kernel via -kernel option

2022-09-20 Thread Ard Biesheuvel
(cc Ilias, Matt, Peter[], Daniel[]) On Tue, 20 Sept 2022 at 02:20, Xu, Min M wrote: > > On September 19, 2022 2:59 PM, Ard Biesheuvel wrote: > > On Mon, 19 Sept 2022 at 04:13, Xu, Min M wrote: > > > > > > On September 18, 2022 8:52 PM, Ard Biesheuvel wrote: > > > > Hello Min Xu, > > > > > > > >

[edk2-devel] [PATCH] UefiPayloadPkg: Provide a wrapper for UniversalPayloadBuild.py

2022-09-20 Thread victorx . hsu
From: VictorX Hsu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4071 Provide a wrapper to wrap UniversalPayloadBuild.py Cc: Guo Dong Cc: James Lu Signed-off-by: VictorX Hsu --- UefiPayloadPkg/UniversalPayloadBuild | 14 ++ 1 file changed, 14 insertions(+) create mode

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-20 Thread Jiading Zhang
Hi Miki: I want to file a Bugzilla to track this issue , but I haven't a Bugzilla account yet, could you please help to process? Thanks! -- 张家定 固件产品部 产品三部 昆仑太科(北京)技术股份有限公司

Re: [edk2-devel] Logical operator function in shell environment

2022-09-20 Thread Tiger Liu(BJ-RD)
Hi, Ray: Thanks for your reply! I looked it up in shell spec, not find logical operator functions supported. I found shell supported redirect output to an environment variable. But I could not succeed in my experiment. For example: 1. I create a environment variable "testvar" with set command 2.

Re: [edk2-devel] Logical operator function in shell environment

2022-09-20 Thread Ni, Ray
I don't know whether Shell supports such capability. Can you check the Shell spec? It's also possible that Spec supports such capability but implementation doesn't. Then you are welcome to implement that in ShellPkg. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tiger

Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

2022-09-20 Thread Wu, Hao A
Thanks. Could you help to: 1) File a Bugzilla to track this issue at https://bugzilla.tianocore.org/enter_bug.cgi?product=EDK2; 2) Send a new version of the patch for code changes (please update XhcEvaluateContext function accordingly as well). Best Regards, Hao Wu From: devel@edk2.groups.io