Will follow up in my next patch.
-Original Message-
From: Michael Kubacki
Sent: Wednesday, December 21, 2022 11:42 AM
To: devel@edk2.groups.io; Guo, Gua
Cc: Sean Brogan ; Barkelew, Bret
; Kinney, Michael D ;
Gao, Liming
Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Install c
On Wed, Dec 21, 2022 at 09:29:51AM +0800, gaoliming via groups.io wrote:
> Gerd:
> I will merge these two changes in tools_def.txt. Is it OK to you?
Yes.
thanks,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97676): https://e
Please let me summarize my feedback:
0) In general, please don't just say something is "secure" or "not secure".
Without a clear threat mode, it just brings confusing to other security people.
I recommend we describe clearly on the TCB assumption, adversary,
vulnerability, etc.
1) I recommend
Merged https://github.com/tianocore/edk2/pull/3812
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, December 16, 2022 2:28 AM
> To: Yao, Jiewen ; Wang, Jian J
> ; devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Mistry, Nishant C ; Vang, Judah
>
> Subject: RE: [PATCH] Secur
From: Vu Nguyen
The hob was built but wasn't consumed yet. This change will let the DXE
Main shift the memory space consumed by DXE modules to the region
specified by the PcdSystemMemoryBase and PcdSystemMemorySize.
Signed-off-by: Nhi Pham
---
.../Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc |
From: Tinh Nguyen
PrePeiCore's Arm module just added a requirement to run all library
constructors that PrePeiCore uses. One of them is included in the
constructor of the ExtractGuidedSectionLib. This constructor will build
a HOB that is not supported "at this time" and causes an error.
We don't
I understand the problem. Have you looked into tools like the one I
linked? It also has a DevOps extension -
https://marketplace.visualstudio.com/items?itemName=Palmmedia.reportgenerator.
I have not looked at it closely, but at a high-level, it appears to at
least attempt to address this probl
Simplify the code to set memory used by smm page table as RO.
Since memory used by smm page table are in PageTablePool list,
we only need to set all PageTablePool as ReadOnly in smm page
table itself. Also, we only need to flush tlb once after
setting all page table pool as Read Only.
Signed-off-b
Remove SmmCpuFeaturesAllocatePageTableMemory in this headfile.
This API is not used by PiSmmCpuDxeSmm driver any more. Also
no other files use this API.
Signed-off-by: Dun Tan
Cc: Eric Dong
Reviewed-by: Ray Ni
Cc: Rahul Kumar
---
UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 25 ---
Introduce page table pool mechanism for smm page table to simplify
page table memory management and protection. This mechanism has been
used in DxeIpl. The basic idea is to allocate a bunch of continuous
pages of memory in advance, and all future page tables consumption
will happen in those pool in
1.Introduce page table pool mechanism in SMM page table
In V2 patch, add code to disable CET before disable CR0.WP
2.Remove unused API in SmmCpuFeaturesLib.h
3.Simplify the code to set smm page table as RO
In V2 patch, remove unneeded code to align pool address and add some comments
when mark
It might cause problems depending on markdown linter settings, but if it
passes CI, it's fine.
Thanks,
Michael
On 12/20/2022 10:53 PM, Guo, Gua wrote:
You means "```" to "```inf ", it just make markdown file more readability only.
Thanks,
Gua
-Original Message-
From: Michael Kubacki
You means "```" to "```inf ", it just make markdown file more readability only.
Thanks,
Gua
-Original Message-
From: Michael Kubacki
Sent: Wednesday, December 21, 2022 11:41 AM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Sean Brogan
; Barkelew, Bret
Subject: Re: [PATCH
Hi Ray,
Can you please help investigate/evaluate options to solve this problem?
Thanks,
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, December 13, 2022 1:40 PM
> To: devel@edk2.groups.io; ppola...@redhat.com; Ni, Ray ;
> Zimmer, Vincent ;
> Kinney, Michael D
>
The "DiskName" variable in this line does not appear to be used (in
gen_code_coverage_msvc()):
DiskName = workspace[:workspace.find (":\\") + 2]
---
Can you move the HostBasedUnitRunner changes to patch 2? That was scoped
for BaseTools and this patch is scoped for .azurepipelines.
On 9/29
Since you have direct access to the UEFI builder object, I think you can
use "thebuilder.ws" to get the workspace path instead of looking it up
in the build vars.
---
I know many of these pre-existing files place parentheses around
conditions. This is not really Pythonic and I suggest new cod
Thanks Ray for the comments. I'll modify the code in V2 patch set.
For comments 3, I'll replace the code by LinkedList library APIs from BaseLib
in future patches.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Monday, December 19, 2022 3:53 PM
To: Tan, Dun ; devel@edk2.groups.io;
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Judah Vang
> Sent: Tuesday, December 20, 2022 7:04 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Xiaoyu Lu ; Jiang,
> Guomin ; Mistry, Nishant C
>
> Subject: [edk2-d
I might be misunderstanding the problem, but can you merge the XML file
from each package into one and then pass that to the
"PublishCodeCoverageResult" task?
Perhaps with something like this
https://github.com/danielpalme/ReportGenerator
Thanks,
Michael
On 12/20/2022 8:32 PM, Guo, Gua wrot
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992
V2: Update Readme and CryptoPkg.dsc to reflect changes and be in sync.
V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase.
Update Readme.md
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Nishant C
https://bugzilla.tianocore.org/show_bug.cgi?id=3992
Enable Aes services in PEI based on PCD_CRYPTO_SERVICE_ENABLE_FAMILY.
Enable Hkdf in SMM based on PCD_CRYPTO_SERVICE_ENABLE_FAMILY.
Update Readme table reflect these changes.
Judah Vang (1):
CryptoPkg: Need to enable crypto functions
CryptoP
On Sat, Dec 17, 2022 at 2:16 AM Tuan Phan wrote:
>
>
> On Fri, Dec 16, 2022 at 5:59 PM Pedro Falcato
> wrote:
>
>> On Sat, Dec 17, 2022 at 12:06 AM Michael D Kinney <
>> michael.d.kin...@intel.com> wrote:
>>
>>> If that intrinsic is specific to RISCV, then should CompilerHelper.c go
>>> into a R
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, December 20, 2022
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344
I reviewed it and it looks good to me.
Judah
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, December 14, 2022 7:11 PM
To: Wang, Jian J ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Mistry, Nishant C
; Vang, Judah
Subject: RE: [PATCH] SecurityPkg: deprecate RpmcLib and Variable
Create PR https://github.com/tianocore/edk2/pull/3807 to merge it.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2022年12月7日 9:39
> 收件人: devel@edk2.groups.io; quic_rc...@quicinc.com; 'Michael D Kinney'
> ; 'Zhiguang Liu'
> 抄送: 'Rebecca Cran'
> 主
Gerd:
I will merge these two changes in tools_def.txt. Is it OK to you?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming via
> groups.io
> 发送时间: 2022年12月7日 9:36
> 收件人: devel@edk2.groups.io; brian.john...@hpe.com; kra...@redhat.com
> 抄送: 'Alexey Kardashevskiy' ; 'Erdem Akt
This change is good to me. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Pedro Falcato
> 发送时间: 2022年12月17日 3:50
> 收件人: devel@edk2.groups.io
> 抄送: Pedro Falcato ; Marvin Häuser
> ; Bob Feng ; Liming Gao
> ; Yuwei Chen
> 主题: [PATCH 1/1] BaseTools: Fix IA32 UINT64 alignment for CLANG
> toolchain
Rob:
I suggest to only update EfiSignalEventReadyToBoot () API in UefiLib to trig
ReadyToBoot and AfterReadyToBoot event both.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Robert Phelps
> via groups.io
> 发送时间: 2022年12月15日 1:50
> 收件人: gaoliming ; 'Kinney, Michael D'
> ; devel@
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Alexey
> Kardashevskiy via groups.io
> 发送时间: 2022年12月7日 20:25
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Ard Biesheuvel' ; 'Jiewen Yao'
> ; 'Jordan Justen' ; 'Gerd
> Hoffmann' ; 'Brijesh Singh' ;
> 'Erdem Aktas' ; 'James Bottomley'
> ; 'Min Xu
Prakash:
Have you updated PR 3656?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Prakash K
发送时间: 2022年12月7日 21:04
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH]
ShellPkg: Displaying SMBIOS Type38 fields in formatted manner
H
Merged via:
PR - https://github.com/tianocore/edk2/pull/3806
Commit -
https://github.com/tianocore/edk2/commit/ec25e904c7da70302f2725e2005e3762f1ae891e
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Monday, December 19, 2022 3:46
Merged via:
PR - https://github.com/tianocore/edk2/pull/3806
Commit -
https://github.com/tianocore/edk2/commit/01c2fb0d2260d4de898e4e91e48770ffa5510153
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Monday, December 19, 2022 2:16
Hi Gua,
I created a PR with this series.
https://github.com/tianocore/edk2/pull/3795
When I follow link to Azure Pipelines for the GCC builds, I can see the
coverage.xml file in the ZIP file of artifacts.
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=73664&view=results
But I
Judah,
The readme update was not complete.
I provided a pointer to the Table at the beginning of the readme
that need to be updated too.
Thanks,
Mike
> -Original Message-
> From: Vang, Judah
> Sent: Tuesday, December 20, 2022 10:43 AM
> To: Yao, Jiewen ; Kinney, Michael D
> ; devel@e
The readme was updated, however, I did miss the .dsc.
Will submit another patch to address the .dsc file
Judah
-Original Message-
From: Yao, Jiewen
Sent: Monday, December 19, 2022 6:52 PM
To: Kinney, Michael D ; devel@edk2.groups.io; Vang,
Judah
Cc: Wang, Jian J ; Xiaoyu Lu ;
Jiang,
Hi,
can we merge this?
https://edk2.groups.io/g/devel/message/97026
I've created a pull request if it's easier to merge for you:
https://github.com/tianocore/edk2/pull/3718
--
Best regards,
Corvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Vie
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: Nickle Wang
Sent: Tuesday, December 20, 2022 1:45 AM
To: abner.ch...@amd.com; devel@edk2.groups.io
Cc: Igor Kulchytskyy
Subject: [EXTERNAL] RE: [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add
NULL function
**CAUTION: The e-m
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: Nickle Wang
Sent: Tuesday, December 20, 2022 1:45 AM
To: abner.ch...@amd.com; devel@edk2.groups.io
Cc: Igor Kulchytskyy
Subject: [EXTERNAL] RE: [PATCH V3 1/2] RedfishPkg/RedfishHostInterface:
Platform Redfish HI notification
**CA
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: abner.ch...@amd.com
Sent: Monday, December 19, 2022 9:52 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL
function
**CAUTION: The e-mail
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: abner.ch...@amd.com
Sent: Monday, December 19, 2022 9:51 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform
Redfish HI notification
**CAUTIO
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: abner.ch...@amd.com
Sent: Monday, December 19, 2022 9:17 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL
function
**CAUTION: The e-mail bel
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: abner.ch...@amd.com
Sent: Monday, December 19, 2022 9:17 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH 1/2] RedfishPkg/RedfishHostInterface: Platform
Redfish HI notification
**CAUTION:
On 09/12/2022 15:22, Michael Brown wrote:
On 09/12/2022 15:02, Gerd Hoffmann wrote:
Add the Nested Interrupt TPL Library (NestedInterruptTplLib) to
provide helper functions that can be used by nested interrupt
handlers in place of RaiseTPL()/RestoreTPL().
The idea looks sane to me and I c
When checking the version in DevicePath's Makefile, use BUILD_CC instead
of assuming "gcc". BUILD_CC is set in header.makefile and is the
compiler that will actually be used to build DevicePath. It defaults to
"gcc", but may be overridden.
Signed-off-by: Jake Garver
---
BaseTools/Source/C/Devi
OK. I see. I am fine with that.
Reviewed-by: Ray Ni
> -Original Message-
> From: Guo, Gua
> Sent: Tuesday, December 20, 2022 9:33 AM
> To: Ni, Ray ; Liu, KasimX ;
> devel@edk2.groups.io
> Cc: Dong, Guo ; Lu, James
> Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD
>
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TDVF once accepts memory only by BSP. To improve the boot performance
this patch introduce the multi-core accpet memory. Multi-core means
BSP and APs work together to accept memory.
TDVF leverages mailbox to wake up APs. It
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TDVF APs once did nothing but spin around to wait for the Wakeup command.
This patch enables APs to handle the AcceptPages command. Once APs find
the AcceptPages command, it set its stack and jump to the function of
ApAcceptM
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
This patch moves the TDX APs nasm code from SecEntry.nasm to
IntelTdxAPs.nasm. IntelTdxX64 and OvmfPkgX64 use the same nasm so that
it can be easier to be managed. In the following patch there will be
AcceptMemory related cha
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
In the following patches TdxMailboxLib will be included in
PlatformInitLib. While PlatformInitLib is imported by some IA32/X64
platforms (for example AmdSevX64.dsc). So TdxMailboxLibNull is added in
those platforms which don'
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TdxMailboxLib is designed only for TDX guest which arch is X64. This
patch set the VALID_ARCHITECTURES of TdxMailboxLib as X64.
Because in the following patches TdxMailboxLib will be included in
PlatformInitLib. While Platfo
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TdxMailboxLib once was designed to be used in DXE phase. But now it is
going to be used in SEC/PEI phase (in the following patches). Global
variables are not allowed. The library is refactored after those global
variables are
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TDVF once accepts memory only by BSP. To improve the boot performance
this patch-set introduce the multi-core accpet memory. Multi-core means
BSP and APs work together to accept memory.
TDVF leverages mailbox to wake up APs. It is not enable
52 matches
Mail list logo
