Re: [edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

2023-03-30 Thread Ni, Ray
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionH= andlerAsm.nasm b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ExceptionHan= dlerAsm.nasm similarity index 92% rename from UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionHa= ndlerAsm.nasm rename to UefiCpuPk

回复: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-30 Thread gaoliming via groups.io
Marvin: Platform developer can decide how to configure this option in their DSC file to resolve their problem. This is one option for the platform developer. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Marvin > H?user > 发送时间: 2023年3月28日 19:26 > 收件人: gaoliming > 抄送: devel@edk

回复: [edk2-devel] [PATCH 1/1] Maintainers.txt: BaseTools Bob Feng -> reviewer, Rebecca Cran -> maintainer

2023-03-30 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2023年3月30日 18:18 > 收件人: devel@edk2.groups.io; rebe...@bsdio.com > 抄送: Liming Gao ; Bob Feng > > 主题: Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: BaseTools Bob Feng -> > reviewer, Rebecca Cran -> maint

Re: [edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

2023-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Friday, March 31, 2023 5:21 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Ni; Ni, Ray ; Andrew Fish ; Kinney, Michael D ; Liu, Zhiguang ; Rebecca Cran ; Tom Lendacky Subject: [edk2-

Re: [edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

2023-03-30 Thread Ni, Ray
Thanks for the change. But it doesn't highlight another impact due to this change: CET logic is removed from the SEC/PEI version. It's not an issue because CET is only enabled in SMM environment today. But better to highlight the impact in the commit message, and explicitly say that limitation i

Re: [edk2-devel] [RFT PATCH v2 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Drop special XCODE5 version

2023-03-30 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Friday, March 31, 2023 5:21 AM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Ni; Ni, Ray ; Andrew Fish ; Kinney, Michael D ; Liu, Zhiguang ; Rebecca Cran ; Tom Lendacky Subject: [edk2-

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-03-30 Thread Pedro Falcato
On Fri, Mar 31, 2023 at 12:32 AM Kinney, Michael D wrote: > Appreciate the feedback. Agree that any libc API that is implemented in a > wrapper should conform to the standard. > > > We also have a whole libc implementation in edk2-libc that seems to be > > permanently gathering dust until Intel t

[edk2-devel] [RFC PATCH 1/1] MdePkg: Add a libc implementation

2023-03-30 Thread Pedro Falcato
Add LibcLib, a libc implementation meant to centralize all libc bits in edk2. Work in progress, does not support Windows targets (CLANGPDB and MSVC) just yet. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Benny Lin Signed-off-by: Pedro Falcato --- Wrote this to fulfill the new ne

[edk2-devel] [edk2-platforms] Platform/Loongson: Fixed multi-core boot issue

2023-03-30 Thread xianglai
Fixed the bug of slave cpu querying MAILBUF register address. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Sec/LoongArch64/Start.S | 2 ++ 1 file changed, 2 insertions(+)

Re: [edk2-devel] [RFT PATCH v2 5/6] OvmfPkg: Drop special Xcode5 version of exception handler library

2023-03-30 Thread Yao, Jiewen
Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 5:21 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni; Ni, Ray ; > Andrew Fish ; Kinney, Michael D > ; Liu, Zhiguang ; > Rebecca Cran ; Tom Lendacky

Re: [edk2-devel] edk2 MdeModulePkg build error

2023-03-30 Thread Nickle Wang via groups.io
VFR compiler is in BaseTools. Please check this to see how to generate binary tool: https://github.com/tianocore/edk2/tree/master/BaseTools#build-step-to-generate-the-binary-tools Regards, Nickle From: ritul guru Sent: Thursday, March 30, 2023 11:05 PM To: Nickle Wang ; edk2-devel-groups-io

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-03-30 Thread Michael D Kinney
> -Original Message- > From: Pedro Falcato > Sent: Thursday, March 30, 2023 4:27 PM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Lin, Benny ; Gao, Liming > ; Liu, Zhiguang > ; Sean Brogan ; Michael > Kubacki ; Leif > Lindholm > Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-03-30 Thread Pedro Falcato
On Thu, Mar 30, 2023 at 11:59 PM Kinney, Michael D wrote: > > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Pedro Falcato > > Sent: Thursday, March 30, 2023 2:50 PM > > To: devel@edk2.groups.io; Lin, Benny > > Cc: Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguan

Re: [edk2-devel] [PATCH 1/2] MdePkg: Support FDT library.

2023-03-30 Thread Pedro Falcato
On Thu, Mar 30, 2023 at 6:13 PM Benny Lin wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 > Add FDT support in EDK2 by submodule 3rd party libfdt > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Si

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-03-30 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Pedro Falcato > Sent: Thursday, March 30, 2023 2:50 PM > To: devel@edk2.groups.io; Lin, Benny > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang > ; Sean Brogan ; Michael > Kubacki > Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

2023-03-30 Thread Marvin Häuser
Hi Ard, Thanks for these important updates! On Thu, Mar 30, 2023 at 02:21 PM, Ard Biesheuvel wrote: > > Recent versions of the XCODE linker can be instructed to permit text > relocations, so we no longer have to work around this, which is > especially nice as our workaround assumes that the .te

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

2023-03-30 Thread Marvin Häuser
Hi Ard, Sorry, I cannot preserve the CC list as the groups.io interface doesn't seem to allow it. Can you please CC me on future revisions? This patch will badly corrupt binaries. I cannot cite a source right now (if you want me to, please remind me in your response, so I can look it up tomorr

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

2023-03-30 Thread Pedro Falcato
On Thu, Mar 30, 2023 at 6:13 PM Benny Lin wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 > Add FDT support in EDK2 by submodule 3rd party libfdt > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc

[edk2-devel] [RFT PATCH v2 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Drop special XCODE5 version

2023-03-30 Thread Ard Biesheuvel
This library is no longer used or needed, so let's remove it. Signed-off-by: Ard Biesheuvel --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf | 65 UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.uni | 18 --

[edk2-devel] [RFT PATCH v2 5/6] OvmfPkg: Drop special Xcode5 version of exception handler library

2023-03-30 Thread Ard Biesheuvel
The generic and XCODE5 versions of this library are now identical, so drop the special case. The library will be removed entirely in a subsequent patch. Signed-off-by: Ard Biesheuvel --- OvmfPkg/AmdSev/AmdSevX64.dsc | 4 OvmfPkg/CloudHv/CloudHvX64.dsc | 4 OvmfPkg/IntelTdx/IntelT

[edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

2023-03-30 Thread Ard Biesheuvel
Recent versions of the XCODE linker can be instructed to permit text relocations, so we no longer have to work around this, which is especially nice as our workaround assumes that the .text section is mapped both writable and executable at the same time. So remove the runtime fixups and instead, j

[edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

2023-03-30 Thread Ard Biesheuvel
Currently, we use the non-Xcode5 version of ExceptionHandlerAsm.nasm only for the SEC and PEI phases, and this version was not compatible with the XCODE or LLD linkers, which do not permit absolute relocations in read-only sections by default. This has been fixed now, so we can use it for all toolc

[edk2-devel] [RFT PATCH v2 2/6] BaseTools/tools_def CLANGDWARF: Permit text relocations

2023-03-30 Thread Ard Biesheuvel
We rely on PIE executables to get the codegen that is suitable for PE/COFF conversion where the resulting executables can be loaded anywhere in the address space. However, ELF linkers may default to disallowing text relocations in PIE executables, as this would require text segments to be updated

[edk2-devel] [RFT PATCH v2 0/6] UefiCpuPkg, OvmfPkf: Simplify CpuExceptionHandlerLib

2023-03-30 Thread Ard Biesheuvel
We have a special version of CpuExceptionHandlerLib for XCODE5, whose linker (LLD) does not permit absolute symbol references in read-only sections. Instead of fixing this up at runtime (which is done by writing the fixed up values to the .text section, which we'd prefer to avoid), pass the approp

[edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

2023-03-30 Thread Ard Biesheuvel
Earlier XCODE versions did not support the -read_only_relocs suppress linker option, which suppresses errors resulting from absolute relocations emitted into read-only sections when building PIE executables. This requires a rather messy workaround in the CPU exception handler libraries, to permit

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching

2023-03-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Thursday, March 30, 2023 1:44 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Michael Kubacki > ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH v1 1/1] .github/wo

Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

2023-03-30 Thread Rebecca Cran
Good idea. I'll send out a v2 patch with that change. On 3/30/23 2:09 PM, Kinney, Michael D wrote: Rebecca, In order to avoid issues with the order or timing or merges, could CFLAGS be added in one set of patches and then later remove BUILD_CLAGS in a second set of patches? Mike -Origin

Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

2023-03-30 Thread Michael D Kinney
Rebecca, In order to avoid issues with the order or timing or merges, could CFLAGS be added in one set of patches and then later remove BUILD_CLAGS in a second set of patches? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Thursday, March 30, 20

[edk2-devel] [PATCH edk2-basetools 1/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

2023-03-30 Thread Rebecca Cran
In order to support building BaseTools using non-default compilers, a change is being made in the edk2 BaseTools directory to remove the 'BUILD_' prefix to CC, CXX, CFLAGS etc. so developers can for example run 'make CC=clang CXX=clang++' to build using clang. Update DscBuildData.py to generate Ma

[edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

2023-03-30 Thread Rebecca Cran
Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change This should be merged at the same time as the edk2 patch that supports passing CC and CXX to make when building BaseTools. Rebecca Cran (1): Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change edk2basetools/Workspace/DscBui

Re: [edk2-devel] edk2 MdeModulePkg build error

2023-03-30 Thread ritul guru
Thanks, How to install vfr compiler in ubuntu? *Thanks & RegardsRitul Guru+91-9916513186* On Thu, Mar 30, 2023 at 6:42 PM Nickle Wang wrote: > You probably need to update VFR compiler. REST_STYLE token was introduced > in below commit long time ago. > > > > > https://github.com/tianocore/edk

[edk2-devel] [PATCH 1/2] MdePkg: Support FDT library.

2023-03-30 Thread Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Benny Lin --- .gitmodules

[edk2-devel] [PATCH 2/2] .pytool: Support FDT library.

2023-03-30 Thread Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Add RequiredSubmodule object for CI setting. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Sig

[edk2-devel] [PATCH 0/2] Support FDT library.

2023-03-30 Thread Benny Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 Add FDT support in EDK2 by submodule 3rd party libfdt (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Cc: Michael Kubacki Signed-off-by: Benny Lin Benn

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 18:54, Rebecca Cran wrote: > > On 3/30/23 10:33 AM, Ard Biesheuvel wrote: > > i'll respin the series I sent out earlier today with that if I manage > > to build a working OVMF.fd with XCODE5 > > Let me know if you'd like any help test building/running anything with > XCODE5

Re: [edk2-devel] [PATCH 1/2] MdePkg: Support FDT library.

2023-03-30 Thread Michael D Kinney
+Leif +Andrew For .gitmodules and ReadMe.rst changes Mike > -Original Message- > From: Lin, Benny > Sent: Thursday, March 30, 2023 9:52 AM > To: devel@edk2.groups.io > Cc: Lin, Benny ; Kinney, Michael D > ; Gao, Liming > ; Liu, Zhiguang > Subject: [PATCH 1/2] MdePkg: Support FDT libr

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Rebecca Cran
On 3/30/23 10:33 AM, Ard Biesheuvel wrote: i'll respin the series I sent out earlier today with that if I manage to build a working OVMF.fd with XCODE5 Let me know if you'd like any help test building/running anything with XCODE5 on an Intel or ARM Mac. I have both a 2012 era Intel Mac Pro a

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 18:33, Ard Biesheuvel wrote: > > On Thu, 30 Mar 2023 at 17:04, Ard Biesheuvel wrote: > > > > On Thu, 30 Mar 2023 at 16:25, Ni, Ray wrote: > > > > > > I am afraid they are not template code. > > > That means if nx is set for data section, they can not be executed. > > > > >

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 17:04, Ard Biesheuvel wrote: > > On Thu, 30 Mar 2023 at 16:25, Ni, Ray wrote: > > > > I am afraid they are not template code. > > That means if nx is set for data section, they can not be executed. > > > > Currently, we fix up the entries by writing to the .text section at

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Michael D Kinney
Hi Ray, No sure if I recall all the details. Andrew may know them much better than me. The code gen for XCODE uses PIE and RIP relative addressing, which does not require the same number/type of relocation fixups. Whenever there is a need to access a data element at an absolute address and th

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

2023-03-30 Thread Chiu, Chasel
Thanks for reviewing Ray! Please see my reply below inline. > -Original Message- > From: Ni, Ray > Sent: Wednesday, March 29, 2023 10:31 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [PATCH v2] IntelFsp2Pkg: LoadMicrocodeDefault

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-30 Thread Lendacky, Thomas via groups.io
On 3/29/23 21:26, Ni, Ray wrote: Tom, I would assume this won't break any AMD system because the CPUID bit doesn't declare this feature. Right, shouldn't be an issue on AMD systems. Though it does bring to mind that we should probably do something similar for AMD at some point. With SEV ther

Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 17:17, Michael D Kinney wrote: > > Increase the CI agent timeout to boot to UEFI Shell from > 1 minute to 2 minutes. There have been a few cases where > the boot to shell in QEMU has not quite completed in 1 > minute and it is failing the CI check and preventing a PR > from

[edk2-devel] [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout

2023-03-30 Thread Michael D Kinney
Increase the CI agent timeout to boot to UEFI Shell from 1 minute to 2 minutes. There have been a few cases where the boot to shell in QEMU has not quite completed in 1 minute and it is failing the CI check and preventing a PR from being merged. Cc: Sean Brogan Cc: Michael Kubacki Cc: Liming Ga

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 16:25, Ni, Ray wrote: > > I am afraid they are not template code. > That means if nx is set for data section, they can not be executed. > Currently, we fix up the entries by writing to the .text section at runtime, so NX seems out of scope in any case. Someone should check

Re: [edk2-devel] [PATCH v2 16/17] MdePkg/PeCoffLib: Capture DLL characteristics fieldis in image context

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 16:45, Michael Kubacki wrote: > > On 3/27/2023 7:01 AM, Ard Biesheuvel wrote: > > When loading a PE/COFF image, capture the DLL characteristics fields of > > the header into our image context structure so we can refer to them when > > mapping the image. > > > > Signed-off-by

Re: [edk2-devel] [PATCH v2 16/17] MdePkg/PeCoffLib: Capture DLL characteristics fieldis in image context

2023-03-30 Thread Michael Kubacki
On 3/27/2023 7:01 AM, Ard Biesheuvel wrote: When loading a PE/COFF image, capture the DLL characteristics fields of the header into our image context structure so we can refer to them when mapping the image. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/IndustryStandard/PeImage.h | 13

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ni, Ray
I am afraid they are not template code. That means if nx is set for data section, they can not be executed. thanks, ray From: Ard Biesheuvel Sent: Thursday, March 30, 2023 7:47:03 PM To: devel@edk2.groups.io ; Ni, Ray ; Rebecca Cran Cc: Andrew Fish ; Kinney, Mi

[edk2-devel] [PATCH 4/4] UefiCpuPkg/CpuExceptionHandlerLib: Drop special XCODE5 version

2023-03-30 Thread Ard Biesheuvel
This library is no longer used or needed, so let's remove it. Signed-off-by: Ard Biesheuvel --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf | 65 UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.uni | 18 --

[edk2-devel] [PATCH 3/4] OvmfPkg: Drop special Xcode5 version of exception handler library

2023-03-30 Thread Ard Biesheuvel
The generic and XCODE5 versions of this library are now identical, so drop the special case. The library will be removed entirely in a subsequent patch. Signed-off-by: Ard Biesheuvel --- OvmfPkg/AmdSev/AmdSevX64.dsc | 4 OvmfPkg/CloudHv/CloudHvX64.dsc | 4 OvmfPkg/IntelTdx/IntelT

[edk2-devel] [PATCH 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Remove pointless runtime fixups

2023-03-30 Thread Ard Biesheuvel
The XCODE5 compatible version of ExceptionHandlerAsm, which is in fact used for all builds of this library except the SecPei flavor, performs runtime fixups that are not really necessary: we can just move the code templates into the .data section where absolute relocations are permitted. So simpli

[edk2-devel] [PATCH 1/4] UefiCpuPkg/CpuExceptionHandlerLib: Create LLD compatible SEC/PEI version

2023-03-30 Thread Ard Biesheuvel
Currently, we use the non-Xcode5 version of ExceptionHandlerAsm.nasm only for the SEC and PEI phases, and this version is not compatible with the LLD linker, which does not permit absolute relocations in read-only sections. Let's rename the .nasm file to reflect this, and tweak it so that LLD acce

[edk2-devel] [PATCH 0/4] UefiCpuPkg, OvmfPkf: Simplify CpuExceptionHandlerLib

2023-03-30 Thread Ard Biesheuvel
We have a special version of CpuExceptionHandlerLib for XCODE5, whose linker (LLD) does not permit absolute symbol references in read-only sections. Instead of fixing this up at runtime (which is done by writing the fixed up values to the .text section), move the code templates into .data instead.

Re: [edk2-devel] [RESEND v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

2023-03-30 Thread Dhaval Sharma
Hi Oliver, when is this patch expected to get merged? I need to use CI with GCC12 in order to get my changes through for this https://edk2.groups.io/g/devel/message/101795?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Ccmo%2C20%2C2%2C0%2C97826395 =D -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] edk2 MdeModulePkg build error

2023-03-30 Thread Nickle Wang via groups.io
You probably need to update VFR compiler. REST_STYLE token was introduced in below commit long time ago. https://github.com/tianocore/edk2/commit/1b840718f72711d442ecd7b7e54256a31df8bd20 Regards, Nickle From: devel@edk2.groups.io On Behalf Of ritul guru via groups.io Sent: Thursday, March 30,

[edk2-devel] edk2 MdeModulePkg build error

2023-03-30 Thread ritul guru
Hi, getting below error while building MdeModulePkg, help is appreciated. build cmd: build -p "MdeModulePkg/MdeModulePkg.dsc" -b DEBUG -t GCC5 MdeModulePkg/Include -I/home/a/src/opensource/edk2/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/include /home/a/src/opensource/edk2/Build/MdeM

[edk2-devel] [PATCH] ShellPkg: Fixed system hang issue when executing ping6 command cross network segment in EFI Shell.

2023-03-30 Thread Kanagavel S via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4376 While shell is polling to send/receive ICMP packets, Private ->status is not updated for below scenario, Considering 10 packets are transferred and it's RTT time is between 1764-1812 ms .In this 10 packets 2 or 3 packets are lost in betwee

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ard Biesheuvel
(cc Rebecca) On Thu, 30 Mar 2023 at 12:48, Ard Biesheuvel wrote: > > On Thu, 30 Mar 2023 at 12:16, Ni, Ray wrote: > > > > Andrew, > > > > In UefiCpuPkg\Library\CpuExceptionHandlerLib\X64\, there are two nasm > > files: ExceptionHandlerAsm.nasm and the other XCODE version. > > > > > > > > The ma

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*

2023-03-30 Thread Gerd Hoffmann
On Thu, Mar 30, 2023 at 12:18:35PM +0200, Fiona Ebner wrote: > Am 30.03.23 um 10:53 schrieb Gerd Hoffmann: > > On Thu, Mar 30, 2023 at 10:04:02AM +0200, Fiona Ebner wrote: > >> Am 28.11.22 um 06:40 schrieb Gerd Hoffmann: > >> Hi, > >> after this patch, certain SMBIOS values are different[2]. We got

Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ard Biesheuvel
On Thu, 30 Mar 2023 at 12:16, Ni, Ray wrote: > > Andrew, > > In UefiCpuPkg\Library\CpuExceptionHandlerLib\X64\, there are two nasm files: > ExceptionHandlerAsm.nasm and the other XCODE version. > > > > The major diff between the two is the second operand in “mov rax, > ASM_PFX(CommonInterruptEnt

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

2023-03-30 Thread Leif Lindholm
On Thu, Mar 30, 2023 at 09:28:45 +0200, Ard Biesheuvel wrote: > > > Patch-set wide comment: is there any chance we could take this > > > opportunity to introduce a global ASM_FUNC (or a more Linux-named > > > ENTRY(FuncName))? > > > It seems to be that the current way is a bit error prone and you e

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*

2023-03-30 Thread Fiona Ebner
Am 30.03.23 um 10:53 schrieb Gerd Hoffmann: > On Thu, Mar 30, 2023 at 10:04:02AM +0200, Fiona Ebner wrote: >> Am 28.11.22 um 06:40 schrieb Gerd Hoffmann: >>> Instead of using hard-coded strings ("0.0.0" for BiosVersion etc) >>> which is mostly useless read the PCDs (PcdFirmwareVendor, >>> PcdFirmwa

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: BaseTools Bob Feng -> reviewer, Rebecca Cran -> maintainer

2023-03-30 Thread Leif Lindholm
On Wed, Mar 29, 2023 at 11:34:53 -0600, Rebecca Cran wrote: > Update Maintainers.txt for BaseTools: move Bob Feng from being a > maintainer to reviewer, and add myself (Rebecca Cran) as a new > maintainer. Ooh, that's excellent! Reviewed-by: Leif Lindholm > Signed-off-by: Rebecca Cran > Cc: Lim

[edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?

2023-03-30 Thread Ni, Ray
Andrew, In UefiCpuPkg\Library\CpuExceptionHandlerLib\X64\, there are two nasm files: ExceptionHandlerAsm.nasm and the other XCODE version. The major diff between the two is the second operand in "mov rax, ASM_PFX(CommonInterruptEntry)" is patched at runtime by code, instead of relying on linker

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/5] Enable SoC expansion block and Virtio-P9 for RD-N2 variants

2023-03-30 Thread Vivek Kumar Gautam
Hi Pierre, On 3/30/23 15:16, Pierre Gondois wrote: Hello Vivek, Thanks for the new version, Reviewed-by: Pierre Gondois: Thanks a lot for your review. Best regards Vivek [snip] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#1021

[edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-03-30 Thread Patrick Rudolph
The clang toolchain might default to fPIE/fPIC, which prevents lld from linking the objects into a binary. Specify -fno-pie -fno-pic as done on GCC to fix linking. Test: Building the Universal Payload using the command 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually works. Sign

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-03-30 Thread Patrick Rudolph
Hi Marvin, will send out a new patch series. Regards, Patrick Rudolph On Thu, Mar 30, 2023 at 10:05 AM Marvin Häuser wrote: > > Hi Lean, > > I don’t think individual patches from a series are merged generally. Your 2/3 > has open concerns from both Liming and myself. > > Best regards, > Marvin

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/5] Enable SoC expansion block and Virtio-P9 for RD-N2 variants

2023-03-30 Thread PierreGondois
Hello Vivek, Thanks for the new version, Reviewed-by: Pierre Gondois: On 3/24/23 12:02, Vivek Gautam wrote: Arm reference design Fixed Virtual Platforms (FVPs) such as the RD-N2 platform variants have multiple IO virtualization blocks that allow connecting PCIe root bus or non-PCIe SoC periphe

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-30 Thread Gerd Hoffmann
Hi, > For tdx, the actual max physical address bits is decreased by the KEY_ID_BITS > bits. > But the max physical address bits reported from CPUID instruction don't > change. I guess the physical address bits calculation for tdx needs adjustment then. Right now we have: if (TdIsEnabled (

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*

2023-03-30 Thread Gerd Hoffmann
On Thu, Mar 30, 2023 at 10:04:02AM +0200, Fiona Ebner wrote: > Am 28.11.22 um 06:40 schrieb Gerd Hoffmann: > > Instead of using hard-coded strings ("0.0.0" for BiosVersion etc) > > which is mostly useless read the PCDs (PcdFirmwareVendor, > > PcdFirmwareVersionString and PcdFirmwareReleaseDateStrin

Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package

2023-03-30 Thread Tinh Nguyen via groups.io
Thank you Abner, Let's go on Regards, - Tinh On 3/29/2023 8:32 AM, Chang, Abner wrote: [AMD Official Use Only - General] Hi Tinh, See my response below, -Original Message- From: devel@edk2.groups.io On Behalf Of Tinh Nguyen via groups.io Sent: Tuesday, March 28, 2023 8:37 PM To: d

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-30 Thread Ni, Ray
I don' t think vt is related. For tdx, the actual max physical address bits is decreased by the KEY_ID_BITS bits. But the max physical address bits reported from CPUID instruction don't change. Details in https://cdrdv2-public.intel.com/679154/multi-key-total-memory-encryption-spec-1.4.pdf >

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-03-30 Thread Marvin Häuser
Hi Lean,I don’t think individual patches from a series are merged generally. Your 2/3 has open concerns from both Liming and myself.Best regards,MarvinOn 30. Mar 2023, at 09:31, Lean Sheng Tan wrote:HI Liming,If no further concern, would you mind to help get this patch merged?Thanks!Best Regards,

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*

2023-03-30 Thread Fiona Ebner
Am 28.11.22 um 06:40 schrieb Gerd Hoffmann: > Instead of using hard-coded strings ("0.0.0" for BiosVersion etc) > which is mostly useless read the PCDs (PcdFirmwareVendor, > PcdFirmwareVersionString and PcdFirmwareReleaseDateString) and > build the string table dynamuically at runtime. > > Signed-

Re: [edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-03-30 Thread Rohit Mathew
Thanks Sami, Michael, Liming for the review/ack. I'll post a V2 with the comments addressed. Let me also work on the Acpi parser for the same. Regards, Rohit > -Original Message- > From: Sami Mujawar > Sent: Wednesday, March 29, 2023 10:57 AM > To: Rohit Mathew ; devel@edk2.groups.io >

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

2023-03-30 Thread Gerd Hoffmann
On Wed, Mar 29, 2023 at 01:23:10PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4379 > > PlatformInitEmuVariableNvStore is called to initialize the > EmuVariableNvStore with the content pointed by > PcdOvmfFlashNvStorageVariableBase. This is becaus

Re: [edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table

2023-03-30 Thread Ard Biesheuvel
On Wed, 29 Mar 2023 at 18:31, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 13:00:55 +0200, Ard Biesheuvel wrote: > > Implement version 2 of the memory attributes table, which now contains a > > flag informing the OS whether or not code regions may be mapped with CFI > > mitigations such as IBT

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: BaseTools Bob Feng -> reviewer, Rebecca Cran -> maintainer

2023-03-30 Thread Ard Biesheuvel
On Wed, 29 Mar 2023 at 19:35, Rebecca Cran wrote: > > Update Maintainers.txt for BaseTools: move Bob Feng from being a > maintainer to reviewer, and add myself (Rebecca Cran) as a new > maintainer. > > Signed-off-by: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > --- > Maintainers.txt | 3 ++-

Re: [edk2-devel] [PATCH v2 0/2] SEV-SNP guest support fixes

2023-03-30 Thread Gerd Hoffmann
On Tue, Mar 28, 2023 at 01:09:22PM -0500, Lendacky, Thomas via groups.io wrote: > This patch series provides some fixes around AP creation: > > - An erratum on AMD hardware requires that a VMSA not be aligned on a > 2MB boundary. To work around this issue, allocate 2 pages of memory > and usin

Re: [edk2-devel] [PATCH v2 0/6] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-30 Thread Gerd Hoffmann
On Wed, Mar 22, 2023 at 08:02:37AM +0100, Gerd Hoffmann wrote: > v2 changes: > - rebase to latest master, adapt patches to changes. > - update macro documentation to use @retval TRUE/FALSE. > - added patch to use IS_POW2 in MtrrLib. > - add reviews and acks. Ping. This is fully reviewed now,

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

2023-03-30 Thread Sheng Lean Tan
HI Liming, If no further concern, would you mind to help get this patch merged? Thanks! Best Regards, *Lean Sheng Tan* On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io wrote: > Reviewed-by: Liming Gao > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Patrick > > Rudolph > > 发送时间: 20

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

2023-03-30 Thread Ard Biesheuvel
On Mon, 27 Mar 2023 at 16:24, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 15:12:29 +0100, Pedro Falcato wrote: > > On Mon, Mar 27, 2023 at 12:01 PM Ard Biesheuvel wrote: > > > > > > Implement a CPP macro that can be called from .S files to emit the .note > > > section carrying the annotation

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-30 Thread Gerd Hoffmann
On Thu, Mar 30, 2023 at 02:26:25AM +, Ni, Ray wrote: > Gerd, > This is needed by Intel platform for TME-MK. Can you help to analyze if it > has any impact to OVMF? I assume no. How does that feature interact with vt and tdx? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You r