There is info about toolchains checked in here:edk2/BaseTools/Conf/tools_def.template at master · tianocore/edk2github.comOn Sep 27, 2023, at 8:10 PM, Daniel Samuelraj wrote:We tried GCC at https://sourceforge.net/projects/gcc-win64/And then we tried GCC ver5.4We are getting the following
Patch merged via:
PR - https://github.com/tianocore/edk2/pull/4875
Commit -
https://github.com/tianocore/edk2/commit/f36e1ec1f0a5fd3be84913e09181d7813444b620
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Wednesday, September 27,
Hi Hao,
Thanks for the support.
Best Regards,
Gao
-Original Message-
From: Wu, Hao A
Sent: Thursday, September 28, 2023 10:07 AM
To: devel@edk2.groups.io; Wu, Hao A ; Cheng, Gao
Cc: Ni, Ray ; Wang, Jian J ; Gao,
Liming
Subject: RE: [edk2-devel] [PATCH v2] MdeModulePkg/Xhci: Skip
Fix incorrect number of arguments in VtdLibDumpSetAttribute().
Signed-off-by: Sheng Wei
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Jenny Huang
---
.../Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c| 1 +
1 file changed, 1 insertion(+)
diff --git
Hi Gerd,
We have validated HTTPs boot and WIFI with EAP-TLS, where the code consumed
openssl3.0 TLS lib API.
So we cannot reproduce this issue. Could you provide detail test steps to me, I
will look into it.
Thanks,
Yi
-Original Message-
From: devel@edk2.groups.io On Behalf Of
Hi,
Can you recommend a GCC compiler to build UDK2022?
Thanks
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
Hi Mike,
Can you help merge this? Looks like it has all of the reviews.
Thank you!
- Vivian
On 9/12/2023 7:42 AM, Michael D Kinney wrote:
Series Reviewed-by: Michael D Kinney
-Original Message-
From:devel@edk2.groups.ioOn Behalf Of VivianNK
Sent: Wednesday, August 16, 2023 2:15
Hi Gerd
Thanks for the reporting.
We will look into that. Is below text full reproduce steps? Which server you
are using? Which TLS version is configured?
Please provide as detail as possible, if you could.
One more thing: We are going to have 1 week National Holiday since Tomorrow.
If we
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, September 27, 2023 4:07 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Sami Mujawar
> ; Andrew Fish ; Kinney, Michael
> D
> Subject: [PATCH 1/1] Maintainers.txt: add Sami as maintainer of
This commit adds host-based unit tests for device path lib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Mateusz Albecki
---
MdePkg/MdePkg.ci.yaml | 5 +-
MdePkg/Test/MdePkgHostTest.dsc| 2 +
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4555
Add logic that checks if the code doesn't overflow
ACPI_EXTENDED_HID_DEVICE_PATH node when searching for optional
strings. If the string is not provided in the device path node
default value of "\0" is used.
Cc: Michael D Kinney
Cc: Liming
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4555
Github PR: https://github.com/tianocore/edk2/pull/4865
Fix for buffer overlows that arise in DevPathToTextAcpiEx when device path node
producer doesn't specify all of the optional strings.
Changes in v2:
- Fix AcpiExp print logic that got
Hello Abdul,
On 9/23/23 06:22, Attar, AbdulLateef (Abdul Lateef) wrote:
[AMD Official Use Only - General]
Hi Jeff, Sami,
I’m not reviewer, just providing the opinion.
How about making it generic(generic to integer argument) instead of single
integer argument.
IN
any thoughts on this?
On Tue, Sep 26, 2023 at 5:48 PM Alireza Banejad via groups.io
wrote:
> Hi everybody,
> I have built the Whisky Lake platform and I got the fd file but now I want
> to upload it into my motherboard's flash chip but I haven't found the right
> way of doing so. it seems I
Hi,
I've noticed that the edk2 ext4 driver does case-insensitive filename
matching. I know the fat filesystem is case-insensitive, and the uefi
spec describing the fat filesystem also explicitly says it is
case-insensitive. On a quick scan I can't find anything in the uefi
spec requiring
This patch has a bug related to AcpiExp device path. I will resend the fixed
version along with unit tests to cover AcpiExp cases.
Thanks,
Mateusz
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109120):
We added Sami as a reviewer to ArmPkg early last year, and I think it was
always our intention to have him as a reviewer of Arm architectural stuff
in general, but we seem to have missed out the Arm/AArch64 subdir
wildcards. So let's fix that.
Signed-off-by: Leif Lindholm
Cc: Ard Biesheuvel
Cc:
Hi Yuquan,
I am mostly happy with the below, but there are a couple of things I'd
like to change (comments inline).
On Fri, Sep 22, 2023 at 21:41:15 +0800, Yuquan Wang wrote:
> As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
> that only has 32-bit DMA capablity and sbsa-ref board
Look good to me.
Thanks!
Reviewed-by: levi.yun
From: devel@edk2.groups.io on behalf of Tuan Phan via
groups.io
Sent: 15 September 2023 00:10
To: devel@edk2.groups.io
Cc: ardb+tianoc...@kernel.org; Sami Mujawar; ray...@intel.com;
Look good to me.
Thanks!
Reviewed-by: levi.yun
From: devel@edk2.groups.io on behalf of Tuan Phan via
groups.io
Sent: 15 September 2023 00:10
To: devel@edk2.groups.io
Cc: ardb+tianoc...@kernel.org; Sami Mujawar; ray...@intel.com;
W dniu 22.09.2023 o 15:41, Yuquan Wang pisze:
As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
that only has 32-bit DMA capablity and sbsa-ref board uses xhci
to replace ehci.
This updates DSDT to match the platform xhci controller with two
usb ports changed from type A to type
Hi,
I've noticed that setting chipers for TLS stopped working in ovmf, most
likely due to the openssl 3.0 update.
Test case: try http boot from https server, set ciphers on the qemu
command line using:
-object tls-cipher-suites,id=tls-cipher0,priority=@SYSTEM
-fw_cfg
On Tue, Sep 19, 2023 at 05:57:43PM -0700, Taylor Beebe wrote:
> Now that the EDK2 tree uses GetMemoryProtectionsLib to query
> the platform memory protection settings, we can add additional
> profiles to SetMemoryProtectionsLib to give plaforms more options
> for setting memory protections.
What
The return value after calls to functions
gBS->UninstallMultipleProtocolInterfaces, StartPciDevicesOnBridge,
PciPciDeviceInfoCollector, BarExisted, PciRootBridgeIo->Pci.Write,
gPciHotPlugInit->InitializeRootHpc and PciRootBridgeP2CProcess is
stored in Status, but it is not made of any use and
From: Ranbir Singh
The function StartPciDevices has a check
ASSERT (RootBridge != NULL);
but this comes into play only in DEBUG mode. In Release mode, there
is no handling if the RootBridge value is NULL and the code proceeds
to unconditionally dereference "RootBridge" which will lead to
From: Ranbir Singh
The function PciHostBridgeResourceAllocator is not making use of the
generic approach as is used in one of the other function namely -
DumpResourceMap. As a result, the following warnings can be seen as
reported by Coverity e.g.
(30) Event address_of: Taking address with ""
From: Ranbir Singh
The function UpdatePciInfo has switch-case code in which there are fall
through from case 32: to case 64:. While this is seeemingly intentional,
it is not evident to any static analyzer tool. Just adding
// No break; here as this is an intentional fallthrough.
as
From: Ranbir Singh
The function PciHotPlugRequestNotify has two if blocks towards the end
of function both containing return. Due to the parameter checks ensured
at the beginning of the function, one of the two if blocks is bound to
come in execution flow. Hence, the return EFI_SUCCESS; at line
Ranbir Singh (5):
MdeModulePkg/Bus/Pci/PciBusDxe: Fix DEADCODE Coverity issue
MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues
MdeModulePkg/Bus/Pci/PciBusDxe: Fix ARRAY_VS_SINGLETON Coverity issues
MdeModulePkg/Bus/Pci/PciBusDxe: Fix NULL_RETURNS Coverity issue
The return value after calls to functions CoreProcessFvImageFile,
CoreStartImage, CoreGetDepexSectionAndPreProccess,
CoreInternalAddMemorySpace, CoreAddIoSpace, CoreAllocateMemorySpace
and CoreCloseProtocol is stored in Status, but it is not made of any
use and later Status gets overridden.
An
From: Ranbir Singh
"1 << Priority" / "1 << Event->NotifyTpl" are potentially overflowing
expressions with type "int" (32 bits, signed) evaluated using 32-bit
arithmetic, and then used in a context that expects an expression of
type "UINTN" (64 bits, unsigned).
To avoid overflow, cast "1" to
From: Ranbir Singh
The functions CoreConvertSpace and CoreAllocateSpace in
MdeModulePkg/Core/Dxe/Gcd/Gcd.c has
ASSERT (FALSE); at lines 755 and 1155 which gets hit when
Operation neither include GCD_MEMORY_SPACE_OPERATION nor include
GCD_IO_SPACE_OPERATION but this comes into play
From: Ranbir Singh
In the function PromoteGuardedFreePages(), the value of AvailablePages
cannot be ZERO at the condition check point
if (AvailablePages != 0) {
as the code can come out of the while loop above only when AvailablePages
is non-ZERO.
Hence, remove the redundant condition check
From: Ranbir Singh
The function CoreIsSchedulable has switch-case code in which
case EFI_DEP_BEFORE:
case EFI_DEP_AFTER:
has a comment that
// For a well-formed Dependency Expression, the code should never get here.
It also has an ASSERT (FALSE); but this is applicable only in
v1 -> v2:
- Rebased
- Commit message update wrt Fix UNUSED_VALUE Coverity issues
Ranbir Singh (5):
MdeModulePkg/Core/Dxe: Fix FORWARD_NULL Coverity issues
MdeModulePkg/Core/Dxe: Fix MISSING_BREAK Coverity issue
MdeModulePkg/Core/Dxe: Fix DEADCODE Coverity issue
MdeModulePkg/Core/Dxe:
35 matches
Mail list logo
