[AMD Official Use Only - General]
Reviewed-by: Abner Chang
I can help to merge this change if maintainer or review have no problem with
it, as I am not any of those.
Abner
> -Original Message-
> From: Lixia Huang
> Sent: Tuesday, October 31, 2023 2:24 PM
> To: devel@edk2.groups.io
> C
Thanks a lot for reviewing the patch.
I have different opinions with (2), could you please check that? Thanks a lot.
If you agree (2) is not an issue, I will prepare a new patch version to only
address (1) and (3)
BR,
Wei
>-Original Message-
>From: Laszlo Ersek
>Sent: Monday, October 30,
Hi, Abner:
I ask you a favor.
KCS actually layer on LPC interface.
KCS is a usual BMC-to-CPU communication channel.
Does MCTP-over-KCS feature require some special LPC interface hardware changes?
Or, MCTP is just a software stack and it uses current LPC interface, not any
special hardward desi
On 2023-10-28 12:23:30, Michael D Kinney wrote:
> @@ -497,7 +463,6 @@ F: OvmfPkg/
> W: http://www.tianocore.org/ovmf/
> M: Ard Biesheuvel [ardbiesheuvel]
> M: Jiewen Yao [jyao1]
> -R: Jordan Justen [jljusten]
> R: Gerd Hoffmann [kraxel]
> S: Maintained
Acked-by: Jordan Justen
-=-=-=-=-
Can we define these bits in the header file so that the definitions can
be used by multiple modules?
[Dhaval] I could put it un Baselib.h (MDE_CPU_RISCV64) but sounds like right
now BaseLib.h is free of such #defines. If you think it is still better would
do it. I do not have any preference.
-=
Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild'
for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Lixia Huang
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIp
NIT: I am wondering whether PcdRiscVCpuFeatureDisable is better so that
it is explicit.
[Dhaval] Well setting it to 1 would mean feature is enabled. Do it would be
confusing to see PcdRiscVCpuFeatureDisable == 1 means feature is enabled.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all m
Thanks. This PCD is for Virt platform only. Or maybe I am missing the point.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110369): https://edk2.groups.io/g/devel/message/110369
Mute This Topic: https://groups.io/mt/102256471/21656
Group
[AMD Official Use Only - General]
> -Original Message-
> From: Lixia Huang
> Sent: Tuesday, October 31, 2023 2:00 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nate DeSimone
>
> Subject: [PATCH v3 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone
> MM
>
> Caution: This message ori
Hi Laszlo,
If I generate the certificate like
openssl req -new -nodes -x509 -days 365 -keyout server.key -out server.crt
-config config
it works perfectly fine (with the original configuration).
The problem stands with the *chain* of certificates, meaning that I have a root
certificate (let's
Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild'
for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Lixia Huang
---
Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIp
Remove checking SMM Rev ID in AMD Save State lib when reading Save
State Register EFI_MM_SAVE_STATE_REGISTER_IO.
For AMD, it is not necessary to check SmmRevId when reading Save State
Register EFI_MM_SAVE_STATE_REGISTER_IO.
Cc: Abdul Lateef Attar
Cc: Abner Chang
Signed-off-by: Jacque Lin
---
U
Here we go. https://github.com/tianocore/edk2/pull/4974
On Tue, Oct 31, 2023 at 9:46 AM Warkentin, Andrei <
andrei.warken...@intel.com> wrote:
> Hi Dhaval,
>
> Do you mind sharing the repo with the full patch set? Like a github link?
>
> A
>
> > -Original Message-
> > From: Dhaval
> > S
Hi Dhaval,
Do you mind sharing the repo with the full patch set? Like a github link?
A
> -Original Message-
> From: Dhaval
> Sent: Sunday, October 29, 2023 9:46 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L ; Gerd
> Hoffmann ; Sunil V L ;
> Warken
Looks fine to me. While it's not necessary to add a default value PCD to every
platform DSC, it might me a good idea to do so for "example" platforms like
RiscVVirt, so that folks who borrow code are aware of the feature?
Reviewed-by: Andrei Warkentin
> -Original Message-
> From: Dhav
Reviewed-by: Andrei Warkentin
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, October 28, 2023 2:24 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm
> ; Warkentin, Andrei
> ; West, Catharine ;
> Bi, Dandan ; Daniel Schaefer
> ; David Woodhouse ; De,
> Debk
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Monday, October 30, 2023 6:41 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Michael Kubacki
> ; Kinney, Michael D
> ; Laszlo Ersek
> Subject: [PATCH v1 1/1] .github/workflows: Add S
Does using a static volatile global instead of a volatile local work?
Mike
From: Ni, Ray
Sent: Monday, October 30, 2023 7:52 PM
To: Andrew (EFI) Fish ; edk2-devel-groups-io
; Rebecca Cran ; Hernandez Miramontes,
Jose Miguel
Cc: Kinney, Michael D
Subject: Re: [edk2-devel] CpuDeadLoop() is opt
Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace Smst
with Mmst. Remove unused UefiBootServicesTableLib reference.
Cc: Abner Chang
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Wei6 Xu
---
.../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 17 -
.../Library
This patch is to add Standalone MM support for SmmIpmiBaseLib.
PR: https://github.com/tianocore/edk2-platforms/pull/107
Cc: Abner Chang
Cc: Nate DeSimone
Cc: Liming Gao
Wei6 Xu (1):
IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.
.../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 17 +
It's been a while.
Is there any better solution? Can we go with assembly solution?
Thanks,
Ray
From: Andrew (EFI) Fish
Sent: Saturday, May 20, 2023 12:31 AM
To: edk2-devel-groups-io ; Rebecca Cran
Cc: Ni, Ray ; Kinney, Michael D
Subject: Re: [edk2-devel] CpuDe
From: Michael Kubacki
Adds a GitHub workflow that uses the actions/stale GitHub action to
automatically leave notifications on and close PRs that have had no
activity for a long time.
Note: Modifications to a PR reset the staleness counter. This
includes pushing to the PR, adding a label t
(Add MdePkg maintainers for their feedbacks)
Sorry that I do not have strong opinion on this one.
Some of my thoughts are:
* If you find the to-be-added APIs can be used in serveral places to reduce
repetative codes, then it will be worthwhile to add new library APIs.
* TimerLib has many insta
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, October 31, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-
Hi Michael and Laszlo,
Thanks a lot for the review.
We reconsidered the solution and find better way to implement the 'platform
hook'. So Let's drop this patch.
Thanks Ray for suggesting a better solution.
BR,
Wei
-Original Message-
From: Michael Kubacki
Sent: Tuesday, October 31, 202
On Sun, Oct 29, 2023 at 11:42 PM Sun, CepingX wrote:
>
> On Saturday, October 28, 2023 12:45 AM, Erdem Aktas wrote:
> This should be the [PATCH V1 2/2] I assume?
> Yes, the name is same with [PATCH v1 0/2] , may be confusion, I would update
> in next version to avoid the same title name.
>
>
> On
*Tools, CI, Code base construction meeting series*
*When:*
Monday, October 30, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86
From: Michael Kubacki
Since the code is most regularly tested in CI, distro/versioning
details are updated to match the latest CI configuration.
CI has moved from Ubuntu 18.04 to Ubuntu 22.04 since the time of the
file's creation, but the code is actually built in a Fedora container
so Fedora is
On Mon, 30 Oct 2023 at 21:31, wrote:
>
> From: Michael Kubacki
>
> Adds the varpolicy EFI shell command to all DSC files that
> currently include other dynamic shell commands from ShellPkg.
>
> This command allows variable policies to be dumped in the EFI
> shell for convenient auditing and debug
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, October 30, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%227
Hi Laszlo,
I do not support orphaned categories and that option should be
removed from Maintainer.txt. One of the motivations to get
Maintainers.txt updated is to work on the set of tasks related to
using GitHub PRs for code review. If a component is orphaned,
then nobody would be assigned to a
My changes have been in for a little over a month now, I've been looking into
updating the TimerLib API but I'm questioning if it still makes sense to go
down that path. The functions I had implemented, XhcGetElapsedTicks () and
XhcConvertTimeToTicks (), now rely heavily on the use of global va
From: Michael Kubacki
Adds the varpolicy EFI shell command to all DSC files that
currently include other dynamic shell commands from ShellPkg.
This command allows variable policies to be dumped in the EFI
shell for convenient auditing and debug.
Use the command in the EFI shell as follows:
- `
From: Michael Kubacki
Adds a new module (dynamic shell command) to ShellPkg that lists
variable policy information for all UEFI variables on the system.
Some other UEFI variable related functionality is also included to
give a greater sense of platform UEFI variable state. This command
is intend
From: Michael Kubacki
Introduces two new APIs to EDKII_VARIABLE_POLICY_PROTOCOL:
1. GetVariablePolicyInfo()
2. GetLockOnVariableStateVariablePolicyInfo()
These allow a caller to retrieve policy information associated with
a UEFI variable given the variable name and vendor GUID.
GetVariableP
AndroidBootImgLib allows for platforms to append to kernel command
line but does not allow for the overall kernel command line to go
beyond the limit set by the image header. Address this limitation
by adding a pcd where platform can tell how many extra characters
they expect on their platform in a
Curently, AndroidBootImgLib expects input kernel command line
to never exceed 256 unicode characters where the image header
allows for 512 ascii characters. If image header allows 512
ascii characters, similar number of unicode characters should be
allowed at the minimum.
Signed-off-by: Ashish Sin
On 10/28/2023 10:03 AM, Laszlo Ersek wrote:
On 10/27/23 18:08, Michael Kubacki wrote:
This allows ambiguous "platform" code in the critical path of the MM
core. Is this necessary?
Do you need this for one feature that others might too and can be
abstracted? Or, do you plan to perform an unknown
Anything else needed to get this merged as the November stable release is
coming up.
Thanks,
Jeff
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, October 16, 2023 8:39 PM
> To: Jeff Brasen ; Gao, Liming
> ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Bi, Dandan
>
> Subject: RE:
Anything else needed to get this merged would as the November stable release is
coming up.
Thanks,
Jeff
> -Original Message-
> From: gaoliming
> Sent: Friday, October 6, 2023 11:23 PM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; dandan...@intel.com; Ashish Singh
For changes to item "> -M: Ray Han Lim Ng
[rayhanlimng]":
Reviewed-by: Ray Han Lim Ng
-Original Message-
From: Pedro Falcato
Sent: Sunday, October 29, 2023 10:17 AM
To: devel@edk2.groups.io; Kinney, Michael D
Cc: Andrew Fish ; Leif Lindholm ;
Warkentin, Andrei ; West, Catharine
;
Add GenericFruDriver and generate data based on SMBIOS data.
Signed-off-by: Zhen Gong
# Conflicts:
# Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 4 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 3 +-
...
Add DXE and SMM drivers that send "Set ACPI Power State" command to BMC.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 1 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 2 +
.../IpmiFeaturePkg/Include/PostMemory.fdf | 2 +
.../BmcAcpiState/BmcAcpiState
Hi Abner,
Thanks for the heads-up.
I caught your commit right before submitting the patch. MdeModulePKg is already
consumed by all libraries referencing the header.
However there's a merge conflict now and I just sent out a v2 version to
address it.
Regarding to the migration to ManageabilityPk
Lightweight lib to support Server Management drivers.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 1 +
.../ServerManagementLib.inf | 35 +
.../ServerManagementLibNull.inf | 38 +
.../Include/Library/ServerMgmtRtLib.h |
Add generic Elog driver and support BMC Elog operations.
Signed-off-by: Zhen Gong
---
.../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 +
.../IpmiFeaturePkg/Include/IpmiFeature.dsc| 7 +-
.../IpmiFeaturePkg/Include/PostMemory.fdf | 5 +-
.../IpmiFeaturePkg/Include/PreMemory.fdf
This patch set adds serveral IPMI features to support server management:
BmcAcpiState: A DXE driver to notify BMC of S0 power state.
BmcAcpiSwChild: An SMM driver to notify BMC of ACPI power state changes and add
SEL records.
BmcElog: PEI, DXE, and SMM drivers to support BMC event log functions.
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Joey Vagedes
> Sent: Monday, October 30, 2023 9:42 AM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Michael Kubacki
> ; Kinney, Michael D
> ; Gao, Liming
> Subject: [PATCH v1 1/1] .azurepipelines: Fix Python version (to 3.12)
>
On Mon, Oct 30, 2023 at 9:38 AM Laszlo Ersek wrote:
>
> On 10/29/23 20:12, Pedro Falcato wrote:
> > On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote:
> >>
> >> Implement Cache Management Operations (CMO) defined by
> >> RISC-V spec https://github.com/riscv/riscv-CMOs.
> >>
> >> Notes:
> >> 1.
On Fri, 27 Oct 2023 at 07:43, Dun Tan wrote:
>
> PlatformInitLib uses the CcProbe API in MemDetect.c
> but doensn't add CcProbeLib in .inf LibraryClasses
> section. Add CcProbeLib to fix the build error.
>
> Signed-off-by: Dun Tan
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc:
On Fri, 27 Oct 2023 at 07:43, duntan wrote:
>
> Use BaseIoLibIntrinsic.inf in dsc files. The
> BaseIoLibIntrinsic supports Tdx and sev now.
> The BaseIoLibIntrinsicSev will be removed in
> the following patches.
>
> Signed-off-by: Dun Tan
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Juste
Merged as dc8de7cc888f..1ae7cffab740
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110319): https://edk2.groups.io/g/devel/message/110319
Mute This Topic: https://groups.io/mt/101522378/21656
Group Owner:
Merged as 4f3ee7fbafc8..a671a14e63fd
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110318): https://edk2.groups.io/g/devel/message/110318
Mute This Topic: https://groups.io/mt/101522262/21656
Group Owner:
+Gerd, +Paolo
On 10/30/23 07:12, Jacque Lin via groups.io wrote:
> Remove checking SMM Rev ID in AMD Save State lib when reading Save
> State Register EFI_MM_SAVE_STATE_REGISTER_IO.
> For AMD, it is not necessary to check SmmRevId when reading Save State
> Register EFI_MM_SAVE_STATE_REGISTER_IO.
>
On 10/30/23 08:49, Wei6 Xu wrote:
> The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs.
> When an inner FV is uncompressed, StandaloneMmCore will miss the FV and
> all the MM drivers in the FV will not be dispatched.
> Add checks for uncompressed inner FV to fix this issue.
>
>
On 10/30/23 08:49, Wei6 Xu wrote:
> MmCoreFfsFindMmDriver() assumes FileHeader is EFI_FFS_FILE_HEADER.
> If FileHeader is an EFI_FFS_FILE_HEADER2, 'FileHeader + 1' will get a
> wrong section address. Use FfsFindSection to get the section directly,
> instead of 'FileHeader + 1' to avoid this issue.
On 10/30/23 08:49, Wei6 Xu wrote:
> In MmCoreFfsFindMmDriver(), ScratchBuffer is not freed in the error
> return path that DstBuffer page allocation fails. Free ScratchBuffer
> before return with error.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Ray Ni
> Signed-off-by:
On 10/30/23 08:49, Wei6 Xu wrote:
> MmCoreFfsFindMmDriver() is called recursively for encapsulation sections.
> Currently this recursion is not limited. Introduce a new PCD
> (fixed-at-build, or patchable-in-module), and make MmCoreFfsFindMmDriver()
> track the section nesting depth against that PC
On Mon, Oct 30, 2023 at 10:38:21AM +0100, Laszlo Ersek wrote:
> On 10/29/23 20:12, Pedro Falcato wrote:
> > On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote:
> >>
> >> Implement Cache Management Operations (CMO) defined by
> >> RISC-V spec https://github.com/riscv/riscv-CMOs.
> >>
> >> Notes:
>
On 10/30/23 06:31, Kinney, Michael D wrote:
> There is a very good discussion here on the roles and responsibility
> and potential suggestions for changes to the Wiki page that document
> those roles and responsibilities.
>
> May I suggest that someone start a new thread that discusses
> the propo
On 10/29/23 20:01, Pedro Falcato wrote:
> On Sun, Oct 29, 2023 at 1:30 PM Laszlo Ersek wrote:
>>
>> On 10/29/23 03:16, Pedro Falcato wrote:
diff --git a/Maintainers.txt b/Maintainers.txt
index 3f40cdeb5554..2b03ccbe54aa 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@
On Mon, Oct 30, 2023 at 04:48:18PM +0530, Sunil V L wrote:
> On Sun, Oct 29, 2023 at 08:16:12PM +0530, Dhaval Sharma wrote:
> > Use newly defined cache management operations for RISC-V where possible
> > It builds up on the support added for RISC-V cache management
> > instructions in BaseLib.
> >
On Sun, Oct 29, 2023 at 08:16:12PM +0530, Dhaval Sharma wrote:
> Use newly defined cache management operations for RISC-V where possible
> It builds up on the support added for RISC-V cache management
> instructions in BaseLib.
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Las
On Sun, Oct 29, 2023 at 08:16:11PM +0530, Dhaval wrote:
> Implement Cache Management Operations (CMO) defined by
> RISC-V spec https://github.com/riscv/riscv-CMOs.
>
> Notes:
> 1. CMO only supports block based Operations. Meaning cache
>flush/invd/clean Operations are not available for the ent
Hi Michael,
On 28/10/2023 20:23, Michael D Kinney wrote:
Over the past few months, all the of the Maintainers and
Reviewers listed in Maintainers.txt have been contacted to make
sure Maintainers.txt accurately represents the TianoCore
community members that are actively participating in their
ro
On 10/30/23 03:40, Yao, Jiewen wrote:
> Thanks Mike. I am reading the WIKI page.
>
>
>> and/or provides testing or regression testing for the Package (or some
>> modules thereof), in certain platforms and environments.
>
> [Jiewen] Are we expecting Reviewer to provide testing or regression test
On 10/29/23 20:07, Pedro Falcato wrote:
> On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote:
>>
>> Use newly defined cache management operations for RISC-V where possible
>> It builds up on the support added for RISC-V cache management
>> instructions in BaseLib.
>> Cc: Michael D Kinney
>> Cc:
On 10/29/23 20:12, Pedro Falcato wrote:
> On Sun, Oct 29, 2023 at 2:46 PM Dhaval Sharma wrote:
>>
>> Implement Cache Management Operations (CMO) defined by
>> RISC-V spec https://github.com/riscv/riscv-CMOs.
>>
>> Notes:
>> 1. CMO only supports block based Operations. Meaning cache
>>flush/inv
Reviewed-by: Eric Dong
-Original Message-
From: Xie, Yuanhao
Sent: Saturday, October 7, 2023 2:32 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Tom Lendacky ; Xie, Yuanhao
Subject: [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file
Cc: Eric Dong
C
Hi Laszlo and Ray,
Thanks a lot for the review. Patch V3 is sent out to:
1. Separate patch per individual issue fix
2. Limit FwVol encapsulation section recursion in MmCoreFfsFindMmDriver().
(https://edk2.groups.io/g/devel/message/110296)
Could you please help to review it again? Thanks a lot!
B
The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs.
When an inner FV is uncompressed, StandaloneMmCore will miss the FV and
all the MM drivers in the FV will not be dispatched.
Add checks for uncompressed inner FV to fix this issue.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami
MmCoreFfsFindMmDriver() assumes FileHeader is EFI_FFS_FILE_HEADER.
If FileHeader is an EFI_FFS_FILE_HEADER2, 'FileHeader + 1' will get a
wrong section address. Use FfsFindSection to get the section directly,
instead of 'FileHeader + 1' to avoid this issue.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc:
In MmCoreFfsFindMmDriver(), ScratchBuffer is not freed in the error
return path that DstBuffer page allocation fails. Free ScratchBuffer
before return with error.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Ray Ni
Signed-off-by: Wei6 Xu
---
StandaloneMmPkg/Core/FwVol.c | 1 +
1
MmCoreFfsFindMmDriver() is called recursively for encapsulation sections.
Currently this recursion is not limited. Introduce a new PCD
(fixed-at-build, or patchable-in-module), and make MmCoreFfsFindMmDriver()
track the section nesting depth against that PCD.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
V1:
This patch is to fix the issue that StandaloneMmCore fails to detect
uncompressed inner FV.
PR: https://github.com/tianocore/edk2/pull/4943
V2:
Based on V1, fix some other issues
1. Add Missing object size checks before casting pointers to header types
a. InnerFvHeader = (EFI_FIRMWARE_VOLUM
For changes to item "Hao A Wu [hwu25]":
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Kinney, Michael D
> Sent: Sunday, October 29, 2023 3:24 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm
> ; Warkentin, Andrei
> ; West, Catharine
> ; Bi, Dand
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, October 26, 2023 5:50 PM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle
> Wang ; Konstantin Aladyshev
> Subject: Re: [edk2-devel] [edk2-plat
Reviewed this patch series.
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, October 27, 2023 7:54 AM
> To: devel@edk2.groups.io
> Cc: abner.ch...@amd.com; Nickle Wang ;
> ig...@ami.com; Mike Maslenkin
> Subject: [edk2-redfish-client
78 matches
Mail list logo
