Hi Laszlo,
Sorry, I'm not check carefully, it is really **copied**, and we not
think the ARM version is not good enough.
So, can I move this library to OvmfPkg so other ARCH use it easily?
Thanks,
Chao
在 2023/11/9 06:24, Laszlo Ersek 写道:
On 11/6/23 04:30, Chao Li wrote:
This library is pro
Hi Laszlo,
This is a good question, same as the previous email, some ARCH don't
require running code on memory during PEI phase or other reason can not
used the MdePkg version, so this pointer will be saved by some register,
I saw the ArmPkg version also uses a register to save this pointer.
It was hard to conclude at my end as well what to do where. So I just threw
it open ...
- Status assignment can be ignored or
- Maintain the existing behaviour and just log the error given the original
code existence for quite a long now
Various files were clubbed together being part of the same
I considered the least code change approach without considering any
optimization which also works as such.
However, yes, the duplicated /unnecessary subsequent checks can be removed.
On Tue, Nov 7, 2023 at 9:51 PM Laszlo Ersek wrote:
> On 11/7/23 07:19, Ranbir Singh wrote:
> > From: Ranbir Sing
EFI_NOT_READY was listed as one of the error return values in the function
header of StartPciDevices(). So, I considered it here.
Maybe we can go by a dual approach, including CpuDeadLoop() in
StartPciDevices() as well as add return value check at the call site in
PciBusDriverBindingStart().
On T
I was apprehensive about this from the very beginning.
Anyway, for now I will be dropping this issue from the series.
On Tue, Nov 7, 2023 at 10:11 PM Laszlo Ersek wrote:
> On 11/7/23 07:19, Ranbir Singh wrote:
> > From: Ranbir Singh
> >
> > The function PciHostBridgeResourceAllocator is not ma
Refactor UserAuthenticationSmm to support Standalone MM.
- Factor out variable lock code logic that references boot services.
- UserAuthenticationVariableLockDxe is added to lock the variables.
- UserAuthenticationStandaloneMm doesn't lock the variables, needs to
reply on UserAuthenticationVariab
The this patch is to refator UserAuthenticationSmm to support MM_STANDALONE.
There is no impact to the existing platforms that are using
UserAuthenticationSmm.
PR: https://github.com/tianocore/edk2-platforms/pull/110
Cc: Dandan Bi
Cc: Nate DeSimone
Cc: Liming Gao
Wei6 Xu (1):
UserAuthFeatur
From: Ranbir Singh
The functions
XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has
a switch-case code in which the case USB_ENDPOINT_CONTROL: falls
through to default:
While this may be intentional, it may not be evident to any general code
reader/developer or static analyis to
From: Ranbir Singh
The functions UsbHcGetHostAddrForPciAddr, UsbHcGetPciAddrForHostAddr
and UsbHcFreeMem do have
ASSERT ((Block != NULL));
statements after for loop, but these are applicable only in DEBUG mode.
In RELEASE mode, if for whatever reasons there is no match inside for
loop and t
v2 -> v3:
- Updated FORWARD_NULL issue
- Included DEBUG message and CpuDeadLoop within if blocks
- Updated MISSING_BREAK issues resolution
- Merged fallthrough case with default with conditional messaging
Ranbir Singh (2):
MdeModulePkg/Bus/Pci/XhciDxe: Fix FORWARD_NULL Coverity i
Hi Laszlo,
Sorry, it is my fault, I should separate this this patch for two
standalone patches, and with some detailed commit message. I will fix
this in V3.
Currently, there are two libraries are not independent, so I guess you
are talking about Fdt16550SerialPortHookLib. I would say that t
Options before us till now -
1. Add array overrun check and Debug statement before CpuDeadLoop within
2. Status Quo (not everything can be ideal :-))
Question before us
- Is 1 better than 2 ?
On Fri, Nov 10, 2023 at 8:41 AM Ranbir Singh
wrote:
> As far as I know, from a secure coding per
Hi Sunil,
Ok, I will give it try, I'm leaning towards moving this driver to
UefiCpuPkg and merging it with CpuIo2Dxe with two "inf" files which will
be named CpuIo2Dxe.inf and MmioCpu2Dxe.inf, do you think this way is better?
Thanks,
Chao
在 2023/11/9 07:11, Sunil V L 写道:
On Tue, Nov 07, 202
As far as I know, from a secure coding perspective, it would be recommended
that array overrun condition check is captured in the code even if it is
felt that it will never hit.
Generally speaking, I won't be in favour of handling other ASSERT
conditions updates even if required if they are not re
[AMD Official Use Only - General]
From: Ashish Singhal
Sent: Tuesday, November 7, 2023 1:55 AM
To: devel@edk2.groups.io; quic_llind...@quicinc.com; ardb+tianoc...@kernel.org;
Chang, Abner ; g...@danielschaefer.me; Jeff Brasen
Subject: Re: [PATCH 1/2] EmbeddedPkg: Fix Android Boot Command Lin
Hi Laszlo,
I verified and encountered build failure as some files still consuming
definitions from LegacyBiosMpTable.h, for example:
https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInf
Thank you, Mike, the PR (https://github.com/tianocore/edk2/pull/4867) has been
synced & updated with reviewed by tag, and we can merge once pass the CI check.
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, November 10, 2023 8:25 AM
> To: Wu, Jiaxin ; Laszlo Ersek ;
> de
[AMD Official Use Only - General]
Thanks Leif, some responses are given in line.
As we would like to have this be part of edk2-stable202312, we prefer letting
this change gets in stable release first and address the comment in another
patch afterward.
Hi Igor,
Could you please check my comment
I approve this change for edk2-stable202311
The PR looks out of sync with this email patch.
Can you please update PR with latest patch and commit
message that was reviewed and add review tags?
Mike
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, November 9, 2023 4:01 PM
> To:
Hi Liming & Mike,
Could you help approve & merge this patch into stable tag? It has got below
reviewed-by:
Reviewed-by: Laszlo Ersek
Reviewed-by: Ray Ni
Reviewed-by: Eric Dong
I also created the PR: https://github.com/tianocore/edk2/pull/4867
Thanks,
Jiaxin
> -Original Message-
>
Thank you.
Merged. https://github.com/tianocore/edk2/pull/5026
> -Original Message-
> From: gaoliming
> Sent: Thursday, November 9, 2023 9:54 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; Sun, CepingX
> ; Kinney, Michael D ;
> 'Leif Lindholm' ; 'Andrew Fish'
> Cc: Aktas, Erdem ; 'James Bo
Hi Ranbir,
A deadloop without even a debug print is not good behavior.
If this condition really represents a condition where it is not possible
to complete the PCI resource allocation/assignment, then an error status
code should be returned to the caller of NotifyPhase(). Perhaps
EFI_OUT_OF_RESO
Merged:
https://github.com/tianocore/edk2/pull/5027
https://github.com/tianocore/edk2/commit/35c0c63edbab6a37d6c019d613a4b06529941a80
Mike
> -Original Message-
> From: gaoliming
> Sent: Thursday, November 9, 2023 5:44 AM
> To: devel@edk2.groups.io; quic_llind...@quicinc.com; Kinney, Mic
begining->beginning
dirve->drive
duplicat->duplicate
fuly->fully
Funciton->Function
Functino->Function
optioanl->optional
poitners->pointers
rountine->routine
sucessful->successful
sucessfully->successfully
Signed-off-by: Page Chen
Cc: Zhichao Gao
Cc: Andrew Fish
---
.../HttpDynamicCommand/Htt
Merged:
https://github.com/tianocore/edk2/pull/5023
https://github.com/tianocore/edk2/commit/e077ccff6d0f2e8c3fc44b3e2ab71aff66927c3b
Mike
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, November 9, 2023 6:39 AM
> To: devel@edk2.groups.io; Gao, Liming
> Cc: 'Yeping Song (Q
+Ray
Unless I missed it, I do not see review of the patch series Ray sent back in
July.
Mike
From: devel@edk2.groups.io On Behalf Of Aaron Young via
groups.io
Sent: Thursday, November 9, 2023 8:29 AM
To: Gerd Hoffmann ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 0/4] Sync BSP's API
From: Ranbir Singh
The function SubmitResources has a switch-case code in which the
case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to
case ACPI_ADDRESS_SPACE_TYPE_IO: to include additional common check.
While this may be intentional, it may not be evident to any general code
reader/develo
From: Ranbir Singh
The function NotifyPhase has a check
ASSERT (Index < TypeMax);
but this comes into play only in DEBUG mode. In Release mode, there is
no handling if the Index value is within array limits or not. If for
whatever reasons, the Index does not get re-assigned to Index2 at lin
v2 -> v3:
- Rebased to latest master HEAD
- Replaced continue with CpuDeadLoop wrt OVERRUN issue
- Changed to more generic solution wrt MISSING_BREAK issue
v1 -> v2:
- Rebased to latest master HEAD
- Changed the commit message wrt MISSING_BREAK issues
- Cc update
Ranbir Singh (2):
M
Hello, is this issue/patch still being worked/considered? If so, is there an
ETA?
Without this fix, one cannot hotplug beyond 255 vcpus with OVMF and we need
this capability.
NOTE: Gerd's original fix ( https://edk2.groups.io/g/devel/message/100801 ),
does allow hotplug beyond 255 vcpus. So, t
On 2023-11-07 12:06, Igor Kulchytskyy via groups.io wrote:
Supported function of the driver changed to wait for all newtwork
Typo:
newtwork ->
network
interface to be installed.
Filer out the network interfaces which are not supported by
Filer ->
Filter
Redfish Host Interface.
These sou
Hi Nickle,
I noticed one typo. See below the text.
And I have a question regarding newly introduced
ValidateRedfishStringArrayValues function.
You use that function to check if value in Redfish string array can be found in
HII configuration string array.
And you still call CompareRedfishStringAr
(You have my old now-dysfunctional @nuviainc.com email address on cc,
please delete that one if you can.)
I think it's fine to merge this bugfix, but I have a couple of review
comments I will make on the v3 code itself, replying to that submission.
(I am however not the maintainer of RedFishPkg
Thanks!
https://github.com/tianocore/edk2/pull/5023 raised.
/
Leif
On Thu, Nov 09, 2023 at 21:42:38 +0800, gaoliming via groups.io wrote:
> Leif:
> Sure. This patch can be merged for this stable tag.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Leif Lindholm
>
Abner:
I agree this change. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: Chang, Abner
> 发送时间: 2023年11月8日 11:22
> 收件人: devel@edk2.groups.io
> 抄送: Nate DeSimone ; Liming Gao
> ; Chasel Chiu ; Li-Xia
> Huang ; Attar, AbdulLateef (Abdul Lateef)
> ; Nickle Wang
> 主题: RE: [edk2-dev
Christine:
I can't directly reply to the original mail because it is too large. This
is a new feature to add python version VfrCompiler. I don't think we have
enough time to review the design and implementation. Although it has no real
impact, its code may have many change in future. So, I sugges
On Thu, Nov 09, 2023 at 10:23:02 +0100, Pierre Gondois wrote:
> To enable AARCH64 native instruction support for Openssl,
> some interfaces must be implemented. OPENSSL_cpuid_setup()
> allows to probe the supported features of the platform.
>
> Add ArmReadIdAA64Isar0Reg() to read the AA64Isar0, co
On Thu, Nov 09, 2023 at 10:23:01 +0100, Pierre Gondois wrote:
> To enable AARCH64 native instruction support for Openssl,
> some interfaces must be implemented. OPENSSL_rdtsc() requests
> an access to a counter to get some non-trusted entropy.
>
> Add ArmReadCntPctReg() to read system count.
> A s
Nickle:
This is a bug fix. Its impact is only in RedfishDiscoverDxe. I think it can
be merged for this stable tag.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Nickle Wang via
groups.io
发送时间: 2023年11月8日 10:44
收件人: Liming Gao ; Kinney, Michael D ; devel@edk2.groups.io
抄送: Igor Kulchytskyy ;
Jiewen:
I have gave my reviewed-by for the change in MdePkg. I agree its impact is
small. I think this patch set can be merged for this stable tag.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Yao, Jiewen
> 发送时间: 2023年11月8日 21:29
> 收件人: devel@edk2.groups.io; Yao, Jiewen ; Sun,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Xu, Min M
> 发送时间: 2023年11月8日 16:41
> 收件人: Gao, Liming ; Kinney, Michael D
>
> 抄送: Aktas, Erdem ; James Bottomley
> ; Tom Lendacky ;
> Michael Roth ; Gerd Hoffmann
> ; Yao, Jiewen ; Sun, CepingX
> ; devel@edk2.groups.io; Xu, Min M
>
> 主题: RE: [PAT
I agree to merge it for this stable tag.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Leif Lindholm
> 发送时间: 2023年11月9日 17:51
> 收件人: Michael D Kinney ;
> devel@edk2.groups.io
> 抄送: Andrew Fish ; Erdem Aktas
> ; Jiewen Yao ; Min Xu
> ; Tom Lendacky ;
> Michael Roth
> 主题: Re: [edk2
Leif:
Sure. This patch can be merged for this stable tag.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Leif Lindholm
> 发送时间: 2023年11月7日 21:13
> 收件人: Yeping Song (QUIC) ;
> devel@edk2.groups.io; Liming Gao
> 抄送: Rebecca Cran ; Bob Feng
> ; Yuwei Chen ; Ard
> Biesheuvel ; Sami
-announce, +discuss
On 2023-11-09 12:02, Marcin Juszkiewicz wrote:
W dniu 7.11.2023 o 01:59, gaoliming via groups.io pisze:
Below is edk2-stable202311 tag planning Proposed Schedule
Date (00:00:00 UTC-8) Description
2023-08-25 Beginning of development
2023-11-06 Soft Feature Freeze
2023-11-1
Nothing in edk2 (or edk2-platforms, at this point) references
"LegacyBiosMpTable.h", or the names it introduces (EFI_LEGACY_MP_TABLE_*
and FEATUREBYTE2_5). Remove the header.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhiguang Liu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off
The MPS table is legacy from the traditional BIOS era. According to the
file-top comment in the header, it was only included in UEFI (and so in
edk2) for Itanium's sake (and Itanium is also gone from edk2).
Remove the header, and the MPS table GUID definition. There are no
references left in edk2
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Remove two old headers that play no role in modern UEFI.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhichao Gao
Cc: Zhiguang Liu
Laszlo Ersek (3):
MdePkg: remove
ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref f
We're removing . First, remove the
gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM
debug command.
Cc: Zhichao Gao
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek
---
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command
For removing "MdePkg/Include/Guid/Mps.h" from edk2, first remove the
edk2-platforms references to that header file.
I can't build-test this change. As far as I can tell, building the
BoardX58Ich10 platform with "build_bios.py" should build the change;
however, that platform fails to build without
For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
edk2, first remove the edk2-platforms references to that header file.
I can't build-test this change. As far as I can tell, building the
CooperCityRvp and WilsonCityRvp platforms with "build_bios.py" should
build these changes
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Remove references to two old headers that play no role in modern UEFI.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Sai Chaganty
Laszlo Ersek (2):
WhitleyOpenBoardPkg: remove references
SimicsOpenBoardPkg: remove reference
Platfor
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
I'm sending this as a common anchor message for
[edk2-platforms PATCH 0/2] remove and refs
[PATCH 0/3] remove and ,
including refs
Thanks,
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messa
Reviewed-by: S, Ashraf Ali
Thanks.,
S, Ashraf Ali
-Original Message-
From: Chen, Gang C
Sent: Thursday, November 9, 2023 3:42 PM
To: Guo, Gua ; Hsu, JasonX ;
devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
; Chiu, Chasel ; Duggapu, Chinni B
; Kuo, Ted ; S, Ashraf Ali
;
On Thu, Nov 09, 2023 at 10:58:58 +0100, Pierre Gondois wrote:
> Hello Leif,
>
> On 11/2/23 11:20, Pierre Gondois wrote:
> >
> >
> > On 10/26/23 13:03, Leif Lindholm wrote:
> > > On Wed, Oct 25, 2023 at 13:25:39 +0200, PierreGondois wrote:
> > > > From: Pierre Gondois
> > > >
> > > > The SCP ho
From: YuanhaoXie
SmmCpuRendezvous has a issue in that it summons all APs
into SMM, but there is a time gap before they are set as "present."
During this window, if using the "setVariable" operation,
it can cause issues since "setVariable" requires all APs to be in SMM
and marked as "present."
Th
Reviewed-by: Chen Gang C
BR
Gang
-Original Message-
From: Guo, Gua
Sent: Thursday, November 9, 2023 6:07 PM
To: Hsu, JasonX ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
; Chiu, Chasel ; Chen, Gang C
; Duggapu, Chinni B ; Kuo,
Ted ; S, Ashraf Ali ; Mohapatra,
Susova
Reviewed-by: Gua Guo
-Original Message-
From: Hsu, JasonX
Sent: Thursday, November 9, 2023 6:01 PM
To: devel@edk2.groups.io
Cc: Hsu, JasonX ; Desimone, Nathaniel L
; Zeng, Star ; Chiu,
Chasel ; Chen, Gang C ; Duggapu,
Chinni B ; Kuo, Ted ; S, Ashraf
Ali ; Mohapatra, Susovan ;
Lu, J
Hello Leif,
On 11/2/23 11:20, Pierre Gondois wrote:
On 10/26/23 13:03, Leif Lindholm wrote:
On Wed, Oct 25, 2023 at 13:25:39 +0200, PierreGondois wrote:
From: Pierre Gondois
The SCP holds some power information that could be advertised
through the _CPC object. The communication with the SC
Reviewed-by: Leif Lindholm
I see no issues with this going in during soft freeze.
/
Leif
On 2023-11-08 03:49, Michael D Kinney wrote:
The following commit removed PlatformBootManagerLibGub from
OvmfPkg. Update Maintainers.txt to remove reference to
deleted directory.
https://github.com/
Enable the following modules builds for AARCH64:
- OpensslLibAccel.inf
- OpensslLibFullAccel.inf
Signed-off-by: Pierre Gondois
---
CryptoPkg/CryptoPkg.dsc | 23 ---
CryptoPkg/Readme.md | 14 +++---
2 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/C
Add AARCH64 specific implementations of:
- OPENSSL_cpuid_setup(), probing hardware capabilitie
(presence of FEAT_AES, etc.)
- OPENSSL_rdtsc(), returning non-trusted entropy by accessing
system counter.
Signed-off-by: Pierre Gondois
---
.../Library/OpensslLib/OpensslLibAccel.inf| 1 +
.
Add native instruction support for AARCH64.
Signed-off-by: Pierre Gondois
---
.../Library/OpensslLib/OpensslLibAccel.inf| 21 ++-
.../OpensslLib/OpensslLibFullAccel.inf| 21 ++-
CryptoPkg/Library/OpensslLib/UefiAsm.conf | 6 ++
CryptoPkg/Libra
A ArmReadIdAA64Isar0Reg() function was recently added
to BaseLib. Use it instead of its ArmReadIdIsar0() equivalent,
which was private to the BaseRngLib library.
This also allows to avoid the confusion between the following
registers:
- ID_ISAR0_EL1: allows to probe for Divide instructions, Debug
To enable AARCH64 native instruction support for Openssl,
some interfaces must be implemented. OPENSSL_cpuid_setup()
allows to probe the supported features of the platform.
Add ArmReadIdAA64Isar0Reg() to read the AA64Isar0, containing
Arm64 instruction capabilities.
A similar ArmReadIdAA64Isar0()
v2:
- [PATCH v2 2/7] MdePkg/BaseLib: AARCH64: Add ArmReadIdAA64Isar0Reg()
- Correct bad mask values in MdePkg/Include/Library/BaseLib.h
- [PATCH v2 4/7] CryptoPkg/OpensslLib: Add native instruction support:
- Add armcap.c to configure.py:sources_filter_fn() instead of
manually commenting th
To enable AARCH64 native instruction support for Openssl,
some interfaces must be implemented. OPENSSL_rdtsc() requests
an access to a counter to get some non-trusted entropy.
Add ArmReadCntPctReg() to read system count.
A similar ArmReadCntPct() function is available in the ArmPkg,
but the Crypto
67 matches
Mail list logo
