On Tue, 12 Dec 2023 at 08:17, Mike Beaton wrote:
>
> > > A completely different approach, which allows clang to spot that the
> > > usage has been 'optimised away' and so to not complain (and therefore
> > > allows us to re-enable the warning in CLANGDWARF as well), is the
> > > following:
> > >
> > A completely different approach, which allows clang to spot that the
> > usage has been 'optimised away' and so to not complain (and therefore
> > allows us to re-enable the warning in CLANGDWARF as well), is the
> > following:
> >
> > --- a/MdePkg/Include/Library/DebugLib.h
> > +++
ah never mind, sorry for the noise. Needed to build BaseTools/Source/C
and install some packages.
On 12/12/23 14:52, Alexey Kardashevskiy via groups.io wrote:
Hi,
This broke build:
nice build -q --cmd-len=64436 -n 20 -t GCC5 -a X64 -p
OvmfPkg/OvmfPkgX64.dsc
build.py...
Hi,
This broke build:
nice build -q --cmd-len=64436 -n 20 -t GCC5 -a X64 -p OvmfPkg/OvmfPkgX64.dsc
build.py...
/home/aik/p/o-snp/CryptoPkg/CryptoPkg.dec(32): error 000E:
File/directory not found in workspace
/home/aik/p/o-snp/CryptoPkg/Library/MbedTlsLib/mbedtls/include
What am I
Hi Laszlo,
Thanks for reviewing again this patch while you are sick and please take
care.
My opinion is as follow:
Thanks,
Chao
On 2023/12/12 01:16, Laszlo Ersek wrote:
On 11/23/23 12:43, Chao Li wrote:
On 2023/11/23 00:12, Laszlo Ersek wrote:
On 11/17/23 11:00, Chao Li wrote:
Add the
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, December 12, 2023
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
Hi Laszlo,
Thanks for your reply. Sorry that I didn't add you in the reviewer list from
the beginning of this patch series review. About the patch review, please take
your time. Also take care your body!
The patch set was reviewed-by Ray last week. So I think we can merge the patch
set first.
On 12/11/2023 6:17 PM, Laszlo Ersek wrote:
On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
On 12/8/2023 5:19 PM, Rebecca Cran wrote:
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY
level in
On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
> On 12/8/2023 5:19 PM, Rebecca Cran wrote:
>> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
>>
>> Improve the wording of the description of the DEBUG_MANAGEABILITY
>> level in
>> DebugLib.h.
>>
>> Update the comment
Fan:
Please separate the patch for the different packages.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wang Fan
> 发送时间: 2023年12月11日 17:06
> 收件人: devel@edk2.groups.io
> 抄送: Fan Wang ; Michael D Kinney
> ; Liming Gao ;
> Ray Ni ; Guomin Jiang ; Jian J
> Wang
> 主题:
On 12/11/23 18:26, Mike Beaton wrote:
>>> I believe this would be logically wrong, as the other versions still
>>> wouldn't compile if you changed the relevant debug Pcds. (Which are
>>> logically independent of the compile and link options - e.g. what if for
>>> some reason you wanted to single
The change is good to me. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> PierreGondois
> 发送时间: 2023年12月6日 17:43
> 收件人: Ni, Ray ; devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Sami
> Mujawar ; Leif Lindholm
>
> 主题: Re:
On 12/1/23 09:42, Ni, Ray wrote:
> Reviewed-by: Ray Ni
This series seems to have been merged meanwhile -- that's good, because
I could have usefully reviewed only patch#1, and only ACK patches #2 and
#3, due to time constraints.
However... please do report on the list whenever a series is
Joey:
Does this change still work on old python version, such as Python 3.9?
Thanks
Liming
> -邮件原件-
> 发件人: Joey Vagedes
> 发送时间: 2023年12月7日 4:27
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
>
> 主题: [PATCH v1 1/1] BaseTools: Resolve regex syntax
On 12/6/23 04:35, Wu, Jiaxin wrote:
>> (1) Here's why I don't like this:
>>
>> we already have a function that is supposed to do this, and it is
>> SmmWaitForApArrival().
>>
>> SmmWaitForApArrival() is called in two contexts. One, in BSPHandler().
>> Two, here.
>>
>> Consider the following
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: ManickamX Srinivasan
> 发送时间: 2023年12月8日 13:37
> 收件人: devel@edk2.groups.io
> 抄送: ManickamX Srinivasan ; Michael D
> Kinney ; Liming Gao
> ; Zhiguang Liu ; T V
> Krishnamoorthy
> 主题: [PATCH v3] MdePkg: Add a new memory type definition
>
> New
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 ManickamX
> Srinivasan
> 发送时间: 2023年12月8日 15:29
> 收件人: devel@edk2.groups.io
> 抄送: ManickamX Srinivasan ; Zhiguang
> Liu ; Michael D Kinney
> ; Liming Gao ; T
> V Krishnamoorthy
> 主题: [edk2-devel] [PATCH] MdePkg: Define the
[AMD Official Use Only - General]
Here is the PR https://github.com/tianocore/edk2/pull/5139 with Igor's RB for
the V1.
Hi Igor, please check it again as I had moved the code around.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via
On 12/7/23 10:44, Gerd Hoffmann wrote:
> Extend the ValidateFvHeader function, additionally to the header checks
> walk over the list of variables and sanity check them.
>
> In case we find inconsistencies indicating variable store corruption
> return EFI_NOT_FOUND so the variable store will be
From: Benjamin Doron
Former Intel platforms controlled SMRAM protection using a dedicated
register.
SlimBootloader-supported platforms have converged on the SMRR, but for
coreboot to support prior platforms too, lock-down is advised.
Requires testing.
TODO: It is more correct to install a
From: Benjamin Doron
To be used with the https://review.coreboot.org/c/coreboot/+/70378
patch-series. Now feature complete, awaiting final upstream feedback
whether generating some data inside coreboot is okay.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by:
From: Benjamin Doron
Parse coreboot FMAP structures to find the memory region in SPI flash
by the FMAP area name.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Benjamin Doron
---
UefiPayloadPkg/Include/Coreboot.h | 21
From: Benjamin Doron
UefiPayload does not install all SBL HOBs, EDK2-relevant ones must be
installed individually. This was omitted from the SMM feature pushes.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Benjamin Doron
---
From: Benjamin Doron
Former Intel platforms controlled SMRAM protection using a dedicated
register.
SlimBootloader-supported platforms have converged on the SMRR, but for
coreboot to support prior platforms too, lock-down is advised.
Requires testing.
TODO: It is more correct to install a
From: Benjamin Doron
To be used with the https://review.coreboot.org/c/coreboot/+/70378
patch-series. Now feature complete, awaiting final upstream feedback
whether generating some data inside coreboot is okay.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by:
From: Benjamin Doron
Parse coreboot FMAP structures to find the memory region in SPI flash
by the FMAP area name.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Benjamin Doron
---
UefiPayloadPkg/Include/Coreboot.h | 21
From: Benjamin Doron
UefiPayload does not install all SBL HOBs, EDK2-relevant ones must be
installed individually. This was omitted from the SMM feature pushes.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Benjamin Doron
---
Pushed as 3c0adfe.
-Original Message-
From: Abdul Lateef Attar
Sent: Wednesday, August 2, 2023 11:35 PM
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar ; Chaganty, Rangasai V
; Oram, Isaac W ;
Desimone, Nathaniel L ; Gao, Liming
; Abner Chang
Subject: [PATCH 1/1]
Reviewed-by: Nate DeSimone
-Original Message-
From: Abdul Lateef Attar
Sent: Wednesday, August 2, 2023 11:35 PM
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar ; Chaganty, Rangasai V
; Oram, Isaac W ;
Desimone, Nathaniel L ; Gao, Liming
; Abner Chang
Subject: [PATCH 1/1]
Pushed as 7afba0.
-Original Message-
From: Huang, Li-Xia
Sent: Tuesday, December 5, 2023 11:00 PM
To: devel@edk2.groups.io
Cc: Abner Chang ; Desimone, Nathaniel L
Subject: [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Sync change from SMM
Sync change from SMM to StandaloneMm GenericIpmi
Reviewed-by: Nate DeSimone
-Original Message-
From: Huang, Li-Xia
Sent: Tuesday, December 5, 2023 11:00 PM
To: devel@edk2.groups.io
Cc: Abner Chang ; Desimone, Nathaniel L
Subject: [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Sync change from SMM
Sync change from SMM to StandaloneMm
Merged: https://github.com/tianocore/edk2/pull/5138
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, December 11, 2023 9:34 AM
> To: Tan, Dun ; devel@edk2.groups.io
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Ni, Ray ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [PATCH 2/2]
On 12/7/23 10:01, Sheng Wei wrote:
> Hi Ray,
> I update the copyright year and add your review-by for the 5 patches.
> And here is the PR https://github.com/tianocore/edk2/pull/5109
Why was my Reviewed-by removed from v6 patches #2 through #5?
Those patches didn't change between v6 and v7,
On 11/24/23 04:45, Ni, Ray wrote:
> Reviewed-by: Ray Ni
Please go ahead with merging this. The patch set has changed so much
since v2 (which I last reviewed) that I can't perform an incremental
review, and I can't review this from zero at the moment.
Thanks
Laszlo
>
> Thanks,
> Ray
>>
Acked-by: Michael D Kinney
Mike
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, December 6, 2023 1:26 AM
> To: devel@edk2.groups.io; Tan, Dun
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Ni,
> Ray
> Subject: RE: [edk2-devel] [PATCH 2/2] MdePkg:simplify Fifo API
> > I believe this would be logically wrong, as the other versions still
> > wouldn't compile if you changed the relevant debug Pcds. (Which are
> > logically independent of the compile and link options - e.g. what if for
> > some reason you wanted to single step with the Debug Pcds set to
> >
I don't appear to have permission to push to the edk2-test repo.
Could somebody merge my change please?
Thanks.
Rebecca
On 11/10/2023 12:08 PM, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running on
the
Hi Jianyong,
On 12/11/23 17:31, Laszlo Ersek wrote:
> On 11/23/23 04:22, Jianyong Wu wrote:
>> Add the long lost CI for CloudHv on AArch64.
>> As CloudHv CI works nearly the same way with other VMMs like KvmTool,
>> thus we can easily create its CI configuration based on KvmTool.
>>
>>
On 11/23/23 12:43, Chao Li wrote:
> On 2023/11/23 00:12, Laszlo Ersek wrote:
>> On 11/17/23 11:00, Chao Li wrote:
>>> Add the LoongArch64 CPU Timer library, using CPUCFG 0x4 and 0x5 for
>>> Stable Counter frequency.
>>>
>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
>>>
>>> Cc: Eric
Hit send before adding the cc on this one. (Would probably be good to get that
added to here
(https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process)
so copy paste doesn't get folks .
I sent them as different patch series as I thought this one might cause some
Thank you, Rebecca.
However the other reviewers too felt that your naming convention was more apt.
So we will take it as it is. No need of any changes.
With Warm Regards,
Edhay
> -Original Message-
> From: Rebecca Cran
> Sent: Monday, December 11, 2023 9:38 PM
> To: G Edhaya Chandran ;
On 11/23/23 04:22, Jianyong Wu wrote:
> Add the long lost CI for CloudHv on AArch64.
> As CloudHv CI works nearly the same way with other VMMs like KvmTool,
> thus we can easily create its CI configuration based on KvmTool.
>
> Reviewed-by: Laszlo Ersek
> Signed-off-by: Jianyong Wu
> ---
>
On 12/11/23 16:18, Mike Beaton wrote:
> I believe this would be logically wrong, as the other versions still
> wouldn't compile if you changed the relevant debug Pcds. (Which are
> logically independent of the compile and link options - e.g. what if for
> some reason you wanted to single step with
On 11/29/2023 1:06 AM, G Edhaya Chandran wrote:
Hi Rebecca,
Thank you for these updates.
Just a matter of style, but can we do HowToBuild*SCT*.txt instead of
HowToBuild*Sct*.txt?
Sure! I can make that change just before I push the series.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
On Mon, Dec 11, 2023 at 3:40 PM Jeff Brasen via groups.io
wrote:
>
Jeff,
You're missing CC's on this patch. Also, you should probably send the
3 patches in a single series, since they're all related.
> Rename the standard functions in the LibFdtSupport to remove conflicts
> with other
On Mon, Dec 4, 2023 at 8:30 AM Dhaval Sharma wrote:
>
> Use newly defined cache management operations for RISC-V where possible
> It builds up on the support added for RISC-V cache management
> instructions in BaseLib.
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Laszlo
Add implementation of ReallocatePool which is defined in the
MemoryAllocationLib header file to allow components to not
need special handling for PrePi module types.
Signed-off-by: Jeff Brasen
---
.../MemoryAllocationLib.c | 57 +++
1 file changed, 57
Add Google Mock Library for DtPlatformLoaderDtbLib
Signed-off-by: Jeff Brasen
---
EmbeddedPkg/EmbeddedPkg.dec | 1 +
.../Library/MockDtPlatformDtbLoaderLib.h | 31 +++
.../MockDtPlatformDtbLoaderLib.cpp| 13
Add Google Mock Library for FdtLib
Signed-off-by: Jeff Brasen
---
.../Include/GoogleTest/Library/MockFdtLib.h | 165 ++
.../GoogleTest/MockFdtLib/MockFdtLib.cpp | 34
.../GoogleTest/MockFdtLib/MockFdtLib.inf | 28 +++
3 files changed, 227 insertions(+)
create
On Mon, Dec 11, 2023 at 3:20 PM Sunil V L wrote:
>
> On Mon, Dec 11, 2023 at 03:09:19PM +, Pedro Falcato wrote:
> > On Mon, Dec 11, 2023 at 1:12 PM Sunil V L wrote:
> > >
> > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote:
> > [...]
> > > > nit: Can we pick a log style here?
Rename the standard functions in the LibFdtSupport to remove conflicts
with other libraries that define them.
Signed-off-by: Jeff Brasen
---
MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 16 +++
MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 25 ++-
2 files changed,
On Mon, Dec 11, 2023 at 03:09:19PM +, Pedro Falcato wrote:
> On Mon, Dec 11, 2023 at 1:12 PM Sunil V L wrote:
> >
> > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote:
> [...]
> > > nit: Can we pick a log style here? Like :
> > > In this case, "CacheOpCacheRange: Performing
I believe this would be logically wrong, as the other versions still
wouldn't compile if you changed the relevant debug Pcds. (Which are
logically independent of the compile and link options - e.g. what if for
some reason you wanted to single step with the Debug Pcds set to disabled,
in a NOOPT
On Mon, Dec 11, 2023 at 1:12 PM Sunil V L wrote:
>
> On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote:
[...]
> > nit: Can we pick a log style here? Like :
> > In this case, "CacheOpCacheRange: Performing ...". It's just prettier
> > and more greppable.
> > My interpretation of this
On 12/10/23 11:18, Mike Beaton wrote:
> From: Mike Beaton
>
> This warning was already disabled in CLANGDWARF by commit
> d3225577123767fd09c91201d27e9c91663ae132.
>
> gcc can distinguish between optimised-away variable usage (as can occur in
> valid debug code) and genuinely unused variables,
From: Abner Chang
Remedy Redfish service discovery flow changes made
in commit 8736b8fd.
The above fix creates the dependency with SMBIOS 42h record,
which has a problem as SMBIOS 42h may not be created when
RedfishDiscovery.Supported() is invoked even all of the
required protocols are ready on
On Mon, 11 Dec 2023 at 15:33, Laszlo Ersek wrote:
>
> On 12/11/23 11:55, Gerd Hoffmann wrote:
> >> + //
> >> + // Work around shim's terminally broken use of the EFI memory attributes
> >> + // protocol, by uninstalling it if requested on the QEMU command line.
> >> + //
> >> + // E.g.,
> >>
On 12/11/23 11:55, Gerd Hoffmann wrote:
>> + //
>> + // Work around shim's terminally broken use of the EFI memory attributes
>> + // protocol, by uninstalling it if requested on the QEMU command line.
>> + //
>> + // E.g.,
>> + // -fw_cfg
On 12/8/23 16:34, Ard Biesheuvel wrote:
> On Fri, 8 Dec 2023 at 15:34, Laszlo Ersek wrote:
>>> diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec
>>> index 0f2d7873279f..c55978f75c19 100644
>>> --- a/ArmVirtPkg/ArmVirtPkg.dec
>>> +++ b/ArmVirtPkg/ArmVirtPkg.dec
>>> @@ -68,3 +68,9
Hello Abdul,
Thanks for the new patches. I reviewed this one, but I think it would
be better to have one single generic function to handle the 2 cases
(and the many more that might spawn) that you have.
Would it be possible to make a function based on this kind of interface instead
?
/* Type
Hi Dun,
On 12/11/23 04:16, Tan, Dun wrote:
> Hi Laszlo,
>
> Previously I sent a patch set " Move gMpInformationHobGuid from
> StandaloneMmPkg to UefiCpuPkg. " and thanks for your review. To solve the
> issue that the maximum length of one HOB might not be enough when CPU count
> is 1-2000 or
On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote:
> Thanks for the review. My comments inline:
>
> On Fri, Dec 8, 2023 at 9:58 AM Sunil V L wrote:
>
> > On Thu, Dec 07, 2023 at 10:31:48AM +0530, Dhaval Sharma wrote:
> > > Comments inline:
> > >
> > >
> > > On Wed, Dec 6, 2023 at
Good fix and cleanup, Abdul. EFIAPI is needed for
https://uefi.org/specs/UEFI/2.9_A/02_Overview.html#calling-conventions.
Looks good to me as long as we can also successfully build AARCH64 and other
architectures with this change.
Reviewed-by: Sunny Wang
-Original Message-
From:
Good catch. Looks good to me. Thanks, Rebecca!
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday, November 10, 2023 7:08 PM
To: devel@edk2.groups.io; G Edhaya Chandran ; Barton
Gao ; Carolyn Gjertsen ; Samer
This is good. Thanks, Rebecca!
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday, November 10, 2023 7:02 PM
To: devel@edk2.groups.io; G Edhaya Chandran ; Barton
Gao ; Carolyn Gjertsen ; Samer
El-Haj-Mahmoud ;
Looks good to me.
Better to add
https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C#user-content-CamelCase
in commit message for reference.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: Friday,
Looks good to me.
The commit message looks a little confusing to me in the beginning because one
of purposes to run the edksetup.sh is to correctly configure both WORKSPACE and
PACKAGES_PATH.
However, since buildzip.sh can be independently run, it seems better to remove
the line of sourcing
> + //
> + // Work around shim's terminally broken use of the EFI memory attributes
> + // protocol, by uninstalling it if requested on the QEMU command line.
> + //
> + // E.g.,
> + // -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y
> + //
> + // This is only needed on
From: Ard Biesheuvel
Shim's PE loader uses the EFI memory attributes protocol in a way that
results in an immediate crash when invoking the loaded image, unless the
base and size of its executable segment are both aligned to 4k.
If this is not the case, it will strip the memory allocation of
From: Abdul Lateef Attar
Adds a wrapper API AmlCodeGenMethodInvokeMethodArgnWithInteger() to
the AmlCodeGenMethodInvokeMethodArgn().
Wrapper API provides ability to add integer arguments along
with ArgN argument.
This help to generate dynamic code to invoke another
method(might be in static ASL
From: Abdul Lateef Attar
Adds an API to generate a method which invokes another
method with arguments.
This help to generate dynamic code to invoke another
method(might be in static ASL file) with build-in
argument parameters.
e.g:
Method (MET0, 6, Serialized)
{
\_SB.MET1 (Arg0, Arg1, Arg2,
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5131/
Cc: Pierre Gondois
Cc: Sami Mujawar
Cc: Abdul Lateef Attar
Abdul Lateef Attar (5):
DynamicTablesPkg: AML Code generation for word I/O ranges
DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters
From: Abdul Lateef Attar
Corrects the function pointer typedef AML_PARSE_FUNCTION,
otherwise some compiler like VS2019 gives error.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
.../Include/Library/AmlLib/AmlLib.h | 65 ++
Ok, I will submit the V4 today.
Thanks,
Chao
On 2023/12/11 16:13, Ni, Ray wrote:
Thanks. I think we are aligned. Looking forward to your v4 patch.
Thanks,
Ray
*From:*devel@edk2.groups.io *On Behalf Of *Chao Li
*Sent:* Friday, December 8, 2023 10:10 AM
*To:* Ni, Ray ; devel@edk2.groups.io
Hi,
> OK, so not worth the trouble of trying to detect the first boot, I guess.
>
> For my info, is rhel-9.3 an old GRUB?
2.06 with a huge stack of downstream patches.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Hi Ray, Liming, Mike and Jian
I have updated the patch v4: https://edk2.groups.io/g/devel/message/112276
Pull Request: https://github.com/tianocore/edk2/pull/5124
v2:
- Update commit message for better describe this feature
v3:
- Add more descriptions for "gEdkiiToMigrateFvInfoGuid" PPI
Thanks a lot~
> -Original Message-
> From: gaoliming
> Sent: Monday, December 11, 2023 5:04 PM
> To: Chen, Christine ; devel@edk2.groups.io; Feng,
> Bob C
> Cc: 'Rebecca Cran' ; Guo, Gua
> Subject: 回复: [edk2-devel] [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv
> issue
>
> Christine:
Christine:
Is there the change in Edk2 to apply new VfrCompiler? Can you share your code
branch with new VfrCompiler to pass build on Emulator or Ovmf? I would like to
try this tool first.
Thanks
Liming
发件人: Chen, Christine
发送时间: 2023年12月7日 17:08
收件人: devel@edk2.groups.io; Chen,
On Mon, Dec 11, 2023 at 10:06 AM Gerd Hoffmann wrote:
>
> On Thu, Dec 07, 2023 at 11:06:03AM +0100, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel
> >
> > Shim's PE loader uses the EFI memory attributes protocol in a way that
> > results in an immediate crash when invoking the loaded image,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4533
There are use cases which not all FVs need be migrated from TempRam to
permanent memory before TempRam tears down. This new guid is introduced
to avoid unnecessary FV migration to improve boot performance. Platform
can publish MigrationInfo
On Thu, Dec 07, 2023 at 11:06:03AM +0100, Ard Biesheuvel wrote:
> From: Ard Biesheuvel
>
> Shim's PE loader uses the EFI memory attributes protocol in a way that
> results in an immediate crash when invoking the loaded image, unless the
> base and size of its executable segment are both aligned
Christine:
I add PUSH label for this PR.
Thanks
Liming
> -邮件原件-
> 发件人: Chen, Christine
> 发送时间: 2023年12月4日 10:59
> 收件人: Gao, Liming ; devel@edk2.groups.io;
> Feng, Bob C
> 抄送: 'Rebecca Cran' ; Guo, Gua
> 主题: RE: [edk2-devel] [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue
>
> Hi
Thanks. I think we are aligned. Looking forward to your v4 patch.
Thanks,
Ray
From: devel@edk2.groups.io On Behalf Of Chao Li
Sent: Friday, December 8, 2023 10:10 AM
To: Ni, Ray ; devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Hoffmann ; Leif Lindholm ;
Ard Biesheuvel ; Sami
Hi Zack,
Could you please review the change?
Thanks,
Heng
> -Original Message-
> From: Kasbekar, Saloni
> Sent: Saturday, December 2, 2023 5:25 AM
> To: Luo, Heng ; devel@edk2.groups.io
> Cc: Clark-williams, Zachary
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not
86 matches
Mail list logo
