Hi Liming
The V5 patches have past test. Could you help merge these two patches? Or I
need find Rahul to merge the one in SecurityPkg?
https://github.com/tianocore/edk2/pull/5180
https://github.com/tianocore/edk2/pull/5181
They are totally independent and merge MdeModulePkg patch only will not
On Thu, 21 Dec 2023 at 04:48, Chao Li wrote:
>
...
> Ard,
>
> PcdPciIoTranslationIsEnabled is only use for whether to trigger the Ffio read
> or write, it seem that only x86 or x64 need them, not others.
>
> When I was submitted the patch V2, CpuIo2Dxe was private to LoongArch, just
> like Arm
Chao:
For the changes in MdePkg, I have two comments here.
1) DebugSupport.h definition is from UEFI spec. Current definitions match
the latest spec UEFI2.10. And, current definitions follow the same style to
other archs.
2) CpuLib.h. The patch removes #if defined
Hi Saloni:
I will try to file a Mantis with these details and update you.
Thanks
Siva
From: Natalya Kalistratova
Sent: Thursday, December 21, 2023 4:04 AM
To: Kasbekar, Saloni ; Sivaraman Nainar
; devel@edk2.groups.io; Clark-williams, Zachary
Cc: Dhanaraj V ; Santhosh Kumar V ;
GengYou Zhou
Hi Ray and Ard,
I went out yesterday, sorry for the late reply.
Thanks,
Chao
On 2023/12/20 15:41, Ard Biesheuvel wrote:
On Wed, 20 Dec 2023 at 02:57, Ni, Ray wrote:
It’s new to me that PCI IO (not MMIO) space is accessed through MMIO.
PCIE spec defines different TLP types for Memory and
This patch is to specify SmmCpuSyncLib instance for MinPlatformPkg
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
From: "Ren,Suqiang"
Add status code returned for HiiConfigAccess ExtractConfig to
align with UEFI spec 2.10.
REF: UEFI spec 2.10 Table 35.5.2
Signed-off-by: SuqiangX Ren
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Yi Li
---
MdePkg/Include/Protocol/HiiConfigAccess.h | 9
One round BSP & AP sync for exit SMI is shown as below:
BSP: SmmCpuSyncWaitForAPs <-- AP: SmmCpuSyncReleaseBsp
BSP: ReleaseAllAPs --> AP: SmmCpuSyncWaitForBsp
Above is only required if need configure MTRR and support
SMM source level debug, So, reduce one round BSP & AP sync
if both
This patch is to check SMM Debug Agent support or not before
InitializeDebugAgent.
Cc: Laszlo Ersek
Cc: Eric Dong
Cc: Ray Ni
Cc: Zeng Star
Cc: Gerd Hoffmann
Cc: Rahul Kumar
Signed-off-by: Jiaxin Wu
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 4 +++-
Below piece of code is to sync logic in AP for MTRR programming:
if (SmmCpuFeaturesNeedConfigureMtrrs ()) {
SmmCpuSyncReleaseBsp ();
SmmCpuSyncWaitForBsp ();
...
}
SmmCpuSyncReleaseBsp ();
SmmCpuSyncWaitForBsp ();
This patch is to make BSP sync logic same as above coding
Below BSP & AP sync flow before exit SMI is to:
1. Make sure BSP and all APs finish the MTRR programming and start
later executing the same start line. This is the MTRR programming
requirement.
2. Make sure all APs finish the pending tasks, then BSP can stop
source level debug.
BSP:
Jiaxin Wu (6):
SourceLevelDebugPkg/Library: Indicate SMM Debug Agent support or not
MdeModulePkg/DebugAgentLibNull: Indicate SMM Debug Agent support or
not
UefiCpuPkg/PiSmmCpuDxeSmm: Check SMM Debug Agent support or not
UefiCpuPkg/PiSmmCpuDxeSmm: Align MTRR sync logic between BSP and
This patch use the Context to indicate SMM Debug Agent support or
not if InitFlag is DEBUG_AGENT_INIT_SMM. Context must be the pointer
to the BOOLEAN value if it's not NULL.
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Jiaxin Wu
---
MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c | 9
This patch use the Context to indicate SMM Debug Agent support or
not if InitFlag is DEBUG_AGENT_INIT_SMM. Context must be the pointer
to the BOOLEAN value if it's not NULL.
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
.../Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c| 14 ++
The series has been pushed as 59ef582~..fc6e352
> -Original Message-
> From: Xu, Wei6
> Sent: Wednesday, December 20, 2023 9:02 AM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 ; Abner Chang ;
> Desimone, Nathaniel L
> Subject: [PATCH edk2-platforms 0/4] IpmiFeaturePkg: Support Standalone
>
For the series...
Reviewed-by: Nate DeSimone =
> -Original Message-
> From: Xu, Wei6
> Sent: Wednesday, December 20, 2023 9:02 AM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 ; Abner Chang ;
> Desimone, Nathaniel L
> Subject: [PATCH edk2-platforms 0/4] IpmiFeaturePkg: Support Standalone
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 SuqiangX Ren
> 发送时间: 2023年12月20日 13:36
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Yi Li
>
> 主题: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of
>
Yuting:
Seemly, this is a new feature. Can you submit a new BZ for it? If so, it
can be tracked in stable tag feature planning.
I have confuse on these two options --catch_default and --except_list.
VfrCompiler is used to compile single VFR one by one.
Single VFR can enable
From: Narinder Dhillon
This patch adds an EDK2 shell command to dump board configuration
device tree.
Signed-off-by: Narinder Dhillon
---
.../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 361 ++
.../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.h | 102 +
From: Narinder Dhillon
This patch adds Odyssey SoC project description file, flash description
file, and PCD's.
Signed-off-by: Narinder Dhillon
---
Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc| 216 ++
Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf| 304 ++
From: Narinder Dhillon
This patch adds a device tree driver that is used to read board
configuration information from a device tree.
Signed-off-by: Narinder Dhillon
---
.../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++
.../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43
From: Narinder Dhillon
This patch adds watchdog driver for Odyssey SoC.
Signed-off-by: Narinder Dhillon
---
.../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++
.../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++
2 files changed, 453 insertions(+)
create mode 100644
From: Narinder Dhillon
Marvell Odyssey SoC does not have RTC on chip. This patch provides a
dummy RTC driver to generate architectural protocol and help boot
Odyssey SoC.
Signed-off-by: Narinder Dhillon
---
.../Marvell/Drivers/Null/RtcNull/RtcNullDxe.c | 280 ++
From: Narinder Dhillon
This patch creates ArmPlatformPkg for Odyssey SoC by overriding some of
the files in original ArmPlatformPkg. Differences from standard
ArmPlatformPkg are marked with "--- MRVL Override" comment.
Signed-off-by: Narinder Dhillon
---
.../PrePi/AArch64/ModuleEntryPoint.S
From: Narinder Dhillon
This patch adds ArmPlatformLib for Marvell Odyssey SoC.
Signed-off-by: Narinder Dhillon
---
.../AArch64/ArmPlatformHelper.S | 86
.../Library/ArmPlatformLib/ArmPlatformLib.c | 79 +++
.../Library/ArmPlatformLib/ArmPlatformLib.inf |
From: Narinder Dhillon
This patch provides SMC call needed by Odyssey to determine available
memory size.
Signed-off-by: Narinder Dhillon
---
Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 +++
Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 +++
From: Narinder Dhillon
New Marvell Odyssey SoC
This patchset contains only the very basic elements needed to boot to
EDK2 UiApp on Marvell Odyssey SoC
- ARM BL31 firmware component copies EDK2 image into memory, so it is
always executing from memory
- There is a SMC library to get system
Hi Ted,
Looking at this code, the X64 version will only work if
PcdFspWrapperResetVectorInFsp == TRUE. Moreover, the IA32 version will only
work if PcdFspWrapperResetVectorInFsp == FALSE. So... what is the point of
having a PCD if the PCD must always be set to one value or the other? Please
Queued as https://github.com/tianocore/edk2/pull/5178 .
On 12/6/2023 1:27 PM, Joey Vagedes wrote:
Python 3.12 now produces syntax warnings when using an invalid escape
character (\ followed by an unexpected character). This happens
throughout BaseTools due the usage of regular expressions. the
I see two patches with the same subject line sent within about 15
minutes of each other.
Could you confirm whether I should review this one (1:43am) or the other
(1:27am) please?
Thanks.
Rebecca Cran
On 12/12/2023 1:43 AM, Yuting Yang wrote:
Add --catch_default option
Raise a
Thanks.
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 12/6/2023 1:27 PM, Joey Vagedes wrote:
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.
Cc: Rebecca Cran
Cc: Liming Gao
Thanks for the reminder - I'm catching up on patches today.
One nit that would be good to fix before being merged: the help for
"--ignore-change-id" should use the same capitalization of 'Change-Id'
as the rest of the code (i.e. 'Change-Id' not 'Change-id').
With that fixed:
Reviewed-by:
Queued as https://github.com/tianocore/edk2/pull/5177 .
On 12/19/2023 6:02 AM, gaoliming wrote:
The change is good.
Reviewed-by: Liming Gao
-邮件原件-
发件人: devel@edk2.groups.io 代表 Guo, Gua
发送时间: 2023年12月19日 15:32
收件人: devel@edk2.groups.io; Chen, Christine ;
Rebecca Cran ; Gao, Liming
Reviewed-by: Rebecca Cran
On 12/15/2023 2:11 AM, Yuwei Chen wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran
Reviewed-by: Rebecca Cran
On 12/20/2023 12:31 PM, Jake Garver wrote:
In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, we may encounter an ADR
instead of an ADRP when the toolchain is working around Cortex-A53
erratum #843419. If that's the case, be sure to calculate the offset
appropriately.
In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, we may encounter an ADR
instead of an ADRP when the toolchain is working around Cortex-A53
erratum #843419. If that's the case, be sure to calculate the offset
appropriately.
This resolves an issue experienced when building a StandaloneMm image
with
Refactor GenericElog to support Standalone MM.
Remove unused function SmElogServiceInitialize.
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Lixia Huang
---
.../GenericElog/Smm/GenericElog.c | 35 +++-
.../GenericElog/Smm/GenericElog.h | 28 ++---
Refactor BmcAcpiSwChild to support Standalone MM.
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Wei6 Xu
---
.../BmcAcpiSwChild/BmcAcpiSwChild.c | 12 ++
.../BmcAcpiSwChild/BmcAcpiSwChild.h | 15 ++-
.../BmcAcpiSwChild/BmcAcpiSwChild.inf | 5 ++-
Refactor BmcElog to support Standalone MM.
Remove unused code.
Cc: Abner Chang
Cc: Nate DeSimone
Signed-off-by: Lixia Huang
---
.../IpmiFeaturePkg/BmcElog/Smm/BmcElog.c | 14 ++
.../IpmiFeaturePkg/BmcElog/Smm/BmcElog.h | 15 +--
.../BmcElog/Smm/BmcElogStandaloneMm.c
Split the ServerManagementLib.c into two source files:
- ServerManagementELog.c to support Event Log functions.
- ServerManagementTime.c to support GetTimeStamp function.
- Replace gBS->Stall() with MicroSecondDelay() in TimerLib to
remove dependency on gBS.
Base Lib includes both of the two
This patch series add Standalone MM support for ServerManagementLib,
BmcAcpiSwChild, BmcElog and GenericElog.
PR: https://github.com/tianocore/edk2-platforms/pull/117
Cc: Abner Chang
Cc: Nate DeSimone
Wei6 Xu (4):
IpmiFeaturePkg/ServerManagementLib: Support Standalone MM
On Wed, 20 Dec 2023 at 10:11, Ray Ni wrote:
>
> Load-module-at-fixed-address feature does not work in standalone MM core.
>
> The patch removes the 2 dead functions and related global variables
> that are related to the feature.
>
> Signed-off-by: Ray Ni
> Cc: Sami Mujawar
Reviewed-by: Ard
On Wed, 20 Dec 2023 at 13:28, Ni, Ray wrote:
>
> Thanks for pointing it out.
> I found it in ACPI spec that tells how to use "Resource Type Specific Flags"
> to describe a MEM resource while maps to IO,
> and an IO resource while maps to MEM.
>
> I assume that the IO port accesses are all from
Thanks for pointing it out.
I found it in ACPI spec that tells how to use "Resource Type Specific Flags" to
describe a MEM resource while maps to IO,
and an IO resource while maps to MEM.
I assume that the IO port accesses are all from PCI device drivers.
Then, we can change the PciHostBridgeLib
Hello Abdul,
Thanks for the update!
Reviewed-by: Pierre Gondois
On 12/20/23 10:38, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Adds API to generate AML code to invoke/call another
method. Also provides ability to pass arguments of
type integer, string, ArgObj or LocalObj.
Cc: Pierre
On Wed, 20 Dec 2023 at 10:44, Ni, Ray wrote:
>
> Ard,
> Let me try to understand:
>
> 1. CPU does not support IO instructions to access IO ports.
> 2. PCI devices contain IO space.
> 3. A special PCI host bridge can be configured to map a range of MMIO space
> from CPU side to another range of
Ard,
Let me try to understand:
1. CPU does not support IO instructions to access IO ports.
2. PCI devices contain IO space.
3. A special PCI host bridge can be configured to map a range of MMIO space
from CPU side to another range of IO space to PCI device side.
If above is right, I can imagine
From: Abdul Lateef Attar
Adds API to generate AML code to invoke/call another
method. Also provides ability to pass arguments of
type integer, string, ArgObj or LocalObj.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
---
.../Include/Library/AmlLib/AmlLib.h
From: Abdul Lateef Attar
Corrects the function pointer typedef AML_PARSE_FUNCTION,
otherwise some compiler like VS2019 gives error.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami Mujawar
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Pierre Gondois
---
.../Include/Library/AmlLib/AmlLib.h | 65 ++
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5171/
V5: delta changes
Addressed review comments.
V4:
Address Pierre's review comments.
Merged patch 4 & patch 5.
Also added parameter logic suggested by Pierre.
V3: delta changes
CI fix and error handling for
Load-module-at-fixed-address feature does not work in standalone MM core.
The patch removes the 2 dead functions and related global variables
that are related to the feature.
Signed-off-by: Ray Ni
Cc: Ard Biesheuvel
Cc: Sami Mujawar
---
StandaloneMmPkg/Core/Dispatcher.c | 185
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: gaoliming
> Sent: Tuesday, December 19, 2023 2:28 PM
> To: Wang, Fan ; Kumar, Rahul R
>
> Cc: Wang, Jian J ; Ni, Ray ; Kinney,
> Michael D ; Jiang, Guomin
> ; devel@edk2.groups.io
> Subject: 回复: [edk2-devel] [PATCH v5 0/2]
54 matches
Mail list logo
