The function looks good to me. But still have some coding style issue: "Always
put space before an open parenthesis"
And for patch #2, the comment of GetBaseName is incorrect.
With the coding style issue fix and comments correction, Reviewed-by: Zhichao
Gao
Thanks,
Zhichao
> -Original Mess
On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote:
> Hi, thank you for taking a look at the patch!
>
> This patch can be verified to be working with this app (which was the
> motivation for submitting this):
> https://github.com/codyd51/uefirc/releases/tag/1.0.1.
Quoting https://gith
On Tue, 9 Apr 2024 at 13:56, Gerd Hoffmann wrote:
>
> On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote:
> > Hi, thank you for taking a look at the patch!
> >
> > This patch can be verified to be working with this app (which was the
> > motivation for submitting this):
> > https://git
Reviewed-by: joey.vage...@gmail.com
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117546): https://edk2.groups.io/g/devel/message/117546
Mute This Topic: https://groups.io/mt/105394121/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubs
Thanks for addressing my comments, Abhi.
https://github.com/tianocore/edk2-test/pull/90
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abhimanyu Singh
via groups.io
Sent: Monday, April 8, 2024 11:45 PM
To: devel@edk2.groups.io
Cc: Abhi Singh
Subject
+Leif
Adding a new submodule requires review by the stewards to review
the license and the health and support of the submodule project.
The top level Readme also requires updates. It lists all the submodules
and licenses used. Please update this series with the Readme changes.
https://github.co
On Tue, Apr 9, 2024 at 12:56 PM Gerd Hoffmann wrote:
>
> On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote:
> > Hi, thank you for taking a look at the patch!
> >
> > This patch can be verified to be working with this app (which was the
> > motivation for submitting this):
> > https://
This adds an additional option to the dmem UEFI shell command for verbose
dumping of a couple of UEFI tables.
The tables specified are the RT Properties Table, the Image Execution Table,
and the Conformance Profiles table.
Supporting objects are added in the .inf and .uni files relating to Dmem
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the Image Execution Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
Tested-by: Stuart Yoder
Reviewed-by: Stuart Yoder
Reviewed-by: Zhichao Gao
---
Notes:
v5:
- corrected comment
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented the dumping of the UEFI RT Properties Table using Dmem.c
Added new entry to the help command for the -verbose option
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
Tested-by: Stuart Yoder
Reviewed-by: Stuart Yoder
Re
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c
Additionally added the base support for the table with new
header file ConformanceProfiles.h (Cc'd maintainers of MdePkg for this)
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Mich
I brought the RFC into the CCC community
(https://github.com/confidential-computing/governance) and received
some comments.
Forward the email into the EDK2 dev and linux-coco.
Thanks,
Qinkun
-- Forwarded message -
From: Mingshen Sun
Date: Thu, Apr 4, 2024 at 1:43 PM
Subject: Re:
v1:
- Initial patch series
v2:
- Simplified the check for if the currently evaluated inf is a module or
library.
- Added a commit to use stronger matching of NULL includes (check for pattern
"NULL")
v3:
- In the WorkspaceCommon.py lines 126 and 144 should check
LibraryClassName[4:].isdig
When collecting the required library instances for modules and
libraries, included libraries will be recursed to ensure the module is
built with all the libraries directly linked to it and indirectly
linked to it via included libraries.
Using the following scenario as an example:
[LibraryClasses.
To prevent the possibility that a library with a name like
NULLTestLib is interpreted as a NULL linked library, use
more explicit pattern matching to ensure that the library
name follows the pattern NULL%d.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Taylor Beeb
Hi Liming,
I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144
of WorkspaceCommon.py update the check to:
`LibraryClassName[4:].isdigit()`
instead of
`LibraryClass[4:].isdigit()`
Can you re-review with this change?
-Taylor
On 4/1/2024 6:37 PM, gaoliming via groups.io wr
Thanks Rahul for reviewing this patch.
I created a PR with adding Rahul's 'Reviewed-by' in the commit message:
https://github.com/tianocore/edk2/pull/5538
Could anyone help to merge it? Thanks a lot.
BR,
Wei
>-Original Message-
>From: Kumar, Rahul R
>Sent: Friday, March 29, 2024 11:36 A
[AMD Official Use Only - General]
Hi Nickle,
I don't see the obvious coding error in this patch. However, I think we can
remove HPE copyright from Redfish secure boot feature driver, as this is a new
feature driver and HPE doesn't have contributions to these files, right? If so,
then please rem
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, April 1, 2024 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/F
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735
Should not call HiiGetBrowserData() and HiiSetBrowserData() in FORM_OPEN
call back function.
Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData
which have been used by OpalHii.c.
1. Change callback action from FORM_OPE
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735
Should not call HiiGetBrowserData() and HiiSetBrowserData() in FORM_OPEN
call back function.
Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData
which have been used by OpalHii.c.
1. Change callback action from FORM_OPE
You cannot change across packages. You need to separate the MdePkg change into
one single patch and get reviewed by the reviewer/maintainer of MdePkg.
Thanks,
Zhichao
> -Original Message-
> From: Sam Kaynor
> Sent: Wednesday, April 10, 2024 2:53 AM
> To: devel@edk2.groups.io
> Cc: Ni, R
merged.
Thanks,
Ray
From: Shang, Qingyu
Sent: Monday, April 8, 2024 17:47
To: devel@edk2.groups.io
Cc: Pedro Falcato ; Ni, Ray ; Gahan
Saraiya
Subject: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation
function
Refer to Uefi spec 2.10 section 11
Pedro,
I didn't notice your mail and merged the patch.:(
Your comments to the commit messages are good to me.
However, I am ok with the changes to the function header of an existing
implementation.
Thanks,
Ray
From: Pedro Falcato
Sent: Tuesday, April 9, 2024 1
This commit adds the initial support for BOSC's
nanhu platform which provides up to 2 RISC-V RV64
processor cores.
Signed-off-by: Yang Wang
Signed-off-by: Ran Wang
Signed-off-by: YunFeng Yang
Signed-off-by: YaXing Guo
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Sunil V L
Cc: Daniel Schaefer
Reviewed-by : Jayaprakash N
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Thursday, April 4, 2024 3:14 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D
Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr functio
This patch adds 2 new functions to read and write msrs from specific CPUs.
rdmsr_ex and wrmsr_ex are the 2 new functions added into edk2module to
provide the read and write of CPU specific MSRs.
Jayaprakash N (1):
edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific
msrs
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr APIs
supported in edk2 module. These extension APIs makes it possible
to read / write MSRs from specific processors and fills an existing gap
in this area.
Cc: Rebecca Cran
28 matches
Mail list logo
