Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael Kubacki
On 5/3/2024 4:38 PM, Michael D Kinney wrote: -Original Message- From: Kinney, Michael D Sent: Friday, May 3, 2024 1:13 PM To: Pedro Falcato Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm ; Andrew Fish (af...@apple.com) ; Kinney, Michael D Subject: RE: [edk2-rfc]

[edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405 // RE: [PATCH v2 0/4] TCG2 protocol clean up

2024-05-03 Thread G Edhaya Chandran
Hi All, A new release candidate is published after upstreaming Stuart's commits on build cleanup. https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405 The updates since the old tag are the following commits in the patch series: [PATCH v2 0/4] TCG2 protocol clean up

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael D Kinney
> -Original Message- > From: Kinney, Michael D > Sent: Friday, May 3, 2024 1:13 PM > To: Pedro Falcato > Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm > ; Andrew Fish (af...@apple.com) ; > Kinney, Michael D > Subject: RE: [edk2-rfc] [edk2-devel] Proposal to switch

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael D Kinney
> -Original Message- > From: Pedro Falcato > Sent: Friday, May 3, 2024 10:39 AM > To: Kinney, Michael D > Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm > ; Andrew Fish (af...@apple.com) > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code > Review

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv.py: FIX for GCC 32BIT build error

2024-05-03 Thread Nate DeSimone
Pushed as 248aa15 > -Original Message- > From: Duggapu, Chinni B > Sent: Monday, April 22, 2024 9:03 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; S, Ashraf Ali ; Kuo, > Ted > Subject: [PATCH] IntelFsp2Pkg/PatchFv.py: FIX for GCC

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael D Kinney
Yes. Many options on transition. I would suggest we consider the following steps. 1) Define a manual process where Maintainers/Reviewers look for new PRs and make sure all the required maintainers/reviewers are invited to the review. Current process has many manual steps. Having

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Pedro Falcato
On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D wrote: > > > > > -Original Message- > > From: r...@edk2.groups.io On Behalf Of Pedro Falcato > > Sent: Thursday, May 2, 2024 10:51 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew Fish

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael Kubacki
Hi Mike, I've seen that repo in that past. Are the steps defined for what's needed to move to CODEWONERS (and REVIEWERS) in terms of technical and process changes needed? For example, could we start with CODEOWNERS manually synced to Maintainers.txt, Maintainers.txt dropped, and then add

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael Kubacki
On 5/2/2024 12:37 PM, Kinney, Michael D wrote: -Original Message- From: Leif Lindholm Sent: Thursday, May 2, 2024 3:57 AM To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael D ; r...@edk2.groups.io Cc: Andrew Fish (af...@apple.com) Subject: Re: [edk2-devel]

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael Kubacki
On 5/2/2024 6:57 AM, Leif Lindholm wrote: On 2024-05-02 04:08, Michael Kubacki wrote: Thank you for this proposal. We've been anticipating this change for years and are excited to help support it. Here's some items we'd like to raise for feedback that we could help implement. Many could

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove HOB creation

2024-05-03 Thread Oliver Smith-Denny
On 5/2/2024 7:28 PM, Nhi Pham via groups.io wrote: On 5/2/2024 4:31 AM, Oliver Smith-Denny via groups.io wrote: Hi folks, returning to this thread because I noticed that HOB creation still exists in StandaloneMmCore for ARM:

Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-05-03 Thread Sami Mujawar
Hi All, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 02/05/2024, 17:36, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote: Hello Abdul, I added some comments. I think that: a. patches related to HPET/WSMT should require little work b. MADT patch needs to