[edk2-devel] [PATCH v2 02/13] EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds Hash2DxeCrypto to EmulatorPkg. The Hash2DxeCrypto is used to provide the hashing protocol services. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Doug Flick [MSFT] --- EmulatorPkg/EmulatorPkg.dsc | 9 +++-- EmulatorPkg/EmulatorPkg.fdf | 5 + 2 files

[edk2-devel] [PATCH v2 13/13] NetworkPkg: Update the PxeBcDhcp6GoogleTest due to underlying changes

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch updates the PxeBcDhcp6GoogleTest due to the changes in the underlying code. The changes are as follows: - Random now comes from the RngLib Protocol - The TCP ISN is now generated by the hash function Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by:

[edk2-devel] [PATCH v2 12/13] MdePkg: Add MockHash2 Protocol for testing

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This commit adds a new MockHash2 protocol to the MdePkg. This protocol is used to test Hash2 protocol consumers. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Doug Flick [MSFT] --- MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockHash2.h | 67

[edk2-devel] [PATCH v2 11/13] MdePkg: : Adds Protocol for MockRng

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds a protocol for MockRng. This protocol is used to mock the Rng protocol for testing purposes. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Doug Flick [MSFT] --- MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockRng.h | 48

[edk2-devel] [PATCH v2 10/13] MdePkg: : Add MockUefiBootServicesTableLib

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This commit adds a mock library for UefiBootServicesTableLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Doug Flick [MSFT] --- MdePkg/Test/MdePkgHostTest.dsc | 1 +

[edk2-devel] [PATCH v2 08/13] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4542 Bug Overview: PixieFail Bug #9 CVE-2023-45237 CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N CWE-338 Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG) Use of a Weak PseudoRandom Number Generator Change

[edk2-devel] [PATCH v2 01/13] EmulatorPkg: : Add RngDxe to EmulatorPkg

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds RngDxe to EmulatorPkg. The RngDxe is used to provide random number generation services to the UEFI firmware. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Doug Flick [MSFT] --- EmulatorPkg/EmulatorPkg.dsc | 9 +++-- EmulatorPkg/EmulatorPkg.fdf | 6 +- 2

[edk2-devel] [PATCH v2 09/13] NetworkPkg: TcpDxe: SECURITY PATCH CVE-2023-45236

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4541 REF: https://www.rfc-editor.org/rfc/rfc1948.txt REF: https://www.rfc-editor.org/rfc/rfc6528.txt REF: https://www.rfc-editor.org/rfc/rfc9293.txt Bug Overview: PixieFail Bug #8 CVE-2023-45236

[edk2-devel] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-edk-ii-ipv6-network-stack.html This patch series patches the following CVEs: - CVE-2023-45236: Predictable TCP Initial Sequence Numbers - CVE-2023-45237: Use of a Weak PseudoRandom Number Generator In order to patch

[edk2-devel] [PATCH v2 07/13] SecurityPkg: RngDxe: Remove incorrect limitation on GetRng

2024-05-08 Thread Doug Flick via groups.io
Removed from gEfiRngAlgorithmRaw an incorrect assumption that Raw cannot return less than 256 bits. The DRNG Algorithms should always use a 256 bit seed as per nist standards however a caller is free to request less than 256 bits. > > // >// When a DRBG is used on the output of a entropy

[edk2-devel] [PATCH v2 06/13] ArmVirtPkg: : Add Hash2DxeCrypto to ArmVirtPkg

2024-05-08 Thread Doug Flick via groups.io
This patch adds Hash2DxeCrypto to ArmVirtPkg. The Hash2DxeCrypto is used to provide the hashing protocol services. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- ArmVirtPkg/ArmVirtQemu.dsc | 5 +

[edk2-devel] [PATCH v2 05/13] ArmVirtPkg:PlatformCI: Support virtio-rng-pci

2024-05-08 Thread Doug Flick via groups.io
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py This adds Rng services to the guest VM Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 2 ++ 1 file changed, 2 insertions(+)

[edk2-devel] [PATCH v2 04/13] OvmfPkg: : Add Hash2DxeCrypto to OvmfPkg

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds Hash2DxeCrypto to OvmfPkg. The Hash2DxeCrypto is used to provide the hashing protocol services. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- OvmfPkg/OvmfPkgIa32.dsc| 6 +- OvmfPkg/OvmfPkgIa32X64.dsc | 6

[edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-08 Thread Doug Flick via groups.io
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py This adds Rng services to the guest VM Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

2024-05-08 Thread Du Lin
Encrypted and Special Purpose resource attributes are introduced in PI 1.8 Specification. This patch is to update VMM Hob list integrity check to recognise these resource attributes. Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Signed-off-by: Du Lin ---

[edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-08 Thread Abdul Lateef Attar via groups.io
Adds an AmlAddIntegerToNamedPackage() API to generate AML code, which adds an integer value to the package node. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 41 +++- .../Common/AmlLib/CodeGen/AmlCodeGen.c

[edk2-devel] [edk2-stable202405 RESEND PATCH v2 0/1] DynamicTablesPkg: Adds integer to the AML package node

2024-05-08 Thread Abdul Lateef Attar via groups.io
Please concider this patch for stable release. PR: https://github.com/tianocore/edk2/pull/5636 This patch adds integer to the AML package node. v2 delta : Addressed comments from Pierre Gondois Cc: Pierre Gondois Cc: Sami Mujawar Cc: Liming Gao Cc: Michael D Kinney Abdul Lateef Attar (1):

[edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-08 Thread Du Lin
Add a new entry into GCD attribute conversion table to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. Cc: Liming Gao Cc: Ray Ni Signed-off-by: Du Lin --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c

Re: [edk2-devel] [PATCH 1/3] StandaloneMmPkg: Add LockBox Dependency DXE Driver

2024-05-08 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu mailto:jiaxin...@intel.com>> after resolve Ray's concern. From: Ni, Ray Sent: Wednesday, May 8, 2024 10:46 AM To: Xie, Yuanhao ; devel@edk2.groups.io Cc: Liming Gao ; Wu, Jiaxin Subject: Re: [PATCH 1/3] StandaloneMmPkg: Add LockBox Dependency DXE Driver +#include

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg: Add Standalone MM Lockbox Driver.

2024-05-08 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Xie, Yuanhao > Sent: Tuesday, May 7, 2024 2:09 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Wu, Jiaxin > ; Ni, Ray ; Xie, Yuanhao > > Subject: [PATCH 3/3] MdeModulePkg: Add Standalone MM Lockbox Driver. > > The Lockbox Driver

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Refactors SmmLockBox.c.

2024-05-08 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Xie, Yuanhao > Sent: Tuesday, May 7, 2024 2:09 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Wu, Jiaxin > ; Ni, Ray ; Xie, Yuanhao > > Subject: [PATCH 2/3] MdeModulePkg: Refactors SmmLockBox.c. > > The Lockbox Driver allows

[edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatform: Add MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
MpInfo2HobPei provides backwards compatibility between FSP binaries built with older versions of EDK II and the latest EDK II. Newer versions of CpuMpPei produce the gMpInformation2HobGuid. This HOB is required by newer implementations of the CPU DXE driver, however older versions of CpuMpPei do

[edk2-devel] [edk2-platforms] [PATCH v1 0/2] Intel/MinPlatform: Add MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
Newer versions of CpuMpPei produce the gMpInformation2HobGuid. This HOB is required by newer implementations of the CPU DXE driver, however older versions of CpuMpPei do not produce it. This can cause backwards compatibiliity issues if the FSP binary was built with an older version of EDK II and

[edk2-devel] [edk2-platforms] [PATCH v1 2/2] AlderlakeOpenBoardPkg: Include MpInfo2HobPei

2024-05-08 Thread Nate DeSimone
Because Alder Lake FSP includes an older version of CpuMpPei MpInfo2HobPei is needed to boot with newer versions of EDK II. Accordingly, this change adds MpInfo2HobPei to FvPostMemory. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni Kasbekar Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Michael Brown
On 08/05/2024 22:19, Ard Biesheuvel wrote: I've always found that logic rather bizarre - there is no way the implementation of the raw protocol can ensure that the caller uses it correctly, and so enforcing a minimum read size is pointless and arbitrary. And as you note, it has no basis in the

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Ard Biesheuvel
I've always found that logic rather bizarre - there is no way the implementation of the raw protocol can ensure that the caller uses it correctly, and so enforcing a minimum read size is pointless and arbitrary. And as you note, it has no basis in the UEFI spec either. So this should just be

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
Ard, I went ahead an added your suggestion to use gEfiRngAlgorithmRaw. This however led me to discover a difference in behavior in x86 based platforms and Arm based platforms and I'm usure which is the correct behavior. On x86 based platforms, if the RngValueLength being requested is less than

[edk2-devel] [PATCH v1 0/1] Add MockBiosIdLib to BoardModulePkg

2024-05-08 Thread VivianNK
This patch adds a mock library for MockBiosIdLib. REF: https://github.com/VivianNK/edk2-platforms/tree/vnowkakeane/MockBiosIdLib_v1 Cc: Eric Dong Cc: Liming Gao Signed-off-by: Vivian Nowka-Keane Bhavani Subramanian (1): BoardModulePkg: Added Mock library for BiosIdLib

[edk2-devel] [PATCH v1 1/1] BoardModulePkg: Added Mock library for BiosIdLib

2024-05-08 Thread VivianNK
From: Bhavani Subramanian Added a gmock for GoogleTests that pull in BiosIdLib. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Vivian Nowka-Keane --- Platform/Intel/BoardModulePkg/BoardModulePkg.dec | 1 +

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
In that case, I think that's a fair argument and a simple enough request with limited impact to make. I'll go ahead and add RAW and drop the commits disabling "Secure Algorithms" from VirtioRngDxe based implementations -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Ard Biesheuvel
On Wed, 8 May 2024 at 18:47, Doug Flick via groups.io wrote: > > I don't disagree. > > The intent is not to be limited by NIST specified standards but rather the > only UEFI Spec defined algorithms are NIST Standards. > >

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
I don't disagree. The intent is not to be limited by NIST specified standards but rather the only UEFI Spec defined algorithms are NIST Standards. https://uefi.org/specs/UEFI/2.10/37_Secure_Technologies.html#efi-rng-algorithm-definitions I'm not sure what's the best way to clarify this

Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

2024-05-08 Thread Ard Biesheuvel
Happy to merge this. Liming, please let me know if this meets the soft freeze requirements? Thanks, On Tue, 7 May 2024 at 07:18, Wu, Jiaxin wrote: > > Thanks Jiewen. > > > > > > > > From: Yao, Jiewen > Sent: Tuesday, May 7, 2024 12:59 PM > To: Wu, Jiaxin ; Ni, Ray ; > devel@edk2.groups.io;

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-08 Thread Shih, More
Hi Gaoliming, Could you help push the PR ? BR, More Shih From: Cai, Xianglei Sent: Friday, April 26, 2024 5:13 PM To: gaoliming ; devel@edk2.groups.io Cc: Ni, Ray ; Lewandowski, Krzysztof ; Huang, Jenny ; Shih, More Subject: RE: [edk2-devel] [PATCH V2 1/1]

[edk2-devel] [PATCH v3 1/2] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

2024-05-08 Thread Praveen Sankar N via groups.io
In SPCR table, 4 structure members have been added newly as per SPCR table Rev4, which has to be added in MdePkg/SerialPortConsoleRedirectionTable.h file. Signed-off-by: Praveen Sankar N praveensank...@ami.com CC: michael.d.kin...@intel.com CC: gaolim...@byosoft.com.cn CC: zhiguang@intel.com

[edk2-devel] [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

2024-05-08 Thread Praveen Sankar N via groups.io
In SPCR table, 4 structure members have been added newly as per SPCR table Revision 4, which has to be added in MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h. Signed-off-by: Praveen Sankar N praveensank...@ami.com Cc: michael.d.kin...@intel.com Cc: gaolim...@byosoft.com.cn

[edk2-devel] [PATCH v3 2/2] MdePkg: Added new SPCR table Revision 4 structure

2024-05-08 Thread Praveen Sankar N via groups.io
In SPCR table, 4 structure members have been added newly as per SPCR table Revision 4, which has to be added in MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h. Signed-off-by: Praveen Sankar N praveensank...@ami.com Cc: michael.d.kin...@intel.com Cc: gaolim...@byosoft.com.cn

[edk2-devel] [PATCH v3 0/2] MdePkg: Added new SPCR table Revision 4 structure

2024-05-08 Thread Praveen Sankar N via groups.io
praveensankarn (2): Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4. MdePkg: Added new SPCR table Revision 4 structure .../SerialPortConsoleRedirectionTable.h| 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.38.1.windows.1

Re: [edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Ard Biesheuvel
On Wed, 8 May 2024 at 17:29, Doug Flick via groups.io wrote: > > From: Doug Flick > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4542 > > Bug Overview: > PixieFail Bug #9 > CVE-2023-45237 > CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N > CWE-338 Use of Cryptographically Weak Pseudo-Random

Re: [edk2-devel] pr for stable tag

2024-05-08 Thread Ard Biesheuvel
Yes On Wed, 8 May 2024 at 17:36, gaoliming via groups.io wrote: > > Ard: > So, this patch needs to catch this stable tag. Right? > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Ard Biesheuvel > > 发送时间: 2024年5月8日 20:41 > > 收件人: Liming Gao (Byosoft address) ; Michael > >

回复: [edk2-devel] pr for stable tag

2024-05-08 Thread gaoliming via groups.io
Ard: So, this patch needs to catch this stable tag. Right? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard Biesheuvel > 发送时间: 2024年5月8日 20:41 > 收件人: Liming Gao (Byosoft address) ; Michael > Kinney ; Leif Lindholm > ; edk2-devel-groups-io > 抄送: Peter Batard > 主题:

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, May 8, 2024 #cal-cancelled

2024-05-08 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z

[edk2-devel] [PATCH v1 11/14] MdePkg: : Add MockUefiBootServicesTableLib

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This commit adds a mock library for UefiBootServicesTableLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Doug Flick [MSFT] --- MdePkg/Test/MdePkgHostTest.dsc | 1 +

[edk2-devel] [PATCH v1 06/14] ArmVirtPkg: : Add Hash2DxeCrypto to ArmVirtPkg

2024-05-08 Thread Doug Flick via groups.io
This patch adds Hash2DxeCrypto to ArmVirtPkg. The Hash2DxeCrypto is used to provide the hashing protocol services. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- ArmVirtPkg/ArmVirtQemu.dsc | 5 +

[edk2-devel] [PATCH v1 14/14] NetworkPkg: Update the PxeBcDhcp6GoogleTest due to underlying changes

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch updates the PxeBcDhcp6GoogleTest due to the changes in the underlying code. The changes are as follows: - Random now comes from the RngLib Protocol - The TCP ISN is now generated by the hash function Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by:

[edk2-devel] [PATCH v1 13/14] MdePkg: Add MockHash2 Protocol for testing

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This commit adds a new MockHash2 protocol to the MdePkg. This protocol is used to test Hash2 protocol consumers. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Doug Flick [MSFT] --- MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockHash2.h | 67

[edk2-devel] [PATCH v1 07/14] NetworkPkg:: SECURITY PATCH CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4542 Bug Overview: PixieFail Bug #9 CVE-2023-45237 CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N CWE-338 Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG) Use of a Weak PseudoRandom Number Generator Change

[edk2-devel] [PATCH v1 12/14] MdePkg: : Adds Protocol for MockRng

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds a protocol for MockRng. This protocol is used to mock the Rng protocol for testing purposes. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Doug Flick [MSFT] --- MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockRng.h | 48

[edk2-devel] [PATCH v1 09/14] OvmfPkg: Disable NIST Algorithms NetworkPkg

2024-05-08 Thread Doug Flick via groups.io
This commit disables enforcement of NIST defined RNG algorithms. Such that NetworkPkg will accept "Default" and depend on the platform. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- OvmfPkg/OvmfPkgIa32.dsc| 7 +++ OvmfPkg/OvmfPkgIa32X64.dsc

[edk2-devel] [PATCH v1 08/14] NetworkPkg: TcpDxe: SECURITY PATCH CVE-2023-45236

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4541 REF: https://www.rfc-editor.org/rfc/rfc1948.txt REF: https://www.rfc-editor.org/rfc/rfc6528.txt REF: https://www.rfc-editor.org/rfc/rfc9293.txt Bug Overview: PixieFail Bug #8 CVE-2023-45236

[edk2-devel] [PATCH v1 10/14] ArmVirtPkg: : Disables NIST algorithms NetworkPkg

2024-05-08 Thread Doug Flick via groups.io
The NetworkPkg attempts to use the NIST Algorithms as defined in the EDK2 specification. If not available (or if so desired) the platform may choose to use "Default" and use what is provided by the platform. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann

[edk2-devel] [PATCH v1 04/14] OvmfPkg: : Add Hash2DxeCrypto to OvmfPkg

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds Hash2DxeCrypto to OvmfPkg. The Hash2DxeCrypto is used to provide the hashing protocol services. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- OvmfPkg/OvmfPkgIa32.dsc| 6 +- OvmfPkg/OvmfPkgIa32X64.dsc | 6

[edk2-devel] [PATCH v1 05/14] ArmVirtPkg:PlatformCI: Support virtio-rng-pci

2024-05-08 Thread Doug Flick via groups.io
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py This adds Rng services to the guest VM Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 2 ++ 1 file changed, 2 insertions(+)

[edk2-devel] [PATCH v1 02/14] EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds Hash2DxeCrypto to EmulatorPkg. The Hash2DxeCrypto is used to provide the hashing protocol services. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Doug Flick [MSFT] --- EmulatorPkg/EmulatorPkg.dsc | 9 +++-- EmulatorPkg/EmulatorPkg.fdf | 5 + 2 files

[edk2-devel] [PATCH v1 03/14] OvmfPkg:PlatformCI: Support virtio-rng-pci

2024-05-08 Thread Doug Flick via groups.io
This patch adds "virtio-rng-pci" to the PlatformBuildLib.py This adds Rng services to the guest VM Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Signed-off-by: Doug Flick [MSFT] --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v1 00/14] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

2024-05-08 Thread Doug Flick via groups.io
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-edk-ii-ipv6-network-stack.html This patch series patches the following CVEs: - CVE-2023-45236: Predictable TCP Initial Sequence Numbers - CVE-2023-45237: Use of a Weak PseudoRandom Number Generator In order to patch

[edk2-devel] [PATCH v1 01/14] EmulatorPkg: : Add RngDxe to EmulatorPkg

2024-05-08 Thread Doug Flick via groups.io
From: Doug Flick This patch adds RngDxe to EmulatorPkg. The RngDxe is used to provide random number generation services to the UEFI firmware. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Doug Flick [MSFT] --- EmulatorPkg/EmulatorPkg.dsc | 9 +++-- EmulatorPkg/EmulatorPkg.fdf | 6 +- 2

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver in early DXE

2024-05-08 Thread Borzeszkowski, Alan
We have considered that; however, we aim to avoid maintaining our own implementation of functions that communicate with UART. Please see discussion over previous approach: https://edk2.groups.io/g/devel/topic/104469297#115731 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

[edk2-devel] pr for stable tag

2024-05-08 Thread Ard Biesheuvel
Please set the push label on https://github.com/tianocore/edk2/pull/5642 discussed here: https://openfw.io/edk2-devel/20240508085148.1725-1-p...@akeo.ie/ -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118671):

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

2024-05-08 Thread Ard Biesheuvel
On Wed, 8 May 2024 at 11:21, Pete Batard wrote: > > Hi Ard, > > Thanks for the quick review. > > Note that as opposed to the previous one you referenced, that patches > both the .S and the .asm, my submission only patches the .asm, so it's > probably better to use Adam Liu's for integration (who

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

2024-05-08 Thread Pete Batard via groups.io
Hi Ard, Thanks for the quick review. Note that as opposed to the previous one you referenced, that patches both the .S and the .asm, my submission only patches the .asm, so it's probably better to use Adam Liu's for integration (who was the first to propose a fix anyway). As to your other

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

2024-05-08 Thread Ard Biesheuvel
On Wed, 8 May 2024 at 11:07, Ard Biesheuvel wrote: > > On Wed, 8 May 2024 at 10:52, Pete Batard wrote: > > > > Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression > > resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' > > when compling MdePkg for AARCH64

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

2024-05-08 Thread Ard Biesheuvel
On Wed, 8 May 2024 at 10:52, Pete Batard wrote: > > Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression > resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' > when compling MdePkg for AARCH64 with Visual Studio. > Fix this by adding the relevant EXTERN

[edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

2024-05-08 Thread Pete Batard via groups.io
Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' when compling MdePkg for AARCH64 with Visual Studio. Fix this by adding the relevant EXTERN reference. Signed-off-by: Pete Batard Cc: Leif Lindholm Cc:

[edk2-devel] [PATCH 0/1] MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio

2024-05-08 Thread Pete Batard via groups.io
The following patch fixes a regression/breakage that currently prevents compilation of MdePkg for AARCH64 with Visual Studio 2022. This regression was introduced with the patch that was discussed in October 2020 at: https://edk2.groups.io/g/devel/topic/77247140#msg65813 and that was eventually

[edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

2024-05-08 Thread Nickle Wang via groups.io
Upgrade Werkzeug to version 3.0.3 to address CVE-2024-34069 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- Tools/Redfish-Profile-Simulator/redfishProfileSimulator.py | 7 --- Tools/Redfish-Profile-Simulator/requirements.txt | 6 ++ 2

[edk2-devel] [PATCH 1/2] AmdSev: Rework Blob Verifier

2024-05-08 Thread Tobin Feldman-Fitzthum
The Blob Verifier checks boot artifacts against a hash table injected by the hypervisor and measured by hardware. Update the Blob Verifier to enter a dead loop if the artifacts do not match. Signed-off-by: Tobin Feldman-Fitzthum --- .../BlobVerifierSevHashes.c | 39

回复:[Internet]Re: [edk2-devel] [PATCH] Added support for ACPI related data structures for RISC_V64 platform

2024-05-08 Thread dylanlhdu(杜林恒) via groups.io
Hi Sunil, We mainly want to use UEFI+ACPI mode to start RISCV64 server. However, during the development process, we found that ACPI(6.5) in the current version of UEFI does not support riscv for the time being. In order to solve this problem, We refer to the upstream RISC-V ACPI platform

[edk2-devel] [PATCH 2/2] AmdSev: Halt on failed blob allocation

2024-05-08 Thread Tobin Feldman-Fitzthum
A malicious host may be able to undermine the fw_cfg interface such that loading a blob fails. In this case rather than continuing to the next boot option, the blob verifier should halt. For non-confidential guests, the error should be non-fatal. Signed-off-by: Tobin Feldman-Fitzthum ---

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-08 Thread Leara, William via groups.io
Internal Use - Confidential On 2024-05-01 18:43, Michael D Kinney wrote: > Hello, > > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable

[edk2-devel] [PATCH 0/2] AmdSev: Harden SEV Kernel hashes verifier

2024-05-08 Thread Tobin Feldman-Fitzthum
The AmdSev package has a so-called BlobVerifier, which is meant to extend the TCB of a confidential guest (SEV or SNP) to include components provided via fw_cfg such as initrd, kernel, kernel params. This series fixes a few implementation errors in the blob verifier. One common theme is that the

[edk2-devel] [PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

2024-05-08 Thread Pakkirisamy ShanmugavelX
From: Shanmugavel Pakkirisamy REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4677 Attacker able to modify physical memory and ResumeCount. System will crash/DoS when ResumeCount reaches its MAX_UINT32. Cc: Zhiguang Liu Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Pakkirisamy