回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775)

I just add push label for it. 发件人: Hsueh, Hong-Chih (Neo) 发送时间: 2024年6月4日 23:46 收件人: gaoliming ; devel@edk2.groups.io; Chang, Abner 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; He, Jiangang 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 47

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] Platform/Sgi: Extend SMBIOS support for RD-V2 and RD-Fremont

Hi, Need review on this patches, waiting for a month to get the review on this patch set. Any review on this would be really helpful. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119470): https://edk2.groups.io/g/devel/message/119470

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, June 6, 2024 #cal-reminder

*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, June 6, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB

+ edk2 payload maintainers Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial register: Amtsgericht

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB

Please send PR also. From: Lean Sheng Tan Sent: Wednesday, June 5, 2024 10:18:27 PM To: devel@edk2.groups.io ; Witt, Sebastian ; Guo, Gua ; Rhodes, Sean ; Lu, James ; Dong, Guo Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size

Re: [edk2-devel] [PATCH v1 0/1] EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path

Here's a sample output reflecting the changes: https://github.com/tianocore/edk2-test/pull/96#issuecomment-2150234924 [https://opengraph.githubassets.com/693d739ae94bb87787ee0ac25f41c83df2babd68a6b23b54cb21b9a5e52fb6bc/tianocore/edk2-test/pull/96]

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, June 6, 2024 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, June 6, 2024 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/5] Platform/Sgi: Use PCD value for L2 cache size in PPTT table

Hi Prabin, Thank you for this patch. Please see my response inline marked [SAMI]. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 4/3/24 18:33, Prabin CA wrote: The PcdL2CacheSize PCD specifies the size of L2 cache of the CPU. Use the size specified by this PCD in the

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] Platform/Sgi: Extend SMBIOS support for RD-V2 and RD-Fremont

Hi Prabin, If you agree with my suggestions for patch 2/5, can you reply back on the list, please? I will then fix that patch locally before merging. Other than patch 2/5 the rest of the series looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 4/3/24 18:33, Prabin CA w

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] Platform/Sgi: Extend SMBIOS support for RD-V2 and RD-Fremont

Hi Sami, Thank you for reviewing the patches. Yes that is fine, you can make the changes locally and merge to upstream. *Thanks,* *Prabin CA* -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119478): https://edk2.groups.io/g/devel/messag

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

The other option, that I had started working on then got sidetracked with other things, would just be implement CpuDeadLoop in assembly, so we don't have to worry about random compiler optimizations in the future. This certainly looks like an easy change for the current issue, though. Thanks, Ol

Re: [edk2-devel] [PATCH ovmf v4 1/5] MdePkg/Register/Amd: Define all bits from MSR_SEV_STATUS_REGISTER

On 6/4/24 21:09, Alexey Kardashevskiy wrote: For now we need DebugSwap but others are likely to be needed too. Cc: Tom Lendacky Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Alexey Kardashevskiy Reviewed-by: Tom Lendacky --- Changes: v4: * added more from April/20

Re: [edk2-devel] [PATCH ovmf v4 3/5] OvmfPkg: Add AMD SEV-ES DebugVirtualization feature support

On 6/4/24 21:09, Alexey Kardashevskiy wrote: The SEV-ES DebugVirtualization feature enables type B swapping of debug registers on #VMEXIT and makes #DB and DR7 intercepts unnecessary and unwanted. When DebugVirtualization is enabled, this stops booting if #VC for #DB or DB7 read/write occurs as

Re: [edk2-devel] [PATCH ovmf v4 4/5] UefiCpuPkg: Add AMD SEV-ES features support

On 6/4/24 21:09, Alexey Kardashevskiy wrote: CONFIDENTIAL_COMPUTING_GUEST_ATTR is not a simple SEV level anymore and includes a feature mask since the previous commit. Fix AmdMemEncryptionAttrCheck to check the level and feature correctly and add DebugVirtualization support. Since the actual fe

Re: [edk2-devel] [PATCH ovmf v4 5/5] OvmfPkf: Enable AMD SEV-ES DebugVirtualization

On 6/4/24 21:09, Alexey Kardashevskiy wrote: Write the feature bit into PcdConfidentialComputingGuestAttr and enable DebugVirtualization in PEI, SEC, DXE. Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Michael Roth Cc: Min Xu Cc: Tom Lendacky Signed-off-by: Alexey

[edk2-devel] [PATCH v2 1/1]EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path

[edk2-devel] [PATCH v2 0/1]EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path

Prachotan Bathi (1): EDK2-Test: Bug 4244 - SCT improvement - Print out the PCIe device path For changes and review, please refer to: https://github.com/tianocore/edk2-test/pull/96 https://github.com/PrachotanReddy/edk2-test V1 mail: https://edk2.groups.io/g/devel/message/119438 Test

Re: [edk2-devel] GitHub PR Code Review process now active

Hello, The PR code review process has been active for a little over a week now. There have been about 17 PRs merged since the switch and it appears to have been mostly working well. I also note that the emails per day on this mailing list is much smaller as the code reviews have migrated to PRs.

Re: [edk2-devel] GitHub PR Code Review process now active

On 6/5/2024 4:21 PM, Michael D Kinney via groups.io wrote: * Some PRs have been merged using the "Rebase and Merge" button in the PR after all required reviews completed and all CI checks pass. Instead, the "push" label should continue to be used. There does not appear to be any unexpect

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB

Reviewed-by: Guo Dong mailto:guo.d...@intel.com>> From: Guo, Gua Sent: Wednesday, June 5, 2024 7:22 AM To: Tan, Lean Sheng ; devel@edk2.groups.io; Witt, Sebastian ; Rhodes, Sean ; Lu, James ; Dong, Guo Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16M

Re: [edk2-devel] GitHub PR Code Review process now active

The Merge button may not work in that case either if there is parallel activity by other developers or Mergify. Using the "push" label is recommended so Maintainers do not have to wait and rebase. I understand the desire to apply to other repos quickly. Let's work through some of these known iss

Re: [edk2-devel] GitHub PR Code Review process now active

Hi Mike, Glad to see EDK2 PR code review process is active. In Slim Bootloader project, it runs BaseTools/Scripts/PatchCheck.py to check the PR commit message when running QEMU CI test Maybe you could refer https://github.com/slimbootloader/slimbootloader/blob/48a24b87824321c053cccf367c7c3637

Re: [edk2-devel] GitHub PR Code Review process now active

Hi Guo, Thanks. Edk2 is running PatchCheck.py as part of CI. The Maintainer still needs to verify the commit message contents even if it passes PatchCheck.py. Mike > -Original Message- > From: Dong, Guo > Sent: Wednesday, June 5, 2024 6:22 PM > To: devel@edk2.groups.io; Kinney, Michae

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, June 6, 2024 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, June 6, 2024 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e34

[edk2-devel] [PATCH edk2-platforms 0/6] JadePkg and common Ampere code fixes

These are a set of bug fixes I made to the Mt Jade and common Ampere code while working on updating and improving ADLINK's edk2_aadp project. Rebecca Cran (6): Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci Si

[edk2-devel] [PATCH edk2-platforms 1/6] Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe

Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni b/Silicon/Ampere/AmpereAltraPkg/

[edk2-devel] [PATCH edk2-platforms 2/6] Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentLibPci

Reduce the spam when DEBUG_INFO is enabled by switching DEBUG prints in PciSegmentLibPci from DEBUG_INFO to DEBUG_VERBOSE. Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c | 24 ++-- 1 file changed, 12 insertions(+), 12 delet

[edk2-devel] [PATCH edk2-platforms 3/6] Silicon/Ampere: Add TimerLib to DwGpioLib.inf for MicroSecondDelay

The NOOPT build was failing because MicroSecondDelay is called but TimerLib wasn't included in DwGpioLib.inf Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/DwG

[edk2-devel] [PATCH edk2-platforms 4/6] Platform/Ampere: Don't try and close the ACPI table if OpenSdt fails

In AcpiPatchDsdtTable if the call to OpenSdt fails, don't try and close the TableHandle since it causes a crash. Signed-off-by: Rebecca Cran --- Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatf

[edk2-devel] [PATCH edk2-platforms 6/6] Silicon/Ampere: Remove bogus ASSERT that *PpiList is non-NULL

On entry into ArmPlatformGetPlatformPpiList, *PpiList _can_ be NULL since it's set within the function. So remove the bogus ASSERT. Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Silicon/Am

[edk2-devel] [PATCH edk2-platforms 5/6] Silicon/Ampere: Set default SMBIOS fw major/minor version to 0xFF

According to the SMBIOS specification, the firmware version major/minor values should be set to 0xFF if they're not applicable. Update AmpereSiliconPkg.dec to default to 0xFF instead of 0. Signed-off-by: Rebecca Cran --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 4 ++-- 1 file chan

Re: [edk2-devel] Call for TianoCore Community Meeting topics

No topics received. Meeting canceled. Mike From: Kinney, Michael D Sent: Tuesday, June 4, 2024 11:19 PM To: edk2-devel-groups-io Cc: Kinney, Michael D Subject: Call for TianoCore Community Meeting topics Hi, Are there any topics for the TianoCore community meeting this month? Thanks, Mike

[edk2-devel] Cancelled Event: TianoCore Community Meeting EMEA/NAMO - Thursday, June 6, 2024 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_Ang

[edk2-devel] Cancelled Event: TianoCore Community Meeting - APAC/NAMO - Thursday, June 6, 2024 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_Ang

[edk2-devel] pci command supports CXL device type

Hello Maybe current shell pci command doesn't support parse cxl device type. Do we have plan to update this command? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119505): https://edk2.groups.io/g/devel/message/119505 Mute Th

Re: 回复: Re: [edk2-devel] Is DEBUG output function safe for MP case?

Hi, Jeff/Andrew; Thanks for your help! Appreciates it. best wishes, At 2024-06-04 09:11:50, "Jeff Fan via groups.io" wrote: As Andrew mentioned, DEBUG() is NOT safe for MP. Generally, kernel modules are not suggested to use DEBUG() in AP code becasue they are not the de