Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

[AMD Official Use Only - AMD Internal Distribution Only] No problem. You can add the tag on subject like Silicon/Ampere or something else distinguishable next time. 😊 Thanks Abner > -Original Message- > From: Nhi Pham > Sent: Friday, August 9, 2024 11:05 AM > To: Chang, Abner ; devel@

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

[AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, Just realize this patch is not for ManageabilityPkg when I go through the patch, I will leave this to the owner. Also, I shouldn't suggest you to create PR as I am not the owner, sorry about this. Thanks Abner From: Nhi Pham OS

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

aution when opening attachments, clicking links, or responding. I'm honestly not too fussed, but maybe hold off on telling people we've switched until Rebecca's set is actually merged, so that the PR assignment is working? Regards, Leif On 2024-08-07 11:45, Chang, Abner via gr

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

[AMD Official Use Only - AMD Internal Distribution Only] So Leif, what's your preference? AMD already switched to use PR on edk2-platforms, shall we get back to the email review? Thanks Abner Get Outlook for Android From: Leif Lindholm S

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

[AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please send the PR against edk2-platforms? Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nhi Pham > via groups.io > Sent: W

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[AMD Official Use Only - AMD Internal Distribution Only] Hi Rebecca, Having GitHub CODEOWNERS to assign reviewers for the PR is fine to me, as well as only maintainers have the privilege to set "Push" label. I would suggest we use only one CODEOWNERS file on the repo so we can easily find the co

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[AMD Official Use Only - AMD Internal Distribution Only] Yes, and AMD moved to GitHub PR already. Regards, Abner > -Original Message- > From: Grimes, Paul > Sent: Tuesday, July 2, 2024 3:20 AM > To: Rebecca Cran ; devel@edk2.groups.io > Cc: Leif Lindholm ; Michael D Kinney > ; Ard Biesh

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

.io> mailto:devel@edk2.groups.io>> 代表 Chang, Abner via groups.io 发送时间: 2024年6月18日 10:50 收件人: Chesley, Brit mailto:brit.ches...@amd.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table Hi Hao, Wha

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

? Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> 代表 Chang, Abner via groups.io 发送时间: 2024年6月18日 10:50 收件人: Chesley, Brit mailto:brit.ches...@amd.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [e

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

Hi Hao, What is your comment on the response from Brit? Hoping that I didn't miss the latest conversation of this thread. Thanks Abner -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119598): https://edk2.groups.io/g/devel/message/119598

Re: [edk2-devel] GitHub PR Code Review process now active

[AMD Official Use Only - AMD Internal Distribution Only] Thanks for the clarification, Mike. Thanks Abner From: Kinney, Michael D Sent: Wednesday, May 29, 2024 10:44:41 PM To: Chang, Abner ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: GitHub PR Cod

Re: [edk2-devel] GitHub PR Code Review process now active

[AMD Official Use Only - AMD Internal Distribution Only] Hi Mike, Wondering if we also plan to apply GitHub PR process on edk2-platforms repo? Or other repos under tianocore? I found there is another email thread "Enable GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no

Re: [edk2-devel] [edk2-platforms 2/3] AmdPlatformPkg: Implements SmmCorePlatformHookLib library

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Tuesday, May 28, 2024 10:08 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grimes, Paul > Subject: [edk2-p

Re: [edk2-devel] [edk2-platforms 3/3] AmdPlatformPkg: Adds SPI smm core platform hook

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Tuesday, May 28, 2024 10:08 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grimes, Paul > Subject: [edk2-p

Re: [edk2-devel] [edk2-platforms 1/3] AmdPlatformPkg: Removes unused gBoardBdsBootFromDevicePathProtocolGuid

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Tuesday, May 28, 2024 10:08 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grimes, Paul > Subject: [edk2-p

Re: [edk2-devel] [edk2-platform 0/2] AmdPlatformPkg: Fix the build failure

[AMD Official Use Only - AMD Internal Distribution Only] This patch set was reviewed on GitHub PR. Hi Abdul, please go ahead to push this patch. Thanks! Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Tuesday, May 28, 2024 11:28 AM > To: devel@edk2.gro

[edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

From: Abner Chang Cc: Paul Grimes Cc: Abdul Lateef Attar Cc: Igniculus Fu Cc: Ken Yao Cc: Eric Xing Cc: Duke Zhai Signed-off-by: Abner Chang --- Platform/AMD/Readme.md | 64 -- 1 file changed, 49 insertions(+), 15 deletions(-) diff --git a/Platform

[edk2-devel] [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entries for AMD packages

From: Abner Chang Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 877620a1b0..af688c3813 100644 --- a/Maintainers.txt +++ b/Maintain

Re: [edk2-devel] [edk2-platforms RESEND v2 3/5] AmdMinBoardPkg: Implement BoardInitLib for PEI phase

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, May 20, 2024 9:50 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grimes, Paul > Subject: [edk2-pla

Re: [edk2-devel] [edk2-platforms] AmdPlatformPkg: Adds SmbiosCommonDxe driver

[AMD Official Use Only - AMD Internal Distribution Only] Already reviewed internally. Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, May 20, 2024 6:24 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grime

Re: [edk2-devel] [PATCH 0/5] AmdMinBoardPkg: AMD board specific modules

[AMD Official Use Only - AMD Internal Distribution Only] Already reviewed internally. Reviewed-by: Abner Chang Hi Abdul, please add the tag [edk2-platforms] in subject next time when send the patch for edk2-platforms changes. Thanks Abner > -Original Message- > From: devel@edk2.groups.

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

[AMD Official Use Only - AMD Internal Distribution Only] That is awesome! Thank you! Abner > -Original Message- > From: Nhi Pham > Sent: Thursday, May 16, 2024 4:50 PM > To: Chang, Abner ; devel@edk2.groups.io; > nick...@nvidia.com; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

;> From: Nhi Pham > >>>> Sent: Monday, May 13, 2024 5:02 PM > >>>> To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang > >>>> ; Rebecca Cran > >>>> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul > >>>> Lateef) ; Tinh N

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

iable until exist boot service. > > > > Also, give some more descriptions on the code you invoke to > GetAuthInfo. > > > > > > Thanks for your comment. I add descriptions to explain above before > > > calling GetAuthInfo(). Version 2 path is here: > > >

Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775)

ments, clicking links, or responding. > > > Abner: > This change is good to me. Reviewed-by: Liming Gao > > > But, this is not critical issue. So, I suggest to merge it after the stable > tag. > > Thanks > Liming > > -邮件原件- > > 发件人: devel@edk2

Re: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function

[AMD Official Use Only - AMD Internal Distribution Only] Thanks! Will merge later after the hard freeze. Abner > -Original Message- > From: Nickle Wang > Sent: Thursday, May 16, 2024 9:04 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Nick > Ramir

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

uthInfo(). Version 2 path is here: > https://edk2.groups.io/g/devel/message/118889 > > Regards, > Nickle > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Chang, > Abner > > via groups.io > > Sent: Tuesday, April 23, 2024 3:42 PM >

Re: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang Hi Nickle, Do you have the corresponding PR for this? I will merge it after hard freeze. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle > Wang via groups.io > Sent: Wed

Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775)

[AMD Official Use Only - AMD Internal Distribution Only] Hi Mike, Liming and Zhiguang, Could you please check this patch sent two weeks ago? The corresponding BZ ticket is 4775. We overlooked tracking this issue and missed the 202405 stable release. As this impacts the build, do you think we can

Re: [edk2-devel] [RESEND 0/7] AmdPlatformPkg: Adds board independent modules

[AMD Official Use Only - AMD Internal Distribution Only] Already reviewed off-line. For this patch set, Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Wednesday, May 15, 2024 11:50 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ;

Re: [edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, May 8, 2024 4:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simu

Re: [edk2-devel] [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

[AMD Official Use Only - General] Hi MdeModulePkg maintainers, Please review this patch as we would like to merge it before the upcoming hard freeze. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao

Re: [edk2-devel] [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

[AMD Official Use Only - General] Hi MdeModulePkg maintainers, Please review this patch as we would like to merge it before the upcoming hard freeze. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao

Re: [edk2-devel] [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

[AMD Official Use Only - General] Hi MdeModulePkg maintainers, Please review this patch as we would like to merge it before the upcoming hard freeze. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Friday, May 3, 2024 9:57 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-u

Re: [edk2-devel] [PATCH] RedfishPkg: Rename x-uefi-redfish to x-UEFI-redfish

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Friday, May 3, 2024 9:56 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg: Rename x-uefi-redfish to x-UEFI-redfi

Re: [edk2-devel] [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [PATCH v1 6/6] MdeModulePkg: A

Re: [edk2-devel] [PATCH v1 5/6] MdeModulePkg: SpiHc: SpiHc Drivers

[AMD Official Use Only - General] We had reviewed this patch internally before sending this to community. Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul >

Re: [edk2-devel] [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [PATCH v1 4/6] MdeModulePkg:Ba

Re: [edk2-devel] [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [PATCH v1 3/6] MdeModulePkg: A

Re: [edk2-devel] [PATCH v1 2/6] MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers

[AMD Official Use Only - General] We had reviewed this patch internally before sending this to community. Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul >

Re: [edk2-devel] [PATCH v1 1/6] MdePkg/SpiConfiguration: Correct the definition spelling

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul > Lateef) > Subject: [PATCH v1 1/6] MdePkg/SpiConfiguration: Correct the

Re: [edk2-devel] [PATCH 0/5] SPI Driver Stack

[AMD Official Use Only - General] Hi Brit, We have to fix the CI failure. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Tuesday, April 30, 2024 10:06 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Ray Ni ; > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) > > Subje

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

[AMD Official Use Only - General] Thanks for reviewing this, the change is merged. Abner From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, April 30, 2024 3:36 PM To: Chang, Abner ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: Remove the depen

[edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: Remove the dependency with MinPlatform

From: Abner Chang BZ# 4695 Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../ManageabilityPkg/ManageabilityPkg.dsc | 72 ++- 1 file changed, 56 insertions(+), 16 deletions(-) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Tuesday, April 23, 2024 3:09 PM > To: Igor Kulchytskyy ; Chang, Abner > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: > introduce Re

Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type

[AMD Official Use Only - General] Hi Sean, I was struggling when introduce IPMI KCS base IO PCD in Mde, although it is a industry value but seems it is fine to have it in ManageabilityPkg. How do you think if we relocate those IPMI PCDs back to ManageabilityPkg? Thanks Abner From: Sean Broga

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

[AMD Official Use Only - General] Hi Nickle, One comment and few questions, > -Original Message- > From: Nickle Wang > Sent: Thursday, April 18, 2024 8:28 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] Redfish

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[AMD Official Use Only - General] I guess my RB misled contributors thought the patch is good to merge. However, I was thinking Eric's team should give the final RB after the validation as they are the maintainers for the subordinate VanGoghBoard platform. Suppose the impacted packages should b

Re: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update maintainer for SPI modules

Original Message- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Sunday, August 13, 2023 12:37 PM > > To: devel@edk2.groups.io > > Cc: Michael D Kinney ; Andrew Fish > > ; Leif Lindholm ; Attar, > > AbdulLateef (Abdul

Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib

[AMD Official Use Only - General] Right, Abdul's RB is sufficient! Thanks Abner From: Ni, Ray Sent: Friday, April 19, 2024 11:35:17 AM To: Wu, Jiaxin ; devel@edk2.groups.io Cc: Zeng, Star ; Gerd Hoffmann ; Kumar, Rahul R ; Dong, Guo ; Rhodes, Sean ; Lu, Jame

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[AMD Official Use Only - General] Reviewed-by: Thanks > -Original Message- > From: Lendacky, Thomas > Sent: Monday, April 15, 2024 11:01 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Roth, Michael ; Min Xu > ; Leif Lindholm ; Michael D > Kinney ; Chang, Abner >

Re: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update maintainer for SPI modules

[AMD Official Use Only - General] Hi maintainers, Please help to check this update as we added an entry for Bus\Spi under MdeModulePkg. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Sunday, August 13, 2

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

ht > statement. > > Regards, > Nickle > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of Chang, > Abner > > via groups.io > > Sent: Wednesday, April 10, 2024 9:43 AM > > To: Nickle Wang ; devel@edk2.groups.io

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/Features: release resources

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, April 1, 2024 10:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/F

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

[AMD Official Use Only - General] Hi Nickle, I don't see the obvious coding error in this patch. However, I think we can remove HPE copyright from Redfish secure boot feature driver, as this is a new feature driver and HPE doesn't have contributions to these files, right? If so, then please rem

Re: [edk2-devel] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes

[AMD Official Use Only - General] Thanks Igor. This patch set is merged. Abner > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, April 4, 2024 9:34 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Nickle Wang > Subject: RE: [EXTERNAL] [PATCH V3 0/6] Config language sear

[edk2-devel] [PATCH V3 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report

From: Nickle Wang "MenuPath" is the attribute in BIOS attribute registry. To support reporting this attribute, we need to include the formset without x-uefi-redfish support in database. So driver can find menu path to target attribute in BIOS menu. Signed-off-by: Nickle Wang Cc: Abner Chang Cc

[edk2-devel] [PATCH V3 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Reviewed-by: Nickle Wang --- EmulatorPkg/EmulatorPkg.dsc | 21 + 1 file changed, 21 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 85134b07816..5fa1ed345a3 100644 ---

[edk2-devel] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

From: Abner Chang Add the condition check when delete HII string. Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" and the statement value type = EFI_IFR_TYPE_STRING. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../

[edk2-devel] [PATCH V3 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

From: Abner Chang Add RedfishPlatformConfigDxe debug capability that aligns with edk2 Redfish debug mechanism. - PcdRedfishPlatformConfigDebugProperty, add PCD to control RedfishPlatformConfigDxe subordinate of Redfish debug capabilities. - PcdRedfishPlatformConfigFeatureProperty, add PCD to

[edk2-devel] [PATCH V3 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

From: abnchang Build up the x-uefi-redfish string database for the Redfish confg language searching, instead of using HII String protocol. This can improve the time consumption lot on searching strings. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: N

[edk2-devel] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes

From: Abner Chang PR # 5517 In V3, adddressed comments from Nickle and Igor. In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path implementation based on the performance improvement. In this patch set, 1 We enhance the config language searching algorithm. As the performance o

[edk2-devel] [PATCH V3 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

From: Abner Chang Introduce DEBUG_REDFISH macro for the debug message of edk2 Redfish components. DEBUG_REDFISH can be used in any edk2 Redfish component with Redfish DebugCatagory as the first parameter. Whether the debug message is output or not depends on the platform setting of PcdRedfishDebu

[edk2-devel] [PATCH V5 6/6] Maintainers: AMD as SPI driver stack maintainer

From: Abner Chang Signed-off-by: Abner Chang Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- Maintainers.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 799f27f914c..7d9cdca611f 100644 --- a/Maintainers.txt +++ b/Maintai

[edk2-devel] [PATCH V5 5/6] MdeModulePkg: Add SPI NOR FLash SFDP drivers to DSC

From: abnchang BZ#: 4471 SPI NOR Flash JEDEC Serial Flash Discoverable Driver implementation. Signed-off-by: Abner Chang Cc: Jian J Wang Cc: Liming Gao Cc: Abdul Lateef Attar Cc: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[edk2-devel] [PATCH V5 3/6] MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver

From: Abner Chang BZ#: 4473 Signed-off-by: Abner Chang Cc: Liming Gao Cc: Jian J Wang Cc: Abdul Lateef Attar --- MdeModulePkg/MdeModulePkg.dec | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeMod

[edk2-devel] [PATCH V5 2/6] MdePkg/Include: Add SPI NOR Flash JEDEC SFDP header file

From: abnchang BZ#: 4472 Add definition of JEDEC Serial Flash Discoverable Parameters (SFDP) specification. https://www.jedec.org/standards-documents/docs/jesd216b Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar Cc: Brit Chesley --- .

[edk2-devel] [PATCH V5 1/6] MdePkg/Include: Update definitions of SPI related header files

From: abnchang BZ#: 4471 Update definitions according to PI spec 1.8 errata A Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar Cc: Brit Chesley --- MdePkg/Include/Protocol/SpiConfiguration.h | 10 +- MdePkg/Include/Protocol/Spi

[edk2-devel] [PATCH V5 0/6] SPI NOR Flash Driver for SFDP flash device

From: Abner Chang Sending V4 for review as SPI related ECR is approved by PIWG in PI spec 1.8A In V5: Correct patch 6/6, as some source files are fixed in this patch. In RESEND V4: Add Cc in patch 6/6 In V4: Enhance timeout algorithm In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to MdeM

[edk2-devel] [PATCH RESEND V4 5/6] MdeModulePkg: Add SPI NOR FLash SFDP drivers to DSC

From: abnchang BZ#: 4471 SPI NOR Flash JEDEC Serial Flash Discoverable Driver implementation. Signed-off-by: Abner Chang Cc: Jian J Wang Cc: Liming Gao Cc: Abdul Lateef Attar Cc: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[edk2-devel] [PATCH RESEND V4 6/6] Maintainers: AMD as SPI driver stack maintainer

From: Abner Chang Signed-off-by: Abner Chang Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- .../Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c | 12 ++-- .../Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c | 12 ++-- Maintainers.txt

[edk2-devel] [PATCH RESEND V4 3/6] MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver

From: Abner Chang BZ#: 4473 Signed-off-by: Abner Chang Cc: Liming Gao Cc: Jian J Wang Cc: Abdul Lateef Attar --- MdeModulePkg/MdeModulePkg.dec | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeMod

[edk2-devel] [PATCH RESEND V4 2/6] MdePkg/Include: Add SPI NOR Flash JEDEC SFDP header file

From: abnchang BZ#: 4472 Add definition of JEDEC Serial Flash Discoverable Parameters (SFDP) specification. https://www.jedec.org/standards-documents/docs/jesd216b Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar Cc: Brit Chesley --- .

[edk2-devel] [PATCH RESEND V4 0/6] SPI NOR Flash Driver for SFDP flash device

From: Abner Chang Sending V4 for review as SPI related ECR is approved by PIWG in PI spec 1.8A In RESEND V4: Add Cc in patch 6/6 In V4: Enhance timeout algorithm In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to MdeModulePkg.dec. In V2: Add maintainer entry for Bus/Spi. This patch fixes

[edk2-devel] [PATCH RESEND V4 1/6] MdePkg/Include: Update definitions of SPI related header files

From: abnchang BZ#: 4471 Update definitions according to PI spec 1.8 errata A Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar Cc: Brit Chesley --- MdePkg/Include/Protocol/SpiConfiguration.h | 10 +- MdePkg/Include/Protocol/Spi

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

[AMD Official Use Only - General] Hi Nickle, I will rename it and send out the V3 together with Igor's comments addressed. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Wednesday, March 27, 2024 10:40 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

[AMD Official Use Only - General] Hi Igor, my responses to your three comments in line. > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, April 4, 2024 8:44 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Nickle Wang > Subject: RE: [EXTERNAL] [PATCH V2 1/6] > RedfishPkg

[edk2-devel] [PATCH V4 6/6] Maintainers: AMD as SPI driver stack maintainer

From: Abner Chang Signed-off-by: Abner Chang M: Andrew Fish M: Leif Lindholm M: Michael D Kinney --- Maintainers.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 799f27f914c..7d9cdca611f 100644 --- a/Maintainers.txt +++ b/Maintainer

[edk2-devel] [PATCH V4 5/6] MdeModulePkg: Add SPI NOR FLash SFDP drivers to DSC

From: abnchang BZ#: 4471 SPI NOR Flash JEDEC Serial Flash Discoverable Driver implementation. Signed-off-by: Abner Chang Cc: Jian J Wang Cc: Liming Gao Cc: Abdul Lateef Attar Cc: Brit Chesley --- MdeModulePkg/MdeModulePkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[edk2-devel] [PATCH V4 2/6] MdePkg/Include: Add SPI NOR Flash JEDEC SFDP header file

From: abnchang BZ#: 4472 Add definition of JEDEC Serial Flash Discoverable Parameters (SFDP) specification. https://www.jedec.org/standards-documents/docs/jesd216b Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar Cc: Brit Chesley --- .

[edk2-devel] [PATCH V4 3/6] MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver

From: Abner Chang BZ#: 4473 Signed-off-by: Abner Chang Cc: Liming Gao Cc: Jian J Wang Cc: Abdul Lateef Attar --- MdeModulePkg/MdeModulePkg.dec | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeMod

[edk2-devel] [PATCH V4 1/6] MdePkg/Include: Update definitions of SPI related header files

From: abnchang BZ#: 4471 Update definitions according to PI spec 1.8 errata A Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abdul Lateef Attar Cc: Brit Chesley --- MdePkg/Include/Protocol/SpiConfiguration.h | 10 +- MdePkg/Include/Protocol/Spi

[edk2-devel] [PATCH V4 0/6] SPI NOR Flash Driver for SFDP flash device

From: Abner Chang Sending V4 for review as SPI related ECR is approved by PIWG in PI spec 1.8A IN V4: Enhance timeout algorithm In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to MdeModulePkg.dec. In V2: Add maintainer entry for Bus/Spi. This patch fixes the missing SPI defintions per to

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

[AMD Official Use Only - General] Hi Nickle, Use Uri makes sense to me. Thanks! Please go ahead to merge it. Reviewed-by: Abner Chang . > -Original Message- > From: Nickle Wang > Sent: Monday, April 1, 2024 10:38 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Su

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

io On Behalf Of Chang, > Abner via groups.io > Sent: Thursday, March 28, 2024 2:54 PM > To: Nickle Wang ; devel@edk2.groups.io; Mike > Maslenkin > Cc: Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] > RedfishClientPkg: Set SettingsObject

Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type

[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Saturday, March 30, 2024 1:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > Subj

Re: [edk2-devel] [PATCH v1] MdePkg: Adds a PCD to define IPMI interface type

[AMD Official Use Only - General] Please update AMD copyright to 2024. Thanks Abner > -Original Message- > From: Abdul Lateef Attar > Sent: Friday, March 29, 2024 11:17 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Michael D Kinney > ; Liming Ga

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

[AMD Official Use Only - General] Hi @Mike Maslenkin, would you like to review this patch again as I addressed your comments in V5 patch set. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, March 26, 2024 8:14 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igo

Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

[AMD Official Use Only - General] Hi Igor, If time is allowed, please also review this patch set. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Wednesday, March 27, 2024 3:42 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [PATCH V2 0/6

[edk2-devel] [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang --- EmulatorPkg/EmulatorPkg.dsc | 21 + 1 file changed, 21 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 85134b07816..5fa1ed345a3 100644 --- a/EmulatorPkg/EmulatorPkg.

[edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report

From: Nickle Wang "MenuPath" is the attribute in BIOS attribute registry. To support reporting this attribute, we need to include the formset without x-uefi-redfish support in database. So driver can find menu path to target attribute in BIOS menu. Signed-off-by: Nickle Wang Cc: Abner Chang Cc

[edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

From: Abner Chang Add the condition check when delete HII string. Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" and the statement value type = EFI_IFR_TYPE_STRING. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishPlatformConfigDxe/R

[edk2-devel] [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

From: Abner Chang Add RedfishPlatformConfigDxe debug capability that aligns with edk2 Redfish debug mechanism. - PcdRedfishPlatformConfigDebugProperty, add PCD to control RedfishPlatformConfigDxe subordinate of Redfish debug capabilities. - PcdRedfishPlatformConfigFeatureProperty, add PCD to

[edk2-devel] [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

From: Abner Chang Introduce DEBUG_REDFISH macro for the debug message of edk2 Redfish components. DEBUG_REDFISH can be used in any edk2 Redfish component with Redfish DebugCatagory as the first parameter. Whether the debug message is output or not depends on the platform setting of PcdRedfishDebu

[edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

From: abnchang Build up the x-uefi-redfish string database for the Redfish confg language searching, instead of using HII String protocol. This can improve the time consumption lot on searching strings. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- .../Redfi

[edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

From: Abner Chang PR # 5491 In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path implementation based on the performance improvement. In this patch set, 1 We enhance the config language searching algorithm. As the performance of searching config language using HII GetString i

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

[AMD Official Use Only - General] For this patch set, Reviewed-by: Abner Chang Hi Nickle, please also take a look at this change. Thanks Abner > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulc

Re: [edk2-devel] [edk2-redfish-client][PATCH V3 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

as the config language > > > > > > Caution: This message originated from an External Source. Use proper > caution > > > when opening attachments, clicking links, or responding. > > > > > > > > > Hi Abner, > > > > > > > On 22. 3. 2024.,

[edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

From: Abner Chang Use SetRedfishSettingsObjectsUri to set the config language for SettingsObject URI. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 + RedfishClientPkg/Features/BootOption/v

  1   2   3   4   5   6   7   8   9   10   >