Hi Marcin.
A few high-level thoughs below.
On 2024-05-31 08:14, Marcin Juszkiewicz wrote:
EDK2/ArmPkg/Library/ArmSmcLib has code to do SMC calls.
There are ArmCallSmc[0-3]() functions for up to 3 arguments/results and
ArmCallSmc() function which can use 7 arguments and get 4 results back.
On 2024-05-30 12:58, Rebecca Cran wrote:
On 5/30/2024 4:06 AM, Leif Lindholm via groups.io wrote:
While reviewing https://github.com/tianocore/edk2/pull/5702, I found
myself wondering "shouldn't this (doesn't apply to UEFI-based systems)
be the case for the size field also?".
But
Hi Rebecca,
While reviewing https://github.com/tianocore/edk2/pull/5702, I found
myself wondering "shouldn't this (doesn't apply to UEFI-based systems)
be the case for the size field also?".
But the SMBIOS spec is quite clear that the size field refers to the
size of the physical device the
On 2024-05-29 14:29, Marcin Juszkiewicz wrote:
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
---
Platform/Qemu/Sbsa/Readme.md | 49 ---
Platform/Qemu/Sbsa/bl1.bin | Bin 23349
Can you update the hashes in Readme.md as well?
/
Leif
On 2024-05-29 14:18, Marcin Juszkiewicz wrote:
Update TF-A binaries to the same version as QEMU CI uses.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/Sbsa/bl1.bin | Bin 23349 -> 2 bytes
Platform/Qemu/Sbsa/fip.bin | Bin
behavior.
6.Signed .efi files for secuity boot needing.
Cc: Ard Biesheuvel
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Ryan Chen
Cc: BMC-SW
Signed-off-by: Tommy Huang
---
.../AArch64/ASpeedAst2500Gop.efi | Bin 45056 -> 5 bytes
.../AArc
On 2024-05-02 04:08, Michael Kubacki wrote:
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for feedback that we could help
implement. Many could likely be done in time for the transition.
1.
On 2024-05-02 07:33, Marcin Juszkiewicz wrote:
W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately
On 2024-05-02 02:28, Rebecca Cran wrote:
On Wed, May 1, 2024, at 11:43 AM, Michael D Kinney wrote:
* The Pull Request submitter is required to invite the required
maintainers and reviewers to the pull request. This is the same
set of maintainers and reviewers that are required to be
On 2024-05-01 18:43, Michael D Kinney wrote:
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after the next stable
tag which is currently scheduled for
es DSDT nodes so iasl does not complain.
>
> Marcin Juszkiewicz (2):
> SbsaQemu: do not set Timer interrupts
> SbsaQemu: remove some methods from DSDT
For series:
Reviewed-by: Leif Lindholm
Thanks!
/
Leif
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 10 --
> Si
Signed-off-by: Leif Lindholm
---
p.s. Mike, could you add write access for Marcin in this repo as well?
It was a pure oversight not to ask this at the same time as for
edk2-platforms.
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b
by
> QEMU).
>
> Enable FEAT_ECV for QEMU v9.0+ to get access to CNTPOFF register.
>
> Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
Thanks!
Can you push the change yourself?
/
Leif
> ---
> Platform/Qemu/Sbsa/Readme.md | 55 ++-
nd content safety
> > before clicking links or opening attachments
> >
> > --
> > wt., 2 kwi 2024 o 17:59 Michael D Kinney
> > napisał(a):
> > >
> > > Reviewed-by: Michael D Kinney
Marcin and Narinder are the people most familiar with the Marvell
platforms, so make them the maintainers.
I move myself down to Reviewer for now.
Cc: Marcin Wojtas
Cc: Narinder Dhillon
Cc: Michael D Kinney
Signed-off-by: Leif Lindholm
---
Maintainers.txt | 5 +++--
1 file changed, 3
On Thu, Mar 28, 2024 at 06:19:35 +, Xiong Yining wrote:
> Add support to create SRAT(System resource affinity table) for
> sbsa platform at runtime.
>
> Signed-off-by: Xiong Yining
> Reviewed-by: Marcin Juszkiewicz
> Reviewed-by: Leif Lindholm
You are not suppos
lude
> +
> +EFI_STATUS
> +EFIAPI
> +InitializeHighMemDxe (
> + IN EFI_HANDLEImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> + EFI_CPU_ARCH_PROTOCOL*Cpu;
> + EFI_STATUS Status;
> +
On Thu, Mar 28, 2024 at 07:46:28 +, Xiong Yining wrote:
> From: Marcin Juszkiewicz
>
> We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to
> parse DeviceTree anymore.
>
> Signed-off-by: Marcin Juszkiewicz
> Signed-off-by: Xiong Yining
> Re
I think the patch ordering relative to 3/4 breaks bisect?
/
Leif
On Wed, Mar 27, 2024 at 14:03:05 +, Xiong Yining wrote:
> Provide functions to check for memory information:
>
> - amount of memory nodes
> - memory address
> - NUMA node id for memory
>
> Values are read from TF-A using
On Wed, Mar 27, 2024 at 14:03:02 +, Xiong Yining wrote:
> From: Marcin Juszkiewicz
>
> This library provides functions to check for hardware information.
> For now it covers CPU ones:
>
> - amount of cpu cores
> - MPIDR value for cpu core
> - NUMA node id for cpu core
>
> Values are read
On Wed, Mar 27, 2024 at 13:59:34 +, Xiong Yining wrote:
> Add support to create SRAT(System resource affinity table) for
> sbsa platform at runtime.
>
> Signed-off-by: Xiong Yining
> Signed-off-by: Chen Baozi
No one can sign off patches on behalf of someone else. Please only
include your
On Tue, Mar 26, 2024 at 13:10:58 +0100, Marcin Juszkiewicz wrote:
> With all changes going around sbsa-ref/QemuSbsa platform Leif suggested
> that I should become maintainer as well.
>
> My GitHub account name is "hrw".
>
> Signed-off-by: Marcin Juszkiewicz
Reviewe
> Maintainers.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index e57c32f16a05..a37fc9e60723 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -383,8 +383,8 @@ F: Platform/Qemu/SbsaQemu/
>
On Fri, Mar 22, 2024 at 17:08:50 +0100, Marcin Juszkiewicz wrote:
> From: Xiong Yining
>
> Provide functions to check for memory information:
>
> - amount of memory nodes
> - memory address
> - NUMA node id for memory
>
> Values are read from TF-A using platform specific SMC calls.
Same
On Fri, Mar 22, 2024 at 17:08:49 +0100, Marcin Juszkiewicz wrote:
> There is no need for EDK2 to know that there is DeviceTree around.
> All hardware information is read using functions from
> SbsaQemuHardwareInfoLib library.
>
> Signed-off-by: Marcin Juszkiewicz
Reviewed-by
s patch does not retract from:
Reviewed-by: Leif Lindholm
> ---
> Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 6 ++
> .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 5 ++---
> .../SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.inf | 4 ++--
> Platfo
On Fri, Mar 22, 2024 at 17:08:47 +0100, Marcin Juszkiewicz wrote:
> This library provides functions to check for hardware information.
> For now it covers CPU ones:
>
> - amount of cpu cores
> - MPIDR value for cpu core
> - NUMA node id for cpu core
>
> Values are read from TF-A using platform
On 2024-03-12 09:58, Ard Biesheuvel wrote:
On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote:
On 2024-03-12 09:50, Ard Biesheuvel wrote:
On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote:
On 2024-03-12 08:17, Ard Biesheuvel wrote:
From: Ard Biesheuvel
NonCoherentIoMmuSetAttribute
On 2024-03-12 09:50, Ard Biesheuvel wrote:
On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote:
On 2024-03-12 08:17, Ard Biesheuvel wrote:
From: Ard Biesheuvel
NonCoherentIoMmuSetAttribute() does nothing except return
EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI
to a new directory and include paths must be updated.
I like this!
Traveling this week, so unable to test until Wednesday next week at the
earliest, which I would like to do for something this core before giving
a Reviewed-by. So for now, for the series:
Acked-by: Leif Lindholm
[1] https://edk2
On 2024-03-12 08:17, Ard Biesheuvel wrote:
From: Ard Biesheuvel
NonCoherentIoMmuSetAttribute() does nothing except return
EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI
bus driver will fail a PCI I/O Map() operation if the SetAttributes
fails.
So return EFI_SUCCESS
create multiple DSCs or
add/remove DSC freely.
Having "dependency" in DSC does not matter.
Having dependency in INF is something we should care about.
Thank you
Yao, Jiewen
-----Original Message-
From: Leif Lindholm
Sent: Tuesday, February 13, 2024 1:38 AM
To: Pierre Gondois ; dev
> I will send out the
PR with your rb tag.
On Thu, Feb 15, 2024 at 3:26 PM Leif Lindholm <mailto:quic_llind...@quicinc.com>> wrote:
Hi Liming,
On 2024-02-15 01:41, gaoliming via groups.io <http://groups.io> wrote:
> Hi, all
> This patch was reviewed be
with too old TF-A).
>
> Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
> ---
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 -
> .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 4 +-
> .../SbsaQemu/Library/Fdt
On Tue, Jan 16, 2024 at 08:48:34 +0100, Marcin Juszkiewicz wrote:
> During platform initialization we read amount of cpu cores and set
> PcdCoreCount so there is no need to call FdtHandler.
>
> Signed-off-by: Marcin Juszkiewicz
> ---
> Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf
On Tue, Jan 16, 2024 at 08:48:32 +0100, Marcin Juszkiewicz wrote:
> This library provides functions to check for hardware information.
> For now it covers CPU ones:
>
> - amount of cpu cores
> - MPIDR value for cpu core
> - NUMA node id for cpu core
>
> Values are read from TF-A using platform
d hold source code
> of the components.
>```
>$INSTALL_PATH/qemu-system-aarch64 -m 1024 -M sbsa-ref -pflash
> SBSA_FLASH0.fd -pflash SBSA_FLASH1.fd -serial stdio
>```
> - You can add XHCI controller with keyboard and mouse by:
> + You can keyboard and mouse by:
missing "add&q
Hi Ashish,
On 2024-01-19 18:09, Ashish Singhal via groups.io wrote:
Adding tianocore stewards to see if we can get some traction on this.
You've not cc:d Zhichao - who maintains that component - on this patch,
I've added them.
Please use BaseTools/Scripts/GetMaintainer.py to see who to cc
On 2024-01-15 15:11, Marcin Juszkiewicz wrote:
As part of removing DeviceTree use we moved cpu related parts to TF-A.
On EDK2 side we get values via SMC calls during platform initialization.
Could you split this into three patches?:
- Adding new Library (Library name should have a Lib suffix.)
y objects, I will assume that the change is acceptable and
> merge it by the end of the week.
I'm OK with this.
The last comment from Liming in
https://bugzilla.tianocore.org/show_bug.cgi?id=2831
was that the fix could be merged after "the next UEFI is published",
which it was - in August 2022.
set, and the fallback that
> just prints the image address and the address of the entrypoint.
>
> Cc: Mike Beaton
> Signed-off-by: Ard Biesheuvel
But as far as I'm concerned, cygwin support feels extremely dated
these days and not worth the maintainance overhead to keep aroun
et to 1 if the write policy attribute described is valid. A value
> > of 0 indicates that, where possible, processor architecture specific
> > discovery mechanisms should be used to ascertain the value of this
> > attribute.
>
> Signed-off-by: Marcin Juszkiewicz
Reviewed
On 2023-11-22 13:21, Marcin Juszkiewicz wrote:
W dniu 22.11.2023 o 13:26, Leif Lindholm pisze:
On 2023-11-22 11:11, Sami Mujawar wrote:
[SAMI] The proposal above looks good to me. This may be slightly off
topic, but can we also enable edk2-platform upstream CI as well,
please? This would
On 2023-11-22 11:11, Sami Mujawar wrote:
Hi Leif,
Please see my response inline marked [SAMI].
On the whole, tagging edk2-platforms at the same time as we tag the main
repo is unlikely to be beneficial. We'll need to introduce a freeze of
the platforms tree once the main repo stable tag is
mation and feed it to
> the DynamicTablesPkg.
>
> Signed-off-by: Pierre Gondois
Acked-by: Leif Lindholm
/
Leif
> ---
> DynamicTablesPkg/DynamicTables.dsc.inc| 1 +
> DynamicTablesPkg/DynamicTablesPkg.dec | 3 +
> DynamicTablesPkg/DynamicTablesPk
On Tue, Nov 21, 2023 at 17:51:33 +0100, PierreGondois wrote:
> Fix a typo.
>
> Change-Id: I84807f18855ff4c0a2f34a3556edc4698eea2170
You've accidentally included your internal Change-Id in the commit
messages for all patches in this set.
/
Leif
> Signed-off-by: Pierre Gondois
> ---
>
On Tue, Nov 21, 2023 at 17:49:57 +0100, Pierre Gondois wrote:
> Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different
> versions of the protocol. The macro is neither used in edk2 nor
> in edk2-platforms.
>
> Signed-off-by: Pierre Gondois
Reviewed-by: Leif Lindholm
>
the ArmLib interface definition to MdePkg,
as discussed in
https://edk2.groups.io/g/devel/topic/patch_v5_2_6/102725178
Cc: Pierre Gondois
Cc: Jiewen Yao
Cc: Ard Biesheuvel
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Sami Mujawar
Cc: Zhiguang Liu
Signed-off-by: Leif Lindholm
---
This should have
such a fundamental file. (These would likely be bugs, but
nevertheless...)
Thanks!
/
Leif
> Thank you
> Yao, Jiewen
>
> > -Original Message-
> > From: Leif Lindholm
> > Sent: Tuesday, November 21, 2023 10:26 PM
> > To: Yao, Jiewen
> > Cc: Pierre Gon
k if those are really ARM
> standard, and also have MdePkg owner check if it is acceptable.
>
> Thank you
> Yao, Jiewen
>
>
>
>
> > -Original Message-
> > From: Pierre Gondois
> > Sent: Tuesday, November 21, 2023 8:59 PM
> > To: Yao
> series to be merged, and finally makes a new BZ and remove the ARM version?
>
>
> Thanks,
> Chao
> On 2023/11/17 21:13, Leif Lindholm wrote:
> > On Fri, Nov 17, 2023 at 18:01:39 +0800, Chao Li wrote:
> > > ArmPciCpuIo2Dxe has been merged into CpuIo2Dxe, and CpuIo2Dx
, but it is assumed to be present.
> + Arm ARM for Armv8, sA1.5 Advanced SIMD and floating-point support
> + */
> + OPENSSL_armcap_P |= ARMV7_NEON;
> +
> + if (ArmHasAes ())
> + {
And I think that curly bracket is supposed to be on the previous lin
Copyright (c) 2020 - 2021, NUVIA Inc. All rights reserved.
>
>SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -805,6 +805,232 @@ ArmHasEte (
>VOID
>);
>
> +/** Read AA64Isar0 register.
> +
> + @return AA64Isar0's register value.
> +**/
> +UINTN
> +EFIAPI
>
r even
better write a patch yourself, so we don't end up with sudden
mass-breakage.
It might be worth splitting this patch out of the rest of the set in
order to permit a more graceful switchover.
/
Leif
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
>
> Cc: Leif Lind
gt;
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Laszlo Ersek
> Cc: Sunil V L
> Signed-off-by: Chao Li
> ---
> .../Library/PeiServicesTableP
For the series:
Reviewed-by: Leif Lindholm
On Thu, Nov 16, 2023 at 22:50:55 +0100, Laszlo Ersek wrote:
> I'm offering to restore a subset of my earlier ArmVirtPkg and OvmfPkg
> maintainer responsibilities.
>
> I'm both offering and requesting an escalation of my earlier UefiC
Apologies, I managed to misfile this.
Reviewed-by: Leif Lindholm
Typo in subject line fixed, pushed as ec5de71d83f3.
Thanks!
/
Leif
On Thu, Nov 02, 2023 at 09:15:51 +0530, ndhil...@marvell.com wrote:
> From: Narinder Dhillon
>
> Current Silicon/Marvell package structure does
RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 --
> .../RedfishDiscoverInternal.h | 4 +
> 2 files changed, 158 insertions(+), 71 deletions(-)
Happy with this. Many thanks for the rework.
For the series:
Acked-by: Leif Lindholm
> --
> 2.37.1.windows.
Ah, I fell off cc.
Having a look now.
/
Leif
On 2023-11-16 12:23, Igor Kulchytskyy wrote:
Hi Leif,
Already sent it yesterday.
Thank you,
Igor
-Original Message-
From: Leif Lindholm
Sent: Thursday, November 16, 2023 7:15 AM
To: devel@edk2.groups.io; mike.maslen...@gmail.com; Igor
On 2023-11-15 18:27, Mike Maslenkin wrote:
On Wed, Nov 15, 2023 at 4:52 PM Igor Kulchytskyy wrote:
Hello Leif and Mike,
Let me try to explain the idea of the filtering IP.
That filtering should work only if we know exactly that IP is IPv4 or IPv6 in
SMBIOS Type 42.
Hm. I've already composed
On 2023-11-16 08:15, Pedro Falcato wrote:
Leif,
Can you clarify the meaning of PcdPrePiCpuIoSize?
Not out of memory, so let's go exploring.
> I was thinking it's
> supposed to be the size of the port-mapped IO for the
> architecture/platform (as hinted by in X64 = IA32 = 16, and ARM=0),
>
On 2023-11-06 03:29, Chao Li wrote:
Added LoongArch64 architecture CPU IO width.
https://bugzilla.tianocore.org/show_bug.cgi?id=4584
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Abner Chang
Cc: Daniel Schaefer
Signed-off-by: Chao Li
Reviewed-by: Leif Lindholm
I note that as a result
Hi Pierre,
I apologise for asking this level of rework on a v3, but I would much
prefer if we could add these definitions in
ArmPkg/Include/Chipset/AArch64.h, add helper functions in AArch64Lib*
and declare those in ArmLib.h - and then use those instead of doing
the direct ID register accesses in
On Wed, Nov 15, 2023 at 16:24:46 +, Ashish Singhal via groups.io wrote:
> On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote:
> > Just like CPU _UID, ETE UID also needs to be unique so
> > use AcpiProcessorUid instead of CpuName
> >
> > Signed-off-by: Ashish Singhal
> > ---
> >
On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote:
> Just like CPU _UID, ETE UID also needs to be unique so
> use AcpiProcessorUid instead of CpuName
>
> Signed-off-by: Ashish Singhal
> ---
> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 -
> 1 file changed, 4
On Mon, May 15, 2023 at 16:33:52 +0200, Marcin Juszkiewicz wrote:
> At Linaro I work on sbsa-ref, know direction it goes.
>
> May not get code details each time.
>
> Signed-off-by: Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
Pushed as 4b07df2e6f38.
> ---
> Maintainer
On Wed, Nov 15, 2023 at 13:48:10 +0100, Marcin Juszkiewicz wrote:
> Signed-off-by: Marcin Juszkiewicz
Oops.
Reviewed-by: Leif Lindholm
Pushed as eac04509004e.
Thanks!
> ---
> Maintainers.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
PI specification *does* make it crystal clear that "On
Arm-based systems, all cache properties must be provided in the
table.". So indicating that one of the entries is invalid is
... invalid.
So apparently all Arm instruction caches are Write-back. Lol.
> Signed-off-by: Marcin Juszkiewicz
On 2023-11-14 23:52, Mike Maslenkin wrote:
On Tue, Nov 14, 2023 at 9:57 PM Igor Kulchytskyy via groups.io
wrote:
Hi Leif,
Please see my comments below.
Thank you,
Igor
-Original Message-
From: Leif Lindholm
Sent: Tuesday, November 14, 2023 12:26 PM
To: devel@edk2.groups.io; Igor
, 2023 9:20 AM
To: Mike Maslenkin ; devel@edk2.groups.io;
ig...@ami.com
Cc: Leif Lindholm ; Nickle Wang
Subject: RE: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe:
Optimize the Redfish Discover flow
Hi Mike and Leif,
Thanks for your comments on this change. As we are rushing to get
you please resend the V6 after stable tag is released if Mike and Leif's
comment is reasonable to you?
Thanks
Abner
-Original Message-
From: Mike Maslenkin
Sent: Wednesday, November 15, 2023 7:53 AM
To: devel@edk2.groups.io; ig...@ami.com
Cc: Leif Lindholm ; Chang, Abner
; Nickle Wang
On 2023-11-14 14:28, Igor Kulchytskyy via groups.io wrote:
Filter out the network interfaces which are not supported by
Redfish Host Interface.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Igor Kulchytskyy
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 163
of
a single merged list. This also allows this module to be used
by other scripts that need to distinguish between maintainers,
reviewers, and lists.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py
.
Use set() logic instead of OrderedDict to accumulate the
list of unique addresses that are sorted alphabetically.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py | 10 ++
1 file changed
To clean up interfaces, change the lookup functions to return dictionaries
rather than multiple values.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Michael D Kinney
Signed-off-by: Leif Lindholm
---
BaseTools/Scripts/GetMaintainer.py | 19 ++-
1 file
get_section_maintainers().
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts/GetMaintainer.py | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/BaseTools/Scripts/GetMaintainer.py
b
From: Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593
Fix logic bug where maintainers is incorrectly added to lists.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
BaseTools/Scripts
, so I'm happy to give
Reviewed-by: Leif Lindholm
for those. 3/5 is new and requires review by someone else.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593
Fix logic bug where maintainers was incorrectly added to lists.
If a package only has reviewers and no maintainers, then also
-Original Message-
From: devel@edk2.groups.io On Behalf Of Leif
Lindholm
Sent: Friday, November 10, 2023 4:44 AM
To: Kinney, Michael D
Cc: devel@edk2.groups.io; Rebecca Cran ; Gao,
Liming ; Feng, Bob C ;
Chen, Christine
Subject: Re: [edk2-devel] [edk2-stable202311][Patch 1/1]
BaseTools
On 2023-11-10 09:11, Pierre Gondois wrote:
Hello Leif,
On 11/2/23 11:20, Pierre Gondois wrote:
Hello Leif,
Thanks for the review,
On 10/26/23 12:05, Leif Lindholm wrote:
On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Rename
s
> the comment in another patch afterward.
>
> Hi Igor,
> Could you please check my comment and help to send another patch after
> edk2-stable202312?
>
> Thanks
> Abner
>
>
> > -Original Message-
> > From: Leif Lindholm
> > Sent: Thurs
an
> Cc: Liming Gao
> Cc: Bob Feng
> Cc: Yuwei Chen
> Cc: Leif Lindholm
> Signed-off-by: Michael D Kinney
> ---
> BaseTools/Scripts/GetMaintainer.py | 42 ++
> 1 file changed, 26 insertions(+), 16 deletions(-)
>
> diff --git a/BaseTools/
On 2023-11-07 12:06, Igor Kulchytskyy via groups.io wrote:
Supported function of the driver changed to wait for all newtwork
Typo:
newtwork ->
network
interface to be installed.
Filer out the network interfaces which are not supported by
Filer ->
Filter
Redfish Host Interface.
These
(You have my old now-dysfunctional @nuviainc.com email address on cc,
please delete that one if you can.)
I think it's fine to merge this bugfix, but I have a couple of review
comments I will make on the v3 code itself, replying to that submission.
(I am however not the maintainer of
Thanks!
https://github.com/tianocore/edk2/pull/5023 raised.
/
Leif
On Thu, Nov 09, 2023 at 21:42:38 +0800, gaoliming via groups.io wrote:
> Leif:
> Sure. This patch can be merged for this stable tag.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.
On Thu, Nov 09, 2023 at 10:23:02 +0100, Pierre Gondois wrote:
> To enable AARCH64 native instruction support for Openssl,
> some interfaces must be implemented. OPENSSL_cpuid_setup()
> allows to probe the supported features of the platform.
>
> Add ArmReadIdAA64Isar0Reg() to read the AA64Isar0,
On Thu, Nov 09, 2023 at 10:23:01 +0100, Pierre Gondois wrote:
> To enable AARCH64 native instruction support for Openssl,
> some interfaces must be implemented. OPENSSL_rdtsc() requests
> an access to a counter to get some non-trusted entropy.
>
> Add ArmReadCntPctReg() to read system count.
> A
-announce, +discuss
On 2023-11-09 12:02, Marcin Juszkiewicz wrote:
W dniu 7.11.2023 o 01:59, gaoliming via groups.io pisze:
Below is edk2-stable202311 tag planning Proposed Schedule
Date (00:00:00 UTC-8) Description
2023-08-25 Beginning of development
2023-11-06 Soft Feature Freeze
On Thu, Nov 09, 2023 at 10:58:58 +0100, Pierre Gondois wrote:
> Hello Leif,
>
> On 11/2/23 11:20, Pierre Gondois wrote:
> >
> >
> > On 10/26/23 13:03, Leif Lindholm wrote:
> > > On Wed, Oct 25, 2023 at 13:25:39 +0200, PierreGondois wrote:
> > > >
Reviewed-by: Leif Lindholm
I see no issues with this going in during soft freeze.
/
Leif
On 2023-11-08 03:49, Michael D Kinney wrote:
The following commit removed PlatformBootManagerLibGub from
OvmfPkg. Update Maintainers.txt to remove reference to
deleted directory.
https://github.com
features, we must find community members that are willing to
own it.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Laszlo Ersek
Signed-off-by: Michael D Kinney
Reviewed-by: Laszlo Ersek
Reviewed-by: Leif Lindholm
---
Maintainers.txt | 2 --
1 file changed, 2 deletions(-)
diff --git
Liming,
You reviewed this patch before the stable tag. Am I OK to stage a github
PR for this change?
Reviewed-by: Leif Lindholm
Regards,
Leif
On 2023-11-07 13:11, Yeping Song (QUIC) wrote:
Hi all,
I would like for this to be include in stable tag. Please help to review and
merge
an
entry added to it. This seems superficially unmotivated.
However it is also moved to inside the pack(1) block, which makes no
sense for an enum.
Yes right, I will move it out of the pack(1) section.
Thx, with that change:
Reviewed-by: Leif Lindholm
The reason to move
On 2023-10-31 19:49, Pedro Falcato wrote:
On Tue, Oct 31, 2023 at 7:43 PM Kinney, Michael D
wrote:
Hi Pedro,
SPDX is only for licenses, not copyrights.
IANAL, but several FOSS projects (including Linux) have generally
replaced the "Copyright (c) ..." verbiage with SPDX.
They may have
ers.
> * Bounce: Chan Laura
> * Many smaller updates removing individuals that are no
> longer involved or have replacement coverage.
>
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Andrei Warkentin
> Cc: Catharine West
> Cc: Dandan Bi
> Cc: Daniel Schaefer
> Cc:
EFI_SUCCESS;
> + Status = DisableXhciOnOlderPlatVer ();
> + if (EFI_ERROR (Status)) {
> +DEBUG ((DEBUG_ERROR, "Failed to handle XHCI enablement\n"));
> + }
> +
> + return Status;
Right, this isn't what I asked for though.
There is nothing valid about returning a bad
Marcin Juszkiewicz
Reviewed-by: Leif Lindholm
Pushed as 74b9eacfd453.
Thanks!
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.as
Couple of minor comments on this patch, rest of set good to go:
On Wed, Oct 18, 2023 at 13:55:41 +0200, Marcin Juszkiewicz wrote:
> We need platform version to be at least 0.3 to have XHCI
> in virtual hardware. On older platforms there is non-working
> EHCI which we ignore.
>
> Set DSDT node to
On Thu, Oct 26, 2023 at 16:35:52 +0100, Leif Lindholm wrote:
> On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote:
> > From: Narinder Dhillon
> >
> > Current Marvell package structure makes it difficult to add new silicon
> > packages that reuse commo
On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote:
> From: Narinder Dhillon
>
> Current Marvell package structure makes it difficult to add new silicon
> packages that reuse common elements without creating nested DEC files.
>
> This patch creates a new MarvellSiliconPkg folder
1 - 100 of 1860 matches
Mail list logo
