Hi Rebecca,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI].
Regards,
Sami Mujawar
On 03/01/2024, 20:44, "Rebecca Cran" mailto:rebe...@os.amperecomputing.com>> wrote:
The generic watchdog offset register is 48 bits wide, and can be set by
p
IA32?
Regards,
Sami Mujawar
On 03/01/2024 09:52 am, Abdul Lateef Attar via groups.io wrote:
From: Abdul Lateef Attar
PR: https://github.com/tianocore/edk2/pull/5209
v2: Fix the IA32 compilation errors.
v1: Fix the X64 compilation errors.
Cc: Pierre Gondois pierre.gond...@arm.com
Cc: Sami
Hi Abdul,
Thank you for this patch.
I have some minor suggestions that I will fix before merging. Otherwise
this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/01/2024 09:52 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add the support for X64
Hi Abdul,
Thank you for this patch.
I have some minor suggestions that I will fix before merging. Otherwise
this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/01/2024 09:52 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add the support for X64
Hi Pierre,
Thank you for this patch.
I just have one comment marked inline as [SAMI].
Otherwise this patch looks good to me.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 30/11/2023 11:09 am, Pierre Gondois wrote:
Add definitions for:
- _PSD version: added in
Series merged as 5d533bbc2773..d01defe06b35
Thanks.
Regards,
Sami Mujawar
On 22/12/2023, 03:59, "Attar, AbdulLateef (Abdul Lateef)"
mailto:abdullateef.at...@amd.com>> wrote:
[AMD Official Use Only - General]
Hi Sami,
Below mentioned patch looks good;
https://github.com/
Hi Abdul,
Can you check if the patch 4/4 at
https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_method_invocation_v5
looks ok to you, please?
If you confim, I will apply the push label.
Regards,
Sami Mujawar
On 21/12/2023 01:56 pm, Sami Mujawar via groups.io wrote
d with argument.
V1:
Code changes to
Add API to generate word I/O ranges.
Correct the parameter to generate word bus number.
Corrects the function pointer typedef
Cc: Pierre Gondois
Cc: Sami Mujawar
Cc: Abdul Lateef Attar
Abdul Lateef Attar (4):
DynamicTablesPkg: AML Code generation
the
changes and get this patch merged.
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Adds API to generate AML code to invoke/call another
method. Also provides ability to pass arguments of
type integer, string, ArgObj or LocalObj.
Cc: Pierre
/DynamicTablesPkg/Include/AcpiTableGenerator.h#L217
Maybe we need to find and fix those issues as well.
In either case, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Corrects the function pointer
Hi Abdul,
Thank you for this fix. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc
Hi Abdul,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois
Cc: Sami
Hi Sahil,
As such these changes look good to me. But, we would need to revisit
this based on my response for Patch 3/5.
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 5 +
Platform/ARM/N1Sdp
Hi Sahil,
Please see my response for Patch 3/5.
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 20 ++--
Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 4
/P30NorFlashDeviceLib/P30NorFlashDeviceLib.inf
NorFlashDeviceLib|Platform/Arm/Library/CadenceQspiNorFlashDeviceLib/CadenceQspiNorFlashDeviceLib.inf
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Add NOR flash DXE driver, this brings up NV storage on
QSPI's flash device using FVB pro
Hi Sahil,
Please find my feedback marked inline as [SAMI].
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil wrote:
Add NOR flash library, this library provides APIs for getting the list
of NOR flash devices on the platform.
Signed-off-by
Hi Sahil,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/11/2023 11:45 am, sahil via groups.io wrote:
Enable SCP QSPI flash region access by adding it in the PlatformLibMem
Signed-off-by: sahil
---
Silicon/ARM/NeoverseN1Soc/Include/NeoverseN1Soc.h
Merged as b8a3eec88cc7..59a952d9ab00
Thanks.
Regards,
Sami Mujawar
On 14/12/2023, 13:54, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote:
Hi Laszlo,
On 14/12/2023, 12:28, "Laszlo Ersek" mailto:ler...@redhat.com> <mailto:ler...@redhat.com
<mailto:le
Hi Leif, Ard,
On 14/12/2023, 14:46, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote:
+Sami (who I know once, a very long time ago, used cygwin)
[SAMI] Now that we have WSL, I have stopped using Cygwin.
Also, this patch looks good to me.
Reviewed-by: Sami Mujawar
Hi Laszlo,
On 14/12/2023, 12:28, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
On 12/13/23 16:13, Sami Mujawar wrote:
> From: Jianyong Wu mailto:jianyong...@arm.com>>
>
> Add the long lost CI for CloudHv on AArch64.
> As CloudHv CI works nearly the sam
Hi Himanshu,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Taking reference from Table 2-1 of the Arm
Hi Himanshu,
Thank you for this patch.
Please see my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Add interrupt node to the AML description of the serial-port only if the
IRQ ID from the Configuration Manager is a valid SPI (shared
Hi Laszlo,
I have posted a v3 patch to fix the issue at
https://edk2.groups.io/g/devel/message/112485
I have done a draft pull request to check the v3 patch passes CI and this can
be seen at https://github.com/tianocore/edk2/pull/5145
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
From: Jianyong Wu
Add the long lost CI for CloudHv on AArch64.
As CloudHv CI works nearly the same way with other VMMs like KvmTool,
thus we can easily create its CI configuration based on KvmTool.
Reviewed-by: Laszlo Ersek
Signed-off-by: Jianyong Wu
Signed-off-by: Sami Mujawar
---
The
Hi Laszlo,
I will look into this and provide a fix shortly.
Regards,
Sami Mujawar
On 11/12/2023, 17:21, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
Hi Jianyong,
On 12/11/23 17:31, Laszlo Ersek wrote:
> On 11/23/23 04:22, Jianyong Wu wrote:
>> Add the lo
Hi Sahil,
Thank you for this patch.
I think this patch can be split into 3 or 4 patches. Can you look into
that, please?
I also have other feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 23/08/2023 12:03 pm, sahil wrote:
NT_FW_CONFIG DTB contains platform information passed by
Hi Rohit,
Thank you for this patch.
Please see my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 02/10/2023 06:17 pm, Rohit Mathew wrote:
Add a parser for the MPAM (Memory system resource partitioning and
monitoring) ACPI table. This parser would parse all MPAM related
structures
Hi Rohit,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/10/2023 06:17 pm, Rohit Mathew wrote:
Most of the ACPI tables have fields that are marked reserved. Implement
Hi Rohit,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/10/2023, 18:16, "Rohit Mathew" mailto:rohit.mat...@arm.com>> wrote:
As of now, the print-formatter implemented by the FNPTR_PRINT_FORMATTER
function p
.
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/10/2023 06:15 pm, Rohit Mathew wrote:
As of now, the field-validator implemented by FNPTR_FIELD_VALIDATOR
function pointer takes two parameters, the pointer to the field and a
context pointer. For cases where the
Merged as b95395ba400e..3220cb309390
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112043): https://edk2.groups.io/g/devel/message/112043
Mute This Topic: https://groups.io/mt/102894400/21656
Group Owner
Hi Levi,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 30/11/2023, 14:29, "levi.yun" mailto:yeoreum@arm.com>> wrote:
The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16
introduces a new library ImagePropertiesRecordLib to
consolida
Forwarding this discussion as it unfortunately missed the mailing list.
Regards,
Sami Mujawar
On 29/11/2023 12:33 pm, Yeo Reum Yun wrote:
Thanks Pierre :)
+add Taylor Beebe
@Taylor Beebe
Hi Taylor! Thanks for your recent patch related to ImagePropertiesRecordLib!
But, after applying your
Hi Levi,
Apparently, you have not posted the patch to the edk2 mailing list.
Can you post a v2 series with the line ending issue fixed to the mailing list,
please?
Regards,
Sami Mujawar
On 30/11/2023, 10:30, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote:
Hi Thomas,
B
umably, if you have an internal gerrit instance
that runs CI before pushing, PatchCheck.py may be part of the CI
workflow; in those cases, we don't want it to error out.
So the CI would be adapted to do PatchCheck.py --ignore-change-id, and
all is well.
[SAMI] Just saw your email. You have
Hi Ray,
On 29/11/2023, 00:56, "Ni, Ray" mailto:ray...@intel.com>>
wrote:
It's good. But I am curious why --ignore-change-id is needed?
[SAMI] This option can be useful if an internal CI uses the same script for
checking patches before they are posted on the list.
R
Hi Leif,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 09/11/2023, 13:12, "disc...@edk2.groups.io <mailto:disc...@edk2.groups.io>
on behalf of Leif Lindholm via groups.io" mailto:disc...@edk2.groups.io> on behalf of
quic_llindhol=quicinc@groups
Hi Liming,
Thanks a lot. I can see it in the mainline.
Regards,
Sami Mujawar
On 21/11/2023, 14:15, "gaoliming" mailto:gaolim...@byosoft.com.cn>> wrote:
Sami:
I have merged it. Please check.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io <ma
k you for picking this patch for the stable tag. Apparently, the
patch does not seem to have merged.
I am not sure if you have already applied the push label. Please let me know if
there are any issues that I can help with.
Regards,
Sami Mujawar
Thanks
Liming
> -----邮件原件-
> 发件人: S
Hi Laszlo, Liming, Mike,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 17/11/2023 09:20 am, Laszlo Ersek wrote:
On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName
Hi Ashish,
I have created a bugzilla ticket for this at
https://bugzilla.tianocore.org/show_bug.cgi?id=4600.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111471): https://edk2.groups.io/g/devel/message/111471
Hi Ashish,
Thank you for this fix.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/11/2023 03:19 am, Ashish Singhal wrote:
Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName
Signed-off-by: Ashish Singhal
Hi Chao,
Thank you for this patch.
I have a few suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 06/11/2023 03:29 am, Chao Li wrote:
Moved PcdDeviceTreeInitialBaseAddress and
update the GICC info object parser to add an entry to parse
the ET reference token. Without this change an assert
stating that the RemainingSize != 0 will be triggered.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
| 3 +
Merged as dc8de7cc888f..1ae7cffab740
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110319): https://edk2.groups.io/g/devel/message/110319
Mute This Topic: https://groups.io/mt/101522378/21656
Group Owner
Merged as 4f3ee7fbafc8..a671a14e63fd
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110318): https://edk2.groups.io/g/devel/message/110318
Mute This Topic: https://groups.io/mt/101522262/21656
Group Owner
Hi Jose,
Thank you for this patch.
There was a minor numbering change that I have done before pushing the patch
for merging.
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
Dear MdePkg Maintainers,
Can I have your review feedback for the first 2 patches in this series,
please?
- MdePkg: MADT: Add Online capable flag in GICC
- MdePkg: MADT: Add TRBE interrupt to GICC
I plan to merge this series by end of this week.
Regards,
Sami Mujawar
On 23/10/2023 04:30 pm
I had to add an entry to satisfy the CI spell checker.
With that,
Merged as ec7f73436646..309450db268c
Regards,
Sami Mujawar
On 23/10/2023 06:12 pm, Sami Mujawar via groups.io wrote:
Hi Jeshua,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards
Hi Jeshua,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/10/2023 05:38 pm, Jeshua Smith wrote:
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable
and MemoryRangeType parameters treat specific values
Merged as c591395f4ab5..ec7f73436646
Thanks.
Regards,
Sami Mujawar
On 23/10/2023 05:55 pm, Sami Mujawar via groups.io wrote:
Hi Jeshua,
Thank you for these fixes.
For this series,
Reviewed-by: Sami Mujawar
I have now queued this up for merging.
Regards,
Sami Mujawar
On 06/10/2023 05
Hi Jeshua,
Thank you for these fixes.
For this series,
Reviewed-by: Sami Mujawar
I have now queued this up for merging.
Regards,
Sami Mujawar
On 06/10/2023 05:28 pm, Jeshua Smith wrote:
While using the ConfigurationManagerObjectParser to dump objects and debug
adding new objects, I
Dear Basetool Maintainers,
Is it possible to provide feedback for this patch, please?
This patch fixes an issue that is blocking the patch series at
https://edk2.groups.io/g/devel/message/109178 from being merged.
Regards,
Sami Mujawar
On 13/10/2023, 08:36, "Sami Mujawar" mailto
Hi Laszlo,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/10/2023, 14:42, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote:
Hi Sami,
On 10/12/23 14:33, Sami Mujawar wrote:
> Hi Laszlo,
>
> Thank you for this patch.
> These changes lo
Adding Tuan.
Regards,
Sami Mujawar
On 12/10/2023, 18:12, "levi.yun" mailto:yeoreum@arm.com>> wrote:
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver
architecture independent" (https://edk2.groups.io/g/devel/message/109178
<https://e
Hi Laszlo,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Tested by booting a Linux guest using Kvmtool guest firmware
(ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64.
Tested-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/10/2023, 10:25, "devel
Hi Laszlo,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/10/2023, 10:27, "devel@edk2.groups.io <mailto:devel@edk2.groups.io> on
behalf of Laszlo Ersek via groups.io" mailto:devel@edk2.groups.io> on beha
Hi Tuan,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/09/2023 10:14 pm, Tuan Phan wrote:
Update entry point library for Arm to use the new architecture independent
StandaloneMmCpu driver.
Signed-off-by: Tuan Phan
Reviewed
Hi Leif,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/10/2023, 11:39, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote:
RO -> R0
Signed-off-by: Leif Lindholm mailto:quic_llind...@quicinc.com>>
Reported-by: Philippe
Reviewed-by: Sami Mujawar
Thanks.
Regards,
Sami Mujawar
On 27/09/2023 12:06 pm, Leif Lindholm wrote:
We added Sami as a reviewer to ArmPkg early last year, and I think it was
always our intention to have him as a reviewer of Arm architectural stuff
in general, but we seem to have missed out
Hi Leif,
Thank you for this patch.
There is a minor typo in the commit message, other than that these
changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
The ARM implementation of of InternalLongJump always returned the
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
Both in SetJump and in InternalLongJump, 32-bit w register views were
used for the UINTN return value. In SetJump, this did not
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
There may be architectures on which there are benefits to
eor r0, r0(, r0)
but ARM was never one of them. Change to more
Hi Leif,
Thank you for this patch.
This patch looks good to me.
Just a question, should we also do the same for the AArch32 builds?
In either case,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
The SetJump comment header states that:
If
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 26/09/2023 06:15 pm, Leif Lindholm wrote:
Drop redundant comment about IPF (clearly copied across from now deleted
code).
Also change
"Instead is resumes exec
Hi Pierre,
Thank you for this fix.
Unfortunately, this did not get trapped by the edk2 CI as well.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/09/2023, 13:30, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
Hi Tuan,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 15/09/2023 12:10 am, Tuan Phan wrote:
Update entry point library for Arm to use the new platform independent
[SAMI] Should this be worded as architecture independent instead of
Hi Tuan,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/09/2023 12:10 am, Tuan Phan wrote:
StandaloneMmCpu now can supports more platforms like RISC-V besides
ARM/AARCH64.
Signed-off-by: Tuan Phan
---
.../Drivers
Hi Leif,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 25/09/2023 10:40 am, Leif Lindholm wrote:
On Fri, Sep 22, 2023 at 15:40:38 -0600, Swatisri Kantamsetti via groups.io
wrote:
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https
for the patch series (even if some
patches get merged) in future, please? It helps keep track of the review
history.
Other than that this patch looks good to me and I will queue this for
merging.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/09/2023 10:40 pm, Swatisri Kantamsetti wrote
-C cluster1.has_trbe=1
3. Set the ETE plugin for the model
--plugin \libete-plugin.[so|dll]
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- Use macros instead of magic numbers in ETE feature [Pierre]
detection code.
- Implemented helper functions in ArmLib to
TRBE
-C cluster0.has_trbe=1 -C cluster1.has_trbe=1
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- Use macros instead of magic numbers in TRBE feature [Pierre]
detection code.
- Implemented helper functions in ArmLib to detect if [Sami]
the TRBE feature is present
Add support to dynamically generate the CPU nodes in SSDT.
Signed-off-by: Sami Mujawar
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager
and 13/13 in the edk2
patch series linked above) and using them instead.
Updates from v1 patch series:
- Fixed comment in patch 2/3 to specify the TRBE
interrupt as PPI 15.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2620_ete_dev_fvp_v3
Sami Mujawar (3
Create a helper function to query whether ID_AA64MFR1_EL1 indicates
presence of the Embedded Trace Extension (ETE). This feature is only
visible in AARCH64 state.
Signed-off-by: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Pierre Gondois
---
Notes:
v3:
- New patch in this
Create a helper function to query whether ID_AA64MFR1_EL1 indicates
presence of the Trace Buffer Extension (TRBE). This feature is only
visible in AARCH64 state.
Signed-off-by: Sami Mujawar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Pierre Gondois
---
Notes:
v3:
- New patch in this
require the MADT table revision to be setup to
6 to reflect the ACPI 6.5 specification.
The TRBE field needs to be appropriately setup in the
GICC structure.
Therefore, update the MADT generator to reflect the
above updates required for supporting ACPI 6.5
Signed-off-by: Sami Mujawar
---
Notes
The CpcToken has been incorrectly referenced in the
CreateTopologyFromGicC() and always points to the
CPC token in the first GICC Info object.
Therefore, fix this by correctly indexing into the
GicCInfo object array.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3
registers.
Since this patch aims to support ETE it does
not describe any memory mapped registers.
However, required support for ETM can be added
in the future.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI
The ACPI 6.5 specification updates the minor revision
of the FADT table to 5. Therefore, update the FADT
generator to setup the minor revision for ACPI 6.5.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI
in ArmLib to
detect if ETE is supported.
Updates from v1 patch series:
- Fixed issue with setting TRBE interrupt in patch 5/11.
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
Sami Mujawar (13):
MdePkg: MADT: Add Online capable flag in GICC
MdePk
Object parser to add support
for parsing the CM_ARM_ET_INFO object.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Library
The ASWG ECR 2303 introduces a new field 'TRBE
interrupt' to GICC structure in ACPI 6.5.
The Trace Buffer Extension (TRBE) interrupt is a
Processor Private interrupt (PPI) and is used to
specify a platform-specific interrupt to signal
TRBE events.
Signed-off-by: Sami Mujawar
Reviewed-
interrupt field. Also, add
validations to check that the TRBE interrupt is
within the PPI interrupt range.
Signed-off-by: Sami Mujawar
Reviewed-by: Zhichao Gao
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
- Added rb tag from Zhichao
CM_ARM_GICC_INFO
structure in a previous patch.
Therefore, update the Configuration Manager Object Parser to
reflect the addition of the TRBE interrupt field.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2
the AML
description does not describe any memory mapped
registers. However, support for ETM can be
added in the future.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patc
reflect the addition
of the TRBE interrupt field.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
DynamicTablesPkg/Include/ArmNameSpaceObjects.h
o match the value as
specified in ACPI 6.5.
Signed-off-by: Sami Mujawar
Reviewed-by: Pierre Gondois
---
Notes:
v3:
- No code change from v2 patch series. [SAMI]
v2:
- No code change from v1 patch series. [SAMI]
MdePkg/Include/IndustryStandard/Acpi65.h | 3 ++
Hi Jeff,
Thank out for this patch series.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 21/09/2023 09:10 pm, Jeff Brasen wrote:
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where
Hi Pierre,
Thank you for the feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/09/2023, 09:56, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Hi Sami,
On 9/13/23 14:52, Sami Mujawar wrote:
> When TRBE is enabled the FVP mo
Hi Pierre,
Thank you for the review feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/09/2023, 09:53, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Hi Sami,
On 9/13/23 14:49, Sami Mujawar wrote:
> The ACPI 6.5 specificati
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Signed-off-by: Jeff Brasen
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/09/2023, 13:39, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote:
Create a helper function to query whether ID_AA64MFR1_EL1 indicates
Hi Michael,
Apologies, I initially misunderstood what this patch was trying to do.
As I understand this is an exception for one of the special cases to be handled
differently by the plugin.
Acked-by: Sami Mujawar
Regards,
Sami Mujawar
On 14/09/2023, 09:42, "devel@edk2.grou
Hi Michael,
I would prefer to have the debug macro checks enabled in DynamicTablesPkg to
catch any issues.
Please do not disable this feature for this package.
Regards,
Sami Mujawar
On 13/09/2023, 18:08, "mikub...@linux.microsoft.com
<mailto:mikub...@linux.microsoft.com>&qu
. "
EArmObjEtInfo (OPTIONAL)").
[SAMI] I think I will fix this before I merge the series.
Regards,
Sami Mujawar
-Original Message-
From: Sami Mujawar mailto:sami.muja...@arm.com>>
Sent: Wednesday, September 13, 2023 6:50 AM
To: devel@edk2.groups.io <mailto:devel@
TRBE
-C cluster0.has_trbe=1 -C cluster1.has_trbe=1
Signed-off-by: Sami Mujawar
---
Notes:
V2:
- Incorrect comment for TRBE interrupt number [Jeshua]
- Fixed comment to specify TRBE interrupt as[Sami]
PPI 15
Ref: https://edk2.groups.io/g/devel/message/107426
Add support to dynamically generate the CPU nodes in SSDT.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl
| 38 +---
Platform
-C cluster1.has_trbe=1
3. Set the ETE plugin for the model
--plugin \libete-plugin.[so|dll]
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change from v1 patch series. [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe
201 - 300 of 1066 matches
Mail list logo
