Re: [edk2-devel] [PATCH v1 1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation

2023-06-30 Thread PierreGondois
Hello Kun, The reason was that: - KvmTool uses the SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf module - the RngDxe.inf modules requires an ArmTrng implementation - GetArmTrngVersion() is called to check whether there is a Trng backend - GetArmTrngVersion() asserts as it is a NULL

Re: [edk2-devel] [PATCH v1 1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation

2023-06-29 Thread Kun Qin
Hi Pierre, Do we really need this removal of ASSERT? I tried to use the real ArmTrngLib with this patch and it seems to work fine with a TFA that does not support TRNG interfaces. I think it would be valuable to keep the ASSERT to indicate there might be an integration error? Please let me

Re: [edk2-devel] [PATCH v1 1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation

2023-06-29 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote: From: Pierre Gondois Remove ASSERTs to allow RngDxe probing the Null implementation of the TrngLib. Signed-off-by:

[edk2-devel] [PATCH v1 1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation

2023-05-09 Thread PierreGondois
From: Pierre Gondois Remove ASSERTs to allow RngDxe probing the Null implementation of the TrngLib. Signed-off-by: Pierre Gondois --- MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c | 4 1 file changed, 4 deletions(-) diff --git