Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-19 Thread RichardHo [何明忠] via groups . io
Hi Rebecca, ECM and NCM will be enable when move the UsbNetworkPkg to MdeModulePkg\Bus\Usb\UsbNetwork. About rate limiting. We have test it X86 system. It will be slow to PXE boot. Do you think this PCD should be enabled by default? Thanks, Richard -Original Message- From: Rebecca

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-19 Thread Rebecca Cran
Hi Richard, I was wondering if you'd seen my questions about ECM and NCM, and rate limiting? -- Rebecca Cran On 4/11/23 6:31 AM, Rebecca Cran wrote: Yes, you can add me as a reviewer. A couple more comments on the patches: why are ECM and NCM disabled by default? I've tested on my

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-18 Thread Leif Lindholm
ndrew Fish ; Leif Lindholm > > ; Michael D Kinney > > ; Michael Kubacki > > ; Zhiguang Liu ; > > Liming Gao ; Tinh Nguyen > > ; Tony Lo (羅金松) > > ; Marvin Häuser > > Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] > > UsbNetworkPkg/UsbR

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-12 Thread RichardHo [何明忠] via groups . io
; Michael D Kinney ; Michael Kubacki ; Zhiguang Liu ; Liming Gao ; Tinh Nguyen ; Tony Lo (羅金松) ; Marvin Häuser Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support [AMD Official Use Only - General] Hi Richard and Pedro, Understand

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-11 Thread Chang, Abner via groups.io
Andrew Fish ; Leif Lindholm > ; Michael D Kinney > ; Michael Kubacki > ; Zhiguang Liu ; > Liming Gao ; Tinh Nguyen > ; Tony Lo (羅金松) > ; Marvin Häuser > Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] > UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support > > C

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-11 Thread RichardHo [何明忠] via groups . io
v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** On Tue, Apr 11, 2023 at 1:31 PM Rebecca Cran wrote: > Given this is adding a

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-11 Thread Rebecca Cran
I've pushed the patches to a branch at https://github.com/bcran/edk2/tree/usbnetworkpkg-202304 -- Rebecca Cran On 4/7/23 5:27 AM, Richard Ho (何明忠) wrote: This driver provides UEFI driver for USB RNDIS device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D

Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-04-11 Thread Pedro Falcato
On Tue, Apr 11, 2023 at 1:31 PM Rebecca Cran wrote: > Given this is adding a new top-level package, I'd like to see a > review/feedback from the TianoCore Stewards. I would personally love to understand why this is being pushed as a top level package in edk2 when "supposedly"