Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-30 Thread Miro Hrončok
On 21. 01. 20 13:35, Miro Hrončok wrote: Hello, we try to rebuild all Python packages against Python 3.9 and report the failures. I've seen several similar failures in a row now that can be reproduced in Fedora rawhide with the new gcc version. ld errors on multiple definitions of ..., for

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-25 Thread Richard W.M. Jones
On Wed, Jan 22, 2020 at 12:41:24PM +0100, Miro Hrončok wrote: > ocaml I just did a scratch build of OCaml in Rawhide and it seems fine. I guess it may have FTBFS at that time for some other reason, but without seeing the logs it's hard to tell. Rich. -- Richard Jones, Virtualization Group,

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-23 Thread Steve Grubb
On Thursday, January 23, 2020 5:30:28 PM EST Jeff Law wrote: > On Thu, 2020-01-23 at 17:23 -0500, Steve Grubb wrote: > > On Tuesday, January 21, 2020 1:52:54 PM EST Jeff Law wrote: > > > > > > That was the idea. Provide a trivial opt-out so that upstreams > > > > > > had > > > > > > time to fix

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-23 Thread Jeff Law
On Thu, 2020-01-23 at 17:23 -0500, Steve Grubb wrote: > On Tuesday, January 21, 2020 1:52:54 PM EST Jeff Law wrote: > > > > > That was the idea. Provide a trivial opt-out so that upstreams had > > > > > time to fix properly. I even volunteered to add the opt-out marker > > > > > where

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-23 Thread Steve Grubb
On Tuesday, January 21, 2020 1:52:54 PM EST Jeff Law wrote: > > > > That was the idea. Provide a trivial opt-out so that upstreams had > > > > time to fix properly. I even volunteered to add the opt-out marker > > > > where appropriate to minimize the FTBFS issues. I also volunteered > > > >

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2020 at 04:48:14PM +0100, Robert-André Mauchin wrote: > How to fix the affected packages? For some I ised extern and it worked but > for > other using extern resulted in error like: > > /usr/bin/ld: /builddir/build/BUILD/uTox-0.17.1/src/xlib/main.c:590: undefined > reference to

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-23 Thread Tom Hughes
Well sure, because you need one, and only one, file that actually defines it. Previously every file that included the header created a definition which meant you could wind up with multiple definitions if more than one file included it. Now no file that includes the header will create a

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-23 Thread Robert-André Mauchin
On Tuesday, 21 January 2020 13:35:03 CET Miro Hrončok wrote: > Hello, > > we try to rebuild all Python packages against Python 3.9 and report the > failures. I've seen several similar failures in a row now that can be > reproduced in Fedora rawhide with the new gcc version. > > ld errors on

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Michael Cronenworth
On 1/21/20 6:35 AM, Miro Hrončok wrote: This is a known thing in gcc 10: https://gcc.gnu.org/gcc-10/porting_to.html#common I have seen odd behavior in Wine with this change. Some code compiles successfully without requiring extern in x86 / x86_64 but the same code requires extern for

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Fabio Valentini
On Wed, Jan 22, 2020 at 9:58 PM Christoph Junghans wrote: > > > > On Wed, Jan 22, 2020 at 1:31 PM Stephen John Smoogen wrote: >> >> On Wed, 22 Jan 2020 at 14:54, Christoph Junghans wrote: >> > >> > On Wed, Jan 22, 2020 at 4:42 AM Miro Hrončok wrote: >> >> >> >> >> jtaylornetsniff-ng

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Christoph Junghans
On Wed, Jan 22, 2020 at 1:31 PM Stephen John Smoogen wrote: > On Wed, 22 Jan 2020 at 14:54, Christoph Junghans > wrote: > > > > On Wed, Jan 22, 2020 at 4:42 AM Miro Hrončok > wrote: > >> > > >> jtaylornetsniff-ng ocaml-lablgtk suricata > >> junghans gasnet > > > > Sorry, how do I install

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Stephen John Smoogen
On Wed, 22 Jan 2020 at 14:54, Christoph Junghans wrote: > > On Wed, Jan 22, 2020 at 4:42 AM Miro Hrončok wrote: >> >> jtaylornetsniff-ng ocaml-lablgtk suricata >> junghans gasnet > > Sorry, how do I install gcc10 on Rawhide? > "dnf upgrade --advisory=FEDORA-2020-a165791b6f" doesn't seem

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Christoph Junghans
On Wed, Jan 22, 2020 at 4:42 AM Miro Hrončok wrote: > On 22. 01. 20 12:33, Fabio Valentini wrote: > > On Wed, Jan 22, 2020 at 12:12 PM Kevin Kofler > wrote: > >> > >> Miro Hrončok wrote: > >>> https://gcc.gnu.org/gcc-10/porting_to.html#common > >>> > >>> "Default to -fno-common > >>> > >>> A

Re: Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Jeff Law
> Date: Wed, 22 Jan 2020 07:34:01 -0600 > From: Justin Forbes > Subject: Re: gcc 10: Default to -fno-common, multiple definitions of > ... > To: Development discussions related to Fedora > > Message-ID: > > Content-Type: text/plain; charset="

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Miro Hrončok
On 22. 01. 20 14:34, Justin Forbes wrote: On Wed, Jan 22, 2020 at 5:42 AM Miro Hrončok wrote: On 22. 01. 20 12:33, Fabio Valentini wrote: On Wed, Jan 22, 2020 at 12:12 PM Kevin Kofler wrote: Miro Hrončok wrote: https://gcc.gnu.org/gcc-10/porting_to.html#common "Default to -fno-common A

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Justin Forbes
On Wed, Jan 22, 2020 at 5:42 AM Miro Hrončok wrote: > > On 22. 01. 20 12:33, Fabio Valentini wrote: > > On Wed, Jan 22, 2020 at 12:12 PM Kevin Kofler > > wrote: > >> > >> Miro Hrončok wrote: > >>> https://gcc.gnu.org/gcc-10/porting_to.html#common > >>> > >>> "Default to -fno-common > >>> > >>>

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Miro Hrončok
On 22. 01. 20 12:33, Fabio Valentini wrote: On Wed, Jan 22, 2020 at 12:12 PM Kevin Kofler wrote: Miro Hrončok wrote: https://gcc.gnu.org/gcc-10/porting_to.html#common "Default to -fno-common A common mistake in C is omitting extern when declaring a global variable in a header file. If the

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Fabio Valentini
On Wed, Jan 22, 2020 at 12:12 PM Kevin Kofler wrote: > > Miro Hrončok wrote: > > https://gcc.gnu.org/gcc-10/porting_to.html#common > > > > "Default to -fno-common > > > > A common mistake in C is omitting extern when declaring a global variable > > in a header file. If the header is included by

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-22 Thread Kevin Kofler
Miro Hrončok wrote: > https://gcc.gnu.org/gcc-10/porting_to.html#common > > "Default to -fno-common > > A common mistake in C is omitting extern when declaring a global variable > in a header file. If the header is included by several files it results in > multiple definitions of the same

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Jeff Law
On Tue, 2020-01-21 at 13:47 +0100, Jakub Jelinek wrote: > On Tue, Jan 21, 2020 at 01:42:25PM +0100, Fabio Valentini wrote: > > I've seen this issue pop up in some other packages, as well. > > > > My elementary-files package is affected, and I think it broke > > rubygem-ffi, too (which is blocking

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Jeff Law
> Date: Tue, 21 Jan 2020 14:00:30 +0100 > From: Miro Hrončok > Subject: Re: gcc 10: Default to -fno-common, multiple definitions of > ... > To: devel@lists.fedoraproject.org, Jakub Jelinek > Message-ID: > Content-Type: text/plain; charset=utf-8; format=flowed >

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-21 Thread Jeff Law
ter Robinson > > > Subject: Re: gcc 10: Default to -fno-common, multiple definitions of > > > ... > > > To: l...@redhat.com, Development discussions related to Fedora > > > > > > Message-ID: > > > > > > Content-Type: text/plain; ch

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-21 Thread Jeff Law
On Tue, 2020-01-21 at 13:33 -0500, Steve Grubb wrote: > On Tuesday, January 21, 2020 1:16:00 PM EST Miro Hrončok wrote: > > > > > > I proposed a change to redhat-rpm-config to handle this case by > > > > > > > > > > allowing package to add a single line to their .spec file to turn off > > > > >

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-21 Thread Steve Grubb
On Tuesday, January 21, 2020 1:16:00 PM EST Miro Hrončok wrote: > I proposed a change to redhat-rpm-config to handle this case by > >>> > >>> allowing package to add a single line to their .spec file to turn off > >>> the new common symbol handling. Igor rejected that change arguing that >

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-21 Thread Miro Hrončok
On 21. 01. 20 19:04, Jeff Law wrote: -- Date: Tue, 21 Jan 2020 17:44:37 + From: Peter Robinson Subject: Re: gcc 10: Default to -fno-common, multiple definitions of ... To: l...@redhat.com, Development

Re: gcc 10: Default to -fno-common, multiple definitions of

2020-01-21 Thread Jeff Law
> > -- > > > Date: Tue, 21 Jan 2020 17:44:37 + > From: Peter Robinson > Subject: Re: gcc 10: Default to -fno-common, multiple definitions of > ... > To: l...@redhat.com, Development di

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Peter Robinson
s > > there > > a macro that we can add -fno-common to in ~/.rpmmacros without placing it in > > the %__global_compiler_flags in /usr/lib/rpm/redhat/macros ? > > > > Looking for an easy way to reproduce this without modifying root owned > > files. > > > &

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Jeff Law
> > > > Date: Tue, 21 Jan 2020 11:05:37 -0500 > From: Steve Grubb > Subject: Re: gcc 10: Default to -fno-common, multiple definitions of > ... > To: devel@lists.fedoraproject.org > Cc: Jakub Jelinek > Message-ID: <4127758.jL2Gs7s9Fr@x2> > C

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Miro Hrončok
On 21. 01. 20 17:05, Steve Grubb wrote: On Tuesday, January 21, 2020 7:35:03 AM EST Miro Hrončok wrote: This is a known thing in gcc 10: https://gcc.gnu.org/gcc-10/porting_to.html#common "Default to -fno-common A common mistake in C is omitting extern when declaring a global variable in a

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Steve Grubb
On Tuesday, January 21, 2020 7:35:03 AM EST Miro Hrončok wrote: > This is a known thing in gcc 10: > > https://gcc.gnu.org/gcc-10/porting_to.html#common > > "Default to -fno-common > > A common mistake in C is omitting extern when declaring a global variable > in a header file. If the header is

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Miro Hrončok
On 21. 01. 20 13:47, Jakub Jelinek wrote: On Tue, Jan 21, 2020 at 01:42:25PM +0100, Fabio Valentini wrote: I've seen this issue pop up in some other packages, as well. My elementary-files package is affected, and I think it broke rubygem-ffi, too (which is blocking the ruby 2.7 rebuild,

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Kaleb Keithley
On Tue, Jan 21, 2020 at 7:36 AM Miro Hrončok wrote: > ... glusterfs... > > glusterfs and nfs-ganesha are already fixed upstream. They'll be fixed in their next minor release before it becomes necessary, or I will respin with patches sooner. -- Kaleb

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2020 at 01:42:25PM +0100, Fabio Valentini wrote: > I've seen this issue pop up in some other packages, as well. > > My elementary-files package is affected, and I think it broke > rubygem-ffi, too (which is blocking the ruby 2.7 rebuild, breaking a > lot of ruby packages; though I

Re: gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Fabio Valentini
On Tue, Jan 21, 2020 at 1:35 PM Miro Hrončok wrote: > > Hello, Hi Miro, > we try to rebuild all Python packages against Python 3.9 and report the > failures. I've seen several similar failures in a row now that can be > reproduced > in Fedora rawhide with the new gcc version. > > ld errors on

gcc 10: Default to -fno-common, multiple definitions of ...

2020-01-21 Thread Miro Hrončok
Hello, we try to rebuild all Python packages against Python 3.9 and report the failures. I've seen several similar failures in a row now that can be reproduced in Fedora rawhide with the new gcc version. ld errors on multiple definitions of ..., for example: ld: