Re: [PATCH v2 1/3] cpukit/flash: Add API for Flash devices

2023-04-17 Thread Chris Johns
On 18/4/2023 1:48 pm, Gedare Bloom wrote: > On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm > wrote: >> As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as >> it seamed a good balance between memory usage and function. I wanted to >> avoid using malloc as your previous

Re: [PATCH v2 1/3] cpukit/flash: Add API for Flash devices

2023-04-17 Thread Gedare Bloom
On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm wrote: > > Hi Gedare, > > Thanks for the feedback you’ve provided. I have a couple questions. > > You suggest refactoring the callouts into another sturct, I’m happy to do so. > I originally chose not to as I was was basing the high level structure

Re: [PATCH v2] bsps/aarch64: Enable MMU during remaps

2023-04-17 Thread Chris Johns
Looks good. OK to push. Chris On 18/4/2023 11:41 am, Kinsey Moore wrote: > The MMU must be enabled during mapping changes and TLB invalidations. > When this is not the case, TLB updates do not occur correctly in all > cases. This is especially apparent when changing a block entry to a > table

[PATCH v2] bsps/aarch64: Enable MMU during remaps

2023-04-17 Thread Kinsey Moore
The MMU must be enabled during mapping changes and TLB invalidations. When this is not the case, TLB updates do not occur correctly in all cases. This is especially apparent when changing a block entry to a table entry when remapping small memory ranges in an otherwise contiguous block. ---

Re: [PATCH] bsps/aarch64: Enable MMU during remaps

2023-04-17 Thread Hesham Almatary
On Mon, 17 Apr 2023 at 23:10, Kinsey Moore wrote: > > The MMU must be enabled during mapping changes and TLB invalidations. > When this is not the case, TLB updates do not occur correctly in all > cases. This is especially apparent when changing a block entry to a > table entry when remapping

[PATCH] bsps/aarch64: Enable MMU during remaps

2023-04-17 Thread Kinsey Moore
The MMU must be enabled during mapping changes and TLB invalidations. When this is not the case, TLB updates do not occur correctly in all cases. This is especially apparent when changing a block entry to a table entry when remapping small memory ranges in an otherwise contiguous block. ---

[PATCH v2 10/18] ptpd: Undefine FALSE and TRUE in ptp_primitives.h

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/ptp_primitives.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rtemsbsd/ptpd/src/ptp_primitives.h b/rtemsbsd/ptpd/src/ptp_primitives.h index 56ded20c..d70ae06e 100644 --- a/rtemsbsd/ptpd/src/ptp_primitives.h +++

[PATCH v2 08/18] ptpd: Define GLOB_ABORTED as GLOB_ABEND

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/sys.c | 4 1 file changed, 4 insertions(+) diff --git a/rtemsbsd/ptpd/src/dep/sys.c b/rtemsbsd/ptpd/src/dep/sys.c index bf459a62..b5831701 100644 --- a/rtemsbsd/ptpd/src/dep/sys.c +++ b/rtemsbsd/ptpd/src/dep/sys.c @@ -69,6 +69,10 @@ # include

[PATCH v2 16/18] ptpd: Add to build system

2023-04-17 Thread Gabriel Moyano
--- buildset/default.ini | 1 + libbsd.py| 49 +++- 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/buildset/default.ini b/buildset/default.ini index 88379a96..9145be9b 100644 --- a/buildset/default.ini +++ b/buildset/default.ini

[PATCH v2 03/18] ptpd: Add conditional macros for RTEMS

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/constants_dep.h | 5 +++-- rtemsbsd/ptpd/src/dep/net.c | 7 ++- rtemsbsd/ptpd/src/dep/ptpd_dep.h | 8 rtemsbsd/ptpd/src/dep/startup.c | 2 ++ rtemsbsd/ptpd/src/dep/sys.c | 7 ++- 5 files changed, 25

[PATCH v2 18/18] testsuite: Add test ptpd01

2023-04-17 Thread Gabriel Moyano
--- libbsd.py| 2 + testsuite/ptpd01/test_main.c | 171 +++ 2 files changed, 173 insertions(+) create mode 100644 testsuite/ptpd01/test_main.c diff --git a/libbsd.py b/libbsd.py index 0b215f48..510d28e0 100644 --- a/libbsd.py +++ b/libbsd.py

[PATCH v2 14/18] ptpd: Includes needed to compile statistics dependencies for RTEMS

2023-04-17 Thread Gabriel Moyano
--- rtemsbsd/ptpd/src/ptpd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rtemsbsd/ptpd/src/ptpd.h b/rtemsbsd/ptpd/src/ptpd.h index d8bb4b1e..e0e2b1ac 100644 --- a/rtemsbsd/ptpd/src/ptpd.h +++ b/rtemsbsd/ptpd/src/ptpd.h @@ -169,13 +169,13 @@ #include "timingdomain.h"

[PATCH v2 07/18] ptpd: Saving rtOpst in ptpClock earlier

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/startup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rtemsbsd/ptpd/src/dep/startup.c b/rtemsbsd/ptpd/src/dep/startup.c index 97231d99..ace980fa 100644 --- a/rtemsbsd/ptpd/src/dep/startup.c +++

[PATCH v2 12/18] ptpd: XMALLOC macro defined for RTEMS

2023-04-17 Thread Gabriel Moyano
--- rtemsbsd/ptpd/src/ptpd.h | 9 + 1 file changed, 9 insertions(+) diff --git a/rtemsbsd/ptpd/src/ptpd.h b/rtemsbsd/ptpd/src/ptpd.h index 08090317..387d6525 100644 --- a/rtemsbsd/ptpd/src/ptpd.h +++ b/rtemsbsd/ptpd/src/ptpd.h @@ -183,12 +183,21 @@ /* NOTE: this macro can be

[PATCH v2 11/18] ptpd: Rename main function for RTEMS

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/ptpd.c | 4 1 file changed, 4 insertions(+) diff --git a/rtemsbsd/ptpd/src/ptpd.c b/rtemsbsd/ptpd/src/ptpd.c index 3462dd21..f1026f3b 100644 --- a/rtemsbsd/ptpd/src/ptpd.c +++ b/rtemsbsd/ptpd/src/ptpd.c @@ -75,7 +75,11 @@ PtpClock *G_ptpClock =

[PATCH v2 15/18] ptpd: Add config file

2023-04-17 Thread Gabriel Moyano
--- rtemsbsd/include/ptpd/config.h | 248 + 1 file changed, 248 insertions(+) create mode 100644 rtemsbsd/include/ptpd/config.h diff --git a/rtemsbsd/include/ptpd/config.h b/rtemsbsd/include/ptpd/config.h new file mode 100644 index ..a050a3f9 ---

[PATCH v2 17/18] rtemsbsd: Add ptpd as a shell command

2023-04-17 Thread Gabriel Moyano
--- libbsd.py | 2 + rtemsbsd/include/machine/rtems-bsd-commands.h | 2 + rtemsbsd/include/rtems/ptpd.h | 20 + rtemsbsd/ptpd/rtems/ptpd.c| 78 +++ rtemsbsd/rtems/rtems-bsd-shell-ptpd.c | 66

[PATCH v2 09/18] ptpd: Add malloc definitions for RTEMS

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/sys.c | 16 1 file changed, 16 insertions(+) diff --git a/rtemsbsd/ptpd/src/dep/sys.c b/rtemsbsd/ptpd/src/dep/sys.c index b5831701..6c93bf4c 100644 --- a/rtemsbsd/ptpd/src/dep/sys.c +++ b/rtemsbsd/ptpd/src/dep/sys.c @@ -2668,3

[PATCH v2 13/18] ptpd: Add missing includes for RTEMS

2023-04-17 Thread Gabriel Moyano
--- rtemsbsd/ptpd/src/constants.h | 4 rtemsbsd/ptpd/src/dep/datatypes_dep.h | 7 +++ rtemsbsd/ptpd/src/dep/sys.c | 4 rtemsbsd/ptpd/src/ptpd.h | 6 ++ rtemsbsd/ptpd/src/timingdomain.c | 4 5 files changed, 25 insertions(+) diff --git

[PATCH v2 05/18] ptpd: Add missing cast in dictionary.c

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/iniparser/dictionary.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtemsbsd/ptpd/src/dep/iniparser/dictionary.c b/rtemsbsd/ptpd/src/dep/iniparser/dictionary.c index ffe35791..772ff8ce 100644 ---

[PATCH v2 04/18] ptpd: Add implementation of eventtimer based on kqueue

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/datatypes_dep.h | 10 ++ rtemsbsd/ptpd/src/dep/eventtimer.h| 6 +- rtemsbsd/ptpd/src/dep/eventtimer_kqueue.c | 184 ++ rtemsbsd/ptpd/src/dep/kqueue.c| 80 ++ rtemsbsd/ptpd/src/dep/net.c

[PATCH v2 06/18] ptpd: Add debug prints for ipv4 in net.c

2023-04-17 Thread Gabriel Moyano
From: Chris Johns --- rtemsbsd/ptpd/src/dep/net.c | 12 1 file changed, 12 insertions(+) diff --git a/rtemsbsd/ptpd/src/dep/net.c b/rtemsbsd/ptpd/src/dep/net.c index edee5dc6..a0f44098 100644 --- a/rtemsbsd/ptpd/src/dep/net.c +++ b/rtemsbsd/ptpd/src/dep/net.c @@ -102,6 +102,12 @@

[PATCH v2 00/18] Port PTPd to rtems-libbsd

2023-04-17 Thread Gabriel Moyano
In this second version, the files were moved to rtemsbsd/ptpd. Chris Johns (9): ptpd: Add conditional macros for RTEMS ptpd: Add implementation of eventtimer based on kqueue ptpd: Add missing cast in dictionary.c ptpd: Add debug prints for ipv4 in net.c ptpd: Saving rtOpst in ptpClock

[PATCH v2 02/18] ptpd: Add VERSION file

2023-04-17 Thread Gabriel Moyano
--- rtemsbsd/ptpd/rtems/VERSION | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 rtemsbsd/ptpd/rtems/VERSION diff --git a/rtemsbsd/ptpd/rtems/VERSION b/rtemsbsd/ptpd/rtems/VERSION new file mode 100644 index ..4c95e563 --- /dev/null +++ b/rtemsbsd/ptpd/rtems/VERSION