Re: [PATCH v2] pwdgrp.c: removed assert causing runtime issues

On 19/3/21 6:19 am, Joel Sherrill wrote: > On Thu, Mar 18, 2021 at 2:14 PM Gedare Bloom > wrote: > On Thu, Mar 18, 2021 at 11:40 AM Ryan Long > wrote: > > > > Changed the _Assert_unused_variable_equals macro to just a (void)

Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

On 19/3/21 4:49 am, Joel Sherrill wrote: > On Thu, Mar 18, 2021 at 12:33 PM Stephen Clark > wrote: > > Using 32bit types like uint32_t for pointers creates issues on 64 bit > architectures like AArch64. Replaced occurrences of these with uintptr_t, >

Re: [PATCH 1/4] eng: Update EARS syntax

On 18/3/21 4:50 pm, Sebastian Huber wrote: > On 18/03/2021 01:43, Chris Johns wrote: > >> On 18/3/21 4:34 am, Sebastian Huber wrote: >>> The document used the EARS syntax from 2009 which slightly changed in >>> 2016, see "Listens Learned (8 Lessons Learned App

PTP on RTEMS

Hello, I have created a tarball of my PTP efforts so far: https://ftp.rtems.org/pub/rtems/people/chrisj/ptp/ It is a collection of sources I have as a WIP that you link into an application. This is a development technique I use to avoid building multiple libraries. The package contains: -

Re: [PATCH 1/4] eng: Update EARS syntax

On 18/3/21 4:34 am, Sebastian Huber wrote: > The document used the EARS syntax from 2009 which slightly changed in > 2016, see "Listens Learned (8 Lessons Learned Applying EARS)". The > optional pre-conditions moved to the state-driven pattern. This refined > syntax fits better to the action

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 9:56 am, Joel Sherrill wrote: > On Tue, Mar 16, 2021, 4:47 PM Alex White > wrote: > > > Do any non-compiler-generated symbols include "."? > > Yes, according to the output of nm: > > $ i386-rtems6-nm

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 8:16 am, Alex White wrote: > Assuming I'm sending a v4 of this patch out, should I add the explanation of > the compiler-generated suffixes to the commit message or perhaps as a comment > in the code? Yes if you think it helps. In the end what you are doing makes the tool work and

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

On 17/3/21 2:14 am, Gedare Bloom wrote: > On Tue, Mar 16, 2021 at 1:15 AM Niteesh G. S. wrote: >> On Tue, 16 Mar 2021, 1:37 am Gedare Bloom, wrote: >>> >>> This one looks ok to me, Niteesh? >> >> +1 >> >> The below question is not related to this patch. >> >> Out of interest, I started going

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

On 17/3/21 2:05 am, Alex White wrote: > I’m not sure if I have seen an example of method split into more than one > piece. > It has been a while since I made this fix. > > A specific test executable that shows the suffixes is > testsuites/libtests/block08.exe, but most (if not all) of them

Re: [PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

On 16/3/21 11:49 am, Joel Sherrill wrote: > On Mon, Mar 15, 2021, 6:10 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 15/3/21 2:21 pm, Joel Sherrill wrote: > > On Sun, Mar 14, 2021, 9:27 PM Chris Johns <mailto:chr...@rtems.org> > >

Re: [PATCH] covoar: Handle periods in symbols from objdump

On 16/3/21 8:26 am, Alex White wrote: > The exceptions are being used as legitimate error cases. The "what" messages > that I use here are not helpful. I think that's why it looks like they're > being used as labels. Understood and thanks. > As part of a revision of my "covoar: Fix NOP

Re: [PATCH v2] covoar: Handle periods in symbols from objdump

On 16/3/21 9:04 am, Alex White wrote: > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > This looks to be related to compiler optimizations. Such symbols were > being treated as unique. For our purposes,

Re: [PATCH v2 0/4] coverage/reports: Improve coverage reports

OK. Nice change and thank you. Chris On 16/3/21 9:09 am, Alex White wrote: > v2: > - Replace tab expansion function in ReportsBase with std::string version > > This patch set includes a few improvements to the coverage reports. > > Alex White (4): > covoar/reports: Add new statistics to

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 16/3/21 10:00 am, Joel Sherrill wrote: On Mon, Mar 15, 2021 at 5:58 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > On 16/3/21 9:11 am, Gedare Bloom wrote: > > On Mon, Mar 15, 2021 at 3:34 PM Alex White <mailto:alex.wh...@oarcorp.com> > >

Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

On 16/3/21 10:07 am, Joel Sherrill wrote: > On Mon, Mar 15, 2021 at 6:01 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > On 16/3/21 6:55 am, Joel Sherrill wrote: > > > > > > On Mon, Mar 15, 2021 at 2:46 PM Gedare Bloom <mailto:g

Re: [PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

On 15/3/21 2:21 pm, Joel Sherrill wrote: > On Sun, Mar 14, 2021, 9:27 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > On 13/3/21 2:18 am, Ryan Long wrote: > > CID 1439298: Resource leak in rtems_fdisk_initialize(). > > > > Closes #4299 >

Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

On 16/3/21 6:55 am, Joel Sherrill wrote: > > > On Mon, Mar 15, 2021 at 2:46 PM Gedare Bloom <mailto:ged...@rtems.org>> wrote: > > On Sun, Mar 14, 2021 at 8:27 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 13/3/21

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 16/3/21 9:11 am, Gedare Bloom wrote: > On Mon, Mar 15, 2021 at 3:34 PM Alex White > wrote: > > I honestly can't remember why I changed 1024 to 20,000. > > I've looked back at that code and changed it back to 1024 without any > issues. I think I

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 16/3/21 8:34 am, Alex White wrote: > I honestly can't remember why I changed 1024 to 20,000. > > I've looked back at that code and changed it back to 1024 without any issues. > I think I might have missed that this is all happening in a loop, and at one > point during a (long) debugging

Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

On 13/3/21 2:18 am, Ryan Long wrote: > CID 26032: Resource leak in rtems_shell_hexdump_rewrite(). > > Closes #4296 > --- > cpukit/libmisc/shell/hexdump-parse.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/cpukit/libmisc/shell/hexdump-parse.c >

Re: [PATCH] covoar: Handle periods in symbols from objdump

On 13/3/21 3:37 am, Alex White wrote: > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > This looks to be related to compiler optimizations. Such symbols were > being treated as unique. For our purposes,

Re: [PATCH v3 1/2] covoar: Fix NOP execution marking

This v3 set is blocked by the v2 questions I have raised. Chris On 13/3/21 2:48 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ >

Re: [PATCH 5/5] rtl-shell.c: Resource leak (CID #1444140)

On 13/3/21 2:18 am, Ryan Long wrote: > CID 1444140: Resource leak in rtems_rtl_shell_object(). > > Closes #4300 > --- > cpukit/libdl/rtl-shell.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/cpukit/libdl/rtl-shell.c b/cpukit/libdl/rtl-shell.c > index 9f8a136..bcecdd4 100644 > ---

Re: [PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

On 13/3/21 2:18 am, Ryan Long wrote: > CID 1439298: Resource leak in rtems_fdisk_initialize(). > > Closes #4299 > --- > cpukit/libblock/src/flashdisk.c | 42 > ++--- > 1 file changed, 31 insertions(+), 11 deletions(-) > > diff --git

Re: [PATCH v2] shell.c: Fix Dereference after null check (CID #26083)

Sorry, this patch is blocked by the v1 thread. Chris On 12/3/21 9:17 am, Ryan Long wrote: > CID 26083: Dereference after null check in rtems_shell_login(). > > Closes #4327 > --- > cpukit/libmisc/shell/shell.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

On 12/3/21 5:30 am, Alex White wrote: > There was a potential that the branch info loop never terminated. > This has been fixed by adding a more reliable termination condition > and logging an error if it cannot find the branch target. > --- > tester/covoar/CoverageReaderQEMU.cc | 11 +--

Re: [PATCH 1/2] covoar: Fix NOP execution marking

On 12/3/21 3:18 am, Gedare Bloom wrote: > On Thu, Mar 11, 2021 at 9:01 AM Alex White wrote: >> >> Hi Chris, >> >> Good catch. That looks to be left over from some debugging I was doing. >> > I caught what you did there. Ha, ha, ha, I hope you don't take > exception to my pun. I tried to restrain

Re: [PATCH v2 1/2] covoar: Fix NOP execution marking

On 12/3/21 3:14 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ > tester/covoar/CoverageMapBase.h | 4 ++ >

Re: [PATCH] shell.c: Dereference after null check (CID #26083)

On 12/3/21 2:56 am, Ryan Long wrote: > After talking with Joel, we determined that 'out' shouldn’t be NULL by the > time it gets to rtems_shell_login(). Did you examine telnet use cases, nested shell calls (eg nesting joel scripts), telnet and joel scripts, and then the various options that can

Re: [PATCH] covoar: Fix DWARF reading

On 14/3/21 8:43 am, Joel Sherrill wrote: > On Fri, Mar 12, 2021 at 5:47 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > These are design question and not review issues > > On 12/3/21 5:33 am, Alex White wrote: > > +  // Create data based on

Re: [PATCH] covoar: Fix DWARF reading

These are design question and not review issues On 12/3/21 5:33 am, Alex White wrote: > + // Create data based on target. > + TargetInfo = Target::TargetFactory( buildTarget ); Any pointers in this object given there is a copy operator at work here? > + // Create the set of desired

Re: [PATCH] sb/config.py: Fix operator reconstruction

On 12/3/21 3:55 am, Vijay Kumar Banerjee wrote: > Hi, > > Pushed the patches to upstream and 5. Thank you! > Thank you for the testing and Ricardo thank you for the fix. Excellent work. Chris ___ devel mailing list devel@rtems.org

Re: RSB build breaks

On 11/3/21 4:38 pm, Vijay Kumar Banerjee wrote: > Hello, > > After fixing the logical error in the parser, it exposed another issue that's > causing RSB to break. Strange that it was hidden for so long. > > I have filed a ticket with details: http://deveone linel.rtems.org/ticket/4335 >

Re: [PATCH 1/2] covoar: Fix NOP execution marking

On 11/3/21 10:33 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ > tester/covoar/CoverageMapBase.h | 4 ++ >

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

On 9/3/21 5:28 pm, Gedare Bloom wrote: > On Mon, Mar 8, 2021 at 11:04 PM Sebastian Huber > wrote: >> >> On 09/03/2021 06:47, Gedare Bloom wrote: >> >> I would just use a comment which is understood by GCC, clang, and >> Coverity. What does Linux use? >> > That's fine, if there

Re: Standalone repository for libnetworking stack

On 11/3/21 5:14 am, Joel Sherrill wrote: > > > On Wed, Mar 10, 2021 at 11:48 AM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 11/3/21 1:11 am, Joel Sherrill wrote: > > On Tue, Mar 9, 2021 at 11:00 PM Vijay Kumar Banerjee <mai

Re: Qemu on Zynq Hanging

On 11/3/21 5:17 am, Joel Sherrill wrote: > On Wed, Mar 10, 2021 at 11:42 AM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 11/3/21 1:22 am, Joel Sherrill wrote: > > I see qemu hanging for days testing zynq. This is on the Xeon Centos > compu

Re: [PATCH RSB] sb/config.py: Fix relational operator

On 11/3/21 5:32 am, Vijay Kumar Banerjee wrote: > On Wed, Mar 10, 2021 at 10:53 AM Chris Johns wrote: >> >> Nice find and thanks. OK to push. >> > Pushed to master. > >> I think this should also be applied to the 5 branch. >> > Do I need to make any

Re: Flashdisk driver based on spidev

On 11/3/21 12:59 am, jan.som...@dlr.de wrote: > Hello, > > We will probably at some point need support for Micron-based NOR-flash > devices to store data which are connected via SPI. > I found the flashdisk API in RTEMS and was wondering if I understand > everything correctly. > My idea would

Re: RSB build issue with rtems-libbsd

On 9/3/21 3:53 pm, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 7:57 PM Chris Johns wrote: >> >> On 9/3/21 1:44 pm, Vijay Kumar Banerjee wrote: >>> On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: >>>> On Mon, Mar 8, 2021, 4:02 PM Chris Johns

Re: [PATCH RSB v2] Add recipe for building rtems-net-legacy

Thanks, this looks good and is OK to push. Chris On 10/3/21 5:33 am, Vijay Kumar Banerjee wrote: > --- > rtems/config/6/rtems-net-legacy.bset | 4 + > rtems/config/tools/rtems-net-legacy-6.cfg | 12 +++ > .../config/tools/rtems-net-legacy-common.cfg | 78 +++ > 3

Re: [PATCH, RSB] sparc, leon: GCC-7.5 patch needed for LEON3FT TN0018 errata

On 10/3/21 2:15 am, Sebastian Huber wrote: > On 09/03/2021 15:19, Daniel Hellstrom wrote: > >> Set the __FIX_LEON3FT_TN0018 define for the affected LEON3FT multilibs: >>   * UT699 >>   * UT700 >>   * GR712RC >> >> Update #4322. > This change is fine. Same, OK. Chris

Re: [PATCH v5 0/3] Add cadence-SPI driver

OK to push from me. On 9/3/21 10:22 pm, Jan Sommer wrote: > v5: > - Add some documentation > - Thanks for testing by Rick van der Wal > - Fix bug in CS logic > - Work-around too slow RXNEMPTY flag for some bus frequencies > - Created issue in trac: https://devel.rtems.org/ticket/4320 > >

Re: [PATCH RSB] sb/config.py: Fix relational operator

Nice find and thanks. OK to push. I think this should also be applied to the 5 branch. Chris On 10/3/21 5:32 am, Vijay Kumar Banerjee wrote: > Close #4319 > --- > source-builder/sb/config.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/source-builder/sb/config.py

Re: [PATCH 0/3] tester: Fix RLD classes for covoar

On 10/3/21 7:47 am, Alexander White wrote: > I can confirm that they do compile on Windows. Thanks. As stated OK to push :) Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: Standalone repository for libnetworking stack

On 11/3/21 1:11 am, Joel Sherrill wrote: > On Tue, Mar 9, 2021 at 11:00 PM Vijay Kumar Banerjee <mailto:vi...@rtems.org>> wrote: > > On Tue, Mar 9, 2021 at 9:56 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 10/3/21 3:51 p

Re: Qemu on Zynq Hanging

On 11/3/21 1:22 am, Joel Sherrill wrote: > I see qemu hanging for days testing zynq. This is on the Xeon Centos computer > I > use for batch and automated testing. > > This is ps but top shows six qemu processes having around 2231:52 in CPU time > used and using 100% CPU. Luckily this machine

Re: Standalone repository for libnetworking stack

On 10/3/21 3:51 pm, Gedare Bloom wrote: > On Tue, Mar 9, 2021 at 6:58 PM Joel Sherrill wrote: >> On Tue, Mar 9, 2021, 3:28 PM Vijay Kumar Banerjee wrote: >>> On Fri, Mar 5, 2021 at 10:03 AM Vijay Kumar Banerjee >>> wrote: >>> In this proposed set of patches, I have removed telnetd from RTEMS

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

On 9/3/21 2:03 pm, Vijay Kumar Banerjee wrote: > Hi Chris, > > Thanks for reviewing. > > On Mon, Mar 8, 2021 at 7:54 PM Chris Johns wrote: >> >> Hi Vijay, >> >> Thank you for sorting this out. >> >> On 9/3/21 1:31 pm, Vijay Kumar Ba

Re: RSB build issue with rtems-libbsd

On 9/3/21 1:44 pm, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: >> On Mon, Mar 8, 2021, 4:02 PM Chris Johns wrote: >>> >>> On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: >>>> Hello, >>>> >>>> I'

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

Hi Vijay, Thank you for sorting this out. On 9/3/21 1:31 pm, Vijay Kumar Banerjee wrote: > --- > rtems/config/6/rtems-net-legacy.bset | 4 ++ > rtems/config/tools/rtems-net-legacy-6.cfg | 12 > .../config/tools/rtems-net-legacy-common.cfg | 65 +++ > 3 files

Re: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

On 9/3/21 1:24 pm, Kinsey Moore wrote: > I was working under the impression that I didn't need it since RTEMS uses a > flat > memory model. I'll be spending some time tomorrow seeing what it will take to > enable usage of the "normal" memory model via a configured MMU. Most architectures with

Re: [PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

On 9/3/21 1:21 pm, Kinsey Moore wrote: > The patch to the if_cgem driver is actually a modified (to LibBSD style) > backport of the > 64bit cgem patch that's in 13. FreeBSD doesn't appear to care about ILP32 and > that is > the majority of functional difference between the upstream and what is

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

On 6/3/21 6:04 am, Gedare Bloom wrote: > On Fri, Mar 5, 2021 at 11:48 AM Sebastian Huber > wrote: >> >> On 05/03/2021 19:40, Joel Sherrill wrote: >> >>> On Fri, Mar 5, 2021, 12:25 PM Sebastian Huber >>> >> > wrote: >>> >>> On 05/03/2021 16:27, Gedare

Re: [5 PATCH 0/2] Backport fixes to zynq uart to RTEMS5

OK for 5. On 6/3/21 5:58 am, Jan Sommer wrote: > This patchset backports the commits of Kinsey Moore and myself, which > fix the stdin behavior for the zynq-uart based console driver. > I checked the behavior on hardware with the termios.exe application. > Before, the scanf and similar functions

Re: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

On 9/3/21 10:40 am, Kinsey Moore wrote: > So after a little more diving into this, I have found why --strict-align is > required. > If the MMU is disabled, all memory is treated as device memory which requires > strictly aligned accesses. I think I have missed something or not understanding the

Re: [PATCH v1 1/7] rtembsd: Fix alignment of allocations for 64bit

OK for 1 to 7 from me. In regards to the if_ cgem driver, will any be posted up stream? Chris On 9/3/21 10:27 am, Kinsey Moore wrote: > Alignment on 64bit hardware is strict in comparison to running in an > emulator. This resolves an alignment exception when allocating memory on > real

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

On 9/3/21 9:10 am, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 3:06 PM Chris Johns wrote: >> >> On 6/3/21 6:18 am, Vijay Kumar Banerjee wrote: >>> Pushed. :) >> >> I did not see any vc posts and the archive does not show any. Are the repo's >> h

Re: [PATCH rtems-net-legacy] netlegacy: Build libtelnetd.a and install header file in correct location

On 6/3/21 6:18 am, Vijay Kumar Banerjee wrote: > Pushed. :) I did not see any vc posts and the archive does not show any. Are the repo's hooks working? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: RSB build issue with rtems-libbsd

On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: > Hello, > > I'm getting the following error when trying to build rtems-libbsd from > RSB. Is there anything that I'm missing? > > ``` > ../source-builder/sb-set-builder --prefix=$RTEMS6_PREFIX > 6/rtems-libbsd --host=powerpc-rtems6

Re: [PATCH] wscript: Add post-build processing support

On 5/3/21 6:29 am, Sebastian Huber wrote: > On 04/03/2021 20:15, Kinsey Moore wrote: > >> -Original Message- >> From: Sebastian Huber >> Sent: Thursday, March 4, 2021 12:57 >> To: Kinsey Moore ; devel@rtems.org >> Subject: Re: [PATCH] wscript: Add post-build processing support >> >>> On

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On 5/3/21 4:42 am, Johnson, Andrew N. wrote: > On Mar 3, 2021, at 6:45 PM, Chris Johns via Core-talk <mailto:core-t...@aps.anl.gov>> wrote: >> >> We should encourage users to add BSP build stacks to the RSB. I remember >> Andrew >> Johnson posted on for

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On 5/3/21 1:26 am, Joel Sherrill wrote: > Eventually the NFSv2 client will need to be in the legacy stack  > package. But until the port of the FreeBSD NFSv4 client is available > in libbsd, the existing NFSv2 client has to be used for both stacks. The NFSv2 (and RPC?) code can be moved from

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

On 5/3/21 2:41 am, Gedare Bloom wrote: > On Thu, Mar 4, 2021 at 12:32 AM Chris Johns wrote: >> >> On 4/3/21 5:53 pm, Sebastian Huber wrote: >>> On 04/03/2021 00:18, Chris Johns wrote: >>>> On 3/3/21 7:48 pm, Sebastian Huber wrote: >>>>> On 03/

Re: [PATCH] MAINTAINERS: Add myself to write after approval

Approved. Welcome and congratulations on your commit access. Chris On 4/3/21 6:32 pm, jan.som...@dlr.de wrote: > Could someone approve this patch, please? > > Best regards, > > Jan > >> -Original Message- >> From: Sommer, Jan >> Sent: Thursday, February 25, 2021 2:05 PM >> To:

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

On 4/3/21 5:53 pm, Sebastian Huber wrote: > On 04/03/2021 00:18, Chris Johns wrote: >> On 3/3/21 7:48 pm, Sebastian Huber wrote: >>> On 03/03/2021 08:52, Chris Johns wrote: >>>> Then I hit minimum and some validation tests and they failed because I had >>>&g

Re: [PATCH 0/3] tester: Fix RLD classes for covoar

On 4/3/21 4:01 am, Alex White wrote: > This patch set contains changes to RLD classes necessary for covoar. > > Alex White (3): > rld-dwarf: Add function::has_entry_pc > rld-dwarf: Fix file::get_source > rld-process: Add named tempfile constructor > > rtemstoolkit/rld-dwarf.cpp | 13

Re: [PATCH rtems 5] powerpc/beatnik/net: Remove unused files

On 4/3/21 6:36 am, Gedare Bloom wrote: > yes, all changes to release branches need a ticket OK from me to push to 5 with a ticket. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

Hi, Well done on the hardware testing. On 4/3/21 9:15 am, Vijay Kumar Banerjee wrote: > On Wed, Mar 3, 2021 at 2:32 PM Joel Sherrill wrote: >> >> On Wed, Mar 3, 2021, 2:49 PM Heinz Junkes wrote: >>> >>> Hallo Vijay, >>> I still have to ask a question ;-) >>> >>> When building EPICS, we

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

On 3/3/21 7:48 pm, Sebastian Huber wrote: > On 03/03/2021 08:52, Chris Johns wrote: >> Then I hit minimum and some validation tests and they failed because I had >> removed bsp/default-initial-extension.h and I suppose it needs to come via >> bsp.h >> however it includ

Re: [PATCH 00/22] tester: Update covoar for new build system

On 4/3/21 2:08 am, Alexander White wrote: > I have only tested it on Ubuntu 20.10. I am working on getting it tested on > FreeBSD 12.2 as well. Excellent. Could you please make sure covoar builds on Windows under MSYS2 and cygwin (we have a user on cygwin)? Actual testing on Windows is up to you

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

On 19/2/21 9:02 am, Chris Johns wrote: > On 17/2/21 4:54 pm, Sebastian Huber wrote: >> On 17/02/2021 03:20, Chris Johns wrote: >>> On 16/2/21 5:49 pm, Chris Johns wrote: >>>> On 16/2/21 5:05 pm, Sebastian Huber wrote: >>>> I prefer the first option with

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

On 2/3/21 7:26 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 02.03.21 um 01:03 schrieb Chris Johns: >> On 1/3/21 7:24 pm, Christian MAUDERER wrote: >>> Hello Chris, >>> >>> thanks for the review. >>> >>> Am 26.02.21 um 19:04 schr

Re: [PATCH 01/22] tester: Update to support new build system

On 3/3/21 10:06 am, Joel Sherrill wrote: > On Tue, Mar 2, 2021 at 4:48 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 3/3/21 3:54 am, Gedare Bloom wrote: > > On Tue, Mar 2, 2021 at 8:52 AM Joel Sherrill <mailto:j...@rtems.org>> wrote: >

Re: [PATCH 09/22] covoar: Fix DWARF reading

On 3/3/21 10:32 am, Joel Sherrill wrote: > On Tue, Mar 2, 2021 at 5:16 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 2/3/21 7:01 am, Alex White wrote: > > There were a couple of issues with the way the DWARF info was being > > read. The first i

Re: [PATCH 18/22] covoar: Add option to create named objdumps

On 2/3/21 7:01 am, Alex White wrote: > This adds a new macro USE_TEMPLFILE which allows the creation of named > objdump outputs in the /tmp directory. This allows the outputs to be > reused on subsequent runs of covoar rather than running objdump again. Is the USE_TEMPLFILE macro a debugging aid?

Re: [PATCH 10/22] dwarf: Fix get_source

On 2/3/21 7:01 am, Alex White wrote: > The file::get_source method was giving "unknown:-1" for valid > addresses. This has been fixed. +1 Chris > --- > rtemstoolkit/rld-dwarf.cpp | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/rtemstoolkit/rld-dwarf.cpp

Re: [PATCH 09/22] covoar: Fix DWARF reading

On 2/3/21 7:01 am, Alex White wrote: > There were a couple of issues with the way the DWARF info was being > read. The first issue was that it inefficiently included all symbols, > even symbols that were not desired. The second issue is that it did > not handle inline functions correctly. These

Re: [PATCH 02/22] tester: Add coverage variants for a few BSPs

On 2/3/21 7:01 am, Alex White wrote: > Adds coverage variants for the following BSPs: a53_qemu, pc686, > xilinx_zynq_a9_qemu, and xilinx_zynqmp. > --- > tester/rtems/testing/bsps/a53_qemu-cov.ini| 41 ++ > tester/rtems/testing/bsps/pc-qemu-cov.ini | 42 +++

Re: [PATCH 01/22] tester: Update to support new build system

On 3/3/21 3:54 am, Gedare Bloom wrote: > On Tue, Mar 2, 2021 at 8:52 AM Joel Sherrill wrote: >> On Tue, Mar 2, 2021 at 9:46 AM Gedare Bloom wrote: >>> >>> On Mon, Mar 1, 2021 at 1:01 PM Alex White wrote: The tester configurations had not been updated to match the paths and

Re: [PATCH 00/22] tester: Update covoar for new build system

On 2/3/21 7:01 am, Alex White wrote: > This patch set updates the covoar tool to allow it to work with the > outputs of the current build system. It includes various fixes and > improvements needed to successfully produce coverage reports for the > following BSP configurations: griscv-sis,

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

On 1/3/21 7:24 pm, Christian MAUDERER wrote: > Hello Chris, > > thanks for the review. > > Am 26.02.21 um 19:04 schrieb Chris Johns: >> On 26/2/21 2:01 am, Christian Mauderer wrote: >>> Dynamically allocate a big enough file descriptor set for select(). A >&

Re: [5 PATCH] powerpc/motorola_power: Place any common data in the .bss section

On 28/2/21 3:15 am, Joel Sherrill wrote: > Looks good. Great. The patch has been independently tested. I will push a similar change to master without a review. I think it is safe to do that. Chris > > On Fri, Feb 26, 2021, 5:59 PM mailto:chr...@rtems.org>> > wrote: > &g

Re: [PATCH v2 0/4] Fix Unchecked return value Coverity errors

On 27/2/21 9:36 am, Gedare Bloom wrote: > v2 looks good to me +1 > > On Fri, Feb 26, 2021 at 3:15 PM Ryan Long wrote: >> >> Hi, >> >> Here's the patches with the changes. >> >> Thanks, >> Ryan >> >> Ryan Long (4): >> printertask.c: Fix Unchecked return value (CID #1399710) >>

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

On 26/2/21 2:01 am, Christian Mauderer wrote: > Dynamically allocate a big enough file descriptor set for select(). A > better solution would be to use kqueue() instead of select(). > --- > .../racoon/rtems-bsd-racoon-session-data.h| 6 +-- > ipsec-tools/src/racoon/session.c |

Re: Standalone repository for libnetworking stack

devel about it. There are also quite a few with > RTEMS_NETWORKING defined. > >> This is awesome work and much appreciated. >> > Thank you. :) > >> On Fri, Feb 26, 2021 at 12:12 AM Gedare Bloom wrote: >>> >>> On Thu, Feb 25, 2021 at 6:06 PM Chris J

Re: Standalone repository for libnetworking stack

On 26/2/21 4:49 am, Vijay Kumar Banerjee wrote: > The stand-alone repository is very close to completion now and I could > use the networking01 test with the standalone repo and it successfully > runs on pc-qemu. Fantastic news. > The following are the links to the branches with the > final

Re: [PATCH 01/10] build: Generate build hash

On 26/2/21 2:18 am, Sebastian Huber wrote: > On 25/02/2021 09:42, Sebastian Huber wrote: >>> Should we look to use a list that is contained? A list that effects the >>> code on >>> the target? In a purest sense a hash created from the CU pieces in all >>> target >>> libraries would be ideal

Re: [PATCH 01/10] build: Generate build hash

On 25/2/21 7:42 pm, Sebastian Huber wrote: > On 25/02/2021 05:13, Chris Johns wrote: > >> On 25/2/21 12:57 am, Sebastian Huber wrote: >>> Update #4265. >>> --- >>>   wscript | 27 ++- >>>   1 file changed, 26 insertions(

Re: BSP Builder Results :(

On 26/2/21 8:33 am, junkes wrote: > With RTEMS6, frozen CPU even with the ubuntu mkimage: Thanks Heinz. We need to isolate and resolve this issue before removing autoconf. I do not think the powerpc bsps build with autotools at the moment so it is hard to say if there is an issue in the BSP or

Re: [PATCH 01/10] build: Generate build hash

On 25/2/21 12:57 am, Sebastian Huber wrote: > Update #4265. > --- > wscript | 27 ++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/wscript b/wscript > index 6626fafb74..83c7c446bb 100755 > --- a/wscript > +++ b/wscript > @@ -1359,6 +1359,30 @@ def

Re: [PATCH 02/10] rtems: Add rtems_get_build_hash()

On 25/2/21 12:57 am, Sebastian Huber wrote: > Update #4265. > --- > cpukit/Makefile.am | 1 + > cpukit/include/rtems/config.h | 36 +++- > cpukit/sapi/src/getbuildhash.c | 54 ++ > spec/build/cpukit/cfgbuildhash.yml | 14

Re: [PATCH 2/2] This adds a way to print the host triplet

On 25/2/21 9:21 am, Robin Müller wrote: > There is no first patch (the first patch file was a SIS update, but that's > already inside master I think). > I think I used this when I canadian cross-compiled the RTEMS ARM toolchain for > Windows on Linux and I was not sure what the triplet was. Great

Re: How do we know what priority of the Init task is?

On 24/2/21 6:13 pm, Sebastian Huber wrote: > On 23/02/2021 23:41, Chris Johns wrote: > >> On 24/2/21 9:26 am, dufa...@hda.com wrote: >>> I re-read Joel's mail and I agree, the priority should be left ridiculously >>> low (as it is now) or maybe set in the middl

Re: [PATCH rtems_waf] rtems: Add support to get arch bsp list in conf

On 25/2/21 5:01 am, Vijay Kumar Banerjee wrote: > This patch is a quick workaround to build the legacy net BSP drivers > in the rtems-net-legacy repo. Looks good. OK to push. Thanks ___ devel mailing list devel@rtems.org

Re: [5 PATCH] powerpc/motorola_power: Link all text sections into the executable image

On 25/2/21 3:33 am, Gedare Bloom wrote: > On Tue, Feb 23, 2021 at 11:07 PM wrote: >> >> From: Chris Johns >> >> - The change to building all code with code and data sections means >> we have a section per function. Make sure all functions are >> placed

Re: [PATCH 2/2] This adds a way to print the host triplet

On 25/2/21 5:23 am, Robin Mueller wrote: > Can be useful for cross-compiling toolchains What is the use case for the option? We cross compile tools by default so I am interested to understand where I would use this option. Thanks Chris ___ devel

Re: motorola_powerpc waf vs autoconf difference

> On 24 Feb 2021, at 6:08 pm, Sebastian Huber > wrote: > > On 24/02/2021 06:58, Chris Johns wrote: > >> I have noticed a difference in the build of RTEMS 6 waf compared to RTEMS 5 >> and >> autoconf. The bootloader object files are not built with the

motorola_powerpc waf vs autoconf difference

Hello, I have noticed a difference in the build of RTEMS 6 waf compared to RTEMS 5 and autoconf. The bootloader object files are not built with the code and data section options. This is preferred and I like it but I thought I would ask if this was intended? Thanks Chris

Re: How do we know what priority of the Init task is?

On 24/2/21 9:26 am, dufa...@hda.com wrote: > I re-read Joel's mail and I agree, the priority should be left ridiculously > low (as it is now) or maybe set in the middle (but why bother?). > > I was thinking about matching classic RTEMS behavior. I don't think it > matters in POSIX. The

<    10   11   12   13   14   15   16   17   18   19   >