Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-18 Thread Chris Johns
On 18/9/2023 10:09 pm, Sebastian Huber wrote: > On 17.09.23 00:58, Chris Johns wrote: >>> There are also no test cases for this function. >>> Without test cases it is easy to break something without knowing it. >> The libdl test cases have been updated to reference TLS newlib variables to >> test

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-18 Thread Sebastian Huber
On 17.09.23 00:58, Chris Johns wrote: There are also no test cases for this function. Without test cases it is easy to break something without knowing it. The libdl test cases have been updated to reference TLS newlib variables to test this. Is that enough? If not what would you like to see? T

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-16 Thread Chris Johns
On 15/9/2023 5:07 pm, Sebastian Huber wrote: > On 14.09.23 23:56, Chris Johns wrote: >> On 14/9/2023 7:33 pm, Sebastian Huber wrote: >>> On 14.09.23 10:51, Chris Johns wrote: On 14/9/2023 5:58 pm, Sebastian Huber wrote: > On 14.09.23 09:38, Chris Johns wrote: The issue I faced was

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-15 Thread Sebastian Huber
On 14.09.23 23:56, Chris Johns wrote: On 14/9/2023 7:33 pm, Sebastian Huber wrote: On 14.09.23 10:51, Chris Johns wrote: On 14/9/2023 5:58 pm, Sebastian Huber wrote: On 14.09.23 09:38, Chris Johns wrote: The issue I faced was no score interface to get the TLS base for a thread to determine

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Chris Johns
On 14/9/2023 7:33 pm, Sebastian Huber wrote: > On 14.09.23 10:51, Chris Johns wrote: >> On 14/9/2023 5:58 pm, Sebastian Huber wrote: >>> On 14.09.23 09:38, Chris Johns wrote: >> The issue I faced was no score interface to get the TLS base for a >> thread to >> determine a symbol's offs

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Joel Sherrill
On Thu, Sep 14, 2023 at 4:33 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 14.09.23 10:51, Chris Johns wrote: > > On 14/9/2023 5:58 pm, Sebastian Huber wrote: > >> On 14.09.23 09:38, Chris Johns wrote: > > The issue I faced was no score interface to get the TLS base

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Sebastian Huber
On 14.09.23 10:51, Chris Johns wrote: On 14/9/2023 5:58 pm, Sebastian Huber wrote: On 14.09.23 09:38, Chris Johns wrote: The issue I faced was no score interface to get the TLS base for a thread to determine a symbol's offset. If we had that and something to say if TLS is supported libdl woul

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Chris Johns
On 14/9/2023 5:58 pm, Sebastian Huber wrote: > On 14.09.23 09:38, Chris Johns wrote: The issue I faced was no score interface to get the TLS base for a thread to determine a symbol's offset. If we had that and something to say if TLS is supported libdl would be easy to fix. >>>

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Sebastian Huber
On 14.09.23 09:38, Chris Johns wrote: The issue I faced was no score interface to get the TLS base for a thread to determine a symbol's offset. If we had that and something to say if TLS is supported libdl would be easy to fix. Why don't we add this interface if it simplifies things? Yes please

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Chris Johns
On 14/9/2023 5:20 pm, Sebastian Huber wrote: > On 14.09.23 09:12, Chris Johns wrote: >> On 14/9/2023 4:55 pm, Sebastian Huber wrote: >>> On 14.09.23 08:34, Sebastian Huber wrote: This seems to break the mips build: cpukit/libdl/rtl-tls.c:104:2: error: #error unsupported architecture

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Sebastian Huber
On 14.09.23 09:12, Chris Johns wrote: On 14/9/2023 4:55 pm, Sebastian Huber wrote: On 14.09.23 08:34, Sebastian Huber wrote: This seems to break the mips build: cpukit/libdl/rtl-tls.c:104:2: error: #error unsupported architecture    104 | #error unsupported architecture    |  ^ Als

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-14 Thread Chris Johns
On 14/9/2023 4:55 pm, Sebastian Huber wrote: > On 14.09.23 08:34, Sebastian Huber wrote: >> This seems to break the mips build: >> >> cpukit/libdl/rtl-tls.c:104:2: error: #error unsupported architecture >>    104 | #error unsupported architecture >>    |  ^ >> > > Also the moxie and 64-bit

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-13 Thread Sebastian Huber
On 14.09.23 08:34, Sebastian Huber wrote: This seems to break the mips build: cpukit/libdl/rtl-tls.c:104:2: error: #error unsupported architecture   104 | #error unsupported architecture   |  ^ Also the moxie and 64-bit powerpc (qoriq_e6500_64) no longer build with the error above.

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-13 Thread Sebastian Huber
This seems to break the mips build: cpukit/libdl/rtl-tls.c:104:2: error: #error unsupported architecture 104 | #error unsupported architecture | ^ -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-8