[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

@lundman pushed 2 commits. 17d49e9 Raw DRR_OBJECT records must write raw data 590e210 Fix bounds check in zio_crypt_do_objset_hmacs -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[developer] Re: [openzfs/openzfs] DLPX-49012 nuke spa_dbgmsg (#580)

ahrens commented on this pull request. > @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio; #defineZFS_DEBUG_DNODE_VERIFY (1 << 2) #defineZFS_DEBUG_SNAPNAMES (1 << 3) #defineZFS_DEBUG_MODIFY(1 << 4) -#define

[developer] Re: [openzfs/openzfs] DLPX-49012 nuke spa_dbgmsg (#580)

richardelling commented on this pull request. > @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio; #defineZFS_DEBUG_DNODE_VERIFY (1 << 2) #defineZFS_DEBUG_SNAPNAMES (1 << 3) #defineZFS_DEBUG_MODIFY(1 << 4) -#define

[developer] Re: [openzfs/openzfs] Print stats since boot for first line (#581)

prakashsurya requested changes on this pull request. LGTM. Can you also add a comment where we call `snap_stats` from `init`? To me, that block: ``` # check if L2ARC exists snap_stats(); if (defined $cur{"l2_size"}) { $l2exist = 1; } ``` makes it

[developer] Re: [openzfs/openzfs] DLPX-49012 nuke spa_dbgmsg (#580)

ahrens commented on this pull request. > @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio; #defineZFS_DEBUG_DNODE_VERIFY (1 << 2) #defineZFS_DEBUG_SNAPNAMES (1 << 3) #defineZFS_DEBUG_MODIFY(1 << 4) -#define

[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

avg-I approved this pull request. Looked good for FreeBSD, still looks good. Thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/582#pullrequestreview-101320066

[developer] Re: [openzfs/openzfs] DLPX-49012 nuke spa_dbgmsg (#580)

richardelling commented on this pull request. > @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio; #defineZFS_DEBUG_DNODE_VERIFY (1 << 2) #defineZFS_DEBUG_SNAPNAMES (1 << 3) #defineZFS_DEBUG_MODIFY(1 << 4) -#define

[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

ahrens approved this pull request. I'm not sure that this design of having callers check `errno` is the best, but your fix seems reasonable given how this is used. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

8567 changed the return value of zpool_read_label. Error paths that previously returned 0 began to return -1 instead. However, not all error paths initialized errno. When adding vdevs to a very large pool, errno could be prepopulated with ENOMEM, causing the operation to fail. Fix the bug by

[developer] [openzfs/openzfs] Print stats since boot for first line (#581)

init() already calls snap_stats(), don't call it again the first time through. You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/581 -- Commit Summary -- * Print stats since boot for first line -- File Changes -- M

[developer] [openzfs/openzfs] DLPX-49012 nuke spa_dbgmsg (#580)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Pavel Zakharov Reviewed by: George Wilson We should use zfs_dbgmsg instead of spa_dbgmsg. Or at least, metaslab_condense() should call zfs_dbgmsg because

[developer] [openzfs/openzfs] 9235 rename zpool_rewind_policy_t to zpool_load_policy_t (#579)

Reviewed by: Matt Ahrens Reviewed by: George Wilson We want to be able to pass various settings during import/open of a pool, which are not only related to rewind. Instead of adding a new policy and duplicate a bunch of code, we should just rename

[developer] [openzfs/openzfs] DLPX-50219 reduce apic calibration error by taking multiple measurements (#578)

Reviewed by: George Wilson Reviewed by: Sebastien Roy Calibration of the APIC timer is currently performed by doing one mesurement at boot time. On some hypervisors, like Azure, the calibration can be quite off because timers are