Re: [developer] Adding a -p option to "zpool iostat"

2016-07-08 Thread Richard Elling
> On Jul 8, 2016, at 4:17 PM, Kai Storbeck wrote: > > Hello List, > > I'm new to the list, so please redirect me to the right place if I'm not at > the right place FYI, telegraf on Linux has an agent that collects (some of) this info and sends to a time-series database for

Re: [developer] ZFS - RAIDZ1 Recovery (Evgeny)

2016-06-03 Thread Richard Elling
> On Jun 3, 2016, at 10:56 AM, esamorokov wrote: > > Hello All, > > My name is Evgeny and I have 3 x 3TB in RAIDZ1, where one drive is gone > and I accidentally > screwed the other two. The data should be fine, just need to revert > uberblock in point of

Re: [developer] [openzfs/openzfs] 6418 zpool should have a label clearing command (#83)

2016-04-07 Thread Richard Elling
> On Apr 7, 2016, at 11:04 AM, ilove zfs wrote: > > Sorry, but https://www.illumos.org/issues/6477 > does not depend on the use of -f or > have anything to do with it really. The destruction occurs in the import step > without the

Re: [developer] [openzfs/openzfs] 6418 zpool should have a label clearing command (#83)

2016-04-07 Thread Richard Elling
> On Apr 5, 2016, at 5:56 PM, Jorgen Lundman wrote: > >> >> I agree, and "zpool labelclear" is going to clear the label. >> >> "zpool labelclear" is not going to overwrite something that isn't a zpool >> label, in part because I haven't heard any use case for it. > >

Re: [zfs] [developer] Re: [smartos-discuss] an interesting survey -- the zpool with most disks you have ever built

2016-03-07 Thread Richard Elling
> On Mar 6, 2016, at 9:06 PM, Fred Liu <fred.f...@gmail.com> wrote: > > > > 2016-03-06 22:49 GMT+08:00 Richard Elling <richard.ell...@richardelling.com > <mailto:richard.ell...@richardelling.com>>: > >> On Mar 3, 2016, at 8:35 PM, Fred Liu <

[developer] Re: [smartos-discuss] an interesting survey -- the zpool with most disks you have ever built

2016-03-06 Thread Richard Elling
> On Mar 3, 2016, at 8:35 PM, Fred Liu wrote: > > Hi, > > Today when I was reading Jeff's new nuclear weapon -- DSSD D5's CUBIC RAID > introduction, > the interesting survey -- the zpool with most disks you have ever built > popped in my brain. We test to 2,000 drives.

Re: [OpenZFS Developer] [zfs] Space accounting issues with refquota?

2016-01-07 Thread Richard Elling
Requirements question: if you have [ref]quota enforcement on the primary, do you also need enforcement on the replicant? In other words, is this really a space problem to be solved by quota or retention policy? -- richard ___ developer mailing list

Re: [OpenZFS Developer] [openzfs] 6393 zfs receive a full send as a clone (#23)

2015-11-15 Thread Richard Elling
LGTM, clever! --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/23#issuecomment-156852298___ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer

Re: [OpenZFS Developer] Review Request 261: DLPX-36432 Fix cstyle errors in zfs codebase

2015-10-13 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/261/#review831 --- Ship it! Ship It! - Richard Elling On Oct. 13, 2015, 5:26 p.m

Re: [OpenZFS Developer] Review Request 249: 6293 ztest failure: error == 28 (0xc == 0x1c) in ztest_tx_assign()

2015-10-07 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/249/#review821 --- Ship it! Ship It! - Richard Elling On Oct. 7, 2015, 3:10 a.m

Re: [OpenZFS Developer] Review Request 253: DLPX-31869 GRUB should try all DVAs

2015-10-07 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/253/#review816 --- Ship it! Ship It! - Richard Elling On Oct. 7, 2015, 3:15 a.m

Re: [OpenZFS Developer] Review Request 251: 6288 dmu_buf_will_dirty could be faster

2015-10-07 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/251/#review817 --- Ship it! Ship It! - Richard Elling On Oct. 7, 2015, 4:03 p.m

Re: [OpenZFS Developer] Review Request 240: 2605 want to resume interrupted zfs send

2015-10-04 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/240/#review795 --- Ship it! Ship It! - Richard Elling On Sept. 23, 2015, 3:48 p.m

Re: [OpenZFS Developer] Review Request 244: 6251 add tunable to disable free_bpobj processing

2015-09-23 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/244/#review785 --- Ship it! Ship It! - Richard Elling On Sept. 20, 2015, 5:57 p.m

Re: [OpenZFS Developer] Review Request 226: 1778 Assertion failed: rn-rn_nozpool == B_FALSE, file ../common/libzfs_import.c, line 1077, function zpool_open_func

2015-05-27 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/226/#review736 --- Ship it! Ship It! - Richard Elling On May 27, 2015, 1:51 p.m

Re: [OpenZFS Developer] Review Request 204: 5818 zfs {ref}compressratio is incorrect with 4k sector size

2015-05-16 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/204/#review723 --- Ship it! Ship It! - Richard Elling On May 16, 2015, 4:28 p.m

Re: [OpenZFS Developer] Strided prefetch -- good or evil?

2015-04-04 Thread Richard Elling
On Apr 4, 2015, at 9:08 AM, Matthew Ahrens mahr...@delphix.com wrote: Strided prefetch: mostly evil. Agree, we’ve routinely disabled on many workloads, especially virtualization workloads with many VMs. At the very least you can measure the effectiveness and determine whether prefetching

Re: [OpenZFS Developer] Review Request 189: 5770 Add load_nvlist() error handling

2015-03-29 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/189/#review598 --- Ship it! Ship It! - Richard Elling On March 29, 2015, 11:01 p.m

Re: [OpenZFS Developer] Review Request 151: 5497 lock contention on arcs_mtx

2015-01-02 Thread Richard Elling
when we see limits reached in production environments. At the time, the limit might not be important, but if we don't collect the data, we can't retrospect. For lab environments, we can track here with dtrace, and that is certainly an improvement. - Richard Elling On Dec. 30, 2014

Re: [OpenZFS Developer] Review Request 151: 5497 lock contention on arcs_mtx

2015-01-02 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/151/#review434 --- Ship it! Ship It! - Richard Elling On Dec. 30, 2014, 11 p.m

Re: [OpenZFS Developer] Review Request 151: 5497 lock contention on arcs_mtx

2015-01-01 Thread Richard Elling
? usr/src/uts/common/fs/zfs/arc.c https://reviews.csiden.org/r/151/#comment360 It seems to me that we want to bump an arcstat when we are overflowing. If we are consistently in this situation, then we need to balance the system elsewhere, perhaps outside of ZFS. - Richard Elling On Dec. 30

Re: [OpenZFS Developer] Review Request 139: 5369, 5370 arc code cleanup

2014-11-24 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/139/#review361 --- Ship it! Ship It! - Richard Elling On Nov. 23, 2014, 5:11 p.m

Re: [OpenZFS Developer] Review Request 138: 5368 ARC should cache more metadata

2014-11-24 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/138/#review362 --- Ship it! Ship It! - Richard Elling On Nov. 23, 2014, 5:08 p.m

Re: [OpenZFS Developer] Jsonify outputs

2014-11-19 Thread Richard Elling
On Nov 19, 2014, at 10:33 AM, Matthew Ahrens mahr...@delphix.com wrote: On Wed, Nov 19, 2014 at 10:08 AM, Joshua M. Clulow j...@sysmgr.org wrote: On 18 November 2014 13:55, Matthew Ahrens mahr...@delphix.com wrote: This seems a reasonable structure to me, except that I would make the

Re: [OpenZFS Developer] Jsonify outputs

2014-11-19 Thread Richard Elling
On Nov 19, 2014, at 11:42 AM, Yacine Kheddache yacine.khedda...@alyseo.com wrote: On Wed, Nov 19, 2014 at 8:23 PM, Richard Elling richard.ell...@richardelling.com wrote: On Nov 19, 2014, at 10:33 AM, Matthew Ahrens mahr...@delphix.com wrote: On Wed, Nov 19, 2014 at 10:08 AM, Joshua

Re: [OpenZFS Developer] Jsonify outputs

2014-11-19 Thread Richard Elling
On Nov 19, 2014, at 12:17 PM, Joshua M. Clulow j...@sysmgr.org wrote: On 19 November 2014 11:56, Richard Elling richard.ell...@richardelling.com wrote: On Nov 19, 2014, at 11:42 AM, Yacine Kheddache yacine.khedda...@alyseo.com wrote: I really do not understand why you guys would like

Re: [OpenZFS Developer] Jsonify outputs

2014-11-18 Thread Richard Elling
On Nov 18, 2014, at 10:18 AM, Matthew Ahrens mahr...@delphix.com wrote: On Tue, Nov 18, 2014 at 8:00 AM, Francois Billard francois.bill...@alyseo.com wrote: Matt, In C you use a structure with predefined fields names, it would be difficult to use it if names change every time ?

Re: [OpenZFS Developer] Review Request 136: 5351, 5352 scrub time fixes

2014-11-16 Thread Richard Elling
usr/src/uts/common/fs/zfs/dsl_scan.c https://reviews.csiden.org/r/136/#comment284 since we don't have to be very precise here, rather than divide, is it ok to shift 30? - Richard Elling On Nov. 16, 2014, 3:37 p.m., Matthew Ahrens wrote

Re: [OpenZFS Developer] Jsonify outputs

2014-11-07 Thread Richard Elling
! - Garrett On Sep 25, 2014, at 8:39 AM, Richard Elling richard.ell...@richardelling.com wrote: On Sep 24, 2014, at 10:55 PM, Robert Mustacchi r...@joyent.com wrote: On 9/24/14 22:51 , Matthew Ahrens wrote: On Mon, Sep 22, 2014 at 9:34 AM, Yacine Kheddache yacine.khedda

Re: [OpenZFS Developer] [developer] [develop] Possibility to physically reserve space in ZFS

2014-10-28 Thread Richard Elling
On Oct 28, 2014, at 9:02 AM, Daniil Lunev via illumos-developer develo...@lists.illumos.org wrote: (1) When a leaf block is filled in, the BP with the bit set is COW'd without the bit set. Correct? Correct. (2) Why even bother writing out the non-leaf blocks? Wouldn't just Some

Re: [OpenZFS Developer] [developer] [develop] Possibility to physically reserve space in ZFS

2014-10-28 Thread Richard Elling
On Oct 28, 2014, at 10:36 AM, Daniil Lunev daniil.lu...@nexenta.com wrote: On Tue, Oct 28, 2014 at 8:41 PM, Richard Elling via illumos-developer develo...@lists.illumos.org wrote: On Oct 28, 2014, at 9:02 AM, Daniil Lunev via illumos-developer develo...@lists.illumos.org wrote: (1

Re: [OpenZFS Developer] Review Request 118: 5243 zdb -b could be much faster

2014-10-26 Thread Richard Elling
for zfs_vdev_async_read_max_active 4, but the improvement is still useful - Richard Elling On Oct. 19, 2014, 6:20 a.m., Matthew Ahrens wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/118

Re: [OpenZFS Developer] Review Request 105: 5178 zdb -vvvvv on old-format pool fails in dump_deadlist()

2014-09-28 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/105/#review262 --- Ship it! Ship It! - Richard Elling On Sept. 17, 2014, 3:15 a.m

Re: [OpenZFS Developer] Review Request 103: 5176 lock contention on godfather zio

2014-09-28 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/103/#review263 --- Ship it! Ship It! - Richard Elling On Sept. 17, 2014, 3:04 a.m

Re: [OpenZFS Developer] Review Request 102: 5175 implement dmu_read_uio_dbuf() to improve cached read performance

2014-09-28 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/102/#review264 --- Ship it! Ship It! - Richard Elling On Sept. 17, 2014, 2:53 a.m

Re: [OpenZFS Developer] Debugging a Faulted raidz1 on zfs-fuse

2014-09-25 Thread Richard Elling
On Sep 25, 2014, at 5:15 AM, Venci Vatashki vvatas...@gmail.com wrote: Hello, I'm debugging a Faulted raidz1 on zfs-fuse.This is dev pool, created from loop devices and files. The way I broke is first to degrade pool by removing a device from it. After that do some transactions. ie copy

Re: [OpenZFS Developer] Jsonify outputs

2014-09-25 Thread Richard Elling
On Sep 24, 2014, at 10:55 PM, Robert Mustacchi r...@joyent.com wrote: On 9/24/14 22:51 , Matthew Ahrens wrote: On Mon, Sep 22, 2014 at 9:34 AM, Yacine Kheddache yacine.khedda...@alyseo.com wrote: Hi, I know this is an old topic : https://github.com/zfsonlinux/zfs/issues/740 And also

Re: [OpenZFS Developer] Review Request 104: 5177 remove dead code from dsl_scan.c

2014-09-17 Thread Richard Elling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/104/#review257 --- Ship it! Ship It! - Richard Elling On Sept. 17, 2014, 3:11 a.m

Re: [OpenZFS Developer] review request: 5027 zfs large block support

2014-09-08 Thread Richard Elling
HI Matt, I don't see anything of concern in the approach or the code. But it is unclear to me if it has been tested to 16MB in ztest or the zfs test suite? -- richard On Jul 20, 2014, at 9:34 PM, Matthew Ahrens m...@mahrens.org wrote: https://reviews.csiden.org/r/51/diff/# Note: this

Re: [OpenZFS Developer] [zfs] 4873 zvol unmap calls can take a very long time for larger datasets

2014-06-07 Thread Richard Elling
LGTM, thanks! -- richard On Jun 6, 2014, at 3:34 PM, Alex Reece a...@delphix.com wrote: http://reviews.csiden.org/r/45/ http://reviews.csiden.org/r/22/ Work by Alex Reece and Matt Ahrens. Note - Chris will be upgrading this review board instance for about 30 minutes on Saturday night

Re: [OpenZFS Developer] ARC performance improvements on ZoL; other implementations interested?

2014-02-28 Thread Richard Elling
On Feb 24, 2014, at 8:20 AM, Prakash Surya sur...@llnl.gov wrote: On Sun, Feb 23, 2014 at 06:56:39PM -0800, Richard Elling wrote: On Feb 10, 2014, at 11:26 AM, Prakash Surya sur...@llnl.gov wrote: -- Cheers, Prakash On Sun, Feb 09, 2014 at 10:28:44PM -0800, Richard Elling

Re: [OpenZFS Developer] RFC: zpool status -g

2013-12-29 Thread Richard Elling
On Dec 29, 2013, at 1:41 PM, Richard Yao r...@gentoo.org wrote: I have written a patch to permit system administrators to force display of vdev GUIDs by passing `-g` to `zpool status`. It is currently in a ZoL pull request: good idea! https://github.com/zfsonlinux/zfs/pull/2012 This