Re: [Development] Naming convention for (scoped) enums

2018-08-13 Thread Shawn Rutledge
On Aug 13, 2018, at 18:12, Giuseppe D'Angelo via Development wrote: > Il 13/08/2018 16:40, Tor Arne Vestbø ha scritto: >> Or: >> if (event->device()->pointerType() != QQuickPointerDevice::Finger >> Gives me all the info I need, and having to type or read this instead is >> worse in my

Re: [Development] Calendar classes: API review request

2018-08-13 Thread Edward Welbourne
On Dienstag, 31. Juli 2018 14:25:21 CEST Edward Welbourne wrote: >>> My primary concern with this API is that it promotes an unclear >>> ownership model. >> hmm ... this is partly a symptom of most QAbstractCalendar instances >> being dataless. Each calendar has different code to implement

Re: [Development] Naming convention for (scoped) enums

2018-08-13 Thread Edward Welbourne
Il 13/08/2018 16:40, Tor Arne Vestbø ha scritto: >>> Or: >>> if (event->device()->pointerType() != QQuickPointerDevice::Finger >>> Gives me all the info I need, and having to type or read this >>> instead is worse in my opinion: On 13 Aug 2018, at 18:12, Giuseppe D'Angelo via Development

Re: [Development] Naming convention for (scoped) enums

2018-08-13 Thread Tor Arne Vestbø
On 13 Aug 2018, at 18:12, Giuseppe D'Angelo via Development wrote: > > Il 13/08/2018 16:40, Tor Arne Vestbø ha scritto: >> Or: >> if (event->device()->pointerType() != QQuickPointerDevice::Finger >> Gives me all the info I need, and having to type or read this instead is >> worse in my

Re: [Development] Naming convention for (scoped) enums

2018-08-13 Thread Giuseppe D'Angelo via Development
Il 13/08/2018 16:40, Tor Arne Vestbø ha scritto: Or: if (event->device()->pointerType() != QQuickPointerDevice::Finger Gives me all the info I need, and having to type or read this instead is worse in my opinion: This is actually against the old "non-enum class" coding standards: one

Re: [Development] Coin maintenance notification: Master machine distro will be upgraded on Monday

2018-08-13 Thread Aapo Keskimölö
The Coin service is running again after some struggles with CI master disk running out of space so the storage had to be wiped again. The influxb observer is now enabled and is submitting data to Grafana. We will keep monitoring it to ensure that it does not cause any problems. -Original

Re: [Development] Naming convention for (scoped) enums

2018-08-13 Thread Tor Arne Vestbø
Bringing this up again in light of e.g. https://codereview.qt-project.org/#/c/235167/ When I gave my support to this I thought we were talking about global enums. I do not think that using class enums inside existing classes is a win for code readability/writability: When you have switch

Re: [Development] Merge and Integration status report - 2018.08.13

2018-08-13 Thread Jani Heikkinen
> -Original Message- > From: Development project.org> On Behalf Of Liang Qi > Sent: maanantai 13. elokuuta 2018 12.30 > To: development@qt-project.org > Subject: [Development] Merge and Integration status report - 2018.08.13 > > Integrations > > * qt5 5.11 integration is healthy, last

[Development] Merge and Integration status report - 2018.08.13

2018-08-13 Thread Liang Qi
Integrations * qt5 5.11 integration is healthy, last one is yesterday, August 12 * qt5 dev, last one is August 11, excluding qtbase since August 8 * * http://bugreports.qt.io/browse/QTBUG-69891 tests/auto/quick/drawingmodes hanging Tor Arne is working on that. But if can't get fix soon,

Re: [Development] Coin maintenance notification: Master machine distro will be upgraded on Monday

2018-08-13 Thread Aapo Keskimölö
The update was a success, but the process took a bit longer than expected. Coin is currently busy with building qt/qt5 binaries for dev+5.11 and this should take couple of hours. The service will come back up after the binaries are rebuilt. I apologize for the delay. -Original