Re: [Development] Trouble getting reviews in months and years

2024-05-08 Thread Ilya Fedin
Hello Morten, On Thu, 11 Apr 2024 10:53:07 + Morten Sørvig wrote: > These are of the “need to get around to it” category for my part. > For 528953 we need to make sure we are not regressing > other platforms, and I have at least one related bug I’d like to take > a look at at the same

Re: [Development] Trouble getting reviews in months and years

2024-04-16 Thread Ilya Fedin
On Tue, 16 Apr 2024 08:12:51 + Morten Sørvig wrote: > Should this be up to the application (somehow)? There is more than > one way to handle DPI settings on X11, so we could enable apps to > make choices which are different from the Qt default. Well, there's only one way currently

Re: [Development] Trouble getting reviews in months and years

2024-04-16 Thread Morten Sørvig via Development
On Apr 12, 2024, at 11:51, Ilya Fedin wrote: On Thu, 11 Apr 2024 10:53:07 + Morten Sørvig wrote: - Should Qt read Gdk settings? Should the XCB platform plugin read Gdk settings? The current approach is that we stick to X11-level settings, at least as far as DPI is concerned. I hope the

Re: [Development] Trouble getting reviews in months and years

2024-04-12 Thread Ilya Fedin
On Thu, 11 Apr 2024 10:53:07 + Morten Sørvig wrote: > Hello Ilya! > > > On Apr 9, 2024, at 00:17, Ilya Fedin wrote: > > > > > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is > > 1.5 years old and no review > > > > This one could be candidate for discussion on the

Re: [Development] Trouble getting reviews in months and years

2024-04-11 Thread Morten Sørvig via Development
Hello Ilya! > On Apr 9, 2024, at 00:17, Ilya Fedin wrote: > > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is 1.5 > years old and no review > This one could be candidate for discussion on the mailing list. There are two issues: - Should Qt read Gdk settings? Should the

Re: [Development] Trouble getting reviews in months and years

2024-04-09 Thread Thiago Macieira
On Tuesday 9 April 2024 10:12:48 PDT Ilya Fedin wrote: > Oh, sorry, I was answering in quite a sleepy state but now I checked the > change you quoted and it seems I did almost everything as you said? The > change is supplied at Nov 23, 2022 which is long before Christmas, with > only a rebase and

Re: [Development] Trouble getting reviews in months and years

2024-04-09 Thread Ilya Fedin
On Mon, 08 Apr 2024 22:36:56 -0500 Thiago Macieira wrote: > On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote: > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is > > 1.5 years old and no review > > Submitted during Christmas break and no changes since New Years. No >

Re: [Development] Trouble getting reviews in months and years

2024-04-08 Thread Ilya Fedin
В Mon, 08 Apr 2024 22:36:56 -0500 Thiago Macieira пишет: > On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote: > > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is > > 1.5 years old and no review > > Submitted during Christmas break and no changes since New Years. No >

Re: [Development] Trouble getting reviews in months and years

2024-04-08 Thread Thiago Macieira
On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote: > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is 1.5 > years old and no review Submitted during Christmas break and no changes since New Years. No wonder it was missed. You should have sent a "ping" during the second week

Re: [Development] Trouble getting reviews in months and years

2024-04-08 Thread Chris Adams
Hi, I have no horse in these particular races, but I am going to throw my 2c in regardless: In my opinion, 6 months or so delay on some reviews is fairly acceptable (there can be higher-priority items which take attention, it's understandable). But beyond that, especially if the contributor is

[Development] Trouble getting reviews in months and years

2024-04-08 Thread Ilya Fedin
I have multiple changes which hang for months and years which no idea what to do to push them forward... I tried to write there asking for review but reviewers seem to just ignore the messages... 1. The oldest change I have is https://codereview.qt-project.org/c/qt/qtbase/+/343628 which is 3