[Development] Qt Examples need to be self-contained

2024-03-07 Thread Kai Köhne via Development
Hi, We have quite a few Qt examples and tutorials that share assets (images, sources, ...) via relative paths in the file system. That is, there's often a 'shared' directory that multiple examples use by relative paths (see e.g.

Re: [Development] Extending qt_attribution.json files to mark provisioned components

2024-03-06 Thread Kai Köhne via Development
Hi Volker! > From: Volker Hilsheimer > Sent: Tuesday, March 5, 2024 10:40 > To: Kai Köhne > Cc: development@qt-project.org > Subject: Re: [Development] Extending qt_attribution.json files to mark > provisioned components >  > > >> On 4 Mar 2024, at

Re: [Development] Using '#pragma once' instead of include guards?

2024-03-04 Thread Kai Köhne via Development
Hi Marc, I've nothing against using '#pragma once' for private/internal headers. But you said you mainly want to have this to differentiate between different types of headers. If this is the motivation, I think we can make this differentiation even more explicit. For instance, public headers

[Development] Extending qt_attribution.json files to mark provisioned components

2024-03-04 Thread Kai Köhne via Development
Hi, I suggest extending our qt_attribution.json format to explicitly mark third-party components not part of the Qt sources, like https://doc.qt.io/qt-6/qtmultimedia-attribution-ffmpeg.html. QUIP-7 change: https://codereview.qt-project.org/c/meta/quips/+/545126?usp=search

Re: [Development] Let's drop MSVC 2019 for dev (6.8)

2024-02-09 Thread Kai Köhne via Development
> MSVC2019 and MSVC2022 is supposed to be compatible. So in theory at least > packages made with MSVC2022 is still usable for MSVC2019 as well. It is just a > question of which compiler we use to generate the binaries with. That's not the case, at least according to Microsoft

Re: [Development] HEADS-UP: Qt 6.7 API change review

2024-01-04 Thread Kai Köhne via Development
Hi, also a reminder from my side: When checking out any API changes, please also check the API _documentation_. A good start for this is https://doc-snapshots.qt.io/qt6-6.7/newclasses67.html New API * Is it documented, and marked with \since? * Is the documentation in good shape (grammar,

Re: [Development] Lots of qdoc-related warning messages when building 'docs' target in Qt-6.6.0?

2023-10-23 Thread Kai Köhne via Development
Hi, QDoc needs to parse C++ sources to actually generate the API documentation. This requires a build where the modules are actually configured. This explains some of the warnings you see - Qt WebEngine, Qt PDF cannot be built on MinGW, and likewise Qt Wayland (Compositor). Anyway, like Paul

[Development] How to document API only deprecated in future Qt versions

2023-09-15 Thread Kai Köhne via Development
Hi, Eddy and Ivan did a great job in documenting how to formally deprecate API in at https://wiki.qt.io/Deprecation . It's not only giving you the right macros to use ... it also contains some suggestions for which version to do it. About the Qt version to deprecate an API for, the page says:

[Development] Avoid QT_BEGIN_NAMESPACE..QT_END_NAMESPACE in Qt examples

2023-09-13 Thread Kai Köhne via Development
Hi, I suggest extending QUIP 13 [1] with a paragraph explaining that we shouldn't pre-declare Qt types in Qt examples: https://codereview.qt-project.org/c/meta/quips/+/503709 For the reasoning: While it's good practice to pre-declare referenced types in header files in our tools and Qt

[Development] Documenting API changes in Qt Framework

2023-08-29 Thread Kai Köhne via Development
Hi, I've been reviewing some of the Qt 6.6 API diff's lately, focusing on the API documentation. And frankly speaking, there was (and still is) a lot to improve ... In particular, if you are the original *reviewer of any public API change*, please check: * Is there documentation for *new

Re: [Development] On the use of the inline keyword

2023-08-25 Thread Kai Köhne via Development
Not an GCC expert, but this is the code that emits the warning in GCC: https://github.com/gcc-mirror/gcc/blob/66be6ed81f369573824f1a8f5a3538a63472292f/gcc/attribs.cc#L1818 First argument for warning() is 0 ... which explains why it cannot be easily disabled with say -Wno-ignored-attributes. I

Re: [Development] How to use `init-repository` properly to clean up the working tree after checking out?

2023-08-22 Thread Kai Köhne via Development
> The question you must answer is why git > submodule update isn't checking those > commits out for those submodules. > > Anyway, why are you checking out 6.2.4 using Git? That's the key: qtlocation and qtspeech weren't part of 6.2 qt5.git. So when switching from dev to 6.2.4, 'git checkout'

Re: [Development] Failed to run configure.bat in qt/qt5 repository on Windows?

2023-08-22 Thread Kai Köhne via Development
> I followed what you said, build qminimal manually. > However, after that, it still failed to build docs target. Like I said in a previous mail, you need qminimal and qsqlite (at least if you don't use latest dev). So make this: cmake --build . --parallel 4 --target qminimal qsqlite cmake

Re: [Development] Failed to run configure.bat in qt/qt5 repository on Windows?

2023-08-17 Thread Kai Köhne via Development
> so running > $ ninja qdoc qtattributionsscanner > qhelpgenerator. > should hopefully be sufficient Actually both are dependencies of the doc target. And since https://codereview.qt-project.org/c/qt/qttools/+/494893, just running configure cmake --build . docs should be enough. If you're

Re: [Development] [RFCs] Migrate from GCC MinGW to LLVM MinGW

2023-07-20 Thread Kai Köhne via Development
> From: Development on behalf of Yang Fan > > Sent: Thursday, July 20, 2023 3:55 AM > To: Cristian Adam > Cc: development@qt-project.org > Subject: Re: [Development] [RFCs] Migrate from GCC MinGW to LLVM MinGW > > I wanted to point out that MSYS2 offers precompiled packages of Qt6 in > four

Re: [Development] Support for *Notes and UpstreamFiles fields in qt_attributions.json files

2023-03-09 Thread Kai Köhne via Development
> -Original Message- > From: Development On Behalf Of > Hasselmann Mathias via Development > Subject: Re: [Development] Support for *Notes and UpstreamFiles fields in > qt_attributions.json files > > Hi, > > Just to make ensure all options are considered: How about the elephant in the >

Re: [Development] Security-relevant 3rd party components bundled with Qt

2023-02-22 Thread Kai Köhne via Development
Hi, Does moving the information closer to the code make sense? Most of the information provided in the wiki is already part of the qt_attribution.json files that we use to generate the official documentation about third party modules. What’s missing is the ‘process untrusted content’ flag,

Re: [Development] Support for *Notes and UpstreamFiles fields in qt_attributions.json files

2023-02-15 Thread Kai Köhne via Development
> -Original Message- > From: Edward Welbourne > Sent: Wednesday, February 15, 2023 10:45 AM > To: Kai Köhne > Cc: Development@qt-project.org > Subject: Re: Support for *Notes and UpstreamFiles fields in > qt_attributions.json > files > > Kai Köhne (15 February 2023 08:50) replied: > >

Re: [Development] Support for *Notes and UpstreamFiles fields in qt_attributions.json files

2023-02-14 Thread Kai Köhne via Development
> -Original Message- > From: Development On Behalf Of Ulf > Hermann via Development > Subject: Re: [Development] Support for *Notes and UpstreamFiles fields in > qt_attributions.json files > > YAML is really quite terrible. If we're going to switch, let's choose > something > else. > >

Re: [Development] Support for *Notes and UpstreamFiles fields in qt_attributions.json files

2023-02-14 Thread Kai Köhne via Development
Hi Eddy, > -Original Message- > From: Development On Behalf Of > Edward Welbourne via Development > Sent: Tuesday, February 14, 2023 3:14 PM > To: Development@qt-project.org > Subject: [Development] Support for *Notes and UpstreamFiles fields in > qt_attributions.json files > > Hi all,

Re: [Development] Do we need VS2019 for Qt 6.6?

2023-02-03 Thread Kai Köhne via Development
Hi, We’ve been looking into this. I’m convinced now that the data Vladimir was looking at on the server side is the one shown in the “Compiler Information” in the Telemetry view of Qt Creator. This is the compiler Qt Creator was built with though, not the compiler that Qt Creator uses for

Re: [Development] Qt TextToSpeech: Adding dependency to Qt Multimedia - ok?

2023-01-23 Thread Kai Köhne via Development
Hi, > -Original Message- > From: Development On Behalf Of > [...] > This is a binary compatibility breakage of sorts. Applications that were > linked > against Qt 6.4 or Qt 6.5, and want to run against Qt 6.6 won’t work unless Qt > Multimedia is present. This doesn't violate the binary

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Kai Köhne via Development
> -Original Message- >[...] > > MANDATORY > > > > Do not use QT_BEGIN_NAMESPACE ... QT_END_NAMESPACE for example > types. This namespace is exclusively for types in the Qt libraries. > > This is broken. How is one going to correctly forward declare Qt names > in a namespaced build of