Re: [PATCH v4 1/3] dt-binding: power: Add otg regulator binding

2015-12-15 Thread Sebastian Reichel
Hi, On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > Add a binding for the regulator which controls the OTG chargepath switch. > The OTG switch gets its power from pm8941_5vs1, and that should be > expressed as a usb_otg_in-supply property in the DT node for the > charger driver. The

Re: [PATCH linux-next 1/2] power: Add brcm,bcm6358-power-controller device tree binding

2015-12-15 Thread Sebastian Reichel
Hi, On Wed, Dec 09, 2015 at 10:29:35PM +, Simon Arlott wrote: > The BCM6358 contains power domains controlled with a register. Power > domains are indexed by bits in the register. Power domain bits can be > interleaved with other status bits and clocks in the same register. > > Newer SoCs

Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver

2015-12-15 Thread Sebastian Reichel
Hi, On Tue, Dec 15, 2015 at 04:53:31PM -0800, Eric Anholt wrote: > >>> What motivated the location of this power domain driver in > >>> arch/arm/mach-bcm? Should not we have this in drivers/power/ or > >>> somewhere in drivers/ at the very least? > >> > >> ls stronly suggests that power contains

Re: [PATCH v2 1/3] dt-binding: power: Add otg regulator binding

2015-12-09 Thread Sebastian Reichel
Hi, On Wed, Dec 09, 2015 at 09:42:09AM -0800, Tim Bird wrote: > Or maybe our power maintainers will chime in with some wisdom. I > can't be the first person to be adding a charge pathway switch to > mainline, so I'm open to doing it the "right way". :-) I don't think there is a standard way for

Re: [PATCH 0/2] power: Add support for TI BQ24261 charger

2015-12-05 Thread Sebastian Reichel
Hi Ramakrishna, On Thu, Oct 29, 2015 at 10:07:03PM +0530, Ramakrishna Pallala wrote: > This patch series adds the support for TI BQ24261 charger driver. > > TI BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging

Re: [PATCH] power: qcom_smbb: Add otg regulator for control of vbus

2015-12-05 Thread Sebastian Reichel
Hi Tim, On Thu, Oct 22, 2015 at 02:12:17PM -0700, Tim Bird wrote: > Add a regulator to control the OTG chargepath switch. The OTG > switch gets its power from pm8941_5vs1, and that should be expressed > as an usb_otg_in-supply property in the DT node for the charger driver. > The regulator name

Re: [PATCH v2 5/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping

2015-11-13 Thread Sebastian Reichel
Hi, On Fri, Nov 13, 2015 at 09:35:56PM +0100, H. Nikolaus Schaller wrote: > commit b98abe52fa8e ("Input: add common DT binding for touchscreens") > introduced common DT bindings for touchscreens [1] and a helper function to > parse the DT. > > This has been integrated and interpretation of the

Re: [PATCH] regulator: tps65217: remove tps65217.dtsi file

2015-10-27 Thread Sebastian Reichel
Hi, On Mon, Oct 26, 2015 at 10:13:55AM +0100, Heiko Schocher wrote: > remove tps65217.dtsi and adapt all boards, which > used it. > > Signed-off-by: Heiko Schocher > --- > Suggested by Mark Brown, see: > https://lkml.org/lkml/2015/10/21/581 > >

Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode

2015-10-12 Thread Sebastian Reichel
Hi, On Mon, Oct 12, 2015 at 03:20:10PM -0700, Tony Lindgren wrote: > * Tony Lindgren [151012 14:43]: > > * Belisko Marek [150926 13:02]: > > > Tony sorry I forgot to add you to the recipients for this patchset. > > > Can you please queue this patch.

Re: [PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-10-09 Thread Sebastian Reichel
Hi, On Fri, Oct 09, 2015 at 02:27:42PM -0700, Eric Anholt wrote: > VC4 is the GPU (display and 3D) subsystem present on the 2835 and some > other Broadcom SoCs. > > This binding follows the model of msm, imx, sti, and others, where > there is a subsystem node for the whole GPU, with nodes for

Re: [PATCH v8 00/14] power: bq24257: Add support for bq24250/bq24251

2015-09-30 Thread Sebastian Reichel
Hi, On Mon, Sep 28, 2015 at 05:33:48PM -0500, Andreas Dannenberg wrote: > This patch series extends the driver to also support bq24250/bq24251. > > The bq24250/251/257 devices have a very similar feature set and are > virtually identical from a control register point of view so it made > sense

Re: [PATCH v7 03/15] power: bq24257: Streamline input current limit setup

2015-09-28 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:08AM -0500, Andreas Dannenberg wrote: > The maximum amount of input current the charger should draw is dependent > on the power supply and should only be (re-)configured when the power > supply gets connected and disconnected. However the driver was also >

Re: [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251

2015-09-28 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:05AM -0500, Andreas Dannenberg wrote: > This patch series extends the driver to also support bq24250/bq24251. > > The bq24250/251/257 devices have a very similar feature set and are > virtually identical from a control register point of view so it made > sense

Re: [PATCH v7 14/15] power: bq24257: Add platform data based initialization

2015-09-28 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:19AM -0500, Andreas Dannenberg wrote: > The patch adds a way to setup and initialize the device through the use > of platform data with configuration options equivalent to when using > device firmware (DT or ACPI) for systems where this is not available. Which

Re: [PATCH v7 01/15] dt: power: bq24257-charger: Cover additional devices

2015-09-28 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:06AM -0500, Andreas Dannenberg wrote: > Extend the bq24257 charger's device tree documentation to cover the > bq24250 and bq24251 devices as well feature additions. > > [...] > > +- ti,current-limit: The maximum current to be drawn from the charger's input > +

Re: [PATCH v7 02/15] power: bq24257: Remove IRQ config through stat-gpios

2015-09-28 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:07AM -0500, Andreas Dannenberg wrote: > At the time the driver was written GpioInt resources in ACPI were not > passed to the driver in client->irq, as opposed to DT enumeration. To > accommodate this use case, a "stat-gpios" property was introduced to > allow

Re: [PATCH v7 04/15] power: bq24257: Use managed power supply register

2015-09-28 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:09AM -0500, Andreas Dannenberg wrote: > Use the devm_* managed version of the function to register the power > supply and remove the associated unregister function. > > Signed-off-by: Andreas Dannenberg > --- >

Re: [PATCH v7 09/15] power: bq24257: Add SW-based approach for Power Good determination

2015-09-28 Thread Sebastian Reichel
Hi, On Mon, Sep 28, 2015 at 07:04:12AM -0500, Andreas Dannenberg wrote: > On Sun, Sep 27, 2015 at 10:20:26PM +0200, Sebastian Reichel wrote: > > On Fri, Sep 25, 2015 at 10:54:14AM -0500, Andreas Dannenberg wrote: > > > @@ -651,15 +670,18 @@ static int bq24257_power_

Re: [PATCH v7 09/15] power: bq24257: Add SW-based approach for Power Good determination

2015-09-27 Thread Sebastian Reichel
Hi, On Fri, Sep 25, 2015 at 10:54:14AM -0500, Andreas Dannenberg wrote: > @@ -651,15 +670,18 @@ static int bq24257_power_supply_init(struct > bq24257_device *bq) > return PTR_ERR_OR_ZERO(bq->charger); > } > > -static int bq24257_pg_gpio_probe(struct bq24257_device *bq) > +static void

Re: [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module

2015-09-26 Thread Sebastian Reichel
Hi Marek, On Fri, Sep 25, 2015 at 10:20:45PM +0200, Marek Belisko wrote: > If either twl4030_charger or twl4030_madc is configured as MODULE, > we get build (link) errors. > > To solve, the direct call of twl4030_get_madc_conversion() is replaced > by a call to iio_read_channel_processed(). > >

Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode

2015-09-26 Thread Sebastian Reichel
charger: bci { > compatible = "ti,twl4030-bci"; > interrupts = <9>, <2>; > + io-channels = <_madc 11>; > + io-channel-name = "vac"; > bci3v1-supply = <>; > }; Ack

Re: [PATCHv2 2/2] power_supply: Add support for tps65217-charger.

2015-09-24 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2015 at 09:23:25AM +0200, Enric Balletbo i Serra wrote: > This patch adds support for the tps65217 charger driver. This driver is > responsible for controlling the charger aspect of the tps65217 mfd. > Currently, this mainly consists of turning on and off the charger, but >

Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module

2015-09-24 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2015 at 09:09:15PM +0200, Belisko Marek wrote: > On Tue, Sep 22, 2015 at 11:29 PM, Sebastian Reichel <s...@kernel.org> wrote: > > On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote: > >> If either twl4030_charger or twl4030_madc is configure

Re: [PATCHv3 0/2] Add support for tps65217 charger

2015-09-24 Thread Sebastian Reichel
Hi, On Thu, Sep 24, 2015 at 09:44:19PM +0200, Enric Balletbo i Serra wrote: > The following series add initial support for tps65217 battery charger. Thanks, queued. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v5 09/11] power: bq24257: Allow input current limit sysfs access

2015-09-23 Thread Sebastian Reichel
Hi, On Wed, Sep 23, 2015 at 09:11:46AM -0500, Andreas Dannenberg wrote: > On Wed, Sep 23, 2015 at 02:29:06AM +0200, Sebastian Reichel wrote: > > On Tue, Sep 22, 2015 at 05:10:45PM -0500, Andreas Dannenberg wrote: > > > On Tue, Sep 22, 2015 at 09:16:49PM +0200, Sebas

Re: [PATCH v5 09/11] power: bq24257: Allow input current limit sysfs access

2015-09-23 Thread Sebastian Reichel
Hi, On Wed, Sep 23, 2015 at 01:32:58PM -0500, Andreas Dannenberg wrote: > On Wed, Sep 23, 2015 at 05:02:28PM +0200, Sebastian Reichel wrote: > > On Wed, Sep 23, 2015 at 09:11:46AM -0500, Andreas Dannenberg wrote: > > > Ok. So how should we best go about e

Re: [PATCH v5 00/11] power: bq24257: Add support for bq24250/bq24251

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 18, 2015 at 04:39:48PM -0500, Andreas Dannenberg wrote: > This patch series extends the driver to also support bq24250/bq24251. > > The bq24250/251/257 devices have a very similar feature set and are > virtually identical from a control register point of view so it made > sense

Re: [PATCH v5 05/11] power: bq24257: Add SW-based approach for Power Good determination

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 18, 2015 at 04:39:53PM -0500, Andreas Dannenberg wrote: > A software-based approach for determining the charger's input voltage > "Power Good" state is introduced for devices like the bq24250 which > don't have a dedicated hardware pin for that purpose. This SW-based > approach is

Re: [PATCH v5 11/11] power: bq24257: Add platform data based initialization

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 18, 2015 at 04:39:59PM -0500, Andreas Dannenberg wrote: > The patch adds a way to setup and initialize the device through the use > of platform data with configuration options equivalent to when using > device firmware (DT or ACPI) for systems where this is not available. > --- >

Re: [PATCH v5 09/11] power: bq24257: Allow input current limit sysfs access

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 18, 2015 at 04:39:57PM -0500, Andreas Dannenberg wrote: > This patch allows reading (and writing, if the D+/D- USB signal-based > charger type detection is disabled) of the input current limit through > the power supply's input_current_limit sysfs property. This allows > userspace

Re: [PATCH v5 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge

2015-09-22 Thread Sebastian Reichel
This value should be lower than the warning level. > + [1 - 100] > + > + > +Example: > + > + fuel-gauge { > + compatible = "dlg,da9150-fuel-gauge"; > + > + dlg,update-interval = <1>; > + dlg,warn-soc-level = /bits/

Re: [PATCH v5 0/6] Add support for DA9150 Fuel-Gauge

2015-09-22 Thread Sebastian Reichel
Hi Lee, On Fri, Sep 11, 2015 at 11:05:21AM +0100, Adam Thomson wrote: > This patch set adds support for the Dialog DA9150 Fuel-Gauge. > > [...] > > Adam Thomson (6): > mfd: da9150: Add support for Fuel-Gauge > mfd: da9150: Update DT bindings for Fuel-Gauge support > power: Add support for

Re: [PATCH v5 01/11] dt: power: bq24257-charger: Cover additional devices

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 18, 2015 at 04:39:49PM -0500, Andreas Dannenberg wrote: > Extend the bq24257 charger's device tree documentation to cover the > bq24250 and bq24251 devices as well feature additions. The binding looks fine to except for: > +- stat-gpios: GPIO used for the devices STAT_IN pin.

Re: [PATCH v5 01/11] dt: power: bq24257-charger: Cover additional devices

2015-09-22 Thread Sebastian Reichel
Hi, On Tue, Sep 22, 2015 at 04:58:24PM -0500, Andreas Dannenberg wrote: > On Tue, Sep 22, 2015 at 06:24:48PM +0200, Sebastian Reichel wrote: > > On Fri, Sep 18, 2015 at 04:39:49PM -0500, Andreas Dannenberg wrote: > > > Extend the bq24257 charger's device tree docu

Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module

2015-09-22 Thread Sebastian Reichel
Hi Marek, On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote: > If either twl4030_charger or twl4030_madc is configured as MODULE, > we get build (link) errors. > > To solve, the direct call of twl4030_get_madc_conversion() is replaced > by a call to iio_read_channel_processed(). > >

Re: [PATCH v5 09/11] power: bq24257: Allow input current limit sysfs access

2015-09-22 Thread Sebastian Reichel
On Tue, Sep 22, 2015 at 05:10:45PM -0500, Andreas Dannenberg wrote: > On Tue, Sep 22, 2015 at 09:16:49PM +0200, Sebastian Reichel wrote: > > On Fri, Sep 18, 2015 at 04:39:57PM -0500, Andreas Dannenberg wrote: > > > This patch allows reading (and writing, if the D+/D- USB signal-b

Re: [PATCH v5 3/6] power: Add support for DA9150 Fuel-Gauge

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 11, 2015 at 11:05:35AM +0100, Adam Thomson wrote: > This adds power supply driver support for the Fuel-Gauge part of > the DA9150 combined Charger and Fuel-Gauge device. Acked-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 2/3] power_supply: Add support for tps65217-charger.

2015-09-22 Thread Sebastian Reichel
Hi, On Tue, Sep 08, 2015 at 10:09:38AM +0200, Enric Balletbo i Serra wrote: > This patch adds support for the tps65217 charger driver. This driver is > responsible for controlling the charger aspect of the tps65217 mfd. > Currently, this mainly consists of turning on and off the charger, but >

Re: [PATCH 3/3] mfd: Add battery charger as subdevice to the tps65217.

2015-09-22 Thread Sebastian Reichel
Hi, On Tue, Sep 22, 2015 at 09:43:50AM +0200, Enric Balletbo Serra wrote: > 2015-09-20 6:19 GMT+02:00 Lee Jones : > > On Tue, 08 Sep 2015, Enric Balletbo i Serra wrote: > > > >> Add tps65217 battery charger subdevice. > >> > >> Signed-off-by: Enric Balletbo i Serra

Re: [PATCH v4 resend 0/2] power: Add an axp20x-usb-power driver

2015-09-22 Thread Sebastian Reichel
Hi, On Sun, Sep 20, 2015 at 08:39:31AM -0400, Hans de Goede wrote: > This is a resend of v4 of the axp20x-usb-power power-supply driver, > after v4 there have been no further comments, so I assume that this > version is ready for merging, yet for some reason it has not been > merged yet. My

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-22 Thread Sebastian Reichel
Hi, On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > On 11.09.2015 01:42, Andrew F. Davis wrote: > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > +- ti,enable-user-write: boolean, if present driver will allow the > > user space > > +to control the

Re: [PATCH v2 1/2] power: reset: at91: add sama5d3 reset function

2015-08-05 Thread Sebastian Reichel
compatibility string as a fallback = the newer will be used when merged... FWIW: Acked-By: Sebastian Reichel s...@kernel.org -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge

2015-08-04 Thread Sebastian Reichel
Hi, On Tue, Aug 04, 2015 at 08:21:36AM +, Opensource [Adam Thomson] wrote: The header states GPL v2+. Yes, and this matches the GPL string as I understand it. The following is taken from include/linux/module.h: --- /* * The following license idents are currently accepted as

Re: [PATCH v3 3/6] power: Add support for DA9150 Fuel-Gauge

2015-07-25 Thread Sebastian Reichel
Hi Adam, The driver looks mostly fine. I have a few comments, though: On Tue, Jul 07, 2015 at 05:34:19PM +0100, Adam Thomson wrote: Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com Please add a short description to the commit message. [...] +config FG_DA9150 Please name

Re: [PATCH v3 4/4] power: Add an axp20x-usb-power driver

2015-07-24 Thread Sebastian Reichel
Hi, On Fri, Jun 26, 2015 at 12:59:17PM +0200, Hans de Goede wrote: This adds a driver for the usb power_supply bits of the axp20x PMICs. I initially started writing my own driver, before coming aware of Bruno Prémont's excellent earlier RFC with a driver for this. My driver was lacking

Re: [PATCH v3 1/4] ARM: dts: Add binding documentation for AXP20x pmic usb power supply

2015-07-24 Thread Sebastian Reichel
Hi, On Fri, Jun 26, 2015 at 12:59:14PM +0200, Hans de Goede wrote: Add binding documentation for the usb power supply part of the AXP20x pmic. [...] +Example: + [...] + + usb_power_supply: usb_power_supply { use

Re: [PATCH v3 4/6] power: da9150: Add DT bindings documentation for Fuel-Gauge

2015-07-24 Thread Sebastian Reichel
Hi, On Tue, Jul 07, 2015 at 05:34:21PM +0100, Adam Thomson wrote: diff --git a/Documentation/devicetree/bindings/power/da9150-fg.txt b/Documentation/devicetree/bindings/power/da9150-fg.txt new file mode 100644 index 000..c3c76eb --- /dev/null +++

Re: [PATCH v2 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Sebastian Reichel
Hi, On Mon, Jul 20, 2015 at 05:32:05PM +0800, Josh Wu wrote: This patch introduces a new compatible string: atmel,sama5d3-rstc and new reset function for sama5d3 and later chips. As in sama5d3 or later chips, we don't have to shutdown the DDR controller before reset. Shutdown the DDR

Re: [PATCH v2] power_supply: rt9455_charger: Properly notify userspace about charging events

2015-07-08 Thread Sebastian Reichel
Hi, On Tue, Jul 07, 2015 at 03:25:53PM +0300, Anda-Maria Nicolae wrote: Charging events this patch refers to are: - charger is connected to/disconnected from the power source - battery is reconnected to the charger, after it was absent. When the charger is connected to/disconnected from the

Re: rx51-battery.ko incompatiblity: board code vs DT

2015-07-07 Thread Sebastian Reichel
Hi, On Mon, Jul 06, 2015 at 09:44:22PM +0200, Pali Rohár wrote: now I found out that rx51-battery.ko driver register sysnode /sys/class/power_supply/rx51-battery/ when booting with legacy board code. But when booting DT kernel it register sysnode with different name

Re: [PATCH] power_supply: rt9455_charger: Fix error reported by static analysis tool

2015-06-12 Thread Sebastian Reichel
Hi, On Fri, Jun 12, 2015 at 03:25:51PM +0300, Anda-Maria Nicolae wrote: The result of container_of macro cannot be NULL, so there is no need to check whether info is NULL. Thanks, queued for 4.2. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 3/8] power: Add devm_power_supply_get_by_phandle() helper function

2015-06-10 Thread Sebastian Reichel
Hi, On Tue, Jun 09, 2015 at 11:37:56PM +0200, Hans de Goede wrote: This commit adds a resource-managed version of the power_supply_get_by_phandle() function. Thanks, queued. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 1/2] power_supply: max17042: Add OF support for setting thresholds

2015-06-10 Thread Sebastian Reichel
Hi, On Mon, Jun 08, 2015 at 10:11:38AM +0900, Krzysztof Kozlowski wrote: The commit edd4ab055931 (power: max17042_battery: add HEALTH and TEMP_* properties support) added support for setting voltage and temperature thresholds with platform data. For DeviceTree default of 0 was always used.

Re: [PATCH] power_supply: rt9455_charger: Check if CONFIG_USB_PHY is enabled

2015-06-03 Thread Sebastian Reichel
Hi Anda-Maria, On Wed, Jun 03, 2015 at 11:47:03AM +0300, Anda-Maria Nicolae wrote: If CONFIG_USB_PHY is not enabled, struct notifier_block is not defined and compilation fails. Therefore, the functions that process USB event notifications are defined only if CONFIG_USB_PHY is enabled. There

Re: [PATCH v7 0/3] Add support for Richtek RT9455 battery charger

2015-06-02 Thread Sebastian Reichel
Hi Anda, On Fri, May 29, 2015 at 05:25:42PM +0300, Anda-Maria Nicolae wrote: The next 3 patches do the following: - first patch adds Richtek Technology Corporation in the vendor-prefixes list - second patch adds device tree binding example for Richtek RT9455 battery charger - third patch

Re: [PATCH 0/3] Add support for Richtek RT9455 battery charger

2015-05-28 Thread Sebastian Reichel
Hi Anda-Maria, On Mon, May 25, 2015 at 01:22:20PM +0300, Anda-Maria Nicolae wrote: The next 3 patches do the following: - first patch adds Richtek Technology Corporation in the vendor-prefixes list - second patch adds device tree binding example for Richtek RT9455 battery charger - third

Re: [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem

2015-05-27 Thread Sebastian Reichel
Hi Stefan, On Wed, May 27, 2015 at 09:12:48AM +0200, Stefan Wahren wrote: Am 23.05.2015 um 19:41 schrieb Sebastian Reichel: On Wed, Apr 29, 2015 at 10:32:24PM +, Stefan Wahren wrote: This patch adds a minimal driver for the Freescale i.MX23, i.MX28 power subsystem. It's required

Re: [PATCH v5] power_supply: Add support for Richtek rt9455 battery charger

2015-05-24 Thread Sebastian Reichel
Hi Anda-Maria, On Fri, May 08, 2015 at 03:57:49PM +0300, Anda-Maria Nicolae wrote: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v4 version:

Re: [PATCH v2] power_supply: Add TI BQ24257 charger driver

2015-05-24 Thread Sebastian Reichel
On Thu, Apr 16, 2015 at 12:31:16PM +0300, Laurentiu Palcu wrote: Based on the datasheet found here: http://www.ti.com/lit/ds/symlink/bq24257.pdf Signed-off-by: Laurentiu Palcu laurentiu.pa...@intel.com Thanks, queued. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 0/2] power_supply: bq2415x_charger: Fix coding style issues add ACPI support

2015-05-24 Thread Sebastian Reichel
Hi, On Tue, May 12, 2015 at 12:11:31PM +0300, Anda-Maria Nicolae wrote: The following 2 patches do the following to bq2415x_charger: - first patch fixes pre-existing coding style issues reported by checkpatch.pl - second patch adds ACPI enumeration support Thanks, queued. -- Sebastian

Re: [PATCH v2 0/2] Add support for BQ25890 charger chip

2015-05-24 Thread Sebastian Reichel
Hi, On Tue, May 19, 2015 at 04:24:38PM +0300, Laurentiu Palcu wrote: Changes since v1: * add comment in DT bindings regarding default driver behavior when ti,thermal-regulation-threshold property is missing; * addressed all Krzysztof's comments, including addition of a reset check

Re: [PATCH V2 3/6] power: mxs_power: add driver for mxs power subsystem

2015-05-23 Thread Sebastian Reichel
Hi, On Wed, Apr 29, 2015 at 10:32:24PM +, Stefan Wahren wrote: This patch adds a minimal driver for the Freescale i.MX23, i.MX28 power subsystem. It's required to trigger the probing of the underlying drivers like on-chip regulators. I'm not sure what you need the power supply class for.

Re: [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653

2015-04-16 Thread Sebastian Reichel
Hi Pavel, On Thu, Apr 16, 2015 at 07:58:18AM +0200, Pavel Machek wrote: On Thu 2015-04-16 07:24:42, Sebastian Reichel wrote: Hi Sakari, Since this driver won't make it into 4.1 anyways, I have one more comment: Like this driver did not receive enough bikesheding. You should become

Re: [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653

2015-04-15 Thread Sebastian Reichel
Hi Sakari, Since this driver won't make it into 4.1 anyways, I have one more comment: On Thu, Apr 16, 2015 at 02:37:13AM +0300, Sakari Ailus wrote: From: Pavel Machek pa...@ucw.cz Add device tree support for adp1653 flash LED driver. Signed-off-by: Pavel Machek pa...@ucw.cz

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Sebastian Reichel
Hi, On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: [...] +#include linux/of_gpio.h +#include linux/gpio.h [...] This should probably be #include linux/of.h #include linux/gpio/consumer.h -- Sebastian signature.asc Description: Digital signature

Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653

2015-04-09 Thread Sebastian Reichel
On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: [...] +#include linux/of_gpio.h +#include linux/gpio.h [...] This should probably be #include

Re: [PATCH v4 6/6] power: twl4030_madc_battery: Add missing MODULE_ALIAS

2015-04-06 Thread Sebastian Reichel
Hi, On Tue, Mar 10, 2015 at 10:27:27PM +0100, Marek Belisko wrote: Without MODULE_ALIAS twl4030_madc_battery won't get loaded automatically. Thanks, pulled. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v4 1/6] power: twl4030-madc-battery: Convert to iio consumer.

2015-04-06 Thread Sebastian Reichel
Hi, On Tue, Mar 10, 2015 at 10:27:22PM +0100, Marek Belisko wrote: Because of added iio error handling private data allocation was converted to managed to simplify code. Thanks, pulled (only PATCH 1/6 for now). -- Sebastian signature.asc Description: Digital signature

Re: [PATCHv3 0/2] Add support for generic register mapped poweroff.

2015-04-06 Thread Sebastian Reichel
Hi, On Wed, Mar 11, 2015 at 05:37:17PM -0700, Moritz Fischer wrote: This patchset adds support for generic register mapped poweroff via SYCON. Thanks, pulled: http://git.infradead.org/battery-2.6.git/commit/8a577608ba4a3cab1d74025cea382e40544ab9cd

Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653

2015-04-03 Thread Sebastian Reichel
Hi, On Fri, Apr 03, 2015 at 10:49:12AM +0200, Javier Martinez Canillas wrote: The convention nowadays is to not use unnamed DT properties for GPIOs but instead use a prefix that explains what those GPIOs are used for. So something like power-gpios or power-gpio (if there is only one GPIO)

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-31 Thread Sebastian Reichel
Hi, On Mon, Mar 30, 2015 at 10:50:52AM -0700, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 10:46]: Well, there has been regression but finding exactly how far should the fix go didn't look instantly straightforward due all DT, codec driver mic bias etc changes and

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-27 Thread Sebastian Reichel
Hi, On Fri, Mar 27, 2015 at 10:22:11AM +0100, Dr. H. Nikolaus Schaller wrote: Coming back at my sentence: I asked about a non-trivial, non-bus connected HW, which has a DT binding. from omap3-beagle-xm.dts: hsusb2_phy (connected through ULPI) gpio-keys (it is not a trivial on/off)

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-26 Thread Sebastian Reichel
Hi, On Wed, Mar 25, 2015 at 05:44:42PM +0100, Dr. H. Nikolaus Schaller wrote: Am 25.03.2015 um 16:21 schrieb Sebastian Reichel s...@kernel.org: On Wed, Mar 25, 2015 at 08:59:14AM +0100, Dr. H. Nikolaus Schaller wrote: Am 25.03.2015 um 02:45 schrieb Sebastian Reichel s...@kernel.org: On Tue

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Sebastian Reichel
Hi, On Wed, Mar 25, 2015 at 08:59:14AM +0100, Dr. H. Nikolaus Schaller wrote: Am 25.03.2015 um 02:45 schrieb Sebastian Reichel s...@kernel.org: On Tue, Mar 24, 2015 at 06:58:15PM +0100, Dr. H. Nikolaus Schaller wrote: So you propose that the parent-child relationship is “control”? I.e. some

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-24 Thread Sebastian Reichel
Hi, On Tue, Mar 24, 2015 at 06:58:15PM +0100, Dr. H. Nikolaus Schaller wrote: So you propose that the parent-child relationship is “control”? I.e. some channel which allows to address some bus client (through reg) and control that devices. Makes sense. This is how i2c and spi clients are

Re: [PATCH 2/7] power: mxs_power: add driver for mxs power subsystem

2015-03-22 Thread Sebastian Reichel
Hi, On Sun, Mar 22, 2015 at 12:29:58AM +, Stefan Wahren wrote: This patch adds a minimal driver for the Freescale i.MX23, i.MX28 power subsystem. It's required to trigger the probing of the underlying drivers like on-chip regulators. [...] +config MXS_POWER + tristate Freescale

[PATCHv2 4/4] DTS: ARM: OMAP3-N900: Add lis3lv02d support

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel s...@kernel.or This adds support for the N900's accelerometer to the Nokia N900 DTS file. Signed-off-by: Sebastian Reichel s...@kernel.org --- arch/arm/boot/dts/omap3-n900.dts | 52 1 file changed, 52 insertions(+) diff --git

[PATCHv2 1/4] lis3lv02d: DT: use s32 to support negative values

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel s...@kernel.or st,axis-{x,y,z} can be negative to imply inverted axis. Apart from that the minimal and maximal threshold may be negative. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/misc/lis3lv02d/lis3lv02d.c | 39

[PATCHv2 3/4] Documentation: DT: lis302: update wakeup binding

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel s...@kernel.or This updated the documentation of the DT binding to describe the added wakeup threshold and second wakeup engine. It also adds a note, that the axis values may be negative. Signed-off-by: Sebastian Reichel s...@kernel.org --- Documentation/devicetree

[PATCHv2 0/4] lis3lv02d: update DT binding for use with Nokia N900

2015-03-21 Thread Sebastian Reichel
of second wakeup unit and wakeup threshold support. The series is based on top of v4.0-rc1 and has been tested on my Nokia N900. [0] Documentation/devicetree/bindings/misc/lis302.txt -- Sebastian Sebastian Reichel (4): lis3lv02d: DT: use s32 to support negative values lis3lv02d: DT: add wakeup unit

[PATCHv2 2/4] lis3lv02d: DT: add wakeup unit 2 and wakeup threshold

2015-03-21 Thread Sebastian Reichel
From: Sebastian Reichel s...@kernel.or This adds support for the the wakeup threshold and support for the second wakeup unit to the DT based setup. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/misc/lis3lv02d/lis3lv02d.c | 17 + 1 file changed, 17 insertions

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Sebastian Reichel
Hi, On Fri, Mar 20, 2015 at 09:54:21AM +0100, Dr. H. Nikolaus Schaller wrote: [...] And we do not write a driver for the w2sg0004 but the regulator inside that chip. DT describes the hardware structure and not the Linux driver structure. You also won’t expect that the omap3 driver hides

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Sebastian Reichel
Hi, On Fri, Mar 20, 2015 at 02:57:12PM +0100, Dr. H. Nikolaus Schaller wrote: On Fri, Mar 20, 2015 at 09:54:21AM +0100, Dr. H. Nikolaus Schaller wrote: [...] And we do not write a driver for the w2sg0004 but the regulator inside that chip. DT describes the hardware structure and not

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-16 Thread Sebastian Reichel
Hi, On Mon, Mar 16, 2015 at 08:29:39AM -0700, Tony Lindgren wrote: * Arnd Bergmann a...@arndb.de [150315 05:10]: On Sunday 15 March 2015 10:50:42 Eliad Peller wrote: yeah, i missed it :/ looks like there's no platform that defines platform data for it. i'll replace the

Re: [RFC 14/18] dt: bindings: Add bindings for omap3isp

2015-03-13 Thread Sebastian Reichel
Hi, On Fri, Mar 13, 2015 at 01:03:21AM +0200, Sakari Ailus wrote: [...] +Required properties +=== + +compatible : ti,omap3-isp I would rephrase that using the usual wording as compatible: Must contain ti,omap3-isp. [...] +ti,phy-type : 0 --

Re: [RFC 18/18] omap3isp: Deprecate platform data support

2015-03-13 Thread Sebastian Reichel
Hi, [+CC Tony] On Sat, Mar 07, 2015 at 11:41:15PM +0200, Sakari Ailus wrote: Print a warning when the driver is used with platform data. Existing platform data user should move to DT now. I guess this should become a more visible warning on OMAP SoC level, since platform data based boot will

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-12 Thread Sebastian Reichel
Hi, On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote: No no, capacity-uah is what we should use, but you need an ack from the battery and device tree people that this is OK. Let's not add ti,capacity-uah” as that can obviously be a generic property. I'm okay with capacity-uah.

Re: [PATCHv2 1/2] power: reset: Add generic SYSCON register mapped poweroff.

2015-03-11 Thread Sebastian Reichel
Hi Moritz, On Wed, Mar 11, 2015 at 03:32:24PM -0700, Moritz Fischer wrote: [...] +static struct platform_driver syscon_poweroff_driver = { + .probe = syscon_poweroff_probe, + .remove = syscon_poweroff_remove, + .driver = { + .name = syscon-poweroff, +

Re: [PATCH 1/2] power: reset: Add generic SYSCON register mapped poweroff.

2015-03-10 Thread Sebastian Reichel
Hi, On Tue, Mar 10, 2015 at 04:21:09PM -0700, Moritz Fischer wrote: Add a generic SYSCON register mapped poweroff mechanism. Driver looks mostly fine. [...] +#ifdef CONFIG_OF +static const struct of_device_id syscon_poweroff_of_match[] = { + { .compatible = syscon-poweroff }, + {}

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 01:53:58PM +0900, Beomho Seo wrote: remove the special handling of POWER_SUPPLY_PROP_CURRENT_MAX in rt5033_get_charger_current() and do it like this: case POWER_SUPPLY_PROP_CURRENT_NOW: val-intval = rt5033_get_charger_current(charger); break;

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Sebastian Reichel
. They are have vary charge rate, charge parameters. The charge parameters can be controlled by i2c interface. Driver looks mostly ok, but I have some comments [inline]. Cc: Sebastian Reichel s...@kernel.org Cc: Dmitry Eremin-Solenikov dbarysh...@gmail.com Cc: David Woodhouse dw...@infradead.org

Re: [PATCH v1 0/3 RESEND] NI Ettus Research USRP E3x0 soft-poweroff.

2015-03-07 Thread Sebastian Reichel
Hi, Please CC linux-pm. On Wed, Mar 04, 2015 at 02:25:46PM -0800, Moritz Fischer wrote: This patchset adds support for the NI Ettus Research USRP E3x0 SDR's poweroff functionality. I would prefer to have a generic driver like syscon-reboot does for system reset. -- Sebastian signature.asc

Re: [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver

2015-03-07 Thread Sebastian Reichel
and portable devices. Cc: Sebastian Reichel s...@kernel.org Signed-off-by: Beomho Seo beomho@samsung.com Reviewed-By: Sebastian Reichel s...@kernel.org I can't take it as is, since it depends on the private header file of PATCH 1. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

2015-03-07 Thread Sebastian Reichel
charging paramters to use i2c interface. Cc: Sebastian Reichel s...@kernel.org Signed-off-by: Beomho Seo beomho@samsung.com Reviewed-By: Sebastian Reichel s...@kernel.org I can't take it as is, since it depends on the private header file of PATCHv1. -- Sebastian signature.asc Description

Re: [PATCH v7 4/5] Input: add haptic drvier on max77843

2015-03-07 Thread Sebastian Reichel
Hi, On Wed, Mar 04, 2015 at 02:47:42PM -0800, Dmitry Torokhov wrote: [...] Do you want it to go through my or MFD tree? Other drivers merged in each maintainers git. Actually only Lee took PATCH 1 so far. If you don`t hava a problem, please merge your input git tree. Applied, thank

Re: [PATCH v3 4/6] ARM: dts: omap3-gta04: Add battery support

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 11:14:33PM +0100, Marek Belisko wrote: Signed-off-by: Marek Belisko ma...@goldelico.com --- arch/arm/boot/dts/omap3-gta04.dtsi | 30 ++ 1 file changed, 30 insertions(+) DTS changes must go via omap-dt tree once the driver changes have

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 11:14:32PM +0100, Marek Belisko wrote: + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values + for charging calibration (see example) + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values + for discharging calibration

Re: [PATCH v7 2/7] mfd: da9150: Add DT binding documentation for core

2015-02-25 Thread Sebastian Reichel
Hi, On Wed, Feb 18, 2015 at 02:08:26PM +, Adam Thomson wrote: Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com --- Documentation/devicetree/bindings/mfd/da9150.txt | 43 1 file changed, 43 insertions(+) create mode 100644

Re: [PATCH v7 1/7] mfd: Add support for DA9150 combined charger fuel-gauge device

2015-02-25 Thread Sebastian Reichel
Hi, On Wed, Feb 18, 2015 at 02:08:24PM +, Adam Thomson wrote: DA9150 is a combined Charger and Fuel-Gauge IC, with additional GPIO and GPADC functionality. Signed-off-by: Adam Thomson adam.thomson.opensou...@diasemi.com Acked-by: Lee Jones lee.jo...@linaro.org This patch is already in

Re: [PATCH v7 0/7] Add initial support for DA9150 Charger Fuel-Gauge IC

2015-02-25 Thread Sebastian Reichel
Hi, On Wed, Feb 18, 2015 at 02:08:19PM +, Adam Thomson wrote: This patch set adds initial support for the Dialog DA9150 Integrated Charger Fuel-Gauge IC. The device also provides GPIO and GPADC functionality. In this patch set the following is provided: - MFD Core support and DT

  1   2   3   4   5   6   >