Re: [PATCH 0/5 v7][RFC] ASoC: simple-card DT support

2013-07-11 Thread Daniel Mack
Hi Kuninori, On 25.02.2013 09:49, Kuninori Morimoto wrote: Hi Mark, Stephen, Lars These are v7 of simple-card DT support. I well considered your comments/advices. Then, I noticed that creating snd_soc_register_cpu() is better solution. It is very basic/simple version at this point, and I

Appended DTB files for multi-machine kernels

2013-07-04 Thread Daniel Mack
Hi, I'm facing a problem with a transition from legacy board-file driven ARM machines to DTB, and I'm under the impression that a solution for it could be of broader interest. In short, devices that have been deployed in quantities come in three hardware variants, which all boot with a unique

Re: Appended DTB files for multi-machine kernels

2013-07-04 Thread Daniel Mack
Hi Nicolas, On 04.07.2013 19:28, Nicolas Pitre wrote: On Thu, 4 Jul 2013, Daniel Mack wrote: I'm open to opinion and sugesstions :) What you describe above more or less fits the definition of what I called the impedance matcher. However it doesn't need to be part of the kernel at all

Re: Appended DTB files for multi-machine kernels

2013-07-04 Thread Daniel Mack
Hi Arnd, On 04.07.2013 23:34, Arnd Bergmann wrote: On Thursday 04 July 2013, Mark Brown wrote: Another way of skinning this would be for either the kernel to contain a set of machine ID to compatible string mappings or for the device trees for the boards to have an additional properties

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Daniel Mack
Hi Marek, On 26.06.2013 15:05, Marek Belisko wrote: PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add support only for I2C mode. Signed-off-by: Marek Belisko marek.beli...@streamunlimited.com --- .../devicetree/bindings/sound/ti,pcm1681.txt | 15 +

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Daniel Mack
On 26.06.2013 15:46, Marek Belisko wrote: Hi Daniel, On 06/26/2013 03:16 PM, Daniel Mack wrote: Hi Marek, On 26.06.2013 15:05, Marek Belisko wrote: PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add support only for I2C mode. Signed-off-by: Marek Belisko marek.beli

Re: [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support

2013-04-19 Thread Daniel Mack
Hi Michal, On 19.04.2013 15:38, Michal Bachraty wrote: Add devicetree support for this dummy audio soc driver. I think Mark wants to see only ASoC: in the patch subjects now. Signed-off-by: Michal Bachraty michal.bachr...@streamunlimited.com --- sound/soc/codecs/spdif_transciever.c |

Re: [PATCH 2/2] of: remove /proc/device-tree

2013-03-20 Thread Daniel Mack
On Wed, Mar 20, 2013 at 4:19 PM, Rob Herring robherri...@gmail.com wrote: On 03/20/2013 09:51 AM, Grant Likely wrote: The same data is now available in sysfs, so we can remove the code that exports it in /proc and replace it with a symlink to the sysfs version. Tested on versatile qemu model

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-20 Thread Daniel Mack
Hi Michal, On 20.03.2013 14:55, michal.bachr...@gmail.com wrote: Thanks for writing this driver! I have tested your si5351 clock driver and his tuning capabilities. It works well, it generates proper clock frequency, but when new frequency is generated, little clock gap (1ms) is generated.

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-18 Thread Daniel Mack
stored Si5351 configuration which is very helpful for clock generators with empty eeprom configuration. Corresponding device tree binding documentation is also added. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com Tested-by: Daniel Mack zon...@gmail.com Thanks! Daniel

Re: [PATCH v2] clk: add si5351 i2c common clock driver

2013-03-16 Thread Daniel Mack
functions as they read from i2c (Reported by Daniel Mack) - add CLK_SET_RATE_PARENT on clkout reparent if clkout uses its own multisync Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com Cc: Rob Landley r...@landley.net Cc: Mike Turquette mturque

Re: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

2013-03-13 Thread Daniel Mack
On 13.03.2013 06:32, Dan Carpenter wrote: val has to be signed for the error handling to work. Absolutely. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Daniel Mack zon...@gmail.com diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c index 008bea4

Re: [PATCH -next] ASoC: tas5086: use module_i2c_driver to simplify the code

2013-03-12 Thread Daniel Mack
On 12.03.2013 14:36, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Use the module_i2c_driver() macro to make the code smaller and a bit simpler. Thanks for catching this! Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Daniel Mack zon...@gmail.com

Re: [PATCH] clk: add si5351 i2c common clock driver

2013-03-01 Thread Daniel Mack
Hi Sebastian, On 27.02.2013 11:01, Sebastian Hesselbarth wrote: first of all sorry for the late answer but thanks for testing the driver. On 2/19/13, Daniel Mack zon...@gmail.com wrote: Hi Sebastian, I did some more tests today and it took me a while to dig for the root cause why things

Re: [PATCH] clk: add si5351 i2c common clock driver

2013-02-19 Thread Daniel Mack
Hi Sebastian, I did some more tests today and it took me a while to dig for the root cause why things were not working for me in the first place - see below. On 09.02.2013 13:59, Sebastian Hesselbarth wrote: +==Example== + +/* 25MHz reference crystal */ +ref25: ref25M { + compatible =

Re: [PATCH] clk: add si5351 i2c common clock driver

2013-02-18 Thread Daniel Mack
Hi Sebastian, On 09.02.2013 13:59, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver supports DT kernels only and VXCO feature of si5351b is not implemented. DT bindings selectively allow to

Re: [PATCH] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-02-18 Thread Daniel Mack
On 10.01.2013 21:22, Tony Lindgren wrote: * Andreas Fenkart andreas.fenk...@streamunlimited.com [121220 14:15]: Without functional clock the omap_hsmmc module can't forward SDIO IRQs to the system. This patch reconfigures dat1 line as a gpio while the fclk is off. And uses SDIO IRQ detection

Re: [PATCH v2 3/3] arm: omap2: gpmc: add DT bindings for OneNAND

2013-01-22 Thread Daniel Mack
Hi Tony, Mark, Ezequiel, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [130121 09:00]: Hi Mark, On Mon, Jan 21, 2013 at 9:30 AM, Mark Rutland mark.rutl...@arm.com wrote: [...] diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index

Re: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2013-01-14 Thread Daniel Mack
On Jan 15, 2013 2:06 AM, Tony Lindgren t...@atomide.com wrote: * Ezequiel Garcia elezegar...@gmail.com [121223 13:49]: On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack zon...@gmail.com wrote: + +Example for an AM33xx board: + + gpmc: gpmc@5000 { + compatible

[PATCH v8 3/5] ARM: OMAP: gpmc-nand: drop __init annotation

2012-12-14 Thread Daniel Mack
gpmc_nand_init() will be called from another driver's probe() function, so the easiest way to prevent section mismatches is to drop the annotation here. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v8 2/5] mtd: omap-nand: pass device_node in platform data

2012-12-14 Thread Daniel Mack
-by: Daniel Mack zon...@gmail.com --- drivers/mtd/nand/omap2.c | 4 +++- include/linux/platform_data/mtd-nand-omap2.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 0002d5e..1d333497c 100644

[PATCH v8 1/5] ARM: OMAP: gpmc: don't create devices from initcall on DT

2012-12-14 Thread Daniel Mack
On DT driven boards, the gpmc node will match the driver. Hence, there's no need to do that unconditionally from the initcall. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch

[PATCH v8 0/5] OMAP GPMC DT bindings

2012-12-14 Thread Daniel Mack
strings for different derivates of OMAPs - Renamed num-cs to gpmc,num-cs - Renamed num-waitpins to gpmc,num-waitpins Daniel Mack (5): ARM: OMAP: gpmc: don't create devices from initcall on DT mtd: omap-nand: pass device_node in platform data ARM: OMAP: gpmc-nand: drop __init annotation ARM

[PATCH v8 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-12-14 Thread Daniel Mack
The am33xx is capable of handling bch error correction modes, so enable that feature in the driver. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch

[PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-14 Thread Daniel Mack
to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/bus/ti-gpmc.txt | 84 ++ .../devicetree/bindings/mtd/gpmc-nand.txt | 76 + arch/arm/mach-omap2/gpmc.c | 173

Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-12 Thread Daniel Mack
On 06.12.2012 17:19, Jon Hunter wrote: On 12/05/2012 05:24 PM, Grant Likely wrote: On Wed, 5 Dec 2012 16:33:48 -0600, Jon Hunter jon-hun...@ti.com wrote: Hi Grant, On 12/05/2012 04:22 PM, Grant Likely wrote: On Wed, 5 Dec 2012 20:09:31 +0100, Daniel Mack zon...@gmail.com wrote

Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-06 Thread Daniel Mack
On 06.12.2012 17:22, Jon Hunter wrote: On 12/05/2012 06:03 PM, Tony Lindgren wrote: * Grant Likely grant.lik...@secretlab.ca [121205 15:26]: On Wed, 5 Dec 2012 16:33:48 -0600, Jon Hunter jon-hun...@ti.com wrote: On 12/05/2012 04:22 PM, Grant Likely wrote: Please, be specific. Use something

Re: [PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-06 Thread Daniel Mack
Hi Jon, On 06.12.2012 17:19, Jon Hunter wrote: On 12/05/2012 05:24 PM, Grant Likely wrote: On Wed, 5 Dec 2012 16:33:48 -0600, Jon Hunter jon-hun...@ti.com wrote: Hi Grant, On 12/05/2012 04:22 PM, Grant Likely wrote: On Wed, 5 Dec 2012 20:09:31 +0100, Daniel Mack zon...@gmail.com wrote

Re: [PATCH v6 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-12-05 Thread Daniel Mack
On 29.11.2012 21:59, Jon Hunter wrote: On 11/29/2012 02:42 PM, Daniel Mack wrote: On 29.11.2012 21:32, Jon Hunter wrote: On 11/29/2012 01:59 PM, Jon Hunter wrote: On 11/29/2012 10:01 AM, Daniel Mack wrote: The am33xx is capable of handling bch error correction modes, so enable that feature

Re: [PATCH v6 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-12-05 Thread Daniel Mack
Hi Tony, On 05.12.2012 18:19, Tony Lindgren wrote: * Daniel Mack zon...@gmail.com [121205 05:07]: On 29.11.2012 21:59, Jon Hunter wrote: On 11/29/2012 02:42 PM, Daniel Mack wrote: On 29.11.2012 21:32, Jon Hunter wrote: On 11/29/2012 01:59 PM, Jon Hunter wrote: On 11/29/2012 10:01 AM

Re: [PATCH v6 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-12-05 Thread Daniel Mack
On 05.12.2012 19:33, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [121205 10:22]: On 12/05/2012 11:41 AM, Tony Lindgren wrote: * Daniel Mack zon...@gmail.com [121205 09:29]: On 05.12.2012 18:19, Tony Lindgren wrote: The plat/cpu.h file will disappear after the merge window, which

Re: [PATCH v6 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-12-05 Thread Daniel Mack
On 05.12.2012 18:41, Tony Lindgren wrote: * Daniel Mack zon...@gmail.com [121205 09:29]: On 05.12.2012 18:19, Tony Lindgren wrote: The plat/cpu.h file will disappear after the merge window, which means omap2+ related drivers cannot use cpu_is_omap macros. For legacy booting systems

[PATCH v7 1/5] ARM: OMAP: gpmc: don't create devices from initcall on DT

2012-12-05 Thread Daniel Mack
On DT driven boards, the gpmc node will match the driver. Hence, there's no need to do that unconditionally from the initcall. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch

[PATCH v7 2/5] mtd: omap-nand: pass device_node in platform data

2012-12-05 Thread Daniel Mack
-by: Daniel Mack zon...@gmail.com --- drivers/mtd/nand/omap2.c | 4 +++- include/linux/platform_data/mtd-nand-omap2.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 0002d5e..1d333497c 100644

[PATCH v7 3/5] ARM: OMAP: gpmc-nand: drop __init annotation

2012-12-05 Thread Daniel Mack
gpmc_nand_init() will be called from another driver's probe() function, so the easiest way to prevent section mismatches is to drop the annotation here. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v7 0/5] OMAP GPMC DT bindings

2012-12-05 Thread Daniel Mack
thanks to everybody, in particular Avinash, for the long disussion about how to the these details right in the first place. Daniel Daniel Mack (5): ARM: OMAP: gpmc: don't create devices from initcall on DT mtd: omap-nand: pass device_node in platform data ARM: OMAP: gpmc-nand: drop __init

[PATCH v7 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-05 Thread Daniel Mack
to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/bus/ti-gpmc.txt | 77 ++ .../devicetree/bindings/mtd/gpmc-nand.txt | 76 + arch/arm/mach-omap2/gpmc.c | 171

Re: [PATCH v7 0/5] OMAP GPMC DT bindings

2012-12-05 Thread Daniel Mack
On 05.12.2012 20:22, Jon Hunter wrote: On 12/05/2012 01:09 PM, Daniel Mack wrote: This is a series of patches to support GPMC peripherals on OMAP boards. Grant, Rob, could you have a look and give your Acked-by if appropriate? Many thanks again, Daniel Tested on Linus' master + omap

Re: omap_hsmmc: SDIO IRQ on AM335x family

2012-11-30 Thread Daniel Mack
Hi Tony, Hi Andreas, On 30.11.2012 18:40, Tony Lindgren wrote: * Andreas Fenkart andreas.fenk...@streamunlimited.com [121130 03:21]: The alternative was to configure dat1 line as a GPIO, while waiting for an IRQ. Then configuring it back as dat1 when the SDIO card is signalling an IRQ. Or

Re: [PATCH RESEND v5 0/4] OMAP GPMC DT bindings

2012-11-29 Thread Daniel Mack
Hi Avinash, On 29.11.2012 06:24, Philip, Avinash wrote: On Wed, Nov 28, 2012 at 22:28:55, Daniel Mack wrote: [Resending +devicetree-discuss, +Rob, +Grant] This is a series of patches to support GPMC peripherals on OMAP boards. Depends on Linus' master + omap-next (branch omap-for-v3.8

Re: [PATCH v5 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-29 Thread Daniel Mack
On 29.11.2012 13:36, Philip, Avinash wrote: On Wed, Nov 28, 2012 at 22:28:59, Daniel Mack wrote: [...] +if (!of_property_read_string(child, ti,nand-ecc-opt, s)) { +for (val = 0; val ARRAY_SIZE(nand_ecc_opts); val++) +if (!strcasecmp(s, nand_ecc_opts[val

Re: [PATCH v5 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-29 Thread Daniel Mack
On 29.11.2012 15:59, Philip, Avinash wrote: On Thu, Nov 29, 2012 at 18:11:42, Daniel Mack wrote: On 29.11.2012 13:36, Philip, Avinash wrote: On Wed, Nov 28, 2012 at 22:28:59, Daniel Mack wrote: [...] + if (!of_property_read_string(child, ti,nand-ecc-opt, s)) { + for (val = 0; val

Re: [PATCH RESEND v5 0/4] OMAP GPMC DT bindings

2012-11-29 Thread Daniel Mack
On 29.11.2012 16:08, Philip, Avinash wrote: On Thu, Nov 29, 2012 at 17:28:04, Daniel Mack wrote: Hi Avinash, On 29.11.2012 06:24, Philip, Avinash wrote: On Wed, Nov 28, 2012 at 22:28:55, Daniel Mack wrote: [Resending +devicetree-discuss, +Rob, +Grant] This is a series of patches

[PATCH v6 1/5] ARM: OMAP: gpmc: don't create devices from initcall on DT

2012-11-29 Thread Daniel Mack
On DT driven boards, the gpmc node will match the driver. Hence, there's no need to do that unconditionally from the initcall. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch

[PATCH v6 2/5] mtd: omap-nand: pass device_node in platform data

2012-11-29 Thread Daniel Mack
-by: Daniel Mack zon...@gmail.com --- drivers/mtd/nand/omap2.c | 4 +++- include/linux/platform_data/mtd-nand-omap2.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 3282b15..a733f15 100644 --- a/drivers

[PATCH v6 3/5] ARM: OMAP: gpmc-nand: drop __init annotation

2012-11-29 Thread Daniel Mack
gpmc_nand_init() will be called from another driver's probe() function, so the easiest way to prevent section mismatches is to drop the annotation here. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v6 0/5] OMAP GPMC DT bindings

2012-11-29 Thread Daniel Mack
to the these details right in the first place. Daniel Daniel Mack (5): ARM: OMAP: gpmc: don't create devices from initcall on DT mtd: omap-nand: pass device_node in platform data ARM: OMAP: gpmc-nand: drop __init annotation ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs ARM: OMAP: gpmc: add DT bindings

[PATCH v6 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-11-29 Thread Daniel Mack
The am33xx is capable of handling bch error correction modes, so enable that feature in the driver. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch

[PATCH v6 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-29 Thread Daniel Mack
to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/bus/ti-gpmc.txt | 76 + .../devicetree/bindings/mtd/gpmc-nand.txt | 76 + arch/arm/mach-omap2/gpmc.c | 171

Re: [PATCH v6 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-11-29 Thread Daniel Mack
On 29.11.2012 21:32, Jon Hunter wrote: On 11/29/2012 01:59 PM, Jon Hunter wrote: On 11/29/2012 10:01 AM, Daniel Mack wrote: The am33xx is capable of handling bch error correction modes, so enable that feature in the driver. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach

Re: [PATCH v6 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-29 Thread Daniel Mack
On 29.11.2012 21:28, Jon Hunter wrote: On 11/29/2012 10:01 AM, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instantiated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND. Code was added

[PATCH v5 2/4] ARM: OMAP: gpmc-nand: drop __init annotation

2012-11-28 Thread Daniel Mack
gpmc_nand_init() will be called from another driver's probe() function, so the easiest way to prevent section mismatches is to drop the annotation here. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v5 1/4] mtd: omap-nand: pass device_node in platform data

2012-11-28 Thread Daniel Mack
-by: Daniel Mack zon...@gmail.com --- drivers/mtd/nand/omap2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 3282b15..a733f15 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1331,6 +1331,7 @@ static

[PATCH v5 3/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-11-28 Thread Daniel Mack
The am33xx is capable of handling bch error correction modes, so enable that feature in the driver. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch

[PATCH RESEND v5 0/4] OMAP GPMC DT bindings

2012-11-28 Thread Daniel Mack
software ecc mode to sw - Initialize gpmc_nand_data-is_elm_used to 'true' rather than 1 - Drop ti,nand-ecc-use-elm binding in favor of a new ecc mode named bch8-am335xrbl-compatible - Add two more patches for section mismatch fixups Daniel Mack (4): mtd: omap-nand: pass device_node in platform

[PATCH v5 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-28 Thread Daniel Mack
to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/bus/ti-gpmc.txt | 76 + .../devicetree/bindings/mtd/gpmc-nand.txt | 81 + arch/arm/mach-omap2/gpmc.c | 181

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-27 Thread Daniel Mack
Hi Avinash, Hi Peter, On 23.11.2012 11:43, Philip, Avinash wrote: On Wed, Nov 21, 2012 at 15:45:23, Daniel Mack wrote: On 20.11.2012 16:59, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Peter, In patch [1], mtd: nand: omap2: Support for hardware BCH ecc_layout

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-21 Thread Daniel Mack
On 20.11.2012 16:59, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Hi, In omap2 driver NAND_ECC_HW ecc mode supports 3 ecc layout OMAP_ECC_HAMMING_CODE_HW_ROMCODE OMAP_ECC_BCH4_CODE_HW OMAP_ECC_BCH8_CODE_HW So selection of ecc layout data should

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-14 Thread Daniel Mack
On 11.11.2012 02:56, Daniel Mack wrote: On 07.11.2012 16:37, Philip, Avinash wrote: On Wed, Nov 07, 2012 at 15:18:37, Daniel Mack wrote: On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-07 Thread Daniel Mack
On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-05 Thread Daniel Mack
On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND

Re: [PATCH v2 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-05 Thread Daniel Mack
On 05.11.2012 22:46, Jon Hunter wrote: On 11/02/2012 03:23 PM, Daniel Mack wrote: On 02.11.2012 20:57, Jon Hunter wrote: On 11/02/2012 02:23 PM, Daniel Mack wrote: On 02.11.2012 20:18, Jon Hunter wrote: On 11/02/2012 06:14 AM, Daniel Mack wrote: diff --git a/Documentation/devicetree

Re: [PATCH v2 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-02 Thread Daniel Mack
, On 11/01/2012 01:36 PM, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND. Code was added to parse the generic GPMC timing

[PATCH v3 0/4] RFC: OMAP GPMC DT bindings

2012-11-02 Thread Daniel Mack
of the child iteration Daniel Mack (4): mtd: omap-nand: pass device_node in platform data ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs ARM: OMAP: gpmc: don't create devices from initcall on DT ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Documentation/devicetree/bindings/bus

[PATCH v3 2/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-11-02 Thread Daniel Mack
Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c index 8607735..c3616c6 100644 --- a/arch/arm/mach-omap2/gpmc-nand.c +++ b/arch/arm

[PATCH v3 1/4] mtd: omap-nand: pass device_node in platform data

2012-11-02 Thread Daniel Mack
-by: Daniel Mack zon...@gmail.com --- drivers/mtd/nand/omap2.c | 4 +++- include/linux/platform_data/mtd-nand-omap2.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 3282b15..a733f15 100644 --- a/drivers

[PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-02 Thread Daniel Mack
to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/bus/ti-gpmc.txt | 76 +++ .../devicetree/bindings/mtd/gpmc-nand.txt | 60 + arch/arm/mach-omap2/gpmc.c | 141

Re: [PATCH v2 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-02 Thread Daniel Mack
Hi Jon, On 02.11.2012 20:18, Jon Hunter wrote: On 11/02/2012 06:14 AM, Daniel Mack wrote: Hi Jon, as all comments so far focussed on patch 4/4, could we agree to merge 1-3 of this series already? These are all small and straight-forward things that don't depend on 4/4. That way, I only need

Re: [PATCH 0/5] usb: musb: am335x support

2012-11-02 Thread Daniel Mack
Hi Afzal, On 02.11.2012 17:31, Afzal Mohammed wrote: This series adds usb support to am335x SoC's found on boards like Beagle Bone. Here only first instance is supported, as currently multiple phy's of same type is not supported (am335x has two USB2 phy's). I'm testing these patches with an

[PATCH v2 1/4] mtd: omap-nand: pass device_node in platform data

2012-11-01 Thread Daniel Mack
-by: Daniel Mack zon...@gmail.com --- drivers/mtd/nand/omap2.c | 4 +++- include/linux/platform_data/mtd-nand-omap2.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 3282b15..a733f15 100644 --- a/drivers

[PATCH v2 3/4] ARM: OMAP: gpmc: don't create devices from initcall on DT

2012-11-01 Thread Daniel Mack
On DT driven boards, the gpmc node will match the driver. Hence, there's no need to do that unconditionally from the initcall. Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch

[PATCH v2 0/4] RFC: OMAP GPMC DT bindings

2012-11-01 Thread Daniel Mack
with less pain. Thanks, Daniel Daniel Mack (4): mtd: omap-nand: pass device_node in platform data ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs ARM: OMAP: gpmc: don't create devices from initcall on DT ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Documentation/devicetree/bindings

[PATCH v2 2/4] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs

2012-11-01 Thread Daniel Mack
Signed-off-by: Daniel Mack zon...@gmail.com --- arch/arm/mach-omap2/gpmc-nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c index 8607735..c3616c6 100644 --- a/arch/arm/mach-omap2/gpmc-nand.c +++ b/arch/arm

[PATCH v2 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-01 Thread Daniel Mack
to use them. Successfully tested on an AM33xx board. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/bus/ti-gpmc.txt | 73 +++ .../devicetree/bindings/mtd/gpmc-nand.txt | 61 + arch/arm/mach-omap2/gpmc.c | 139

Re: [U-Boot] Merging device trees at runtime for module-based systems

2012-10-31 Thread Daniel Mack
cc devicetree-discuss. Here's a reference to the full thread: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/145221/ On 26.10.2012 20:39, Stephen Warren wrote: On 10/24/2012 03:47 AM, Daniel Mack wrote: Hi, a project I'm involved in uses a module/baseboard combo, and components

Re: [U-Boot] Merging device trees at runtime for module-based systems

2012-10-31 Thread Daniel Mack
On 01.11.2012 00:13, Stephen Warren wrote: On 10/31/2012 05:00 PM, Daniel Mack wrote: cc devicetree-discuss. Here's a reference to the full thread: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/145221/ On 26.10.2012 20:39, Stephen Warren wrote: On 10/24/2012 03:47 AM, Daniel Mack

Re: Representation of external memory-mapped devices in DT (gpmc)

2012-10-31 Thread Daniel Mack
On 30.10.2012 11:50, Afzal Mohammed wrote: Hi Daniel, On Monday 29 October 2012 10:52 PM, Daniel Mack wrote: On 29.10.2012 16:09, Rob Herring wrote: You may want a CS0 node with nand as a child node of that. Hmm, I don't see what that would buy us. The question is which way is feasible

Representation of external memory-mapped devices in DT (gpmc)

2012-10-29 Thread Daniel Mack
Hi, we're currently working on a DT binding for the GPMC bus that is found on SoCs by TI. The implementation is based on CS lines and an 8, 16 or 32 bit parallel interface. That IP is quite flexible, and it can for example be used for physmap flash, external peripherals or even NAND. Depending

Re: Representation of external memory-mapped devices in DT (gpmc)

2012-10-29 Thread Daniel Mack
On 29.10.2012 16:09, Rob Herring wrote: On 10/29/2012 09:39 AM, Daniel Mack wrote: Hi, we're currently working on a DT binding for the GPMC bus that is found on SoCs by TI. The implementation is based on CS lines and an 8, 16 or 32 bit parallel interface. That IP is quite flexible

Re: Representation of external memory-mapped devices in DT (gpmc)

2012-10-29 Thread Daniel Mack
Hi Rob, On Oct 29, 2012 10:49 PM, Rob Herring robherri...@gmail.com wrote: On 10/29/2012 12:22 PM, Daniel Mack wrote: On 29.10.2012 16:09, Rob Herring wrote: On 10/29/2012 09:39 AM, Daniel Mack wrote: Hi, we're currently working on a DT binding for the GPMC bus that is found on SoCs

Re: [PATCH v4 3/5] rtc: omap: dt support

2012-10-21 Thread Daniel Mack
On 19.10.2012 11:59, Afzal Mohammed wrote: enhance rtc-omap driver with DT capability Signed-off-by: Afzal Mohammed af...@ti.com Acked-by: Sekhar Nori nsek...@ti.com --- v4: Proper devicetree documentation v2: Use compatible as ti,da830-rtc instead of ti,am1808-rtc

Re: [RFC] Common clock framework for external clock generators

2012-10-14 Thread Daniel Mack
Hi, On 14.10.2012 12:59, Sebastian Hesselbarth wrote: Adding LAKML and devtree as there might be people willing to comment about DT representation of i2c-attached clock generators, too. On 10/12/2012 08:17 PM, Daniel Mack wrote: On 11.10.2012 18:00, Sebastian Hesselbarth wrote

Re: [PATCH 1/2] net: ti cpsw ethernet: allow reading phy interface mode from DT

2012-10-01 Thread Daniel Mack
On 01.10.2012 23:11, David Miller wrote: From: Daniel Mack zon...@gmail.com Date: Wed, 26 Sep 2012 19:24:27 +0200 Allow users to specify the phy interface of the CPSW slaves. The new node parameter is called phy_if_mode and is optional. The original behaviour of the driver is preserved when

Re: [PATCH 2/2] net: ti cpsw ethernet: set IFCTL_{A, B} bits for RMII mode

2012-09-27 Thread Daniel Mack
On 26.09.2012 20:50, N, Mugunthan V wrote: For RMII mode operation in 100Mbps, the CPSW needs to set the IFCTL_A / IFCTL_B bits in the MACCONTROL register. Signed-off-by: Daniel Mack zon...@gmail.com Cc: Mugunthan V N mugunthan...@ti.com Cc: Vaibhav Hiremath hvaib...@ti.com Cc: David S

[PATCH 1/2] net: ti cpsw ethernet: allow reading phy interface mode from DT

2012-09-26 Thread Daniel Mack
Allow users to specify the phy interface of the CPSW slaves. The new node parameter is called phy_if_mode and is optional. The original behaviour of the driver is preserved when not given. Signed-off-by: Daniel Mack zon...@gmail.com Cc: Mugunthan V N mugunthan...@ti.com Cc: Vaibhav Hiremath hvaib

[PATCH 2/2] net: ti cpsw ethernet: set IFCTL_{A, B} bits for RMII mode

2012-09-26 Thread Daniel Mack
For RMII mode operation in 100Mbps, the CPSW needs to set the IFCTL_A / IFCTL_B bits in the MACCONTROL register. Signed-off-by: Daniel Mack zon...@gmail.com Cc: Mugunthan V N mugunthan...@ti.com Cc: Vaibhav Hiremath hvaib...@ti.com Cc: David S. Miller da...@davemloft.net --- drivers/net/ethernet

Re: [PATCH v2] regulator: gpio-regulator: add DT bindings

2012-09-12 Thread Daniel Mack
Hi Stephen, On 10.09.2012 21:40, Stephen Warren wrote: On 09/10/2012 09:03 AM, Daniel Mack wrote: Add DT bindings for the gpio-regulator driver and some documentation on how to use it. +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt @@ -0,0 +1,58 @@ +Device tree

[PATCH] regulator: gpio-regulator: add DT bindings

2012-09-10 Thread Daniel Mack
Add DT bindings for the gpio-regulator driver and some documentation on how to use it. Signed-off-by: Daniel Mack zon...@gmail.com --- .../bindings/regulator/gpio-regulator.txt | 58 ++ drivers/regulator/gpio-regulator.c | 118 - 2 files

[PATCH v2] regulator: gpio-regulator: add DT bindings

2012-09-10 Thread Daniel Mack
Add DT bindings for the gpio-regulator driver and some documentation on how to use it. Signed-off-by: Daniel Mack zon...@gmail.com --- v1 - v2 Fixed wrong kzalloc() size. .../bindings/regulator/gpio-regulator.txt | 58 ++ drivers/regulator/gpio-regulator.c

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-05 Thread Daniel Mack
On 05.09.2012 05:24, Mark Brown wrote: On Mon, Sep 03, 2012 at 01:50:34PM +0200, Linus Walleij wrote: On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack zon...@gmail.com wrote: Hmm, I don't know whether anyone took those patches yet? Mark? Mark better take them, ping on Mark. IIRC I did reply

[PATCH RESEND-2 2/2] SPI: spi-gpio: Add DT bindings

2012-09-05 Thread Daniel Mack
This patch adds DT bindings to the spi-gpio driver and some documentation about how to use it. Signed-off-by: Daniel Mack zon...@gmail.com --- Documentation/devicetree/bindings/spi/spi-gpio.txt | 29 +++ drivers/spi/spi-gpio.c | 99 +- 2 files

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-02 Thread Daniel Mack
On 05.08.2012 21:12, Linus Walleij wrote: On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack zon...@gmail.com wrote: Acked-by: Linus Walleij linus.wall...@linaro.org Ok, thanks. Mark, did the patches reach you this time? I think they should go thru the SPI tree. Yeah no problem, Mark is always

Re: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-15 Thread Daniel Mack
On 15.08.2012 09:13, Éric Piel wrote: On 07-08-12 20:49, Daniel Mack wrote: : I fixed all these issues now and attached a v4. Sorry for the late reply, I had read the v3 but didn't find time to send comments. They are all addressed in v4. For both [PATCH v4 1/2] and [PATCH v3 2/2

Re: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-08 Thread Daniel Mack
On 08.08.2012 07:19, AnilKumar, Chimata wrote: Hi Mack, Call me Daniel :) On Wed, Aug 08, 2012 at 00:19:01, Daniel Mack wrote: On 06.08.2012 12:45, AnilKumar, Chimata wrote: On Sun, Aug 05, 2012 at 21:48:42, Daniel Mack wrote: On 30.07.2012 09:36, Daniel Mack wrote: This patch adds logic

Re: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-07 Thread Daniel Mack
Hi, thanks for your review. On 06.08.2012 12:45, AnilKumar, Chimata wrote: On Sun, Aug 05, 2012 at 21:48:42, Daniel Mack wrote: On 30.07.2012 09:36, Daniel Mack wrote: This patch adds logic to parse lis3 properties from a device tree node and store them in a freshly allocated

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-08-05 Thread Daniel Mack
On 05.08.2012 02:14, Linus Walleij wrote: On Wed, Aug 1, 2012 at 10:57 PM, Daniel Mack zon...@gmail.com wrote: This patch adds DT bindings to the spi-gpio driver and some documentation about how to use it. Signed-off-by: Daniel Mack zon...@gmail.com Cc: Mark Brown broo

Re: [PATCH resend 1/2] SPI: spi-gpio: store chipselect information in private structure

2012-08-05 Thread Daniel Mack
On 04.08.2012 13:12, Mark Brown wrote: On Wed, Aug 01, 2012 at 10:57:17PM +0200, Daniel Mack wrote: The spi-gpio driver currently assumes the chipselect gpio number is stored in -controller_data of the device's static board information. Applied both, thanks. It's a bit sad that we need

Re: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-05 Thread Daniel Mack
Ping, anyone? On 30.07.2012 09:36, Daniel Mack wrote: This patch adds logic to parse lis3 properties from a device tree node and store them in a freshly allocated lis3lv02d_platform_data. Note that the actual match tables are left out here. This part should happen in the drivers that bind

Re: [PATCH v7 00/11] usb: musb: adding multi instance support

2012-08-05 Thread Daniel Mack
On 03.08.2012 17:48, Hiremath, Vaibhav wrote: On Fri, Aug 03, 2012 at 17:11:38, Daniel Mack wrote: On 03.08.2012 11:07, Hiremath, Vaibhav wrote: I have just pushed the code (V7 which Ravi submitted), so can you please try with below branch? https://github.com/hvaibhav/am335x-linux/tree

Re: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-05 Thread Daniel Mack
On 06.08.2012 06:52, Rob Herring wrote: On 08/05/2012 11:18 AM, Daniel Mack wrote: Ping, anyone? On 30.07.2012 09:36, Daniel Mack wrote: This patch adds logic to parse lis3 properties from a device tree node and store them in a freshly allocated lis3lv02d_platform_data. Note

  1   2   >