Re: std.experimental.color, request reviews

2015-08-04 Thread Guillaume Chatelet via Digitalmars-d
On Tuesday, 4 August 2015 at 14:24:47 UTC, Manu wrote: On 4 August 2015 at 21:01, Manu wrote: On 4 August 2015 at 05:47, Tofu Ninja via Digitalmars-d wrote: On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite ha

Re: std.experimental.color, request reviews

2015-08-04 Thread Manu via Digitalmars-d
On 4 August 2015 at 22:13, Suliman via Digitalmars-d wrote: > On Tuesday, 4 August 2015 at 11:01:58 UTC, Manu wrote: >> >> On 4 August 2015 at 05:47, Tofu Ninja via Digitalmars-d >> wrote: >>> >>> On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programmin

Re: std.experimental.color, request reviews

2015-08-04 Thread Manu via Digitalmars-d
On 4 August 2015 at 21:01, Manu wrote: > On 4 August 2015 at 05:47, Tofu Ninja via Digitalmars-d > wrote: >> On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: >>> >>> https://github.com/D-Programming-Language/phobos/pull/2845 >>> >>> I'm getting quite happy with it. >>> I think it's a good an

Re: std.experimental.color, request reviews

2015-08-04 Thread Suliman via Digitalmars-d
On Tuesday, 4 August 2015 at 11:01:58 UTC, Manu wrote: On 4 August 2015 at 05:47, Tofu Ninja via Digitalmars-d wrote: On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fair

Re: std.experimental.color, request reviews

2015-08-04 Thread Manu via Digitalmars-d
On 4 August 2015 at 05:47, Tofu Ninja via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: >> >> https://github.com/D-Programming-Language/phobos/pull/2845 >> >> I'm getting quite happy with it. >> I think it's a good and fairly minimal but useful starting point. >> >>

Re: std.experimental.color, request reviews

2015-08-03 Thread Tofu Ninja via Digitalmars-d
On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fairly minimal but useful starting point. It'd be great to get some reviews from here. Whats the status on this? This rea

Re: std.experimental.color, request reviews

2015-06-30 Thread Danni Coy via Digitalmars-d
Huey (pronounced with an Australian Twang)? HSx works On Fri, Jun 26, 2015 at 7:11 AM, Guillaume Chatelet via Digitalmars-d wrote: > On Thursday, 25 June 2015 at 21:06:59 UTC, Guillaume Chatelet wrote: >> >> On Thursday, 25 June 2015 at 13:36:57 UTC, Manu wrote: >>> >>> How about HSx ? That's t

Re: std.experimental.color, request reviews

2015-06-25 Thread Guillaume Chatelet via Digitalmars-d
On Thursday, 25 June 2015 at 21:06:59 UTC, Guillaume Chatelet wrote: On Thursday, 25 June 2015 at 13:36:57 UTC, Manu wrote: How about HSx ? That's the best I've got! :P Not too bad :-) I'm not too excited about this but how about : HS!L HS!V .,. It could work with a good documentation. Or

Re: std.experimental.color, request reviews

2015-06-25 Thread Guillaume Chatelet via Digitalmars-d
On Thursday, 25 June 2015 at 13:36:57 UTC, Manu wrote: How about HSx ? That's the best I've got! :P Not too bad :-) I'm not too excited about this but how about : HS!L HS!V .,. It could work with a good documentation.

Re: std.experimental.color, request reviews

2015-06-25 Thread Kagamin via Digitalmars-d
On Thursday, 25 June 2015 at 13:36:57 UTC, Manu wrote: How about HSx ? That's the best I've got! :P HueBased?

Re: std.experimental.color, request reviews

2015-06-25 Thread Manu via Digitalmars-d
How about HSx ? That's the best I've got! :P On 25 June 2015 at 15:45, Manu wrote: > On 25 June 2015 at 15:18, Danni Coy via Digitalmars-d > wrote: >> I would probably go with "perceptual" or something like it > > That sounds like you're talking about Lab or CAM. > > >> On Thu, Jun 25, 2015 at 2

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 25 June 2015 at 15:18, Danni Coy via Digitalmars-d wrote: > I would probably go with "perceptual" or something like it That sounds like you're talking about Lab or CAM. > On Thu, Jun 25, 2015 at 2:39 PM, Danni Coy wrote: >> Wikipedia at least refer to these as cylindrical colour spaces

Re: std.experimental.color, request reviews

2015-06-24 Thread Danni Coy via Digitalmars-d
I would probably go with "perceptual" or something like it On Thu, Jun 25, 2015 at 2:39 PM, Danni Coy wrote: > Wikipedia at least refer to these as cylindrical colour spaces > > > On Thu, Jun 25, 2015 at 2:05 PM, Manu via Digitalmars-d > wrote: >> On 25 June 2015 at 07:14, Guillaume Chatelet vi

Re: std.experimental.color, request reviews

2015-06-24 Thread Danni Coy via Digitalmars-d
Wikipedia at least refer to these as cylindrical colour spaces On Thu, Jun 25, 2015 at 2:05 PM, Manu via Digitalmars-d wrote: > On 25 June 2015 at 07:14, Guillaume Chatelet via Digitalmars-d > wrote: >> On Wednesday, 24 June 2015 at 21:08:03 UTC, Guillaume Chatelet wrote: >>> >>> On Wednesday,

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 25 June 2015 at 07:14, Guillaume Chatelet via Digitalmars-d wrote: > On Wednesday, 24 June 2015 at 21:08:03 UTC, Guillaume Chatelet wrote: >> >> On Wednesday, 24 June 2015 at 16:05:31 UTC, Manu wrote: >>> >>> On a tangent, I need a name for the struct that will represent >>> HSL/HSV/HSI/HCY. >>

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 25 June 2015 at 07:05, Tofu Ninja via Digitalmars-d wrote: > On Wednesday, 24 June 2015 at 08:47:50 UTC, Manu wrote: >> >> Ah okay. >> Yeah, it's an interesting idea. It's only applicable to RGB colours. >> What's a bit awkward, is it's not entirely clear where the result of >> the swizzle is a

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 25 June 2015 at 05:59, Adam D. Ruppe via Digitalmars-d wrote: > On Wednesday, 24 June 2015 at 05:30:50 UTC, Manu wrote: >> >> Right, and this was what I had in mind. >> I think the average user would want to: import std.color, and that's >> it. They will probably want RGB8 or RGBA8. >> Most use

Re: std.experimental.color, request reviews

2015-06-24 Thread Guillaume Chatelet via Digitalmars-d
On Wednesday, 24 June 2015 at 21:08:03 UTC, Guillaume Chatelet wrote: On Wednesday, 24 June 2015 at 16:05:31 UTC, Manu wrote: On a tangent, I need a name for the struct that will represent HSL/HSV/HSI/HCY. They're all basically identical, and might as well be a parameter to a shared type... bu

Re: std.experimental.color, request reviews

2015-06-24 Thread Guillaume Chatelet via Digitalmars-d
On Wednesday, 24 June 2015 at 16:05:31 UTC, Manu wrote: On a tangent, I need a name for the struct that will represent HSL/HSV/HSI/HCY. They're all basically identical, and might as well be a parameter to a shared type... but I can't think of a name for that type! >_< I can't reasonably call it

Re: std.experimental.color, request reviews

2015-06-24 Thread Tofu Ninja via Digitalmars-d
On Wednesday, 24 June 2015 at 08:47:50 UTC, Manu wrote: Ah okay. Yeah, it's an interesting idea. It's only applicable to RGB colours. What's a bit awkward, is it's not entirely clear where the result of the swizzle is assigned? Is the result of the swizzle assigned to the colours present in th

Re: std.experimental.color, request reviews

2015-06-24 Thread Adam D. Ruppe via Digitalmars-d
On Wednesday, 24 June 2015 at 05:30:50 UTC, Manu wrote: Right, and this was what I had in mind. I think the average user would want to: import std.color, and that's it. They will probably want RGB8 or RGBA8. Most users will never touch anything else in the API, so using package.d as an "import

Re: std.experimental.color, request reviews

2015-06-24 Thread Fool via Digitalmars-d
On Wednesday, 24 June 2015 at 16:05:31 UTC, Manu wrote: On a tangent, I need a name for the struct that will represent HSL/HSV/HSI/HCY. They're all basically identical, and might as well be a parameter to a shared type... but I can't think of a name for that type! >_< I can't reasonably call it

Re: std.experimental.color, request reviews

2015-06-24 Thread via Digitalmars-d
I probably didn't express myself very clearly, with the double negation... What I wanted to suggest is to put into package.d _only_ the very minimum that you will always need, e.g. the basic structures. Example: std/ color/ package.d# only very basic stuff definitions.d

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On a tangent, I need a name for the struct that will represent HSL/HSV/HSI/HCY. They're all basically identical, and might as well be a parameter to a shared type... but I can't think of a name for that type! >_< I can't reasonably call it any of those or it would be confused, rather, each of those

Re: std.experimental.color, request reviews

2015-06-24 Thread Guillaume Chatelet via Digitalmars-d
On Wednesday, 24 June 2015 at 11:02:04 UTC, Manu wrote: Don't worry, I'm an optics nerd! Well I can tell by reading the PR already ;) I just wanted to make sure : - nothing important was overlooked - what was the scope ot the proposal Now I think my main concern is about conversions getting ou

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 24 June 2015 at 20:11, Guillaume Chatelet via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: >> >> https://github.com/D-Programming-Language/phobos/pull/2845 >> >> I'm getting quite happy with it. >> I think it's a good and fairly minimal but useful starting point.

Re: std.experimental.color, request reviews

2015-06-24 Thread Guillaume Chatelet via Digitalmars-d
On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fairly minimal but useful starting point. It'd be great to get some reviews from here. My experience (my previous job inv

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 24 June 2015 at 17:58, Andrea Fontana via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: >> >> https://github.com/D-Programming-Language/phobos/pull/2845 >> >> I'm getting quite happy with it. >> I think it's a good and fairly minimal but useful starting point. >>

Re: std.experimental.color, request reviews

2015-06-24 Thread Manu via Digitalmars-d
On 24 June 2015 at 17:18, Tofu Ninja via Digitalmars-d wrote: > On Wednesday, 24 June 2015 at 04:47:35 UTC, Manu wrote: >> >> They work fine. Just cast between color structs with different component >> orders: >> >> BGR8 a = Color.white; >> RGB8 b = a; // <- did swizzle >> >> Is there a specific a

Re: std.experimental.color, request reviews

2015-06-24 Thread Andrea Fontana via Digitalmars-d
On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fairly minimal but useful starting point. It'd be great to get some reviews from here. Some points about blend/lerp: - U

Re: std.experimental.color, request reviews

2015-06-24 Thread Tofu Ninja via Digitalmars-d
On Wednesday, 24 June 2015 at 04:47:35 UTC, Manu wrote: They work fine. Just cast between color structs with different component orders: BGR8 a = Color.white; RGB8 b = a; // <- did swizzle Is there a specific api you miss? On 24 June 2015 at 05:34, Tofu Ninja via Digitalmars-d wrote: On T

Re: std.experimental.color, request reviews

2015-06-23 Thread Manu via Digitalmars-d
On 24 June 2015 at 03:11, Adam D. Ruppe via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 16:14:59 UTC, Marc Schütz wrote: >> >> But that's more an argument against putting anything _except_ the basic >> definitions into package.d, no? Then you can always exclude the more >> specific stuff wh

Re: std.experimental.color, request reviews

2015-06-23 Thread Mike via Digitalmars-d
On Wednesday, 24 June 2015 at 04:48:28 UTC, Manu wrote: I just don't want to write all the others which will mirror this set of API decisions almost verbatim until the API is stabilised. A wise decision. I understand.

Re: std.experimental.color, request reviews

2015-06-23 Thread Manu via Digitalmars-d
They work fine. Just cast between color structs with different component orders: BGR8 a = Color.white; RGB8 b = a; // <- did swizzle Is there a specific api you miss? On 24 June 2015 at 05:34, Tofu Ninja via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: >> >> htt

Re: std.experimental.color, request reviews

2015-06-23 Thread Manu via Digitalmars-d
On 24 June 2015 at 08:46, Mike via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: > >> It'd be great to get some reviews from here. > > > I would like to see the packed implementatiin finished before this is > pulled, but I won't stand in its way. I just don't want t

Re: std.experimental.color, request reviews

2015-06-23 Thread Mike via Digitalmars-d
On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: It'd be great to get some reviews from here. I would like to see the packed implementatiin finished before this is pulled, but I won't stand in its way. Mike

Re: std.experimental.color, request reviews

2015-06-23 Thread Tofu Ninja via Digitalmars-d
On Tuesday, 23 June 2015 at 14:58:35 UTC, Manu wrote: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fairly minimal but useful starting point. It'd be great to get some reviews from here. Swizzels would be a nice addition.

Re: std.experimental.color, request reviews

2015-06-23 Thread Sönke Ludwig via Digitalmars-d
Am 23.06.2015 um 16:58 schrieb Manu via Digitalmars-d: https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fairly minimal but useful starting point. It'd be great to get some reviews from here. From a quick glance, looks very ni

Re: std.experimental.color, request reviews

2015-06-23 Thread Adam D. Ruppe via Digitalmars-d
On Tuesday, 23 June 2015 at 17:53:43 UTC, John Colvin wrote: Isn't this what selective imports are for? Not quite the same thing: selective imports control which symbols you pull into the current namespace, but not which code gets pulled into the binary. If you do `import foo : bar;`, the c

Re: std.experimental.color, request reviews

2015-06-23 Thread Steven Schveighoffer via Digitalmars-d
On 6/23/15 1:59 PM, Meta wrote: On Tuesday, 23 June 2015 at 17:53:43 UTC, John Colvin wrote: Isn't this what selective imports are for? Admittedly it's not quite as convenient, but it does let you choose exactly what you want. You can even make a module that wraps a manually selected set of impo

Re: std.experimental.color, request reviews

2015-06-23 Thread John Colvin via Digitalmars-d
On Tuesday, 23 June 2015 at 17:59:48 UTC, Meta wrote: On Tuesday, 23 June 2015 at 17:53:43 UTC, John Colvin wrote: Isn't this what selective imports are for? Admittedly it's not quite as convenient, but it does let you choose exactly what you want. You can even make a module that wraps a manual

Re: std.experimental.color, request reviews

2015-06-23 Thread Meta via Digitalmars-d
On Tuesday, 23 June 2015 at 17:53:43 UTC, John Colvin wrote: Isn't this what selective imports are for? Admittedly it's not quite as convenient, but it does let you choose exactly what you want. You can even make a module that wraps a manually selected set of imports, e.g. you do your own basic

Re: std.experimental.color, request reviews

2015-06-23 Thread John Colvin via Digitalmars-d
On Tuesday, 23 June 2015 at 17:11:57 UTC, Adam D. Ruppe wrote: On Tuesday, 23 June 2015 at 16:14:59 UTC, Marc Schütz wrote: But that's more an argument against putting anything _except_ the basic definitions into package.d, no? Then you can always exclude the more specific stuff whenever you ne

Re: std.experimental.color, request reviews

2015-06-23 Thread H. S. Teoh via Digitalmars-d
On Tue, Jun 23, 2015 at 03:24:41PM +, John Colvin via Digitalmars-d wrote: > On Tuesday, 23 June 2015 at 15:01:59 UTC, Adam D. Ruppe wrote: > >Just a quick concern, I don't think a package.d should ever have > >anything except imports in it. Put all the actual aliases and color > >lists in some

Re: std.experimental.color, request reviews

2015-06-23 Thread Adam D. Ruppe via Digitalmars-d
On Tuesday, 23 June 2015 at 16:14:59 UTC, Marc Schütz wrote: But that's more an argument against putting anything _except_ the basic definitions into package.d, no? Then you can always exclude the more specific stuff whenever you need it, and those modules themselves can publicly import package

Re: std.experimental.color, request reviews

2015-06-23 Thread via Digitalmars-d
On Tuesday, 23 June 2015 at 15:29:42 UTC, Adam D. Ruppe wrote: On Tuesday, 23 June 2015 at 15:24:44 UTC, John Colvin wrote: std/range/package.d and std/regex/package.d both have a bunch of stuff in. Why not? Those are also mistakes (well, probably just semi-migrated from the old big module).

Re: std.experimental.color, request reviews

2015-06-23 Thread Rikki Cattermole via Digitalmars-d
On 24/06/2015 3:29 a.m., Adam D. Ruppe wrote: On Tuesday, 23 June 2015 at 15:24:44 UTC, John Colvin wrote: std/range/package.d and std/regex/package.d both have a bunch of stuff in. Why not? Those are also mistakes (well, probably just semi-migrated from the old big module). Suppose you want s

Re: std.experimental.color, request reviews

2015-06-23 Thread Dmitry Olshansky via Digitalmars-d
On 23-Jun-2015 18:24, John Colvin wrote: On Tuesday, 23 June 2015 at 15:01:59 UTC, Adam D. Ruppe wrote: Just a quick concern, I don't think a package.d should ever have anything except imports in it. Put all the actual aliases and color lists in some other submodule that can be imported independ

Re: std.experimental.color, request reviews

2015-06-23 Thread Adam D. Ruppe via Digitalmars-d
On Tuesday, 23 June 2015 at 15:24:44 UTC, John Colvin wrote: std/range/package.d and std/regex/package.d both have a bunch of stuff in. Why not? Those are also mistakes (well, probably just semi-migrated from the old big module). Suppose you want some of that stuff without the rest of the pac

Re: std.experimental.color, request reviews

2015-06-23 Thread John Colvin via Digitalmars-d
On Tuesday, 23 June 2015 at 15:01:59 UTC, Adam D. Ruppe wrote: Just a quick concern, I don't think a package.d should ever have anything except imports in it. Put all the actual aliases and color lists in some other submodule that can be imported independently with minimal dependencies. std/r

Re: std.experimental.color, request reviews

2015-06-23 Thread Adam D. Ruppe via Digitalmars-d
Just a quick concern, I don't think a package.d should ever have anything except imports in it. Put all the actual aliases and color lists in some other submodule that can be imported independently with minimal dependencies.

std.experimental.color, request reviews

2015-06-23 Thread Manu via Digitalmars-d
https://github.com/D-Programming-Language/phobos/pull/2845 I'm getting quite happy with it. I think it's a good and fairly minimal but useful starting point. It'd be great to get some reviews from here.