Re: [jQuery] Plugin Code Review: jdMenu

2007-02-05 Thread Jason Levine
I'm at work now and was able to compare my customizations to the normal JDMenu code. Here are the changes I made. First of all, after: var x = 0, y = 0; var li = $(ul).parent(); I added this line: var liTop = li.offset().top; I also changed thi

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-04 Thread Jason Levine
By the way, I just wanted to thank you for this plugin. I'm putting it into use on our company's Intranet. We had a couple of applications that used a tabbed interface. The problem was that there were many tabs and items were getting lost in the applications. I put in jdMenu (on a testing basi

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-03 Thread Jörn Zaefferer
Klaus Hartl schrieb: > Jörn Zaefferer schrieb: > >> css() automatically adds "px" to values passed as a number, where >> appropiate (it excludes eg. opacity and z-index), so you don't need to >> add that in your code. >> > > Does it exclude line-height? You can declare line-height unitles

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-03 Thread Klaus Hartl
Jörn Zaefferer schrieb: > css() automatically adds "px" to values passed as a number, where > appropiate (it excludes eg. opacity and z-index), so you don't need to > add that in your code. Does it exclude line-height? You can declare line-height unitless (line-height: 1 and line-height: 1em is

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-03 Thread Jonathan Sharp
Jörn, Thanks for all of your feedback! Those are excellent pointers and will help greatly in the refactor! Thanks again! -Jonathan On 2/2/07, Jörn Zaefferer <[EMAIL PROTECTED]> wrote: Jonathan Sharp schrieb: > I'm just starting on a refactor of this code and am making several > improvements

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-02 Thread Jörn Zaefferer
Jonathan Sharp schrieb: > I'm just starting on a refactor of this code and am making several > improvements including accepting settings when initializing, handling > events through delegation, replacing the iframe code with bgiframe and > supporting vertical menus. > > So before I undergo thi

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-02 Thread Jonathan Sharp
On 2/2/07, John Resig <[EMAIL PROTECTED]> wrote: Jonathan - Your code is looking good. The only line that looked strange to me was: $(ul).append('').prepend(''); Yep, I implemented that in an attempt to fix an issue with IE and security alerts when creating an IFRAME with no src when the pag

Re: [jQuery] Plugin Code Review: jdMenu

2007-02-02 Thread John Resig
Jonathan - Your code is looking good. The only line that looked strange to me was: $(ul).append('').prepend(''); I think you might be looking for a "wrapInner" equivalent: http://motherrussia.polyester.se/jquery/wrapinner/ --John On 2/2/07, Jonathan Sharp <[EMAIL PROTECTED]> wrote: > I'm just s

[jQuery] Plugin Code Review: jdMenu

2007-02-02 Thread Jonathan Sharp
I'm just starting on a refactor of this code and am making several improvements including accepting settings when initializing, handling events through delegation, replacing the iframe code with bgiframe and supporting vertical menus. So before I undergo this refactor. There have been several app