Maybe DEBUG=True should only record the last N SQL queries?

2008-04-19 Thread Simon Willison
I've noticed that a LOT of people get bitten by the problem where every SQL statement is logged if DEBUG=True, resulting in huge memory consumption after a while. This problem seems particularly common for import scripts, which are often run in development (hence with DEBUG on) and can involve tho

Re: SecureForm in newforms

2008-04-19 Thread Simon Willison
On Apr 17, 5:04 pm, "Jeremy Dunck" <[EMAIL PROTECTED]> wrote: > Middleware is easy to set and forget. Is there a reason not to make > SecureForm the default, and InsecureForm for people using Ajax? ;-) I'm pretty sure we can handle the Ajax case by not doing CSRF token checks if request.is_ajax

Re: Maybe DEBUG=True should only record the last N SQL queries?

2008-04-19 Thread James Bennett
On Sat, Apr 19, 2008 at 2:37 AM, Simon Willison <[EMAIL PROTECTED]> wrote: > I've noticed that a LOT of people get bitten by the problem where > every SQL statement is logged if DEBUG=True, resulting in huge memory > consumption after a while. This problem seems particularly common for > impor

Re: Maybe DEBUG=True should only record the last N SQL queries?

2008-04-19 Thread mrts
I'd second Simon's proposal. People often develop their projects on production servers and need to have debug on. Having to manually flush the query log disrupts their normal workflow. I'd suggest being kind to the users and not work against their intuition by default. As Simon proposed, whoever n

Some of newforms-admin branch files have DOS mode line endings!!!

2008-04-19 Thread Marcob
I just exported newforms-admin branch e try to apply this patch http://code.djangoproject.com/ticket/7028 It fails on django/contrib/admin/templatetags/admin_list.py because it is in DOS mode!!! Why on earth? Ciao. Marco. --~--~-~--~~~---~--~~ You received this me

Re: Some of newforms-admin branch files have DOS mode line endings!!!

2008-04-19 Thread Marcob
On 19 Apr, 13:37, Marcob <[EMAIL PROTECTED]> wrote: > I just exported newforms-admin branch e try to apply this > patchhttp://code.djangoproject.com/ticket/7028 > It fails on django/contrib/admin/templatetags/admin_list.py because it > is in DOS mode!!! > Why on earth? Gotcha! Some of the files

Re: Some of newforms-admin branch files have DOS mode line endings!!!

2008-04-19 Thread Malcolm Tredinnick
On Sat, 2008-04-19 at 05:02 -0700, Marcob wrote: > On 19 Apr, 13:37, Marcob <[EMAIL PROTECTED]> wrote: > > I just exported newforms-admin branch e try to apply this > > patchhttp://code.djangoproject.com/ticket/7028 > > It fails on django/contrib/admin/templatetags/admin_list.py because it > > i

Re: Some of newforms-admin branch files have DOS mode line endings!!!

2008-04-19 Thread Ned Batchelder
It's a wonder to me that Subversion doesn't allow this setting to be made repo-wide. The fact that Marco can set it for every file on his client, or the core team can set it file-by-file for all clients, but no one can make it true for all files for everyone, seems to me to be a huge oversight

Re: SVN Milestones

2008-04-19 Thread James Bennett
On Sat, Apr 19, 2008 at 10:17 AM, ydjango <[EMAIL PROTECTED]> wrote: > Is there a reason you cannot call it just 1.0 So would you prefer to have a beta-quality product whose developers lie and call it 1.0? The next version of Django to be released will be 1.0. It will most likely be preceded by

Re: SVN Milestones

2008-04-19 Thread ydjango
I have a concern with calling it beta. It would be difficult to sell a commercial product based on a beta framework. How long do you expect to remain in beta? Is there a reason you cannot call it just 1.0 thanks Ashish On Apr 18, 9:59 am, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: > On Wed, A

Changeset 7427

2008-04-19 Thread Ivan Illarionov
I can't test it but I bet something is wrong with changeset 7427. AFAIK query_class method should create the OracleQuery class as subclass of DefaultQueryClass and return this new class with correct backend-specific resolve_columns and as_sql methods. But it does something strange here. I bet Ora

Re: SVN Milestones

2008-04-19 Thread Kenneth Gonsalves
On 19-Apr-08, at 8:52 PM, James Bennett wrote: > On Sat, Apr 19, 2008 at 10:17 AM, ydjango <[EMAIL PROTECTED]> > wrote: >> Is there a reason you cannot call it just 1.0 > > So would you prefer to have a beta-quality product whose developers > lie and call it 1.0? I wouldn't even call the cur

Re: SVN Milestones

2008-04-19 Thread Steve Holden
Kenneth Gonsalves wrote: > On 19-Apr-08, at 8:52 PM, James Bennett wrote: > > >> On Sat, Apr 19, 2008 at 10:17 AM, ydjango <[EMAIL PROTECTED]> >> wrote: >> >>> Is there a reason you cannot call it just 1.0 >>> >> So would you prefer to have a beta-quality product whose developers

Re: SVN Milestones

2008-04-19 Thread Kenneth Gonsalves
On 20-Apr-08, at 12:47 AM, Steve Holden wrote: >> I wouldn't even call the current svn head a beta-quality product >> >> > Which is probably why it isn't yet a beta release? what I meant is that it is stable and production ready and that it is time people stopped evaluating products by lookin

Re: floating point django.VERSION element versus adding another element to the tuple

2008-04-19 Thread Russell Keith-Magee
On Sat, Apr 19, 2008 at 12:24 PM, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > > How to do the version tuple is mostly a bikeshed argument. Ultimately, > > three things matter in deciding how to handle it: > > > > 1. The BDFLs/core dev team are OK with it. > > > > 2. The system used is

Re: Changeset 7427

2008-04-19 Thread Justin Bronn
> I bet Oracle is broken in qs-rf. Yeah, Malcolm opened up #7036 two days ago in response to errors reported by Ian Kelly. I've attached a patch. The problem had to do with `resolve_columns` not taking into account that extra select SQL is in a different position due to changes in #7340. The e