Re: django-admin startproject settings.py has some security holes

2019-10-11 Thread Nick Sarbicki
I strongly disagree with this. I've not seen a common standard between companies when it comes to settings in Django and for good reason. Different companies employ different standards and practices when it comes to configuration and security. Enforcing an arbitrary standard - such as a settings f

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Nick Sarbicki
raries (see > https://github.com/django/django-docker-box/blob/master/Dockerfile#L4). I > think a few where missing our outdated in Alpine, but if that's changed > then I'm not against trying it again. > > Tom > > On 8 Oct 2019, at 11:58, Nick Sarbicki wrote: > >

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Nick Sarbicki
Just out of interest, Tom, have you tried using Alpine as the base? Or is there a reason to avoid it? I usually find once you introduce all the dependencies for django it doesn't make a huge difference but it might shave some of the weight off if we're worried about image size. - Nick On Tue,

Re: Proposal to format Django using black

2019-04-22 Thread Nick Sarbicki
> > > I'm just saying that if "As contributor, I can haz automatic code > formatter to lower the barrier" is precisely the story you want to solve, > then black may not be the only solution you want to consider deeply ;) > > Jamie, sure, I wasn't responding directly to you about this, more to th

Re: Proposal to format Django using black

2019-04-22 Thread Nick Sarbicki
I'm still quite strongly in support of black. I find it's very nice to read a codebase that has strong consistency (which is historically usually the work of pedantic but very necessary reviews). It's even nicer to go between multiple codebases which are all consistent with each other. PEP8 and li

Re: Proposal to format Django using black

2019-04-14 Thread Nick Sarbicki
Just going to say that one of the main frustration points I've had when making a contribution is having to fix small formatting errors (often minor things in docstrings which aren't _always_ consistent). It produces a lot of inertia and can stop PRs from getting merged for extended periods of time

Re: Bug in utils.encoding producing invalid JSON for request body

2018-01-29 Thread Nick Sarbicki
> does json.dumps inside _encode_data before calling super(). It's possible > to swap the self.client on your TestCase subclasses easily by setting > client_class so you could make it the default in your project. > > On 29 January 2018 at 14:14, Nick Sarbicki > wrote: >

Bug in utils.encoding producing invalid JSON for request body

2018-01-29 Thread Nick Sarbicki
I've just posted a ticket for this here: https://code.djangoproject.com/ticket/29082#ticket The general point is that when I'm using RequestFactory and making a post request with a JSON body, I'd expect to be able to pass in a dict for this - but I can't as the JSON it produces (it does try) is

Having an --include option for collectsstatic.

2018-01-09 Thread Nick Sarbicki
I recently found I needed to create a command to include specific files for collectstatic and ignore everything else (images and fonts). The opposite of the current --ignore functionality. I've tried to do this with the current --ignore option using glob syntax but haven't managed to "ignore al

Re: Javascript Templating Package

2016-10-11 Thread Nick Sarbicki
Hi Daniel, This is a separate idea. Instead of relying on JSON dumps, we actually generate an entire JS script via the engine. The flow is along the lines of: > Client makes request > Django receives request and renders an HTML page which it passes to the client. > The given HTML page has a sc

Javascript Templating Package

2016-10-11 Thread Nick Sarbicki
Hi Everyone, We were tasked at work some time ago with tidying up a legacy Django project. Part of the projects JS relied heavily on Django variables and settings and we were seeing frequent large variable JSON dumps in the templates. We cleaned this up and ended up designing a small package w

Re: Joining the "Python 3 Statement"

2016-07-10 Thread Nick Sarbicki
> > Not going to carry this on much more as I doubt I'll be convincing. And while I, for the most part, agree that group pledges won't change the minds of those locked to 2.7, I'm hopelessly optimistic about it :-). And how exactly can that help Django? > I think anything which advances and promo

Re: Joining the "Python 3 Statement"

2016-07-10 Thread Nick Sarbicki
On my phone so excuse typos. On Sun, 10 Jul 2016, 13:28 Florian Apolloner, wrote: > > > On Saturday, July 9, 2016 at 10:26:25 PM UTC+2, Nick Sarbicki wrote: >> >> I don't think this is a question of what it would do for Django. More >> what Django could do for py

Re: Joining the "Python 3 Statement"

2016-07-09 Thread Nick Sarbicki
Hi Aymeric, I don't think this is a question of what it would do for Django. More what Django could do for python. The web and scientific communities are essentially the two biggest python communities around. If they both joined together to say "2020 is the deadline for us and everyone else" it c

Re: Adding a database-agnostic JSONField into Django

2016-06-23 Thread Nick Sarbicki
Same boat for me. I constantly need the JSON field but can't always rely on postgres. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send

Re: Vote on Jira as bugtracker

2016-01-06 Thread Nick Sarbicki
> > FWIW Jira seems to be an exception among bug trackers: some people really > love it, others really hate it. It depends on who set it up and maintained > it in the company where they used it. > > Since we don’t have a resident Jira expert, we run the risk that most of > the Django community will

Re: Proposal to document the error on trying to import django in python 3.4.

2015-09-09 Thread Nick Sarbicki
l for anyone using Windows or Mac as they won't have a default Python install and will often only have 1 version, so 1 pip. - Nick. On Wednesday, September 9, 2015 at 3:05:15 PM UTC+1, Nick Sarbicki wrote: > > In which case you need to install it again with *pip3*. > > All

Re: Proposal to document the error on trying to import django in python 3.4.

2015-09-09 Thread Nick Sarbicki
In which case you need to install it again with *pip3*. All the defaults in Ubuntu (Python, pip etc.) are focused on 2.7, you always need to append 3 if you want it to be *python3 *specific. For earlier versions of ubuntu this was because some core processes required python2.7 and would call it

Re: Proposal to document the error on trying to import django in python 3.4.

2015-09-09 Thread Nick Sarbicki
Can you show us how you installed django? More specifically, did you do *pip install django* and *pip3 install django* As it looks like you only install django for 2.7, and not for 3.4. - Nick. On Wednesday, September 9, 2015 at 2:51:07 PM UTC+1, Anjul Tyagi(geety) wrote: > > Hi everyone,

Re: Django with Pycharm

2015-09-04 Thread Nick Sarbicki
Hi Prabhu, Are you using the community or professional version? The community version doesn't support specific Django projects (although it is still good to use). https://www.jetbrains.com/pycharm/features/editions_comparison_matrix.html Nick. On Fri, Sep 4, 2015 at 3:47 PM Prabhu wrote: > H

Re: Django Admin New Look

2015-08-28 Thread Nick Sarbicki
This takes the conversation back a ways... But I like the idea of being able to customise the admin scheme. Enforce a default of course, but maybe have some options (in admin.py? or as a separate script?) which can change the core colors of the scheme, either a set of predefined colours, or som