[git pull] drm fixes for 5.19-rc4

2022-06-23 Thread Dave Airlie
Hi Linus, Fixes for this week, bit larger than normal, but I think the last couple have been quieter, and it's only rc4. There are a lot of small msm fixes, and a slightly larger set of vc4 fixes. The vc4 fixes clean up a lot of crashes around the rPI4 hardware differences from earlier ones, and

Re: [PATCH v5 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
On Thu, Jun 23, 2022 at 10:32:08PM -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove

[PATCH v5 2/3] drm/i915: Update i915 uapi documentation

2022-06-23 Thread Niranjana Vishwanathapura
Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld --- include/uapi/drm/i915_drm.h | 205 1 file changed, 160 insertions(+), 45

[PATCH v5 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove I915_GEM_VM_BIND_TLB_FLUSH flag and add additional documentation for

[PATCH v5 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-23 Thread Niranjana Vishwanathapura
VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB flushing and execbuf3. v4: Remove vm_bind tlb flush request support. v5: Update TLB flushing documentation. Signed-off-by: Niranjana

[PATCH v5 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-23 Thread Niranjana Vishwanathapura
This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. v2: Reduce the scope to simple Mesa use case. Remove all compute related uapi, vm_bind/unbind queue support and only support a timeline out fence

Re: How do I gather up new code to be converted as patches?

2022-06-23 Thread Sam Ravnborg
Hi Kevin, On Fri, Jun 24, 2022 at 01:17:40AM +0200, Kevin Brace wrote: > Hi Sam, > > Okay, I think what you proposed works out for me, although adding 20+ files, > one by one, is a pain. Posting one patch per file works - but sometimes it just makes more sense to group some files. The process

Re: [PATCH v2 02/96] soundwire: intel: Migrate to new style legacy DAI naming flag

2022-06-23 Thread Vinod Koul
On 23-06-22, 13:51, Charles Keepax wrote: > Change the legacy DAI naming flag from opting in to the new scheme > (non_legacy_dai_naming), to opting out of it (legacy_dai_naming). > This driver appears to be on the CPU side of the DAI link and > currently uses the legacy naming, so add the new

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Prashant Malani
On Thu, Jun 23, 2022 at 7:13 PM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-06-23 17:35:38) > > On Thu, Jun 23, 2022 at 4:14 PM Stephen Boyd wrote: > > > > > > I'm not aware of any documentation for the dos and don'ts here. Are > > > there any examples in the bindings directory that

[PATCH RESEND] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-23 Thread Hangyu Hua
If drm_connector_init fails, intel_connector_free will be called to take care of proper free. So it is necessary to drop the refcount of port before intel_connector_free. Fixes: 091a4f91942a ("drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector") Signed-off-by: Hangyu Hua

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-23 17:35:38) > On Thu, Jun 23, 2022 at 4:14 PM Stephen Boyd wrote: > > > > I'm not aware of any documentation for the dos and don'ts here. Are > > there any examples in the bindings directory that split up a device into > > subnodes that isn't in bindings/mfd? > >

[PATCH] drm/ingenic: Use resource_size function on resource object

2022-06-23 Thread Jiapeng Chong
This was found by coccicheck: ./drivers/gpu/drm/ingenic/ingenic-drm-drv.c:1149:35-38: WARNING: Suspicious code. resource_size is maybe missing with res. Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Prashant Malani
On Thu, Jun 23, 2022 at 5:35 PM Prashant Malani wrote: > > On Thu, Jun 23, 2022 at 4:14 PM Stephen Boyd wrote: > > > > Quoting Prashant Malani (2022-06-23 12:08:21) > > > On Thu, Jun 23, 2022 at 11:30 AM Stephen Boyd wrote: > > > > > > > > Quoting Prashant Malani (2022-06-22 10:34:30) > > > > >

[PATCH -next] drm: Remove unnecessary print function dev_err()

2022-06-23 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/gpu/drm/sprd/sprd_dpu.c:808:2-9: line 808 is redundant because platform_get_irq() already prints an error Signed-off-by: Yang Li ---

[PATCH -next] drm/amdgpu: Remove duplicated include in amdgpu_dm.c

2022-06-23 Thread Yang Li
Fix following includecheck warning: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: soc15_common.h is included more than once. Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Prashant Malani
On Thu, Jun 23, 2022 at 4:14 PM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-06-23 12:08:21) > > On Thu, Jun 23, 2022 at 11:30 AM Stephen Boyd wrote: > > > > > > Quoting Prashant Malani (2022-06-22 10:34:30) > > > > diff --git a/Documentation/devicetree/bindings/usb/typec-switch.yaml >

Re: [PATCH] drm/msm/dp: no dp_hpd_unplug_handle() required for eDP

2022-06-23 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-23 16:34:16) > eDP implementation does not reuried to support hpd signal. Therefore s/reuried/require/ > it only has either ST_DISPLAY_OFF or ST_CONNECTED state during normal > operation. This patch remove unnecessary dp_hpd_unplug_handle() for > eDP but still keep

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-23 Thread Doug Anderson
Hi, On Fri, Jun 17, 2022 at 5:27 PM Brian Norris wrote: > > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a

[PATCH] drm/msm/dp: no dp_hpd_unplug_handle() required for eDP

2022-06-23 Thread Kuogee Hsieh
eDP implementation does not reuried to support hpd signal. Therefore it only has either ST_DISPLAY_OFF or ST_CONNECTED state during normal operation. This patch remove unnecessary dp_hpd_unplug_handle() for eDP but still keep dp_hpd_plug_handle() to support eDP to either booting up or resume from

[PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-23 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-23 Thread Belgaumkar, Vinay
On 6/22/2022 1:32 PM, Dixit, Ashutosh wrote: On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a

Re: How do I gather up new code to be converted as patches?

2022-06-23 Thread Kevin Brace
Hi Sam, Okay, I think what you proposed works out for me, although adding 20+ files, one by one, is a pain. I wish there is a way to automate this. FWIW, this is how I did it. 1) Create a new branch from the current one just for sending the patches $ git branch Code_Review_1 2)

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-23 12:08:21) > On Thu, Jun 23, 2022 at 11:30 AM Stephen Boyd wrote: > > > > Quoting Prashant Malani (2022-06-22 10:34:30) > > > diff --git a/Documentation/devicetree/bindings/usb/typec-switch.yaml > > > b/Documentation/devicetree/bindings/usb/typec-switch.yaml >

[Bug 201957] amdgpu: ring gfx timeout

2022-06-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #79 from Danil (s48g...@gmail.com) --- Updated to kernel 5.18.4-1-default #1 SMP PREEMPT_DYNAMIC Wed Jun 15 06:00:33 UTC 2022 (ed6345d) x86_64 x86_64 x86_64 GNU/Linux (OpenSuSe latest for now) Seems my integrated AMD GPU freeze

Re: [PATCH 1/5] drm/amdgpu: Fix possible refcount leak for release of external_hw_fence

2022-06-23 Thread Andrey Grodzovsky
On 2022-06-22 11:04, Christian König wrote: Am 22.06.22 um 17:01 schrieb Andrey Grodzovsky: On 2022-06-22 05:00, Christian König wrote: Am 21.06.22 um 21:34 schrieb Andrey Grodzovsky: On 2022-06-21 03:19, Christian König wrote: Am 21.06.22 um 00:02 schrieb Andrey Grodzovsky: Problem: In

RE: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of Tvrtko > Ursulin > Sent: June 23, 2022 7:06 AM > To: Landwerlin, Lionel G ; Vishwanathapura, > Niranjana > Cc: Zanoni, Paulo R ; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; Hellstrom, Thomas >

Re: How do I gather up new code to be converted as patches?

2022-06-23 Thread Thomas Zimmermann
Hi Am 23.06.22 um 21:29 schrieb Kevin Brace: Hi Jeffrey, I did not point to the repository I actively maintain, but since I was able to do so since 2017, I think I have figured out all of what I consider "basic" ways of using git to maintain and keep up with the upstream DRM code.

Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support

2022-06-23 Thread Randy Dunlap
On 6/23/22 04:56, ChiaEn Wu wrote: > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index a49979f..a8c58c3 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -244,6 +244,17 @@ config LEDS_MT6323 > This option enables support for on-chip LED drivers found

Re: How do I gather up new code to be converted as patches?

2022-06-23 Thread Kevin Brace
Hi Jeffrey, I did not point to the repository I actively maintain, but since I was able to do so since 2017, I think I have figured out all of what I consider "basic" ways of using git to maintain and keep up with the upstream DRM code. https://cgit.freedesktop.org/openchrome/drm-openchrome/

Re: [PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-06-23 Thread Prashant Malani
On Thu, Jun 23, 2022 at 12:08 PM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-06-23 11:37:08) > > On Thu, Jun 23, 2022 at 11:24 AM Stephen Boyd wrote: > > > > > > Quoting Prashant Malani (2022-06-22 10:34:35) > > > > From: Pin-Yen Lin > > > > > > > > ITE IT6505 can be used in systems

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Prashant Malani
On Thu, Jun 23, 2022 at 11:30 AM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-06-22 10:34:30) > > diff --git a/Documentation/devicetree/bindings/usb/typec-switch.yaml > > b/Documentation/devicetree/bindings/usb/typec-switch.yaml > > new file mode 100644 > > index

Re: [PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-06-23 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-23 11:37:08) > On Thu, Jun 23, 2022 at 11:24 AM Stephen Boyd wrote: > > > > Quoting Prashant Malani (2022-06-22 10:34:35) > > > From: Pin-Yen Lin > > > > > > ITE IT6505 can be used in systems to switch USB Type-C DisplayPort > > > alternate mode lane traffic

Re: [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver

2022-06-23 Thread Andy Shevchenko
On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > Add Mediatek MT6370 charger driver. ... > +config CHARGER_MT6370 > + tristate "Mediatek MT6370 Charger Driver" > + depends on MFD_MT6370 > + depends on REGULATOR > + select LINEAR_RANGES > +

Re: [PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-06-23 Thread Prashant Malani
On Thu, Jun 23, 2022 at 11:24 AM Stephen Boyd wrote: > > Quoting Prashant Malani (2022-06-22 10:34:35) > > From: Pin-Yen Lin > > > > ITE IT6505 can be used in systems to switch USB Type-C DisplayPort > > alternate mode lane traffic between 2 Type-C ports. > > How does it work? From what I can

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-23 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-22 10:34:30) > diff --git a/Documentation/devicetree/bindings/usb/typec-switch.yaml > b/Documentation/devicetree/bindings/usb/typec-switch.yaml > new file mode 100644 > index ..78b0190c8543 > --- /dev/null > +++

Re: [PATCH v3 10/14] iio: adc: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread Andy Shevchenko
On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > From: ChiaEn Wu > > Add Mediatek MT6370 ADC support. ... > +config MEDIATEK_MT6370_ADC > + tristate "Mediatek MT6370 ADC driver" > + depends on MFD_MT6370 > + help > + Say yes here to enable Mediatek MT6370 ADC

Re: [PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-06-23 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-22 10:34:35) > From: Pin-Yen Lin > > ITE IT6505 can be used in systems to switch USB Type-C DisplayPort > alternate mode lane traffic between 2 Type-C ports. How does it work? From what I can tell from the information I find when googling this part[1] and looking

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-23 Thread David Hildenbrand
On 23.06.22 20:20, Sierra Guiza, Alejandro (Alex) wrote: > > On 6/23/2022 2:57 AM, David Hildenbrand wrote: >> On 23.06.22 01:16, Sierra Guiza, Alejandro (Alex) wrote: >>> On 6/21/2022 11:16 AM, David Hildenbrand wrote: On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: > On

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-23 Thread Sierra Guiza, Alejandro (Alex)
On 6/23/2022 2:57 AM, David Hildenbrand wrote: On 23.06.22 01:16, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 11:16 AM, David Hildenbrand wrote: On 21.06.22 18:08, Sierra Guiza, Alejandro (Alex) wrote: On 6/21/2022 7:25 AM, David Hildenbrand wrote: On 21.06.22 13:55, Alistair Popple

Re: [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

2022-06-23 Thread Andy Shevchenko
On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > From: ChiYuan Huang > > Add mt6370 DisplayBias and VibLDO support. ... > +#include > +#include > +#include > +#include > +#include > +#include Any users of this? (See below) > +#include > +#include > +#include > +#include ...

Re: [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver

2022-06-23 Thread Andy Shevchenko
On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > From: ChiYuan Huang > > Add chip level mt6370 tcpci driver. ... > +config TYPEC_TCPCI_MT6370 > + tristate "Mediatek MT6370 Type-C driver" > + depends on MFD_MT6370 > + help > + Mediatek MT6370 is a multi-functional

Re: [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread Andy Shevchenko
On Thu, Jun 23, 2022 at 1:59 PM ChiaEn Wu wrote: > > From: ChiYuan Huang > > Add Mediatek MT6370 MFD support. ... > +config MFD_MT6370 > + tristate "Mediatek MT6370 SubPMIC" > + select MFD_CORE > + select REGMAP_I2C > + select REGMAP_IRQ > + depends on I2C > +

Re: [PATCH] GPU: drm: i915: drop unexpected word 'for' in comments

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Jiang Jian wrote: > there is an unexpected word 'for' in the comments that need to be dropped While it's also unexpected, it's really *duplicated* word. > file - drivers/gpu/drm/i915/i915_reg.h > line - 2537 > > * Please check the detailed lore in the commit message for

Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 12:26 PM Leo wrote: > > > > On 2022-06-23 11:30, Nathan Chancellor wrote: > > Clang warns: > > > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: > > warning: misleading indentation; statement is not part of

Re: [PATCH][next] drm/amdgpu/display: Fix spelling mistake "supporing" -> "supporting"

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 10:20 AM Harry Wentland wrote: > > > > On 2022-06-23 04:09, Colin Ian King wrote: > > There is a spelling mistake in a dml_print message. Fix it. > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Harry Wentland > > Harry > > > --- > >

Re: [PATCH] drm/amdgpu: drop unexpected word 'for' in comments

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 6:15 AM Jiang Jian wrote: > > there is an unexpected word 'for' in the comments that need to be dropped > > file - drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c > line - 245 > > * position and also advance the position for for Vega10 > > changed to: > >

Re: [PATCH][next] drm/amdkfd: Fix spelling mistake "mechanim" -> "mechanism"

2022-06-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 23, 2022 at 4:12 AM Colin Ian King wrote: > > There is a spelling mistake in a pr_debug message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-23 Thread Sean Paul
On Fri, Jun 17, 2022 at 05:26:52PM -0700, Brian Norris wrote: > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a

[PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-23 Thread Andrzej Hajda
HPD event after fbdev unregistration can cause registration of deferred fbdev which will not be unregistered later, causing use-after-free. To avoid it HPD handling should be suspended before fbdev unregistration. It should fix following GPF: [272.634530] general protection fault, probably for

[PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-06-23 Thread Andrzej Hajda
i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. To avoid re-queuing lets cancel HPD work after intel_dp_mst_suspend. It should fix following WARNINGS: [283.405824] cpu_latency_qos_update_request called for

[PATCH 0/2] drm/i915/display: stop HPD workers before display driver unregister

2022-06-23 Thread Andrzej Hajda
Hi Jani, Ville, This patchset is replacement of patch "drm/i915/display: disable HPD workers before display driver unregister" [1]. Ive decided to split patch into two parts - fbdev and MST, there are different issues. Ive also dropped shutdown path, as it has slightly different requirements, and

Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()

2022-06-23 Thread Leo
On 2022-06-23 11:30, Nathan Chancellor wrote: > Clang warns: > > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: > warning: misleading indentation; statement is not part of the previous 'else' > [-Wmisleading-indentation] > pll_req

Re: (subset) [PATCH v3 00/14] Add Mediatek MT6370 PMIC support

2022-06-23 Thread Mark Brown
On Thu, 23 Jun 2022 19:56:17 +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > This patch series add Mediatek MT6370 PMIC support. The MT6370 is a > highly-integrated smart power management IC, which includes a single > cell Li-Ion/Li-Polymer switching battery charger, a USB > Type-C & Power

Re: [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-23 Thread Matthew Auld
On 23/06/2022 15:52, Christian König wrote: Am 23.06.22 um 16:13 schrieb Matthew Auld: [SNIP] TTM_BO_VM_NUM_PREFAULT); +   /* +    * Ensure we check for any fatal errors if we had to move/clear +    * the object. The device should already be wedged if we hit

[PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()

2022-06-23 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation] pll_req = dc_fixpt_from_int(pll_req_reg &

Re: DMA-buf and uncached system memory

2022-06-23 Thread Lucas Stach
Am Donnerstag, dem 23.06.2022 um 14:52 +0200 schrieb Christian König: > Am 23.06.22 um 14:14 schrieb Lucas Stach: > > Am Donnerstag, dem 23.06.2022 um 13:54 +0200 schrieb Christian König: > > > Am 23.06.22 um 13:29 schrieb Lucas Stach: > > > [SNIP] > > > I mean I even had somebody from ARM which

Re: [PATCH v2] drm/sun4i: Enable output signal premultiplication for DE2/DE3

2022-06-23 Thread Maxime Ripard
On Wed, Jun 08, 2022 at 07:44:03PM +0300, Roman Stratiienko wrote: > ср, 8 июн. 2022 г. в 11:17, Maxime Ripard : > > > > On Mon, Jun 06, 2022 at 01:16:06PM +0300, Roman Stratiienko wrote: > > > вс, 5 июн. 2022 г. в 23:23, Jernej Škrabec : > > > > > > > > Dne nedelja, 05. junij 2022 ob 11:40:18

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-23 Thread Christian König
Am 23.06.22 um 16:51 schrieb Andrey Grodzovsky: On 2022-06-23 01:52, Christian König wrote: Am 22.06.22 um 19:19 schrieb Andrey Grodzovsky: On 2022-06-22 03:17, Christian König wrote: Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22

Re: [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-23 Thread Christian König
Am 23.06.22 um 16:13 schrieb Matthew Auld: [SNIP] TTM_BO_VM_NUM_PREFAULT); +   /* +    * Ensure we check for any fatal errors if we had to move/clear +    * the object. The device should already be wedged if we hit +    * such an error. +  

Re: [PATCH 5/5] drm/amdgpu: Follow up change to previous drm scheduler change.

2022-06-23 Thread Andrey Grodzovsky
On 2022-06-23 01:52, Christian König wrote: Am 22.06.22 um 19:19 schrieb Andrey Grodzovsky: On 2022-06-22 03:17, Christian König wrote: Am 21.06.22 um 22:00 schrieb Andrey Grodzovsky: On 2022-06-21 03:28, Christian König wrote: Am 21.06.22 um 00:03 schrieb Andrey Grodzovsky: Align

[PATCH] drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch

2022-06-23 Thread Imre Deak
The driver expects the pitch of the Intel CCS CC color planes to be 64 bytes aligned, adjust the modifier descriptions accordingly. Cc: Nanley Chery Signed-off-by: Imre Deak --- include/uapi/drm/drm_fourcc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
On Thu, Jun 23, 2022 at 09:27:22AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 17:44, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 04:57:17PM +0100, Tvrtko Ursulin wrote: On 22/06/2022 16:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
On Thu, Jun 23, 2022 at 12:28:32PM +0300, Lionel Landwerlin wrote: On 22/06/2022 18:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the

Re: [PATCH][next] drm/amdgpu/display: Fix spelling mistake "supporing" -> "supporting"

2022-06-23 Thread Harry Wentland
On 2022-06-23 04:09, Colin Ian King wrote: > There is a spelling mistake in a dml_print message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 -next] drm/display: Fix build error without CONFIG_OF

2022-06-23 Thread Linus Walleij
On Sat, Jun 11, 2022 at 6:16 AM YueHaibing wrote: > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] > Selected by [y]: > - DRM_MSM [=y] && HAS_IOMEM [=y] &&

Re: [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-23 Thread Matthew Auld
On 23/06/2022 08:00, Thomas Hellström wrote: On Tue, 2022-06-21 at 11:44 +0100, Matthew Auld wrote: If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or memset. However with small-BAR systems

Re: [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-23 Thread Souza, Jose
On Mon, 2022-05-16 at 15:19 +0800, Hangyu Hua wrote: > If drm_connector_init fails, intel_connector_free will be called to take > care of proper free. So it is necessary to drop the refcount of port > before intel_connector_free. Reviewed-by: José Roberto de Souza > > Fixes: 091a4f91942a

Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread Daniel Thompson
On Thu, Jun 23, 2022 at 07:56:31PM +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > Add Mediatek MT6370 Backlight support. > > Signed-off-by: ChiaEn Wu > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index a003e02..7cd823d 100644 > > +static int

Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add am625 dss compatible

2022-06-23 Thread Krzysztof Kozlowski
On 23/06/2022 12:35, Aradhya Bhatia wrote: > Add ti,am625-dss compatible string. > The DSS IP on TI's AM625 SoC is an update from the DSS on TI's AM65X > SoC. The former has an additional OLDI TX to enable a 2K resolution on > OLDI displays or enable 2 duplicated displayw with a smaller

Re: DMA-buf and uncached system memory

2022-06-23 Thread Christian König
Am 23.06.22 um 14:14 schrieb Lucas Stach: Am Donnerstag, dem 23.06.2022 um 13:54 +0200 schrieb Christian König: Am 23.06.22 um 13:29 schrieb Lucas Stach: [SNIP] I mean I even had somebody from ARM which told me that this is not going to work with our GPUs on a specific SoC. That there are ARM

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Lionel Landwerlin
On 23/06/2022 14:05, Tvrtko Ursulin wrote: On 23/06/2022 09:57, Lionel Landwerlin wrote: On 23/06/2022 11:27, Tvrtko Ursulin wrote: After a vm_unbind, UMD can re-bind to same VA range against an active VM. Though I am not sue with Mesa usecase if that new mapping is required for running

Re: [PATCH v4 2/2] drm/panfrost: Add support for devcoredump

2022-06-23 Thread Steven Price
On 22/06/2022 15:36, Adrián Larumbe wrote: > In the event of a job timeout, debug dump information will be written into > /sys/class/devcoredump. > > Inspired by etnaviv's similar feature. > > Signed-off-by: Adrián Larumbe Looks pretty good, a few comments below. > --- >

Re: [PATCH v4 1/2] drm/panfrost: Add specific register offset macros for JS and MMU AS

2022-06-23 Thread Steven Price
On 22/06/2022 15:36, Adrián Larumbe wrote: > Each Panfrost job has its own job slot and MMU address space set of > registers, which are selected with a job-specific index. > > Turn the shift and stride used for selection of the right register set base > into a define rather than using magic

Re: DMA-buf and uncached system memory

2022-06-23 Thread Lucas Stach
Am Donnerstag, dem 23.06.2022 um 13:54 +0200 schrieb Christian König: > Am 23.06.22 um 13:29 schrieb Lucas Stach: > > [SNIP] > > > Well then the existing DMA-buf framework is not what you want to use for > > > this. > > > > > Sorry, but this is just ignoring reality. You try to flag 8+ years of >

[PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread ChiaEn Wu
From: ChiaEn Wu Add Mediatek MT6370 Backlight support. Signed-off-by: ChiaEn Wu --- v3 - Refine bool properties parsing (pwm-enable, ovp-shutdown, ocp-shutdown) in DT parsing function - Refine u32 and u8 properties parsing (pwm-hys-input-th-steps, ovp-microvolt, ocp-microamp), from using

[PATCH v3 13/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support

2022-06-23 Thread ChiaEn Wu
From: Alice Chen Add Mediatek MT6370 flashlight support. Signed-off-by: Alice Chen --- drivers/leds/flash/Kconfig | 9 + drivers/leds/flash/Makefile| 1 + drivers/leds/flash/leds-mt6370-flash.c | 657 + 3 files changed, 667

[PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add Mediatek MT6370 current sink type LED Indicator driver. Signed-off-by: ChiYuan Huang --- v3 - Refine the grammer of the Kconfig. - Change reg mode to the const current mode. --- drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 +

[PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver

2022-06-23 Thread ChiaEn Wu
From: ChiaEn Wu Add Mediatek MT6370 charger driver. Signed-off-by: ChiaEn Wu --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile |1 + drivers/power/supply/mt6370-charger.c | 1132 + 3 files changed, 1144 insertions(+)

[PATCH v3 10/14] iio: adc: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread ChiaEn Wu
From: ChiaEn Wu Add Mediatek MT6370 ADC support. Signed-off-by: ChiaEn Wu --- v3 - Refine Kconfig help text - Refine all channel value in read_scale() a. current: uA --> mA b. voltage: uV --> mV c. temperature: degrees Celsius --> milli degrees Celsius - Add "default:"

[PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add mt6370 DisplayBias and VibLDO support. Signed-off-by: ChiYuan Huang --- v3 - Refine Kconfig help text --- drivers/regulator/Kconfig| 8 + drivers/regulator/Makefile | 1 + drivers/regulator/mt6370-regulator.c | 388

[PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add chip level mt6370 tcpci driver. Signed-off-by: ChiYuan Huang --- drivers/usb/typec/tcpm/Kconfig| 8 ++ drivers/usb/typec/tcpm/Makefile | 1 + drivers/usb/typec/tcpm/tcpci_mt6370.c | 212 ++ 3 files changed, 221

[PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add Mediatek MT6370 MFD support. Signed-off-by: ChiYuan Huang --- v3 - Refine Kconfig help text - Refine error message of unknown vendor ID in mt6370_check_vendor_info() - Refine return value handling of mt6370_regmap_read() - Refine all probe error by using

[PATCH v3 06/14] dt-bindings: mfd: Add Mediatek MT6370

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add Mediatek MT6370 binding documentation. Signed-off-by: ChiYuan Huang --- v3 - Use " in entire patchset - Refine ADC description - Rename "enable-gpio" to "enable-gpios" in "regualtor" - Change "/schemas/" to "../" in every reference of all MT6370 modules ---

[PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add mt6370 backlight binding documentation. Signed-off-by: ChiYuan Huang --- v3 - Rename "mediatek,bled-pwm-hys-input-threshold-steps" to "mediatek,bled-pwm-hys-input-th-steps" - Refine "bled-pwm-hys-input-th-steps", "bled-ovp-microvolt", "bled-ocp-microamp" enum

[PATCH v3 04/14] dt-bindings: leds: Add Mediatek MT6370 flashlight

2022-06-23 Thread ChiaEn Wu
From: Alice Chen Add Mediatek MT6370 flashlight binding documentation. Signed-off-by: Alice Chen --- v3 - Remove the description of enum. --- .../bindings/leds/mediatek,mt6370-flashlight.yaml | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

[PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add Mediatek mt6370 current sink type LED indicator binding documentation. Signed-off-by: ChiYuan Huang --- v3 - Use leds-class-multicolor.yaml instead of common.yaml. - Split multi-led and led node. - Add subdevice "led" in "multi-led". ---

[PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger

2022-06-23 Thread ChiaEn Wu
From: ChiaEn Wu Add Mediatek MT6370 Charger binding documentation. Signed-off-by: ChiaEn Wu --- v3 - Add items and remove maxItems of io-channels - Add io-channel-names and describe each item - Add "unevaluatedProperties: false" in "usb-otg-vbus-regulator" - Rename "enable-gpio" to

[PATCH v3 01/14] dt-bindings: usb: Add Mediatek MT6370 TCPC

2022-06-23 Thread ChiaEn Wu
From: ChiYuan Huang Add Mediatek MT6370 TCPC binding documentation. Signed-off-by: ChiYuan Huang Reviewed-by: Krzysztof Kozlowski --- .../bindings/usb/mediatek,mt6370-tcpc.yaml | 36 ++ 1 file changed, 36 insertions(+) create mode 100644

[PATCH v3 00/14] Add Mediatek MT6370 PMIC support

2022-06-23 Thread ChiaEn Wu
From: ChiaEn Wu This patch series add Mediatek MT6370 PMIC support. The MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED

Re: DMA-buf and uncached system memory

2022-06-23 Thread Christian König
Am 23.06.22 um 13:29 schrieb Lucas Stach: [SNIP] Well then the existing DMA-buf framework is not what you want to use for this. Sorry, but this is just ignoring reality. You try to flag 8+ years of DMA-buf usage on non-coherent arches as "you shouldn't do this". At this point there are

Re: [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830

2022-06-23 Thread Javier Martinez Canillas
Hello Hans, On 6/23/22 13:27, Hans de Goede wrote: > The Lenovo Yoga Tablet 2 830F / 830L use a panel which has been mounted > 90 degrees rotated. Add a quirk for this. > > Signed-off-by: Hans de Goede > --- The patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards,

[Bug 201957] amdgpu: ring gfx timeout

2022-06-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #78 from Danil (s48g...@gmail.com) --- (I did small mistake in my file organizing, creating nvidia_icd.json with listed above content is enough to fix Wine for me, everything works now) -- You may reply to this email to add a

[RESEND v5 1/2] dt-bindings: display: simple: Add DataImage FG1001L0DSSWMG01 compatible string

2022-06-23 Thread Philip Oberfichtner
Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel compatible string. Signed-off-by: Philip Oberfichtner Acked-by: Krzysztof Kozlowski --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: Rob Herring Cc: Krzysztof Kozlowski Cc:

[RESEND v5 2/2] drm/panel: simple: Add DataImage FG1001L0DSSWMG01 panel support

2022-06-23 Thread Philip Oberfichtner
Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel support. Signed-off-by: Philip Oberfichtner --- Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Cc: matthias.win...@de.bosch.com ---

Re: DMA-buf and uncached system memory

2022-06-23 Thread Christian König
Am 23.06.22 um 13:27 schrieb Daniel Stone: Hi Christian, On Thu, 23 Jun 2022 at 12:11, Christian König wrote: In fact DMA-buf sharing works fine on most of those SoCs because everyone just assumes that all the accelerators don't snoop, so the memory shared via DMA-buf is mostly CPU uncached.

Re: DMA-buf and uncached system memory

2022-06-23 Thread Lucas Stach
Am Donnerstag, dem 23.06.2022 um 13:10 +0200 schrieb Christian König: > Am 23.06.22 um 12:13 schrieb Lucas Stach: > > [SNIP] > > > > On most of the multimedia > > > > targeted ARM SoCs being unable to snoop the cache is the norm, not an > > > > exception. > > > > > > > > > See for example on

Re: DMA-buf and uncached system memory

2022-06-23 Thread Daniel Stone
Hi Christian, On Thu, 23 Jun 2022 at 12:11, Christian König wrote: > > In fact DMA-buf sharing works fine on most of those SoCs because > > everyone just assumes that all the accelerators don't snoop, so the > > memory shared via DMA-buf is mostly CPU uncached. It only falls apart > > for uses

[PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830

2022-06-23 Thread Hans de Goede
The Lenovo Yoga Tablet 2 830F / 830L use a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

Re: [PATCH 6/6] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:40PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Avoid trying to invalidate the TLB in the middle of performing an > engine reset, as this may result in the reset timing out. Currently, > the TLB invalidate is only serialised by its own

Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Don't allow two engines to be reset in parallel, as they would both > try to select a reset bit (and send requests to common registers) > and wait on that register, at the same time.

  1   2   >