Re: [PATCH 2/7] backlight: l4f00242t03: Simplify with dev_err_probe()

2024-03-04 Thread Daniel Thompson
On Mon, Mar 04, 2024 at 11:11:39AM +0100, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

2024-03-04 Thread Sascha Hauer
On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote: > From: Andy Yan > > The Alpha blending for 30 bit RGB/BGR are not > functioning properly for rk3568/rk3588, so remove > it from the format list. > > Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats") >

Re: [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe()

2024-03-04 Thread Daniel Thompson
On Mon, Mar 04, 2024 at 11:11:38AM +0100, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/video/backlight/gpio_backlight.c | 10

[PATCH] fbdev/chipsfb: Include

2024-03-04 Thread Thomas Zimmermann
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from . Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/ Signed-off-by: Thomas Zimmermann

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Thomas Zimmermann
Hi Am 04.03.24 um 10:55 schrieb Jani Nikula: Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju Closes:

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Maxime Ripard
le-endian platforms with +200 GiB/s memory bandwidth): > > > > > > ---8<--- > > > Subject: kisskb: FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Mon Mar > > > 04, 06:35 > > > To: ge

Re: [PATCH v15 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-04 Thread Nautiyal, Ankit K
On 3/1/2024 2:15 PM, Mitul Golani wrote: Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani LGTM. Reviewed-by: Ankit Nautiyal ---

Re: [PATCH v15 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-04 Thread Nautiyal, Ankit K
On 3/1/2024 2:15 PM, Mitul Golani wrote: Add necessary function definitions to compute AS SDP data. The new intel_dp_compute_as_sdp function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Added DP_SDP_ADAPTIVE_SYNC

[PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message

2024-03-04 Thread Krzysztof Kozlowski
Core code already prints detailed information about failure of memory allocation. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/pandora_bl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/backlight/pandora_bl.c

[PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error

2024-03-04 Thread Krzysztof Kozlowski
Code can be simpler: return directly when devm_gpiod_get_optional() failed. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lm3630a_bl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c

[PATCH 4/7] backlight: as3711_bl: Handle deferred probe

2024-03-04 Thread Krzysztof Kozlowski
Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/as3711_bl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/as3711_bl.c

[PATCH 5/7] backlight: lm3630a_bl: Handle deferred probe

2024-03-04 Thread Krzysztof Kozlowski
Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lm3630a_bl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c

[PATCH 3/7] backlight: bd6107: Handle deferred probe

2024-03-04 Thread Krzysztof Kozlowski
Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/bd6107.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/bd6107.c

[PATCH 2/7] backlight: l4f00242t03: Simplify with dev_err_probe()

2024-03-04 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/l4f00242t03.c | 34 ++ 1 file changed, 14 insertions(+), 20

[PATCH 1/7] backlight: gpio: Simplify with dev_err_probe()

2024-03-04 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/gpio_backlight.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH 0/7] backlight: Simplify probe in few drivers

2024-03-04 Thread Krzysztof Kozlowski
(+), 48 deletions(-) --- base-commit: 1870cdc0e8dee32e3c221704a2977898ba4c10e8 change-id: 20240304-backlight-probe-31dee1efe662 Best regards, -- Krzysztof Kozlowski

[PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support

2024-03-04 Thread Andy Yan
From: Andy Yan The Alpha blending for 30 bit RGB/BGR are not functioning properly for rk3568/rk3588, so remove it from the format list. Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats") Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --

Re: [PATCH v15 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-04 Thread Nautiyal, Ankit K
On 3/1/2024 2:14 PM, Mitul Golani wrote: Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani LGTM. Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Geert Uytterhoeven
h +200 GiB/s memory bandwidth): > > > > ---8<--- > > Subject: kisskb: FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Mon Mar 04, > > 06:35 > > To: ge...@linux-m68k.org > > Date: Mon, 04 Mar 2024 08

Re: [PATCH v15 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-04 Thread Nautiyal, Ankit K
On 3/1/2024 2:14 PM, Mitul Golani wrote: Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] -

Re: [PATCH v3 2/5] clk: sunxi-ng: a64: Set minimum and maximum rate for PLL-MIPI

2024-03-04 Thread Maxime Ripard
On Mon, 4 Mar 2024 08:29:18 +0100, Frank Oltmanns wrote: > When the Allwinner A64's TCON0 searches the ideal rate for the connected > panel, it may happen that it requests a rate from its parent PLL-MIPI > which PLL-MIPI does not support. > > This happens for example on the Olimex TERES-I laptop

Re: [PATCH v3 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-03-04 Thread Maxime Ripard
On Mon, Mar 04, 2024 at 08:29:17AM +0100, Frank Oltmanns wrote: > The Allwinner SoC's typically have an upper and lower limit for their > clocks' rates. Up until now, support for that has been implemented > separately for each clock type. > > Implement that functionality in the sunxi-ng's common

Re: [PATCH] drm/sun4i: hdmi: Fix u64 div on 32bit arch

2024-03-04 Thread Geert Uytterhoeven
Hi Maxime, Thanks for your patch! On Mon, Mar 4, 2024 at 10:12 AM Maxime Ripard wrote: > Commit 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and > mode_valid") changed the clock rate from an unsigned long to an unsigned > long long resulting in a a 64-bit division that might not be

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Jani Nikula
On Mon, 04 Mar 2024, Jani Nikula wrote: > Removal of the backlight include from fb.h uncovered an implicit > dependency in powerpc asm/backlight.h. Add the explicit include. > > Reported-by: Naresh Kamboju > Closes: >

[PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Jani Nikula
Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju Closes: https://lore.kernel.org/r/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com Fixes: 11b4eedfc87d ("fbdev: Do not

Re: [PATCH v2 1/1] UPSTREAM: drm/bridge: it6505: fix hibernate to resume no display issue

2024-03-04 Thread Pin-yen Lin
Hi Kuro, On Mon, Mar 4, 2024 at 11:08 AM kuro wrote: > > From: kuro chung > > ITE added a FIFO reset bit for input video. When system power resume, > the TTL input of it6505 may get some noise before video signal stable > and the hardware function reset is required. > But the input FIFO reset

Re: [PATCH v15 3/9] drm: Add crtc state dump for Adaptive Sync SDP

2024-03-04 Thread Nautiyal, Ankit K
Add drm/i915/display in subject line. With that fixed this is: Reviewed-by: Ankit Nautiyal On 3/1/2024 2:14 PM, Mitul Golani wrote: Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani ---

Re: [PATCH 2/2] drm/msm/dpu: drop dpu_kms from _dpu_kms_initialize_writeback

2024-03-04 Thread Dmitry Baryshkov
On Wed, 28 Feb 2024 at 21:47, Abhinav Kumar wrote: > > Following the pattern of other interfaces, lets align writeback > as well by dropping the dpu_kms parameter in its _dpu_kms_initialize_* > function. > > Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov > --- >

Re: [PATCH 1/2] drm/msm/dpu: drop unused dpu_kms from interface initialization

2024-03-04 Thread Dmitry Baryshkov
On Wed, 28 Feb 2024 at 21:47, Abhinav Kumar wrote: > > dpu_kms seems unused while initializing DSI, HDMI and DP through > their respective _dpu_kms_initialize_* functions. > > Hence lets drop the parameter altogether. > > Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov > --- >

Re: [PATCH v2] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-03-04 Thread Krzysztof Kozlowski
On 04/03/2024 10:28, dharm...@microchip.com wrote: > On 04/03/24 1:06 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 04/03/2024 06:36, Dharma Balasubiramani wrote: >>> Convert the atmel,lcdc bindings to DT

Re: [PATCH v2] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-03-04 Thread Dharma.B
On 04/03/24 1:06 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 04/03/2024 06:36, Dharma Balasubiramani wrote: >> Convert the atmel,lcdc bindings to DT schema. >> Changes during conversion: add missing clocks

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Maxime Ripard
On Sat, Mar 02, 2024 at 02:10:51PM -0800, Guenter Roeck wrote: > On Thu, Feb 29, 2024 at 12:21 PM Linus Torvalds > wrote: > > > > On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote: > > > > > > However, I think a better approach would be *not* to add the > > > .gitlab-ci.yaml > > > file in

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Maxime Ripard
config/m68k-gcc8 Mon Mar 04, > 06:35 > To: ge...@linux-m68k.org > Date: Mon, 04 Mar 2024 08:05:14 -0000 > > FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Mon Mar 04, 06:35 > > http://kisskb.ellerman.id.au/kisskb/buildresult/15135537/ > > Commit: Add linux-next specific fi

[PATCH] drm/sun4i: hdmi: Fix u64 div on 32bit arch

2024-03-04 Thread Maxime Ripard
Commit 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid") changed the clock rate from an unsigned long to an unsigned long long resulting in a a 64-bit division that might not be supported on all platforms. The resulted in compilation being broken at least for m68k, xtensa

[PATCH] drm/bridge: imx8mp-hdmi-tx: Convert to platform remove callback returning void

2024-03-04 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve

[PATCH 2/3] drm/panthor: Explicitly include page.h for the {virt, __phys)_to_pfn() defs

2024-03-04 Thread Boris Brezillon
Something on arm[64] must be including , but things fail to compile on sparc64. Make sure this header is included explicitly so this driver can be compile-tested on all supported architectures. Reported-by: kernel test robot Closes:

[PATCH 3/3] drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue

2024-03-04 Thread Boris Brezillon
panthor_device_resume/suspend() are only compiled when CONFIG_PM is enabled but panthro_drv.c doesn't use the pm_ptr() macro to conditionally discard resume/suspend assignments, which causes undefined symbol errors at link time when !PM. We could fix that by using pm_ptr(), but supporting the !PM

[PATCH 1/3] drm/panthor: Fix panthor_devfreq kerneldoc

2024-03-04 Thread Boris Brezillon
Missing '*' to have a valid kerneldoc prefix. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202403031019.6jvroqgt-...@intel.com/ Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 0/3] drm/panthor: Fix 3 issues reported by the kernel test bot

2024-03-04 Thread Boris Brezillon
Hello, Here are three trivial fixes for bugs reported by the intel kernel test bot. Regards, Boris Boris Brezillon (3): drm/panthor: Fix panthor_devfreq kerneldoc drm/panthor: Explicitly include page.h for the {virt,__phys)_to_pfn() defs drm/panthor: Fix undefined

[PATCH] drm/bridge: imx8mp-hdmi-pvi: Convert to platform remove callback returning void

2024-03-04 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve

Re: [PATCH v15 2/9] drm: Add Adaptive Sync SDP logging

2024-03-04 Thread Nautiyal, Ankit K
On 3/1/2024 2:14 PM, Mitul Golani wrote: Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - Use 'as_sdp' instead of 'async' [Ankit] - Correct define

Re: [PATCH v15 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-04 Thread Nautiyal, Ankit K
On 3/1/2024 2:14 PM, Mitul Golani wrote: Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani LGTM. Reviewed-by: Ankit Nautiyal ---

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Guillaume Tucker
On 02/03/2024 10:48 pm, Gustavo Padovan wrote: On Friday, March 01, 2024 18:56 -03, Guillaume Tucker wrote: On 29/02/2024 17:28, Nicolas Dufresne wrote: Hi, Le jeudi 29 février 2024 à 16:16 +0200, Nikolai Kondrashov a écrit : On 2/29/24 2:20 PM, Guillaume Tucker wrote: Hello, On

Re: [PATCH 2/2] backlight: Add new lm3509 backlight driver

2024-03-04 Thread Krzysztof Kozlowski
On 04/03/2024 09:23, Krzysztof Kozlowski wrote: > >> +return PTR_ERR(data->regmap); >> +} >> +i2c_set_clientdata(client, data); >> + >> +data->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); >> +if (IS_ERR(data->reset_gpio)) { >> +ret =

Re: [PATCH 2/2] backlight: Add new lm3509 backlight driver

2024-03-04 Thread Krzysztof Kozlowski
On 02/03/2024 22:27, Patrick Gansterer wrote: > This is a general driver for LM3509 backlight chip of TI. > LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with > Dual Current Sinks. This driver supports OLED/White LED select, brightness > control and sub/main control. > The

fbdev/chipsfb.c:401:31: error: invalid use of undefined type 'struct backlight_device'

2024-03-04 Thread Naresh Kamboju
The powerpc ppc6xx_defconfig builds failed on today's Linux next tag next-20240304. Reported-by: Linux Kernel Functional Testing Build log: - drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init': drivers/video/fbdev/chipsfb.c:401:31: error: invalid use of undefined type 'struct

Re: [PATCH 1/2] dt-bindings: backlight: Add Texas Instruments LM3509 bindings

2024-03-04 Thread Krzysztof Kozlowski
On 02/03/2024 22:27, Patrick Gansterer wrote: > Add Device Tree bindings for Texas Instruments LM3509 - a > High Efficiency Boost for White LED's and/or OLED Displays > > Signed-off-by: Patrick Gansterer A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Geert Uytterhoeven
-- Subject: kisskb: FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Mon Mar 04, 06:35 To: ge...@linux-m68k.org Date: Mon, 04 Mar 2024 08:05:14 - FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Mon Mar 04, 06:35 htt

arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-04 Thread Naresh Kamboju
The arm defconfig builds failed on today's Linux next tag next-20240304. Build log: - ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! Steps to reproduce: # tuxmake --runtime podman --target-arch arm --toolchain clang-17 --kconfig defcon

<    1   2   3