On Fri, Feb 09, 2024 at 07:50:52AM +, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote:
> > > On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > > > On Thu, Feb 08, 2024 at 05:
re. In any case, nice patch:
And it's at the bottom (among SoB lines), there is no violation with Submitting
Patches.
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 08, 2024 at 08:24:46PM +0200, Andy Shevchenko wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Add mod_devicetable.h include.
It seems some emails are missing, I just sent a 'resend v3' hopefully without
m
Replace dev_err() with dev_err_probe().
This helps in simplifing code and standardizing the error output.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 18 +++---
1 file changed, 7 insertions(+), 11
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Reviewed-by: Daniel Thompson
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 30 --
1 file changed, 12 insertions(+), 18
iel)
- add tags (Daniel, Flavio)
- new patch 2
Andy Shevchenko (3):
backlight: mp3309c: Make use of device properties
backlight: mp3309c: use dev_err_probe() instead of dev_err()
backlight: mp3309c: Utilise temporary variable for struct device
drivers/video/backlight/mp3309c.c |
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 44 +--
1
Replace dev_err() with dev_err_probe().
This helps in simplifing code and standardizing the error output.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 18 +++---
1 file changed, 7 insertions(+), 11
iel)
- add tags (Daniel, Flavio)
- new patch 2
Andy Shevchenko (3):
backlight: mp3309c: Make use of device properties
backlight: mp3309c: use dev_err_probe() instead of dev_err()
backlight: mp3309c: Utilise temporary variable for struct device
drivers/video/backlight/mp3309c.c |
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Tested-by: Flavio Suligoi
Reviewed-by: Daniel Thompson
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 44 +--
1
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Reviewed-by: Daniel Thompson
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 30 --
1 file changed, 12 insertions(+), 18
On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote:
> > > On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > > > On Thu, Feb 08, 2024 at 11:
On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote:
> On Thu, 08 Feb 2024, Andy Shevchenko wrote:
> > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote:
> > > On Thu, 01 Feb 2024, Andy Shevchenko wrote:
...
> > > > backlight: mp3309c: Utilise tempor
On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote:
> On Thu, 01 Feb 2024, Andy Shevchenko wrote:
...
> > backlight: mp3309c: Utilise temporary variable for struct device
(1)
> Set no longer applies. Please rebase, thanks.
I got a contradictory messages:
1) email that s
On Thu, Feb 08, 2024 at 10:53:04AM +, Lee Jones wrote:
> On Thu, 01 Feb 2024, Andy Shevchenko wrote:
...
> Someone may wish to address this:
>
> WARNING: DT compatible string "himax,hx8369" appears un-documented -- check
> ./Documentation/devicetree/bindings/
&
On Fri, Feb 02, 2024 at 10:52:32AM +, Flavio Suligoi wrote:
> > Andy Shevchenko (3):
> > backlight: mp3309c: Make use of device properties
> > backlight: mp3309c: use dev_err_probe() instead of dev_err()
> > backlight: mp3309c: Utilise temporary variable for st
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 44 +--
1 file changed, 18 insertions
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Reviewed-by: Daniel Thompson
Tested-by: Flavio Suligoi
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 30 --
1 file changed, 12 insertions(+), 18
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Include mod_devicetable.h explicitly to replace the dropped of.h
which included mod_devicetable.h indirectly.
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video
Move OF table near to the user.
While at it, drop comma at terminator entry.
Reviewed-by: Daniel Thompson
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions
Replace dev_err() with dev_err_probe().
This helps in simplifing code and standardizing the error output.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/video/backlight
Allow to use driver on non-OF platforms and other cleanups.
Changelog v2:
- rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel)
- add tags (Daniel, Flavio)
- new patch 2
Andy Shevchenko (3):
backlight: mp3309c: Make use of device properties
backlight: mp3309c:
We have a temporary variable to keep pointer to struct device.
Utilise it inside the ->probe() implementation.
Reviewed-by: Daniel Thompson
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 7 +++
1 file changed, 3 insertions(+)
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().
Reviewed-by: Daniel Thompson
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 12
1 file changed, 4 insertions(+), 8 deletions
A few ad-hoc cleanups and one patch to make driver OF-independent.
Chagelog v2:
- renamed init to init_fn and typedef accordingly (Daniel)
- added tags (Daniel, Javier)
Andy Shevchenko (4):
backlight: hx8357: Make use of device properties
backlight: hx8357: Move OF table closer to its
On Wed, Jan 24, 2024 at 05:25:07PM +, Daniel Thompson wrote:
> On Sun, Jan 14, 2024 at 05:25:11PM +0200, Andy Shevchenko wrote:
...
> Reviewed-by: Daniel Thompson
Thank you for the review, I will address comments and send a new version
at the end of the next week I hope.
--
Wit
On Wed, Jan 24, 2024 at 05:19:53PM +, Daniel Thompson wrote:
> On Sun, Jan 14, 2024 at 05:25:08PM +0200, Andy Shevchenko wrote:
...
> > +typedef int (*hx8357_init)(struct lcd_device *);
> > + hx8357_init init;
>
> As somewhere else in this thread, I'd find thi
On Mon, Jan 15, 2024 at 09:20:46AM +0100, Javier Martinez Canillas wrote:
> Andy Shevchenko writes:
...
> > +typedef int (*hx8357_init)(struct lcd_device *);
>
> This kind of typedef usage is frowned upon in the Linux coding style [0]
> (per my understanding at least) and in
On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote:
> Andy Shevchenko writes:
...
> > + {}
>
> While at it, maybe add the { /* sentinel */ } convention to the last entry ?
Maybe. Is it a common for this subsystem?
...
> Reviewed-by: Javier Martine
e_device(...);
if (ret)
return ret;
return devm_add_action_or_reset(...)?
I could think of side effects of this, so perhaps the commit message and/or
code needs a comment on why the above proposal can _not_ be used?
--
With Best Regards,
Andy Shevchenko
}
...
> + if (new != pci_command)
if (new == pci_command)
return;
?
> pci_write_config_word(pdev, PCI_COMMAND, new);
--
With Best Regards,
Andy Shevchenko
sure, it might be good to preserve (to some extent) the
order.
--
With Best Regards,
Andy Shevchenko
ature of PCI's devres.
Instead of adding pcim_intx(), please provide proper one for
pci_alloc_irq_vectors(). Ideally it would be nice to deprecate
old IRQ management functions in PCI core and delete them in the
future.
--
With Best Regards,
Andy Shevchenko
r);
> +err_region:
> + pcim_addr_devres_free(res);
> +
> + return IOMEM_ERR_PTR(ret);
> +}
...
> +static int _pcim_request_region(struct pci_dev *pdev, int bar, const char
> *name,
> + int request_flags)
Indentation?
> +{
> + int ret = 0;
Unneded assignment. Also fix this in other places.
> + struct pcim_addr_devres *res;
> +
> + res = pcim_addr_devres_alloc(pdev);
> + if (!res)
> + return -ENOMEM;
> + res->type = PCIM_ADDR_DEVRES_TYPE_REGION;
> + res->bar = bar;
> +
> + ret = __pcim_request_region(pdev, bar, name, request_flags);
> + if (ret != 0) {
if (ret)
Also fix this in other places.
> + pcim_addr_devres_free(res);
> + return ret;
> + }
> +
> + devres_add(>dev, res);
> + return 0;
> +}
--
With Best Regards,
Andy Shevchenko
lusive == IORESOURCE_EXCLUSIVE)
> + return pcim_request_region_exclusive(pdev, bar,
> res_name);
> + else
Redundant 'else'
> + return pcim_request_region(pdev, bar, res_name);
> + }
--
With Best Regards,
Andy Shevchenko
; bar++) {
> + if (!mask_contains_bar(mask, bar))
> continue;
NIH for_each_set_bit()
> - pcim_iounmap(pdev, iomap[i]);
> - pci_release_region(pdev, i);
> + pcim_iounmap_region(pdev, bar);
> + pcim_remove_bar_from_legacy_table(pdev, bar);
> }
--
With Best Regards,
Andy Shevchenko
We have a temporary variable to keep pointer to struct device.
Utilise it inside the ->probe() implementation.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/hx8357.
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Include mod_devicetable.h explicitly to replace the dropped of.h
which included mod_devicetable.h indirectly.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 14
Move OF table near to the user.
While at it, drop comma at terminator entry.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/video/backlight/hx8357.c b/drivers/video
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/hx8357.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/video/backlight/hx8357.c b/drivers/video
A few ad-hoc cleanups and one patch to make driver OF-independent.
Andy Shevchenko (4):
backlight: hx8357: Make use of device properties
backlight: hx8357: Move OF table closer to its consumer
backlight: hx8357: Make use of dev_err_probe()
backlight: hx8357: Utilise temporary variable
The "im" pins are optional. Add missing check in the hx8357_probe().
Reported-by: Dan Carpenter
Closes:
https://lore.kernel.org/r/642e1230-3358-4006-a17f-3f297897ae74@moroto.mountain
Fixes: 7d84a63a39b7 ("backlight: hx8357: Convert to agnostic GPIO API")
Signed-off
it more readable.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/virtio/virtgpu_submit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c
b/drivers/gpu/drm/virtio/virtgpu_submit.c
index 5c514946bbad..1c7c7f61a222 100644
--- a/drivers
On Fri, Dec 15, 2023 at 04:11:02PM +, Daniel Thompson wrote:
> On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote:
...
> > static int pm3309c_parse_dt_node(struct mp3309c_chip *chip,
>
> Pretty minor... but I wonder if it should be renamed:
> mp3309c_parse_fw
Allow to use driver on non-OF platforms and other cleanups.
Andy Shevchenko (2):
backlight: mp3309c: Make use of device properties
backlight: mp3309c: Utilise temporary variable for struct device
drivers/video/backlight/mp3309c.c | 76 +--
1 file changed, 31
We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 38 +--
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/drivers/video/backlight
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Add mod_devicetable.h include.
Signed-off-by: Andy Shevchenko
---
drivers/video/backlight/mp3309c.c | 38 ---
1 file changed, 15 insertions(+), 23 deletions(-)
diff
On Fri, Dec 08, 2023 at 09:18:20PM +0100, Noralf Trønnes wrote:
> On 12/8/23 17:00, Andy Shevchenko wrote:
> > Included authors and latest (non-white-space) contributors to the drivers
> > in question along with relevant mailing list and respective (active in the
> > area) ma
ot be used on
non-OF systems.
--
With Best Regards,
Andy Shevchenko
The of_gpio.h is going to be removed. In preparation of that convert
the driver to the agnostic API.
Reviewed-by: Daniel Thompson
Fixes: fbbbcd177a27 ("gpiolib: of: add quirk for locating reset lines with
legacy bindings")
Reviewed-by: Linus Walleij
Signed-off-by: Andy Shevchen
to put the GPIO-descriptors.
Fine by me, but I'm not to judge if it is a right approach or not.
In my series I have reused existing call... Anyway, FWIW,
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
The driver uses math.h and not util_macros.h.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c
b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index
ght since we do the same for formats anyway. But it did
> occur to me (twice at least) that a kmemdup_array() might a nice thing
> to have for things like this. But that's a separate topic.
JFYI:
https://lore.kernel.org/all/20231017052322.2636-2-kkar...@nvidia.com/
--
With Best Regards,
Andy Shevchenko
fact, using a default value of 1 leads to the display not working when
> the fbdev is attached to the framebuffer console.
>
> Reported-by: Sahaj Sarup
Closes?
Fixes?
> Signed-off-by: Javier Martinez Canillas
--
With Best Regards,
Andy Shevchenko
On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote:
> On 11/3/23 21:18, Andy Shevchenko wrote:
> > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> > talking to GPIO IP behind the actual driver's back. A second attempt
> > to fix that i
n
> a bit flaky recently, so needed to do a rerun.
>
> That said, I'm not sure if we have any hardware in CI that would
> actually exercise the modifications, so in that sense I trust Hans'
> testing much more.
Thank you!
Should I fix checkpatch warnings CI reported about?
--
With Best Regards,
Andy Shevchenko
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++-
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915
Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/vlv_sideband.c | 17 -
drivers/gpu/drm/i915/vlv_sideband.h | 3 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/gpu/drm/i915
Taking all this into consideration replace the hack
with proper GPIO APIs being used.
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 47 +---
1 file changed, 10 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm/i9
ed.
After getting the "backlight" and "panel" GPIOs the lookup table
registered by intel_dsi_vbt_gpio_init() is no longer necessary,
remove it so that another temporary lookup-table for the ":00:02.0"
device can be added.
Signed-off-by: Hans de Goede
Signed-off-by
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.
For CHV case, for example, we will need to distinguish community based index
from the one that VBT is using. Introduce an additional parameter to
soc_gpio_set_value() and its callers.
Signed-off-by: Andy Shevchenko
From: Hans de Goede
Fix wrong initial value for GPIOs in bxt_gpio_set_value().
Signed-off-by: Hans de Goede
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers
In the snippets like the following
if (...)
return / goto / break / continue ...;
else
...
the 'else' is redundant. Get rid of it.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display
Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +
1 file changed, 1 insertion(+), 4
For a couple of cases the branches call the same bxt_gpio_set_value().
As Ville suggested they can be combined by dropping the DISPLAY_VER()
check from Gen 11 to Gen 9. Do it that way.
Suggested-by: Ville Syrjälä
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c
Taking all this into consideration replace the hack with proper
GPIO APIs being used.
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++--
1 file changed, 28 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ds
of precursor patches by Hans
- added Rb tag for used to be first three patches (Andi)
- rebased on top of the above changes
- fixed indexing for multi-community devices, such as Cherry View
In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well
Andy
Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
Acked-by: Jani Nikula
---
drivers
From: Jani Nikula
Drop the unused parameter.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915
From: Jani Nikula
Purely a guess. Drop the nop function.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers
From: Jani Nikula
With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
From: Jani Nikula
The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20
From: Jani Nikula
Follow the contemporary conventions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers
Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display
On Thu, Nov 02, 2023 at 07:10:09PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 02, 2023 at 05:12:14PM +0200, Andy Shevchenko wrote:
...
> > if (native)
> > icl_native_gpio_set_value(dev_priv, gpio_number, value);
> > else if (DISPLA
On Thu, Nov 02, 2023 at 04:47:41PM +0100, Hans de Goede wrote:
> On 11/2/23 16:12, Andy Shevchenko wrote:
...
> > + soc_exec_opaque_gpio(connector, gpio_index,
> > "INT33FF:03", "Panel SE",
> > +
From: Jani Nikula
Purely a guess. Drop the nop function.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers
Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/vlv_sideband.c | 17 -
drivers/gpu/drm/i915/vlv_sideband.h | 3 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/vlv_sideband.c
b/drivers/gpu
Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
On Thu, Nov 02, 2023 at 05:12:23PM +0200, Andy Shevchenko wrote:
> From: Hans de Goede
>
> Fix wrong initial value for GPIOs in bxt_exec_gpio().
Oh, and forgot to update the function name in this patch.
In any case I would wait for Hans to confirm it works (and probably he may give
From: Hans de Goede
Fix wrong initial value for GPIOs in bxt_exec_gpio().
Signed-off-by: Hans de Goede
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
From: Jani Nikula
The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20
In the snippets like the following
if (...)
return / goto / break / continue ...;
else
...
the 'else' is redundant. Get rid of it.
Reviewed-by: Andi Shyti
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 58
On Thu, Nov 02, 2023 at 05:12:13PM +0200, Andy Shevchenko wrote:
> DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> talking to GPIO IP behind the actual driver's back. A second attempt
> to fix that is here.
>
> If I understood correctly, my appro
Taking all this into consideration replace the hack with proper
GPIO APIs being used.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++--
1 file changed, 28 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
b/drivers/gp
ed.
After getting the "backlight" and "panel" GPIOs the lookup table
registered by intel_dsi_vbt_gpio_init() is no longer necessary,
remove it so that another temporary lookup-table for the ":00:02.0"
device can be added.
Signed-off-by: Hans de Goede
Signed-off-b
From: Jani Nikula
Drop the unused parameter.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915
From: Jani Nikula
With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
From: Jani Nikula
Follow the contemporary conventions.
Cc: Andy Shevchenko
Cc: Hans de Goede
Signed-off-by: Jani Nikula
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers
devices, such as Cherry View
In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well
Andy Shevchenko (8):
drm/i915/dsi: Replace while(1) with one with clear exit condition
drm/i915/dsi: Get rid of redundant 'else'
drm/i915/dsi: Replace check
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.
For CHV case, for example, we will need to distinguish community based index
from the one that VBT is using. Introduce an additional parameter to
soc_gpio_set_value() and its callers.
Signed-off-by: Andy Shevchenko
Taking all this into consideration replace the hack
with proper GPIO APIs being used.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 47 +---
1 file changed, 10 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
b/drive
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++-
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
b
On Wed, Nov 01, 2023 at 11:20:23AM +0100, Hans de Goede wrote:
> On 11/1/23 10:32, Andy Shevchenko wrote:
> > On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
> >> On 10/31/23 17:07, Hans de Goede wrote:
> >>> On 10/24/23 18:11, Andy Shevchenko wrot
at sense with less possible invasion
into existing flow.
--
With Best Regards,
Andy Shevchenko
On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote:
> On 10/31/23 17:07, Hans de Goede wrote:
> > On 10/24/23 18:11, Andy Shevchenko wrote:
> >> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
...
> > As for the CHT support, I have not adde
On Tue, Oct 31, 2023 at 05:07:39PM +0100, Hans de Goede wrote:
> On 10/24/23 18:11, Andy Shevchenko wrote:
> > On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
> >> It's a dirty hack in the driver that pokes GPIO registers behind
> >> the driver
On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote:
> It's a dirty hack in the driver that pokes GPIO registers behind
> the driver's back. Moreoever it might be problematic as simultaneous
> I/O may hang the system, see the commit 0bd50d719b00 ("pinctrl:
> ch
that use this piece of code,
is it possible to give a test run on (one of) them?
In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well
Andy Shevchenko (7):
drm/i915/dsi: Replace while(1) with one with clear exit condition
drm/i915/dsi: Get rid
Taking all this into consideration replace the hack with proper
GPIO APIs being used.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++--
1 file changed, 28 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
b/drivers/gp
101 - 200 of 959 matches
Mail list logo
