On 5/25/24 11:26, Melissa Wen wrote:
I haven't been able to follow or review the work on the driver for some
time now and I don't see the situation improving anytime soon. I'd like
to continue being listed as a reviewer.
Signed-off-by: Melissa Wen
Acked-by: Maíra Canal
Thanks for all
Hi Jani,
On 5/21/24 08:07, Jani Nikula wrote:
On Mon, 20 May 2024, Maíra Canal wrote:
On 5/12/24 19:23, Maíra Canal wrote:>
Maíra Canal (6):
drm/v3d: Add Performance Counters descriptions for V3D 4.2 and 7.1
drm/v3d: Different V3D versions can have different number of perfcnt
On 5/12/24 19:23, Maíra Canal wrote:>
Maíra Canal (6):
drm/v3d: Add Performance Counters descriptions for V3D 4.2 and 7.1
drm/v3d: Different V3D versions can have different number of perfcnt
drm/v3d: Create a new V3D parameter for the maximum number of perfcnt
drm/v3d: Create
Hi Louis,
On 5/13/24 04:50, Louis Chauvet wrote:
As all the rotation are now supported by VKMS, this simplification does
not make sense anymore, so remove it.
Signed-off-by: Louis Chauvet
I'd like to push all commits up to this point to drm-misc-next. Do you
see a problem with it? Reason:
information, we can deprecate this enum.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
include/uapi/drm/v3d_drm.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
index 0860ddb3d0b6..87fc5bb0a61e 100644
us to create arrays on the
stack with reasonable size. Note that userspace must use the value
provided by DRM_V3D_PARAM_MAX_PERF_COUNTERS.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_drv.h | 5 -
drivers/gpu/drm/v3d/v3d_sched.c | 2 +-
2 files
ed
in user-space, but not in the kernel, generating invalid requests).
Therefore, create a new IOCTL to expose the performance counters
information, that is name, category, and description.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 +
d
-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +++
include/uapi/drm/v3d_drm.h| 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 6b9dd26df9fe..d2c1d5053132 100644
--- a/drivers/gpu/drm/v3d
("drm/v3d: add brcm,2712-v3d as a compatible V3D device")
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_drv.c | 7 +++
drivers/gpu/drm/v3d/v3d_drv.h | 5 +
drivers/gpu/drm/v3d/v3d_perfmon.c | 3 ++-
3 files changed, 14 insert
.
[1] https://lore.kernel.org/dri-devel/20231031073859.25298-1-ito...@igalia.com/
[2]
https://gitlab.freedesktop.org/mesa/mesa/-/commit/ea1f09a5f21839f4f3b93610b58507c4bd9b9b81
[3] https://gitlab.freedesktop.org/mairacanal/mesa/-/tree/v3dv/fix-perfcnt
Best Regards,
- Maíra Canal
---
v1 ->
by its position
on the array.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_drv.h | 2 +
.../gpu/drm/v3d/v3d_performance_counters.h| 208 ++
2 files changed, 210 insertions(+)
create mode 100644 drivers/gpu/drm/v3d
.
[1] https://lore.kernel.org/dri-devel/20231031073859.25298-1-ito...@igalia.com/
[2]
https://gitlab.freedesktop.org/mesa/mesa/-/commit/ea1f09a5f21839f4f3b93610b58507c4bd9b9b81
[3] https://gitlab.freedesktop.org/mairacanal/mesa/-/tree/v3dv/fix-perfcnt
Best Regards,
- Maíra Canal
Maíra Canal (6
information, we can deprecate this enum.
Signed-off-by: Maíra Canal
---
include/uapi/drm/v3d_drm.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
index 0860ddb3d0b6..706b4dea1c45 100644
--- a/include/uapi/drm/v3d_drm.h
+++ b/include
("drm/v3d: add brcm,2712-v3d as a compatible V3D device")
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 7 +++
drivers/gpu/drm/v3d/v3d_drv.h | 5 +
drivers/gpu/drm/v3d/v3d_perfmon.c | 3 ++-
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/d
-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 +++
include/uapi/drm/v3d_drm.h| 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 6b9dd26df9fe..d2c1d5053132 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d
us to create arrays on the
stack with reasonable size. Note that userspace must use the value
provided by DRM_V3D_PARAM_V3D_MAX_PERF_COUNTERS.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.h | 5 -
drivers/gpu/drm/v3d/v3d_sched.c | 2 +-
2 files changed, 5 insertions(+), 2
ed
in user-space, but not in the kernel, generating invalid requests).
Therefore, create a new IOCTL to expose the performance counters
information, that is name, category, and description.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 +
drivers/gpu/drm/v3d/v3d_drv.
by its position
on the array.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.h | 2 +
.../gpu/drm/v3d/v3d_performance_counters.h| 208 ++
2 files changed, 210 insertions(+)
create mode 100644 drivers/gpu/drm/v3d/v3d_performance_counters.h
diff --git
Hi Iago,
On 4/29/24 02:22, Iago Toral wrote:
Hi Maíra,
a question below:
El dom, 28-04-2024 a las 09:40 -0300, Maíra Canal escribió:
Although Big/Super Pages could appear naturally, it would be quite
hard
to have 1MB or 64KB allocated contiguously naturally. Therefore, we
can
force
Add a modparam for turning off Big/Super Pages to make sure that if an
user doesn't want Big/Super Pages enabled, it can disabled it by setting
the modparam to false.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 7 +++
drivers/gpu/drm/v3d/v3d_gemfs.c | 5 +
2 files
mountpoint with "huge=within_size" (if user has
THP enabled), use this mountpoint for BO creation if available. This
will allow us to create large pages allocated contiguously and make use
of Big/Super Pages.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/d
need a contiguous memory region.
That's why we use a separate mountpoint with THP enabled. In order to
place the page table entries in the MMU, we iterate over the 16 4KB pages
(for big pages) or 256 4KB pages (for super pages) and insert the PTE.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko
com/zmike/vkoverhead/issues/14
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_bo.c | 2 +-
drivers/gpu/drm/v3d/v3d_drv.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c
in
.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/drm_gem_shmem_helper.c | 30 ++
include/drm/drm_gem_shmem_helper.h | 3 +++
2 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c
b/drivers/gpu
1-mca...@igalia.com/T/
* [5/8] Add Iago's R-b to PATCH 5/8 (Iago Toral)
* [6/8] Add Tvrtko's R-b to PATCH 6/8 (Tvrtko Ursulin)
* [7/8] Add Tvrtko's R-b to PATCH 7/8 (Tvrtko Ursulin)
* [8/8] Move `bool super_pages` to the guard (Tvrtko Ursulin)
Best Regards,
- Maíra
Maíra Canal (8):
drm/v3d: Fi
If the scheduler initialization fails, GEM initialization must fail as
well. Therefore, if `v3d_sched_init()` fails, free the DMA memory
allocated and return the error value in `v3d_gem_init()`.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_gem.c | 3
object will be
created. If this parameter is NULL, then we fallback to `shmem_file_setup()`.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/drm_gem.c | 34 ++
include/drm/drm_gem.h | 3 +++
2 files changed, 33 insertions(+), 4
shmem-backed objects.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/Makefile| 3 ++-
drivers/gpu/drm/v3d/v3d_drv.h | 9 +++
drivers/gpu/drm/v3d/v3d_gem.c | 3 +++
drivers/gpu/drm/v3d/v3d_gemfs.c | 46 +
4 files changed,
On 4/23/24 04:05, Maxime Ripard wrote:
Hi,
On Mon, Apr 22, 2024 at 01:08:44PM -0300, Maíra Canal wrote:
@drm-misc maintainers, is there any chance you could backport commit
35f4f8c9fc97 ("drm/v3d: Don't increment `enabled_ns` twice") [1] to drm-
misc-next?
I would like to apply t
l/-/commit/35f4f8c9fc972248055096d63b782060e473311b
Best Regards,
- Maíra
On 4/20/24 18:32, Maíra Canal wrote:
The first version of this series had the intention to fix two major
issues with the GPU stats:
1. We were incrementing `enabled_ns` twice by the end of each job.
2. There is a race-condition between the I
Add a modparam for turning off Big/Super Pages to make sure that if an
user doesn't want Big/Super Pages enabled, it can disabled it by setting
the modparam to false.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 8
drivers/gpu/drm/v3d/v3d_gemfs.c | 5 +
2 files
with "huge=within_size" (if user has THP enabled),
use this mountpoint for BO creation if available. This will allow us to create
large pages allocated contiguously and make use of Big/Super Pages.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_bo.c | 21 +++--
need a contiguous memory region.
That's why we use a separate mountpoint with THP enabled. In order to
place the page table entries in the MMU, we iterate over the 16 4KB pages
(for big pages) or 256 4KB pages (for super pages) and insert the PTE.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm
.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/drm_gem_shmem_helper.c | 30 ++
include/drm/drm_gem_shmem_helper.h | 3 +++
2 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c
b/drivers/gpu
com/zmike/vkoverhead/issues/14
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_bo.c | 2 +-
drivers/gpu/drm/v3d/v3d_drv.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c
index a07ede668cc1..79e31c5299b1 100
gemfs/THP in BO creation if available (Tvrtko Ursulin)
* [8/8] New patch: Add modparam for turning off Big/Super Pages (Tvrtko Ursulin)
* [8/8] Don't expose the modparam `super_pages` unless
CONFIG_TRANSPARENT_HUGEPAGE
is enabled. (Tvrtko Ursulin)
* [8/8] Use `v3d->gemfs` to check if the u
object will be
created. If this parameter is NULL, then we fallback to `shmem_file_setup()`.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/drm_gem.c | 34 ++
include/drm/drm_gem.h | 3 +++
2 files changed, 33 insertions(+), 4
shmem-backed objects.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/Makefile| 3 ++-
drivers/gpu/drm/v3d/v3d_drv.h | 9 +++
drivers/gpu/drm/v3d/v3d_gem.c | 3 +++
drivers/gpu/drm/v3d/v3d_gemfs.c | 46 +
4 files changed,
If the scheduler initialization fails, GEM initialization must fail as
well. Therefore, if `v3d_sched_init()` fails, free the DMA memory
allocated and return the error value in `v3d_gem_init()`.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_gem.c | 3
Create a function to decouple the stats calculation from the printing.
This will be useful in the next step when we add a seqcount to protect
the stats.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 18 ++
drivers/gpu/drm/v3d/v3d_drv.h | 4
drivers/gpu
spike in the queue usage,
that didn't match reality.
In order to address this issue properly, use a seqcount to protect read
and write sections of the code.
Fixes: 09a93cc4f7d1 ("drm/v3d: Implement show_fdinfo() callback for GPU usage
stats")
Reported-by: Tvrtko Ursulin
Signed-off-by: Maíra
Given a set of GPU stats, that is, a `struct v3d_stats` related to a
queue in a given context, create a function that can update this set
of GPU stats.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
Reviewed-by: Jose Maria Casanova Crespo
---
drivers/gpu/drm/v3d/v3d_sched.c | 17
GPU stats
variables. Now, the jobs only need to call for `v3d_job_update_stats()`
when the job is done and `v3d_job_start_stats()` when starting the job.
Co-developed-by: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Maíra Canal
Reviewed-by: Jose Maria Casanova Crespo
---
drivers/g
Tvrtko Ursulin)
- [5/5] s/matches/match (Tvrtko Ursulin)
- [5/5] Add Tvrtko Ursulin's R-b
Best Regards,
- Maíra
Maíra Canal (5):
drm/v3d: Create two functions to update all GPU stats variables
drm/v3d: Create a struct to store the GPU stats
drm/v3d: Create function to update a set of GPU
of
the variable, as we are only accounting jobs that have been completed.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
Reviewed-by: Jose Maria Casanova Crespo
---
drivers/gpu/drm/v3d/v3d_drv.c | 15 +++
drivers/gpu/drm/v3d/v3d_drv.h | 18 ++
drivers/gpu/drm/v3d
spike in the queue usage,
that didn't matches reality.
In order to address this issue properly, use a seqcount to protect read
and write sections of the code.
Fixes: 09a93cc4f7d1 ("drm/v3d: Implement show_fdinfo() callback for GPU usage
stats")
Reported-by: Tvrtko Ursulin
Signed-off
Given a set of GPU stats, that is, a `struct v3d_stats` related to a
queue in a given context, create a function that can update this set
of GPU stats.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
Reviewed-by: Jose Maria Casanova Crespo
---
drivers/gpu/drm/v3d/v3d_sched.c | 17
of
the variable, as we are only accounting jobs that have been completed.
Signed-off-by: Maíra Canal
Reviewed-by: Tvrtko Ursulin
Reviewed-by: Jose Maria Casanova Crespo
---
drivers/gpu/drm/v3d/v3d_drv.c | 15 +++
drivers/gpu/drm/v3d/v3d_drv.h | 18 ++
drivers/gpu/drm/v3d
ine to the correct patch (2/4) (Tvrtko Ursulin)
* [4/4]: Use `seqcount_t` as locking primitive instead of a `rw_lock`
(Tvrtko Ursulin)
Maíra Canal (4):
drm/v3d: Create two functions to update all GPU stats variables
drm/v3d: Create a struct to store the GPU stats
drm/v3d: Create funct
GPU stats
variables. Now, the jobs only need to call for `v3d_job_update_stats()`
when the job is done and `v3d_job_start_stats()` when starting the job.
Co-developed-by: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Maíra Canal
Reviewed-by: Jose Maria Casanova Crespo
---
drivers/g
On 4/10/24 10:02, Thomas Zimmermann wrote:
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of
fbdev-generic's additional shadow buffering. No functional changes.
Signed-off-by: Thomas Zimmermann
Acked-by: Maíra Canal
Best Regards,
- Maíra
Cc: Rodrigo Siqueira
Cc: Melissa
On 4/16/24 02:30, Stefan Wahren wrote:
Hi Maíra,
Am 16.04.24 um 03:02 schrieb Maíra Canal:
On 4/15/24 13:54, Andre Przywara wrote:
On Mon, 15 Apr 2024 13:00:39 -0300
Maíra Canal wrote:
Hi,
RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to
the RPi. Currently
On 4/15/24 13:54, Andre Przywara wrote:
On Mon, 15 Apr 2024 13:00:39 -0300
Maíra Canal wrote:
Hi,
RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to
the RPi. Currently, the downstream kernel uses an overlay to enable the
GPU and use GPU hardware acceleration. When
On 4/3/24 17:24, Maíra Canal wrote:
The commit 509433d8146c ("drm/v3d: Expose the total GPU usage stats on sysfs")
introduced the calculation of global GPU stats. For the regards, it used
the already existing infrastructure provided by commit 09a93cc4f7d1 ("drm/v3d:
Implem
Hi Tvrtko,
On 4/1/24 10:21, Tvrtko Ursulin wrote:
On 01/04/2024 13:45, Christian König wrote:
Am 01.04.24 um 14:39 schrieb Tvrtko Ursulin:
On 29/03/2024 00:00, T.J. Mercier wrote:
On Thu, Mar 28, 2024 at 7:53 AM Tvrtko Ursulin
wrote:
From: Tvrtko Ursulin
There is no point in compiling
On 4/15/24 12:19, Jocelyn Falempe wrote:
Hi,
You're right, I messed up the rename, and I mostly test on x86, where I
don't build the imx driver.
Reviewed-by: Jocelyn Falempe
Best regards,
Applied to drm-misc/drm-misc-next!
Best Regards,
- Maíra
can't use the OpenGL driver).
Therefore, enable the V3D core for the RPi 0-3 in the mainline kernel.
Signed-off-by: Maíra Canal
---
v1 -> v2:
https://lore.kernel.org/dri-devel/41694292-af1f-4760-a7b6-101ed5dd6...@gmx.net/T/
* As mentioned by Krzysztof, enabling should be done in last pl
("drm/fb_dma: Add generic get_scanout_buffer() for
drm_panic"
Signed-off-by: Maíra Canal
---
include/drm/drm_fb_dma_helper.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_fb_dma_helper.h b/include/drm/drm_fb_dma_helper.h
index 61f24c2aba2f..c9
Hi Phil,
On 4/14/24 15:43, Phil Elwell wrote:
Hello all,
On Fri, 12 Apr 2024 at 18:17, Stefan Wahren wrote:
Hi Maíra,
[add Phil & Dave]
Am 12.04.24 um 15:25 schrieb Maíra Canal:
RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to
the RPi. Currently, the downst
can't use the OpenGL driver).
Therefore, enable the V3D core for the RPi 0-3 in the mainline kernel.
Signed-off-by: Maíra Canal
---
I decided to add the status property to the `bcm2835-common.dtsi`, but
there are two other options:
1. To add the status property to the `bcm2835-rpi-common.dtsi
On 4/9/24 12:15, Dmitry Baryshkov wrote:
On Tue, Apr 09, 2024 at 07:22:38PM +0530, Vignesh Raman wrote:
Hi Maíra,
On 09/04/24 15:10, Maíra Canal wrote:
On 4/9/24 05:13, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific tests to
testlist and skip driver-specific tests
On 4/9/24 05:13, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific tests to
testlist and skip driver-specific tests in *-skips.txt.
Also add testlist to the MAINTAINERS file and update xfails.
A better approach would be to stop vendoring the testlist
into the kernel and
On 4/8/24 16:06, Ville Syrjala wrote:
From: Ville Syrjälä
Replace the open coded drm_crtc_vblank_crtc() with the real
thing.
Cc: Rodrigo Siqueira
Cc: Melissa Wen
Cc: "Maíra Canal"
Cc: Haneen Mohammed
Cc: Daniel Vetter
Signed-off-by: Ville Syrjälä
Reviewed-by: Maíra Ca
On 4/4/24 18:30, Adrián Larumbe wrote:
On 04.04.2024 11:31, Maíra Canal wrote:
On 4/4/24 11:00, Adrián Larumbe wrote:
This changeset is heavily inspired by commit 509433d8146c ("drm/v3d: Expose
the total GPU usage stats on sysfs"). The point is making broader GPU
occupancy numbers
need a contiguous memory region.
That's why we use a separate mountpoint with THP enabled. In order to
place the page table entries in the MMU, we iterate over the 16 4KB pages
(for big pages) or 256 4KB pages (for super pages) and insert the PTE.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm
com/zmike/vkoverhead/issues/14
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_bo.c | 2 +-
drivers/gpu/drm/v3d/v3d_drv.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c
index a07ede668cc1..79e31c5299b1 100
.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/drm_gem_shmem_helper.c | 30 ++
include/drm/drm_gem_shmem_helper.h | 3 +++
2 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c
b/drivers/gpu/drm/drm_gem_shmem_helper.c
shmem-backed objects.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/Makefile| 3 ++-
drivers/gpu/drm/v3d/v3d_drv.h | 9 +++
drivers/gpu/drm/v3d/v3d_gem.c | 3 +++
drivers/gpu/drm/v3d/v3d_gemfs.c | 46 +
4 files changed,
object will be
created. If this parameter is NULL, then we fallback to `shmem_file_setup()`.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/drm_gem.c | 34 ++
include/drm/drm_gem.h | 3 +++
2 files changed, 33 insertions(+), 4 deletions(-)
diff --git
ontiguous_size(), as it could give us
misleading data (Tvrtko Ursulin)
* [6/6] Use both Big Pages (64K) and Super Pages (1MB)
Best Regards,
- Maíra
Maíra Canal (6):
drm/v3d: Fix return if scheduler initialization fails
drm/gem: Create a drm_gem_object_init_with_mnt() function
If the scheduler initialization fails, GEM initialization must fail as
well. Therefore, if `v3d_sched_init()` fails, free the DMA memory
allocated and return the error value in `v3d_gem_init()`.
Signed-off-by: Maíra Canal
Reviewed-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_gem.c | 3
On 4/4/24 11:00, Adrián Larumbe wrote:
This changeset is heavily inspired by commit 509433d8146c ("drm/v3d: Expose
the total GPU usage stats on sysfs"). The point is making broader GPU
occupancy numbers available through the sysfs interface, so that for every
job slot, its number of processed
spike in the queue usage,
that didn't matches reality.
In order to address this issue properly, use rw-locks to protect read
and write sections of the code.
Fixes: 09a93cc4f7d1 ("drm/v3d: Implement show_fdinfo() callback for GPU usage
stats")
Reported-by: Tvrtko Ursulin
Signed-off
Given a set of GPU stats, that is, a `struct v3d_stats` related to a
queue in a given context, create a function that can update all this set of
GPU stats.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_sched.c | 20
1 file changed, 12 insertions(+), 8 deletions
This will make it easier to instantiate the GPU stats variables and it
will create a structure where we can store all the variables that refer
to GPU stats.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 14 ++
drivers/gpu/drm/v3d/v3d_drv.h | 18
the fix to issue #1, in order to keep the fix separated
from code improvements.
The issue #1 is addressed on the first patch, while issue #2 is
addressed in the last patch. Patches #2 to #4 are code improvements.
Best Regards,
- Maíra
Maíra Canal (5):
drm/v3d: Don't increment `enabled_ns` twice
drm
xpose the total GPU usage
stats on sysfs").
Fixes: 509433d8146c ("drm/v3d: Expose the total GPU usage stats on sysfs")
Reported-by: Tvrtko Ursulin
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_irq.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v
for `v3d_job_update_stats()`
when the job is done and `v3d_job_start_stats()` when starting the job.
Co-developed-by: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.h | 1 +
drivers/gpu/drm/v3d/v3d_irq.c | 48 ++--
drivers
On 4/2/24 06:41, Dmitry Baryshkov wrote:
On Tue, Apr 02, 2024 at 12:35:17PM +0530, Vignesh Raman wrote:
Hi Maíra,
On 01/04/24 22:33, Maíra Canal wrote:
On 4/1/24 03:12, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific tests to
testlist and skip driver-specific tests
On 4/1/24 03:12, Vignesh Raman wrote:
Uprev IGT and add amd, v3d, vc4 and vgem specific tests to
testlist and skip driver-specific tests. Also add testlist
to the MAINTAINERS file and update xfails.
Signed-off-by: Vignesh Raman
---
v3:
- New patch in series to uprev IGT and update
On 4/1/24 03:12, Vignesh Raman wrote:
Add job that runs igt on top of vkms.
Signed-off-by: Vignesh Raman
Acked-by: Jessica Zhang
Tested-by: Jessica Zhang
Acked-by: Maxime Ripard
Signed-off-by: Helen Koike
Acked-by: Maíra Canal
Best Regards,
- Maíra
---
v4:
- New patch
On 3/26/24 12:56, Louis Chauvet wrote:
Le 25/03/24 - 10:56, Maíra Canal a écrit :
On 3/13/24 14:44, Louis Chauvet wrote:
Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the
compiler to check if the passed functions take the correct arguments.
Such typedefs will help ensuring
On 3/25/24 16:24, Guenter Roeck wrote:
Hi,
On Mon, Mar 25, 2024 at 04:05:06PM -0300, Maíra Canal wrote:
Hi Guenter,
On 3/25/24 14:52, Guenter Roeck wrote:
The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests
intentionally trigger warning backtraces by providing bad
Hi Guenter,
On 3/25/24 14:52, Guenter Roeck wrote:
The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests
intentionally trigger warning backtraces by providing bad parameters to
the tested functions. What is tested is the return value, not the existence
of a warning backtrace.
On 3/13/24 14:45, Louis Chauvet wrote:
From: Arthur Grillo
Create KUnit tests to test the conversion between YUV and RGB. Test each
conversion and range combination with some common colors.
The code used to compute the expected result can be found in comment.
Signed-off-by: Arthur Grillo
On 3/13/24 14:45, Louis Chauvet wrote:
From: Arthur Grillo
Add support to the YUV formats bellow:
- NV12/NV16/NV24
- NV21/NV61/NV42
- YUV420/YUV422/YUV444
- YVU420/YVU422/YVU444
The conversion from yuv to rgb is done with fixed-point arithmetic, using
32.32 floats and the drm_fixed helpers.
On 3/13/24 14:45, Louis Chauvet wrote:
Re-introduce a line-by-line composition algorithm for each pixel format.
This allows more performance by not requiring an indirection per pixel
read. This patch is focused on readability of the code.
Line-by-line composition was introduced by [1] but
On 3/13/24 14:45, Louis Chauvet wrote:
The pixel_read_direction enum is useful to describe the reading direction
in a plane. It avoids using the rotation property of DRM, which not
practical to know the direction of reading.
This patch also introduce two helpers, one to compute the
On 3/13/24 14:45, Louis Chauvet wrote:
As the pixel_read and pixel_write function should never modify the input
buffer, mark those pointers const.
Signed-off-by: Louis Chauvet
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
drivers/gpu/drm/vkms/vkms_drv.h | 4 ++--
drivers/gpu
On 3/13/24 14:44, Louis Chauvet wrote:
Introduce two callbacks which does nothing. They are used in replacement
of NULL and it avoid kernel OOPS if this NULL is called.
If those callback are used, it means that there is a mismatch between
what formats are announced by atomic_check and what is
On 3/13/24 14:44, Louis Chauvet wrote:
Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the
compiler to check if the passed functions take the correct arguments.
Such typedefs will help ensuring consistency across the code base in
case of update of these prototypes.
Rename
On 3/13/24 14:44, Louis Chauvet wrote:
Add some documentation on pixel conversion functions.
Update of outdated comments for pixel_write functions.
Signed-off-by: Louis Chauvet
---
drivers/gpu/drm/vkms/vkms_composer.c | 7
drivers/gpu/drm/vkms/vkms_drv.h | 13
b->offsets[0] + (y * fb->pitches[0])
+ + (x * fb->format->cpp[0]);
Nitpicking: Could this be packed into a single line?
Anyway,
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
}
/*
@@ -131,12 +133,12 @@ void vkms_compose_row(struct line_buffe
On 3/13/24 14:44, Louis Chauvet wrote:
Few no-op changes to remove double spaces and fix wrong alignments.
Signed-off-by: Louis Chauvet
Reviewed-by: Maíra Canal
Best Regards,
- Maíra
---
drivers/gpu/drm/vkms/vkms_composer.c | 10 +-
drivers/gpu/drm/vkms/vkms_crtc.c | 6
Not that the CC list wasn't big enough, but I'm adding MM folks
in the CC list.
On 3/18/24 11:04, Christian König wrote:
Am 18.03.24 um 14:28 schrieb Maíra Canal:
Hi Christian,
On 3/18/24 10:10, Christian König wrote:
Am 18.03.24 um 13:42 schrieb Maíra Canal:
Hi Christian,
On 3/12/24 10:48
On 3/18/24 10:28, Maíra Canal wrote:
Hi Christian,
On 3/18/24 10:10, Christian König wrote:
Am 18.03.24 um 13:42 schrieb Maíra Canal:
Hi Christian,
On 3/12/24 10:48, Christian König wrote:
Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin:
On 12/03/2024 10:37, Christian König wrote:
Am
Hi Christian,
On 3/18/24 10:10, Christian König wrote:
Am 18.03.24 um 13:42 schrieb Maíra Canal:
Hi Christian,
On 3/12/24 10:48, Christian König wrote:
Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin:
On 12/03/2024 10:37, Christian König wrote:
Am 12.03.24 um 11:31 schrieb Tvrtko Ursulin
/2024 08:59, Christian König wrote:
Am 12.03.24 um 09:51 schrieb Tvrtko Ursulin:
Hi Maira,
On 11/03/2024 10:05, Maíra Canal wrote:
For some applications, such as using huge pages, we might want
to have a
different mountpoint, for which we pass in mount flags that
better match
our usecase
Hi Melissa,
On 3/17/24 14:50, Melissa Wen wrote:
On 03/16, Arthur Grillo wrote:
As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong.
To round a number, you need to add 0.5 to the number and floor that,
drm_fixp2int_round() is adding 0.076. Make it add 0.5.
[1]:
that uses THP. This will allow us to create a contiguous
memory region to create our super pages. In order to place the page
table entries in the MMU, we iterate over the 256 4KB pages and insert
the PTE.
Signed-off-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_bo.c| 19 +--
drivers
1 - 100 of 736 matches
Mail list logo
