.
Fix these two issues.
Signed-off-by: Tomi Valkeinen
---
drivers/video/backlight/led_bl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c
index 63693c4f0883..43a5302f163a 100644
--- a/drivers/video
On 21/04/2020 14:26, Tomi Valkeinen wrote:
The led-backlight.txt is
a bit lacking (another thing to improve...) but led-backlight mimics
pwm-backlight, and pwm-backlight.txt says
default-brightness-level: The default brightness level (index into the array
defined by the "brightness-l
On 21/04/2020 13:48, Daniel Thompson wrote:
On Tue, Apr 21, 2020 at 08:52:02AM +0300, Tomi Valkeinen wrote:
On 20/04/2020 19:01, Daniel Thompson wrote:
On Fri, Apr 17, 2020 at 02:33:12PM +0300, Tomi Valkeinen wrote:
led_bl_parse_levels() is rather difficult to follow. Rewrite it with a
more
On 15/04/2020 10:39, Daniel Vetter wrote:
Upcasting using a container_of macro is more typesafe, faster and
easier for the compiler to optimize.
Tested-by: Jyri Sarha
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss
On 15/04/2020 10:40, Daniel Vetter wrote:
Not used anymore since the switch to suspend/resume helpers.
Tested-by: Jyri Sarha
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.h | 2 --
1 file changed, 2 deletions
On 15/04/2020 10:39, Daniel Vetter wrote:
Already using devm_drm_dev_init, so very simple replacment.
Tested-by: Jyri Sarha
Acked-by: Sam Ravnborg
Signed-off-by: Daniel Vetter
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_drv.c | 15 ---
1 file changed, 4
Hi,
On 21/04/2020 04:52, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in:he drm-misc
tree with the drm-misc-fixes tree
drivers/gpu/drm/tidss/tidss_encoder.c
between commit:
9da67433f64e ("drm/tidss: fix crash related to accessing freed
On 20/04/2020 18:55, Daniel Thompson wrote:
On Fri, Apr 17, 2020 at 02:33:11PM +0300, Tomi Valkeinen wrote:
The code that maps the LED default brightness to backlight levels has
two issues: 1) if the default brightness is the first backlight level
(usually 0), the code fails to find it, and 2
On 20/04/2020 19:01, Daniel Thompson wrote:
On Fri, Apr 17, 2020 at 02:33:12PM +0300, Tomi Valkeinen wrote:
led_bl_parse_levels() is rather difficult to follow. Rewrite it with a
more obvious code flow.
... that introduces new behaviour.
There's a couple of new behaviours here but the one
On 17/04/2020 16:29, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Fri, Apr 17, 2020 at 02:41:51PM +0300, Tomi Valkeinen wrote:
If the given videomode does not specify DISPLAY_FLAG_* for the specific
signal property, the driver used a default value. These defaults were
never
(Adding Alex to the thread)
On 17/04/2020 14:40, Tomi Valkeinen wrote:
The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
indicated by the current bus_format.
Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
connector_type to LVDS.
Signed-off-by: Tomi
.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 33 ++---
1 file changed, 6 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c
b/drivers/gpu/drm/omapdrm/dss/dispc.c
index dbb90f2d2ccd..6639ee9b05d3 100644
--- a/drivers
The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
indicated by the current bus_format.
Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
connector_type to LVDS.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/panel/panel-simple.c | 3 ++-
1 file
led_bl_parse_levels() is rather difficult to follow. Rewrite it with a
more obvious code flow.
Signed-off-by: Tomi Valkeinen
---
drivers/video/backlight/led_bl.c | 63
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/drivers/video/backlight
Fix issues reported by checkpatch. No functional changes.
Signed-off-by: Tomi Valkeinen
---
drivers/video/backlight/led_bl.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c
index 3f66549997c8
There's no need to set 'levels' to NULL.
Signed-off-by: Tomi Valkeinen
---
drivers/video/backlight/led_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c
index d4e1ce684366..c46ecdfe8b0a 100644
led_bl does not lock 'led_access' when calling led_sysfs_disable and
led_sysfs_enable, causing the below WARN. Add the locking.
WARNING: CPU: 0 PID: 223 at drivers/leds/led-core.c:353
led_sysfs_disable+0x4c/0x5c
Signed-off-by: Tomi Valkeinen
---
drivers/video/backlight/led_bl.c | 10
.
Fix these two issues.
Signed-off-by: Tomi Valkeinen
---
drivers/video/backlight/led_bl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c
index 63693c4f0883..021b5edd895c 100644
--- a/drivers/video
On 15/04/2020 18:39, Laurent Pinchart wrote:
Hi Yue,
Thank you for the patch.
On Wed, Apr 15, 2020 at 09:21:05PM +0800, YueHaibing wrote:
drivers/gpu/drm/omapdrm/dss/venc.c:211:33:
warning: 'venc_config_pal_bdghi' defined but not used
[-Wunused-const-variable=]
static const struct
Hi,
On 15/04/2020 15:45, Laurent Pinchart wrote:
+static void tidss_crtc_destroy(struct drm_crtc *crtc)
+{
+ struct tidss_crtc *tcrtc = to_tidss_crtc(crtc);
+
+ drm_crtc_cleanup(crtc);
+ kfree(tcrtc);
I would personally store the CRTC pointers, or embed the CRTC instances
(Adding Jyri, forgot to add him)
On 15/04/2020 12:20, Tomi Valkeinen wrote:
tidss uses devm_kzalloc to allocate DRM plane, encoder and crtc objects.
This is not correct as the lifetime of those objects should be longer
than the underlying device's.
When unloading tidss module
, and the driver will accesses
freed memory possibly causing a crash, a kernel WARN, or other undefined
behavior, and also KASAN will give a bug.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_crtc.c| 16 +---
drivers/gpu/drm/tidss/tidss_encoder.c | 14 +++---
drivers
On 07/04/2020 19:44, Sam Ravnborg wrote:
On Tue, Apr 07, 2020 at 04:18:20PM +0300, Tomi Valkeinen wrote:
Hi Jyri,
On 27/01/2020 18:00, Jyri Sarha wrote:
This is intended to be the last patch series. I'll apply these trough
drm-misc-next tomorrow.
Were these ever merged?
See
-node from the dts example in
- "drm/tidss: New driver for TI Keystone platform Display SubSystem"
- Rename dispc_write_irqenable() to dispc_set_irqenable() to avoid
conflict exported omapfb function with same name.
- Add Signed-off-by: Tomi Valkeinen
- "MAINTAINERS: add entry f
On 25/03/2020 15:03, Laurent Pinchart wrote:
Hi Tomi,
On Wed, Mar 25, 2020 at 02:47:48PM +0200, Tomi Valkeinen wrote:
On 25/02/2020 01:20, Sebastian Reichel wrote:
This updates the existing omapdrm DSI code, so that it uses
common drm_mipi_dsi API and drm_panel.
The patchset has been tested
On 25/02/2020 01:21, Sebastian Reichel wrote:
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c
b/drivers/gpu/drm/omapdrm/dss/dsi.c
index acbfffe83b3e..f629e6b1025b
On 25/02/2020 01:20, Sebastian Reichel wrote:
Drop local definition of common MIPI DCS 1.3 defines.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
On 01/04/2020 14:33, Laurent Pinchart wrote:
Hi Tomi,
On Wed, Apr 01, 2020 at 02:30:25PM +0300, Tomi Valkeinen wrote:
On 25/02/2020 17:01, Laurent Pinchart wrote:
On Tue, Feb 25, 2020 at 12:20:40AM +0100, Sebastian Reichel wrote:
This drops the virtual channel logic. Afterwards DSI clients
On 25/02/2020 17:01, Laurent Pinchart wrote:
Hi Sebastian,
Thank you for the patch.
On Tue, Feb 25, 2020 at 12:20:40AM +0100, Sebastian Reichel wrote:
This drops the virtual channel logic. Afterwards DSI clients
request their channel number and get the virtual channel with
the same number or
functions in the following
patches.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 52 +++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ++
2 files changed, 55 insertions(+)
With the white-space issues Laurent reported fixed:
Reviewed-by: Tomi
insertions(+), 17 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
+++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +---
3 files changed, 20 insertions(+), 41 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 25/02/2020 01:20, Sebastian Reichel wrote:
This updates the existing omapdrm DSI code, so that it uses
common drm_mipi_dsi API and drm_panel.
The patchset has been tested with Droid 4 using Linux console, X.org and
Weston. The patchset is based on Laurent Pinchartl's patch series [0]
and
11 ---
drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --
3 files changed, 14 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 061552
Hi,
On 25/02/2020 01:20, Sebastian Reichel wrote:
From: Sebastian Reichel
This reverts commit 4ff8e98879e6eeae9d125dfcf3b642075d00089d.
---
drivers/gpu/drm/omapdrm/dss/base.c | 26 +++
drivers/gpu/drm/omapdrm/dss/omapdss.h | 6
drivers/gpu/drm/omapdrm/omap_encoder.c
On 15/03/2020 15:44, Sam Ravnborg wrote:
Signed-off-by: Sam Ravnborg
Cc: Tomi Valkeinen
Cc: Thierry Reding
Cc: Sam Ravnborg
---
.../bindings/display/panel/sony,acx565akm.txt | 30 ---
.../display/panel/sony,acx565akm.yaml | 53 +++
2 files changed, 53
On 16/03/2020 10:53, Sam Ravnborg wrote:
We have panel-simple-dsi for DSI simple based panels.
This binding includes the reg property.
If we have included DSI panels in panel-simple.yaml, and we likely have
by accident, then they should be moved to panel-simple-dsi.yaml.
If they requires
On 16/03/2020 10:26, Sam Ravnborg wrote:
Isn't this also compatible with panel-simple bindings? 'label' is the only
one not in panel-simple, but that's optional and has never been used by the
panel driver.
The panel is a SPI slave - which is not too obvious from the old
binding.
The new DT
Hi Sam,
On 15/03/2020 15:44, Sam Ravnborg wrote:
Signed-off-by: Sam Ravnborg
Cc: Tomi Valkeinen
Cc: Thierry Reding
Cc: Sam Ravnborg
---
.../display/panel/lgphilips,lb035q02.txt | 33
.../display/panel/lgphilips,lb035q02.yaml | 54 +++
2 files
,osd101t2587-53ts.txt | 14 --
.../bindings/display/panel/panel-simple.yaml | 2 ++
2 files changed, 2 insertions(+), 14 deletions(-)
delete mode 100644
Documentation/devicetree/bindings/display/panel/osddisplays,osd101t2587-53ts.txt
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas
On 13/03/2020 15:38, Laurent Pinchart wrote:
Hi Tomi,
On Fri, Mar 13, 2020 at 03:30:15PM +0200, Tomi Valkeinen wrote:
On 13/03/2020 15:22, Laurent Pinchart wrote:
On Fri, Mar 13, 2020 at 02:24:10PM +0200, Tomi Valkeinen wrote:
Remove unused writeback code. This code will never be used
On 13/03/2020 15:22, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Fri, Mar 13, 2020 at 02:24:10PM +0200, Tomi Valkeinen wrote:
Remove unused writeback code. This code will never be used, as omapfb is
being deprecated.
I'm fine with that, but out of curiosity, is there any
Remove unused writeback code. This code will never be used, as omapfb is
being deprecated.
Signed-off-by: Tomi Valkeinen
---
drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 114 ---
drivers/video/fbdev/omap2/omapfb/dss/dss.h | 20
2 files changed, 134 deletions(-)
diff
Hi Laurent,
On 12/03/2020 00:20, Laurent Pinchart wrote:
+ ret = load_firmware(mhdp);
+ if (ret)
+ goto phy_exit;
+
+ drm_bridge_add(>bridge);
What if someone starts using the bridge before the firmware is
operational ? It seems that you should delay bridge
Hi Laurent,
On 11/03/2020 22:52, Laurent Pinchart wrote:
+void cdns_mhdp_j721e_enable(struct cdns_mhdp_device *mhdp)
+{
+ /*
+* Eneble VIF_0 and select DPI2 as its input. DSS0 DPI0 is connected
+* to eDP DPI2. This is the only supported SST configuration on
+*
On 03/03/2020 17:49, Tony Lindgren wrote:
* Tony Lindgren [200303 15:14]:
* Tomi Valkeinen [200303 06:03]:
On 24/02/2020 21:12, Tony Lindgren wrote:
+ if (sysc_soc->soc == SOC_3430) {
+ /* Clear DSS_SDI_CONTROL */
+ sysc_write(ddata, dispc_offset + 0x44
On 03/03/2020 17:13, Tony Lindgren wrote:
Hi,
* Tomi Valkeinen [200303 06:03]:
On 24/02/2020 21:12, Tony Lindgren wrote:
+ /* Remap the whole module range to be able to reset dispc outputs */
+ devm_iounmap(ddata->dev, ddata->module_va);
+ ddata->module_va = dev
compatible property fixup
2. Update the component code to consider device tree subnodes
Cc: dri-devel@lists.freedesktop.org
Cc: Jyri Sarha
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
This is needed for dropping DSS platform data that I'll be posting
seprately. I
Sarha
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 131 +-
include/linux/platform_data/ti-sysc.h | 1 +
2 files changed, 129 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers
On 27/02/2020 19:44, Tony Lindgren wrote:
FWIW, I dropped omapdss-boot-init.c in my patch series updating DSI
code to use common panel infrastructure, so this will conflict.
Hey that's great :) Sounds like we can set up an immutable branch
for just this $subject patch against v5.6-rc1 to
On 25/02/2020 01:20, Sebastian Reichel wrote:
> This updates the existing omapdrm DSI code, so that it uses
> common drm_mipi_dsi API and drm_panel.
>
> The patchset has been tested with Droid 4 using Linux console, X.org and
> Weston. The patchset is based on Laurent Pinchartl's patch series [0]
On 26/02/2020 01:52, Sebastian Reichel wrote:
Well for now let's get Laurent's and my series forward. I think
the next step would be to get rid of omap_encoder by moving the
encoder init into the DSS output code. Technically we are already
merging omapdrm and omapdss, e.g. omap_connector is
On 26/02/2020 13:24, Laurent Pinchart wrote:
Hello,
This version of the series is there just to make "dim apply" happy, as
it needs to get patches from the list. Sorry for the spam :-)
Thank you! I have pushed to drm-misc-next.
It's been a long journey here, now when we just get Sebastian's
position update are added to
the atomic state in tidss_atomic_check().
Signed-off-by: Jyri Sarha
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
insertions(+), 93 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
| 1 -
drivers/gpu/drm/omapdrm/omap_connector.c | 31 ++--
3 files changed, 2 insertions(+), 53 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Sam,
On 14/02/2020 23:39, Sam Ravnborg wrote:
> Hi Tomi.
>
> On Mon, Feb 10, 2020 at 10:15:33AM +0200, Tomi Valkeinen wrote:
>> Hi Thierry,
>>
>> On 02/12/2019 15:07, Laurent Pinchart wrote:
>>> Hi Tomi,
>>>
>>> Thank you for the patch.
On 13/02/2020 21:37, Jyri Sarha wrote:
The old implementation of placing planes on the CRTC while configuring
the planes was naive and relied on the order in which the planes were
configured, enabled, and disabled. The situation where a plane's zpos
was changed on the fly was completely broken.
On 13/02/2020 12:44, Jyri Sarha wrote:
+ /*
+* If a plane on a CRTC changes add all active planes on that
+* CRTC to the atomic state. This is needed for updating the
+* plane positions in tidss_crtc_position_planes() which is
+* called from
/cdns-mhdp-j721e.c
create mode 100644 drivers/gpu/drm/bridge/cdns-mhdp-j721e.h
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 12/02/2020 06:26, Yuti Amonkar wrote:
This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC.
MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and
embedded Display Port (eDP) standards. It integrates uCPU running the
embedded Firmware(FW) interfaced
On 12/02/2020 06:26, Yuti Amonkar wrote:
Document the bindings used for the Cadence MHDP DPI/DP bridge in
yaml format.
Signed-off-by: Yuti Amonkar
Reviewed-by: Rob Herring
---
.../bindings/display/bridge/cdns,mhdp.yaml| 125 ++
1 file changed, 125 insertions(+)
create
On 11/02/2020 18:27, Tony Lindgren wrote:
We are still missing DSI command mode support, and moving it to the common DRM
model.
Nope, DSI command mode support has been working just fine for
a while now :) And Sebastian has a WIP git tree of the common DRM
Indeed... It had been going on for
On 11/02/2020 18:05, Tony Lindgren wrote:
* Merlijn Wajer [200211 12:54]:
Hi,
On 11/02/2020 12:08, Tomi Valkeinen wrote:
On 11/02/2020 13:07, Laurent Pinchart wrote:
Hopefully soon (in five years? =) we can say that omapdrm supports all
the boards, and we can deprecate omapfb.
I'd love
On 11/02/2020 13:07, Laurent Pinchart wrote:
Hopefully soon (in five years? =) we can say that omapdrm supports all
the boards, and we can deprecate omapfb.
I'd love to send a patch to remove omapfb, but I'll let you do the
honours :-)
Not before we add DSI support to omapdrm...
Tomi
--
On 13/01/2020 14:01, Tomi Valkeinen wrote:
On 12/12/2019 22:35, Laurent Pinchart wrote:
Hi Tomi,
On Thu, Dec 12, 2019 at 11:37:51AM +0200, Tomi Valkeinen wrote:
On 11/12/2019 18:53, Tony Lindgren wrote:
* Laurent Pinchart [191202 13:05]:
Hi Tomi,
Thank you for the patch.
On Thu, Nov 14
Hi Ville,
On 10/02/2020 18:03, Ville Syrjälä wrote:
The usual approach we follow in i915 for things that affect more
than one plane is is to collect that state into the crtc state.
That way we get to remember it for the planes that are not part
of the current commit.
And when we have state
On 31/07/2019 12:42, Peter Ujfalusi wrote:
Hi,
two small correction on the use of DMAengine API, no functional changes
- Use dmaengine_prep_dma_memcpy() to prepare the memcpy
- do not call dma_async_issue_pending() as it is redundant
Regards,
Peter
---
Peter Ujfalusi (2):
drm/omap:
On 09/12/2019 14:33, Kieran Bingham wrote:
Fix trivial spelling identified while examining the code.
s/supprted./supported./
Signed-off-by: Kieran Bingham
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 23/01/2020 09:05, Zheng Bin wrote:
Fixes coccicheck warning:
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:681:1-15: WARNING: Assignment
of 0/1 to bool variable
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:732:1-15: WARNING: Assignment
of 0/1 to bool variable
Reported-by: Hulk Robot
On 10/02/2020 10:49, Andrzej Hajda wrote:
Is this ok to merge?
Yes, If I remember you have merge rights. If not, let me know.
Yes, I have.
Generally speaking, how do you manage bridge patches? If you give reviewed-by/acked-by, does it mean
it's good for the sender to push to
Hi Andrzej,
On 21/01/2020 11:46, Tomi Valkeinen wrote:
Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
max 165MHz.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/ti-tfp410.c | 13 +
1
Hi Thierry,
On 02/12/2019 15:07, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:
The panel datasheet says that the panel samples at falling edge, but
does not say anything about h/v sync signals. Testing shows
+118,7 @@ config DRM_SII902X
select DRM_KMS_HELPER
select REGMAP_I2C
select I2C_MUX
+ select SND_SOC_HDMI_CODEC if SND_SOC
---help---
Silicon Image sii902x bridge chip driver.
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy
Hi Laurent,
On 24/01/2020 05:54, Laurent Pinchart wrote:
+struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
+ struct drm_encoder *encoder)
+{
+ struct drm_bridge_connector *bridge_connector;
+ struct drm_connector
Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
max 165MHz.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Andrzej Hajda
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/bridge/ti-tfp410.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm
On 17/01/2020 14:53, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Mon, Jan 13, 2020 at 03:45:28PM +0200, Tomi Valkeinen wrote:
Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
max 165MHz.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/ti
y: Benoit Parrot
Co-developed-by: Tomi Valkeinen
Signed-off-by: Jyri Sarha
Acked-by: Sam Ravnborg
Reviewed-by: Benoit Parrot
You can add my SoB too:
Signed-off-by: Tomi Valkeinen
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID:
tained
F:drivers/gpu/drm/omapdrm/
F:Documentation/devicetree/bindings/display/ti/
+DRM DRIVERS FOR TI KEYSTONE
+M: Jyri Sarha
+M: Tomi Valkeinen
+L: dri-devel@lists.freedesktop.org
+S: Maintained
+F: drivers/gpu/drm/tidss/
+F: Documentation/devicetree/bindin
Add pixel clock limits to the driver as per TFP410 datasheet: min 25MHz,
max 165MHz.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/ti-tfp410.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
Hi Andrzej,
On 09/12/2019 16:45, Andrey Smirnov wrote:
+ Chris Healy
On Mon, Dec 9, 2019 at 12:27 AM Tomi Valkeinen wrote:
Link training fails with:
Link training timeout waiting for LT_LOOPDONE!
main link enable error: -110
This is caused by too tight timeouts, which were changed
Hi Thierry,
On 02/12/2019 15:07, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:
The panel datasheet says that the panel samples at falling edge, but
does not say anything about h/v sync signals. Testing shows
On 12/12/2019 22:35, Laurent Pinchart wrote:
Hi Tomi,
On Thu, Dec 12, 2019 at 11:37:51AM +0200, Tomi Valkeinen wrote:
On 11/12/2019 18:53, Tony Lindgren wrote:
* Laurent Pinchart [191202 13:05]:
Hi Tomi,
Thank you for the patch.
On Thu, Nov 14, 2019 at 11:39:49AM +0200, Tomi Valkeinen
drm_bridge_attach(E1, E2, E3
+ , flags
)
...>
}
@@
expression E1, E2, E3;
@@
drm_bridge_attach(E1, E2, E3
+ , 0
)
Signed-off-by: Laurent Pinchart
Reviewed-by: Boris Brezillon
Acked-by: Sam Ravnborg
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland
On 07/01/2020 15:30, Tomi Valkeinen wrote:
On 05/01/2020 22:37, Tony Lindgren wrote:
Hi,
* Tony Lindgren [200104 05:51]:
Just changing the alingment fixes the issue. Looks like the minimum
alignment we currently allow is 128, I think 512 was the minimum
that worked for me, so maybe
On 05/01/2020 22:37, Tony Lindgren wrote:
Hi,
* Tony Lindgren [200104 05:51]:
Just changing the alingment fixes the issue. Looks like the minimum
alignment we currently allow is 128, I think 512 was the minimum
that worked for me, so maybe the right fix would be to just change
the minimum to
On 27/12/2019 13:54, Maxime Ripard wrote:
On Wed, Dec 25, 2019 at 09:20:42PM +0800, yu kuai wrote:
no functional change, just to make the code simpler
Signed-off-by: yu kuai
---
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 5 +
drivers/gpu/drm/omapdrm/dss/hdmi4_core.c| 6 ++
related
> omapdrm-specific display drivers.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Tomi Valkeinen
> ---
Something with venc is different than without your series.
I have beagleboard xm, with both DVI and s-video connected. With and without
your series, kmsprint shows:
C
On 19/12/2019 12:03, Laurent Pinchart wrote:
On Thu, Dec 19, 2019 at 12:01:34PM +0200, Tomi Valkeinen wrote:
On 19/12/2019 11:40, Laurent Pinchart wrote:
Do we ever get drm_bridge_funcs calls from multiple threads at the
same time? Is there a difference between having a single DPI output
On 19/12/2019 11:40, Laurent Pinchart wrote:
Do we ever get drm_bridge_funcs calls from multiple threads at the
same time? Is there a difference between having a single DPI output,
or multiple DPI outputs (i.e. can two different DPI outputs get calls
simultaneously?).
I'll drop the lock, it's
/drm/omapdrm/dss/omapdss.h | 3 ---
3 files changed, 1 insertion(+), 32 deletions(-)
delete mode 100644 drivers/gpu/drm/omapdrm/dss/dss-of.c
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka
| 7 ---
3 files changed, 4 insertions(+), 13 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing
drivers/gpu/drm/omapdrm/omap_encoder.c | 44 +++---
3 files changed, 5 insertions(+), 71 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
than that (with the code together if needed, or
in separate patches):
Reviewed-by: Tomi Valkeinen
@@ -171,7 +144,7 @@ struct drm_connector *omap_connector_init(struct drm_device
*dev,
connector->doublescan_allowed = 0;
drm_connector_init(dev, connector, _connector_fu
On 11/12/2019 00:57, Laurent Pinchart wrote:
In order to integrate with a chain of drm_bridge, the internal DPI
output has to expose its operations through the drm_bridge API.
Register a bridge at initialisation time to do so and remove the
omap_dss_device operations that are now unused.
On 11/12/2019 00:57, Laurent Pinchart wrote:
This makes it easier to quickly locate duplicate includes.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/sdi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas
/dpi.c | 32 ---
1 file changed, 8 insertions(+), 24 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
1 file changed, 79 insertions(+), 67 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri
On 11/12/2019 00:57, Laurent Pinchart wrote:
This makes it easier to quickly locate duplicate includes.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas
-
1 file changed, 35 insertions(+), 51 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
dri-devel mailing list
dri
1101 - 1200 of 3393 matches
Mail list logo
