Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Sam Ravnborg
Hi Joe. > > > > > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > > > if (ret < 0) { > > > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); > > > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); > > > > I was under the impression that newlines was optional these days. > >

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Joe Perches
On Thu, 2019-04-04 at 19:00 +0200, Sam Ravnborg wrote: > Hi Joe. > > On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > > These were missing '\n' terminations, add them. > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Thierry Reding
On Thu, Apr 04, 2019 at 05:48:50PM +0200, Guido Günther wrote: > Hi Joe, > On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > > These were missing '\n' terminations, add them. > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 +

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Thierry Reding
On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > These were missing '\n' terminations, add them. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) Applied, thanks.

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Sam Ravnborg
Hi Joe. On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > These were missing '\n' terminations, add them. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Joe Perches
On Thu, 2019-04-04 at 17:48 +0200, Guido Günther wrote: > Hi Joe, [] > P.S.: The cc: list is huge, is there a reason for going way past what > get_maintainers puts out for this patch? No idea, I just used reply-all to your patch. ___ dri-devel mailing

Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Guido Günther
Hi Joe, On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > These were missing '\n' terminations, add them. > > Signed-off-by: Joe Perches > --- > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff

[PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging

2019-04-04 Thread Joe Perches
These were missing '\n' terminations, add them. Signed-off-by: Joe Perches --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/p