[PATCH] drm/nouveau: Fix missing pci_disable_device() in nouveau_pmops_runtime_resume()

2022-11-24 Thread Shang XiaoJing
Add missing pci_disable_device() in fail path of nouveau_do_resume(). Fixes: 7bb6d4428d3d ("drm/nouveau: move the (far too many...) different s/r paths to the same place") Signed-off-by: Shang XiaoJing --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v6 5/7] drm/bridge: anx7625: Register Type C mode switches

2022-11-24 Thread Pin-yen Lin
Hi Andy, Thanks for reviewing the patch. On Thu, Nov 24, 2022 at 8:18 PM Andy Shevchenko wrote: > > On Thu, Nov 24, 2022 at 06:20:54PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant port are available in Device Tree. Configure

Re: [PATCH v6 7/7] drm/bridge: it6505: Register Type C mode switches

2022-11-24 Thread Pin-yen Lin
Hi Andy, Thanks for reviewing the patch. On Thu, Nov 24, 2022 at 8:23 PM Andy Shevchenko wrote: > > On Thu, Nov 24, 2022 at 06:20:56PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant port are available in Device Tree. Configure

Re: [PATCH] drm/msm/dpu: Print interrupt index in addition to the mask

2022-11-24 Thread Abhinav Kumar
On 11/21/2022 2:24 PM, Marijn Suijten wrote: The mask only describes the `irq_idx % 32` part, making it generally impossible to deduce what interrupt is being enabled/disabled. Since `debug/core_irq` in debugfs (and other prints) also include the full `DPU_IRQ_IDX()` value, print the same

Re: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Lazar, Lijo
On 11/25/2022 7:43 AM, Quan, Evan wrote: [AMD Official Use Only - General] -Original Message- From: Lazar, Lijo Sent: Thursday, November 24, 2022 6:49 PM To: Quan, Evan ; 李真能 ; Michel Dänzer ; Koenig, Christian ; Deucher, Alexander Cc: amd-...@lists.freedesktop.org; Pan, Xinhui ;

Re: [Freedreno] [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location

2022-11-24 Thread Abhinav Kumar
On 11/15/2022 5:33 AM, Konrad Dybcio wrote: On 15/11/2022 14:30, Robert Foss wrote: The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss Reviewed-by:

Re: [PATCH v5 08/10] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-24 Thread Abhinav Kumar
On 11/23/2022 1:04 PM, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Reviewed-by: Konrad

Re: [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2022-11-24 Thread Prashant Malani
Hi Andy, Thanks for taking a look at this patch. Pin-Yen beat me to the punch with comment responses, but I'll add mine anyway. On Thu, Nov 24, 2022 at 4:25 AM Andy Shevchenko wrote: > ... > > > + /* > > + * OF graph may have set up some device links with switches, since > >

Re: [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2022-11-24 Thread Pin-yen Lin
Hi Andy, On Thu, Nov 24, 2022 at 8:25 PM Andy Shevchenko wrote: > > On Thu, Nov 24, 2022 at 06:20:51PM +0800, Pin-yen Lin wrote: > > From: Prashant Malani > > > > When using OF graph, the fw_devlink code will create links between the > > individual port driver (cros-ec-typec here) and the

Re: [PATCH] drm/msm/mdp5: fix reading hw revision on db410c platform

2022-11-24 Thread Abhinav Kumar
On 11/24/2022 4:02 PM, Dmitry Baryshkov wrote: Since the commit commit c6122688f265 ("drm/msm/mdp5: stop overriding drvdata") reading the MDP5 hw revision on db410c will crash the board as the MDSS_GDSC is not enabled. Revert a part of the offending commit (moving rpm enablement) and set

Re: [PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-11-24 Thread Pin-yen Lin
Sorry for accidentally using the tab characters. Will fix this in v7. On Fri, Nov 25, 2022 at 1:39 AM Rob Herring wrote: > > > On Thu, 24 Nov 2022 18:20:55 +0800, Pin-yen Lin wrote: > > ITE IT6505 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB

Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-11-24 Thread Pin-yen Lin
Sorry for accidentally using the tab characters. Will fix this in v7. On Fri, Nov 25, 2022 at 1:39 AM Rob Herring wrote: > > > On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB

[git pull] drm fixes for 6.1-rc7

2022-11-24 Thread Dave Airlie
Hi Linus, Weekly fixes, amdgpu has not quite settled down. Most of the changes are small, and the non-amdgpu ones are all fine. There are a bunch of DP MST DSC fixes that fix some issues introduced in a previous larger MST rework. The biggest one is mainly propagating some error values properly

Re: [PATCH] swsmu/amdgpu_smu: Fix the wrong if-condition

2022-11-24 Thread Luben Tuikov
Applied! Thanks, Luben On 2022-11-24 05:10, Quan, Evan wrote: > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > >> -Original Message- >> From: amd-gfx On Behalf Of Yu >> Songping >> Sent: Thursday, November 24, 2022 9:53 AM >> To: airl...@gmail.com; dan...@ffwll.ch >>

RE: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, November 24, 2022 6:49 PM > To: Quan, Evan ; 李真能 ; > Michel Dänzer ; Koenig, Christian > ; Deucher, Alexander > > Cc: amd-...@lists.freedesktop.org; Pan, Xinhui ; >

RE: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] Did you see that? It's a patch which I created by git-format-patch. Anyway I will paste the changes below. I was suspecting maybe we need some waits for smu running. diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c

[PATCH] drm/mediatek: Add checks for devm_kcalloc

2022-11-24 Thread Yuan Can
As the devm_kcalloc may return NULL, the return value needs to be checked to avoid NULL poineter dereference. Fixes: 66b2cf9623fa ("drm/mediatek: use layer_nr function to get layer number to init plane") Signed-off-by: Yuan Can --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 ++ 1 file

[PATCH] drm/msm/mdp5: fix reading hw revision on db410c platform

2022-11-24 Thread Dmitry Baryshkov
Since the commit commit c6122688f265 ("drm/msm/mdp5: stop overriding drvdata") reading the MDP5 hw revision on db410c will crash the board as the MDSS_GDSC is not enabled. Revert a part of the offending commit (moving rpm enablement) and set priv->kms earlier. This make it possible to use

Re: [PATCH] drm/amdgpu: remove redundant NULL check

2022-11-24 Thread Luben Tuikov
Applied. Thanks, Luben On 2022-11-23 02:44, zys.zlj...@gmail.com wrote: > From: Yushan Zhou > > release_firmware() checks whether firmware pointer is NULL. > Remove the redundant NULL check in psp_sw_fini(). > > Signed-off-by: Yushan Zhou > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 36

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Laurent Pinchart
On Thu, Nov 24, 2022 at 06:24:52PM +0100, Daniel Vetter wrote: > On Thu, Nov 24, 2022 at 11:11:21AM +, Robin Murphy wrote: > > On 2022-11-23 17:28, Daniel Vetter wrote: > > > This code was added in b65e64f7ccd4 ("drm/cma: Use > > > dma_mmap_writecombine() to mmap buffer"), but does not explain

[linux-next:master] BUILD REGRESSION c35bd4e428856ed8c1fae7f7dfa08a9141c153d1

2022-11-24 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: c35bd4e428856ed8c1fae7f7dfa08a9141c153d1 Add linux-next specific files for 20221124 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211090634.ryfkk0ws-...@intel.com https

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-24 Thread Daniel Stone
Hi Oded, On Sat, 19 Nov 2022 at 20:44, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Robin Murphy
On 2022-11-24 17:24, Daniel Vetter wrote: On Thu, Nov 24, 2022 at 11:11:21AM +, Robin Murphy wrote: On 2022-11-23 17:28, Daniel Vetter wrote: This code was added in b65e64f7ccd4 ("drm/cma: Use dma_mmap_writecombine() to mmap buffer"), but does not explain why it's needed. It should be

[PATCH 3/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2022-11-24 Thread Jiaxin Yu
Use SND_SOC_DAPM_LINE instead of SND_SOC_DAPM_OUTPUT to trigger DAPM events to hdmi-codec when userspace control the DPAM pin. Signed-off-by: Jiaxin Yu --- sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c | 2 +- sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c | 2 +- 2 files

[PATCH 0/3] ASoC: mediatek:mt8186: fix both the speaker and hdmi

2022-11-24 Thread Jiaxin Yu
The speaker and hdmi of mt8186 platform are shared the same port of I2S, when connect the external display, use build-in speakers to play audio, they both playback at the same time. So we want to manage the playback device through DAPM events. Jiaxin Yu (3): drm: bridge: it6505: bridge to

[PATCH 1/3] drm: bridge: it6505: bridge to hdmi-codec

2022-11-24 Thread Jiaxin Yu
1. Bridge to hdmi-codec to support audio feature. At the same time, the function of automatically detecting audio is removed. 2. It is observed that some DP-to-HDMI dongles will get into bad states if sending InfoFrame without audio data. Defer to enable it6505's audio feature when PCM

[PATCH 2/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-24 Thread Jiaxin Yu
If the speaker and hdmi are connect to the same port of I2S, when try to switch to speaker playback, we will find that hdmi is always turned on automatically. The way of switching is through SOC_DAPM_PIN_SWITCH, however, such events can not be handled in hdmi-codec driver. So add event handler

Re: [PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-11-24 Thread Rob Herring
On Thu, 24 Nov 2022 18:20:55 +0800, Pin-yen Lin wrote: > ITE IT6505 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by

Re: [PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-11-24 Thread Rob Herring
On Thu, 24 Nov 2022 18:20:52 +0800, Pin-yen Lin wrote: > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by

Re: [PATCH v3 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-11-24 Thread Rob Herring
On Thu, 24 Nov 2022 00:47:47 +, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Daniel Vetter
On Thu, Nov 24, 2022 at 11:11:21AM +, Robin Murphy wrote: > On 2022-11-23 17:28, Daniel Vetter wrote: > > This code was added in b65e64f7ccd4 ("drm/cma: Use > > dma_mmap_writecombine() to mmap buffer"), but does not explain why > > it's needed. > > > > It should be entirely unnecessary,

Re: [PATCH AUTOSEL 6.0 38/44] drm/amdgpu: Unlock bo_list_mutex after error handling

2022-11-24 Thread Sasha Levin
On Mon, Nov 21, 2022 at 12:07:40PM +0100, Christian König wrote: Am 21.11.22 um 10:57 schrieb Michel Dänzer: On 11/19/22 03:11, Sasha Levin wrote: From: Philip Yang [ Upstream commit 64f65135c41a75f933d3bca236417ad8e9eb75de ] Get below kernel WARNING backtrace when pressing ctrl-C to kill

Re: [PATCH v2] drm/amdgpu: Fix potential double free and null pointer dereference

2022-11-24 Thread Luben Tuikov
Applied. Regards, Luben On 2022-11-22 19:10, Luben Tuikov wrote: > amdgpu_xgmi_hive_type does provide a release method which frees the allocated > "hive", > so we don't need a kfree() after a kobject_put(). > > Reviewed-by: Luben Tuikov > > Regards, > Luben > > On 2022-11-21 23:28, Liang He

Re: [RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-11-24 Thread Hans Verkuil
On 19/05/2022 18:29, Chris Morgan wrote: > From: Chris Morgan > > Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI. This format is used > by the Geekworm MZP280 panel which interfaces with the Raspberry Pi. > > Signed-off-by: Chris Morgan > --- > .../media/v4l/subdev-formats.rst

Re: [RESEND 3/6 v2] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-11-24 Thread Hans Verkuil
On 19/05/2022 18:29, Chris Morgan wrote: > From: Chris Morgan > > Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm > MZP280 panel for the Raspberry Pi. > > Signed-off-by: Chris Morgan > --- > include/uapi/linux/media-bus-format.h | 3 ++- > 1 file changed, 2 insertions(+),

Re: [PATCH 00/23] Add Tegra20 parallel video input capture

2022-11-24 Thread Luca Ceresoli
HI Hans, On Thu, 24 Nov 2022 09:36:14 +0100 Hans Verkuil wrote: > Hi Luca, > > On 09/11/2022 15:18, luca.ceres...@bootlin.com wrote: > > From: Luca Ceresoli > > > > Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can > > receive from either MIPI CSI-2 or parallel video

igt-kms-rockchip regressions since v6.0-rc1

2022-11-24 Thread Ricardo Cañuelo
Hi Sandy, Going though the KernelCI results I noticed that the v6.0-rc1 kernel introduced a number of regressions in the igt-kms-rockchip tests: https://groups.io/g/kernelci-results/message/34239?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cigt-kms-rockchip%2C20%2C1%2C80%2C95118839 I don't know

Re: [PATCH 00/24] drm: Introduce Kunit Tests to VC4

2022-11-24 Thread Maxime Ripard
Hi David, On Thu, Nov 24, 2022 at 04:31:14PM +0800, David Gow wrote: > On Wed, Nov 23, 2022 at 11:28 PM Maxime Ripard wrote: > > > > Hi, > > > > This series introduce Kunit tests to the vc4 KMS driver, but unlike what we > > have been doing so far in KMS, it actually tests the atomic modesetting

Re: [PATCH v10 06/19] drm/modes: Add a function to generate analog display modes

2022-11-24 Thread Noralf Trønnes
Den 17.11.2022 10.28, skrev Maxime Ripard: > Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and > 625-lines modes in their drivers. > > Since those modes are fairly standard, and that we'll need to use them > in more places in the future, it makes sense to move their

Re: [PATCH v10 05/19] drm/connector: Add TV standard property

2022-11-24 Thread Noralf Trønnes
Den 17.11.2022 10.28, skrev Maxime Ripard: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it hard to

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-24 Thread Christian König
Am 24.11.22 um 13:49 schrieb cuigaosheng: I was already wondering why the order is this way. Why is dma_buf_stats_setup() needing the file in the first place? dmabuf->file will be used in dma_buf_stats_setup(), the dma_buf_stats_setup() as follows: 171 int dma_buf_stats_setup(struct

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-24 Thread cuigaosheng
I was already wondering why the order is this way. Why is dma_buf_stats_setup() needing the file in the first place? dmabuf->file will be used in dma_buf_stats_setup(), the dma_buf_stats_setup() as follows: 171 int dma_buf_stats_setup(struct dma_buf *dmabuf) 172 { 173 struct

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-24 Thread Christian König
Am 24.11.22 um 13:05 schrieb cuigaosheng: Some tips:     Before we call the dma_buf_stats_setup(), we have to finish creating the file, otherwise dma_buf_stats_setup() will return -EINVAL, maybe we need to think about this when making a new patch. I was already wondering why the order is

Re: [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-24 Thread Tvrtko Ursulin
On 23/11/2022 16:21, Janusz Krzysztofik wrote: On Wednesday, 23 November 2022 13:57:26 CET Tvrtko Ursulin wrote: On 23/11/2022 09:28, Janusz Krzysztofik wrote: Hi Tvrtko, Thanks for your comments. On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote: On 21/11/2022 14:56,

Re: [PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2022-11-24 Thread Andy Shevchenko
On Thu, Nov 24, 2022 at 06:20:51PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When using OF graph, the fw_devlink code will create links between the > individual port driver (cros-ec-typec here) and the parent device for > a Type-C switch (like mode-switch). Since the mode-switch will

Re: [PATCH v6 7/7] drm/bridge: it6505: Register Type C mode switches

2022-11-24 Thread Andy Shevchenko
On Thu, Nov 24, 2022 at 06:20:56PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the "lane_swap" > state based on the entered alternate mode for a specific Type-C > connector, which ends up

Re: [PATCH v6 5/7] drm/bridge: anx7625: Register Type C mode switches

2022-11-24 Thread Andy Shevchenko
On Thu, Nov 24, 2022 at 06:20:54PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the crosspoint > switch based on the entered alternate mode for a specific Type-C > connector. ... >

Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

2022-11-24 Thread Robert Foss
Applied to drm-misc-next.

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-24 Thread cuigaosheng
Some tips: Before we call the dma_buf_stats_setup(), we have to finish creating the file, otherwise dma_buf_stats_setup() will return -EINVAL, maybe we need to think about this when making a new patch. Hope these tips are useful, thanks! On 2022/11/24 13:56, Charan Teja Kalla wrote:

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Introduce guard pages to i915_vma

2022-11-24 Thread Tvrtko Ursulin
On 23/11/2022 18:54, Andi Shyti wrote: Hi Tvrtko, [...] @@ -768,6 +768,9 @@ i915_vma_insert(struct i915_vma *vma, struct i915_gem_ww_ctx *ww, GEM_BUG_ON(!IS_ALIGNED(alignment, I915_GTT_MIN_ALIGNMENT)); GEM_BUG_ON(!is_power_of_2(alignment)); + guard = vma->guard; /*

Re: [PATCH v10 00/19] drm: Analog TV Improvements

2022-11-24 Thread Maxime Ripard
On Mon, Nov 21, 2022 at 03:51:26PM +0100, Daniel Vetter wrote: > On Thu, Nov 17, 2022 at 10:28:43AM +0100, Maxime Ripard wrote: > > Hi, > > > > Here's a series aiming at improving the command line named modes support, > > and more importantly how we deal with all the analog TV variants. > > > >

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-24 Thread cuigaosheng
Thanks T.J and Christian, thanks everyone for taking time to review this patch. Charan, actually I don't have a good patch to to fix it, if you can submit a new patch to solve it, please feel free to do it. By the way, I'd appreciate it if you could send to me the new patch when you submit it.

[PATCH linux-next] dma-buf: use strscpy() to instead of strlcpy()

2022-11-24 Thread yang.yang29
From: Xu Panda The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Xu Panda Signed-off-by: Yang Yang --- drivers/dma-buf/dma-buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Gerd Hoffmann
Hi, > > Supporting 16 bpp in the driver wouldn't be that much of a problem, but > > processing the framebuffer on the host side when emulating a big endian > > guest on a little endian host is painful. I think I can't ask pixman to > > do a conversation from DRM_FORMAT_RGB565 |

Re: [PATCH] drm/dma-helpers: Don't change vma flags

2022-11-24 Thread Robin Murphy
On 2022-11-23 17:28, Daniel Vetter wrote: This code was added in b65e64f7ccd4 ("drm/cma: Use dma_mmap_writecombine() to mmap buffer"), but does not explain why it's needed. It should be entirely unnecessary, because remap_pfn_range(), which is what the various dma_mmap functiosn are built on

Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

2022-11-24 Thread Frieder Schrempf
On 24.11.22 12:00, Alexander Stein wrote: > Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf: >> From: Frieder Schrempf >> >> The datasheet specifies a delay of 10 milliseconds, but the current >> driver only waits for 1 ms. Fix this to make sure the initialization >>

Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

2022-11-24 Thread Alexander Stein
Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf: > From: Frieder Schrempf > > The datasheet specifies a delay of 10 milliseconds, but the current > driver only waits for 1 ms. Fix this to make sure the initialization > sequence meets the spec. > > Fixes: ceb515ba29ba

Re: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Lazar, Lijo
On 11/24/2022 4:11 PM, Lazar, Lijo wrote: On 11/24/2022 3:34 PM, Quan, Evan wrote: [AMD Official Use Only - General] Could the attached patch help? Evan -Original Message- From: amd-gfx On Behalf Of ??? Sent: Friday, November 18, 2022 5:25 PM To: Michel Dänzer ; Koenig,

Re: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Lazar, Lijo
On 11/24/2022 3:34 PM, Quan, Evan wrote: [AMD Official Use Only - General] Could the attached patch help? Evan -Original Message- From: amd-gfx On Behalf Of ??? Sent: Friday, November 18, 2022 5:25 PM To: Michel Dänzer ; Koenig, Christian ; Deucher, Alexander Cc:

Re: [PATCH 1/3] drm/ttm: remove ttm_bo_(un)lock_delayed_workqueue

2022-11-24 Thread Matthew Auld
On Thu, 24 Nov 2022 at 10:03, Christian König wrote: > > Those functions never worked correctly since it is still perfectly > possible that a buffer object is released and the background worker > restarted even after calling them. > > Signed-off-by: Christian König I know you usually do, but

[PULL] drm-misc-fixes

2022-11-24 Thread Maarten Lankhorst
Hey Daniel and Dae, Not much here, a few fixes to dma-fence handling and a fix to amdgpu and logo. Enjoy! Maarten Lankhorst drm-misc-fixes-2022-11-24: drm-misc-fixes for v6.1-rc7: - Another amdgpu gang submit fix. - Use dma_fence_unwrap_for_each when importing sync files. - Fix race in

[PATCH v6 6/7] dt/bindings: drm/bridge: it6505: Add mode-switch support

2022-11-24 Thread Pin-yen Lin
ITE IT6505 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints.

[PATCH v6 7/7] drm/bridge: it6505: Register Type C mode switches

2022-11-24 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the "lane_swap" state based on the entered alternate mode for a specific Type-C connector, which ends up updating the lane swap registers of the it6505 chip. Signed-off-by:

[PATCH v6 4/7] drm/bridge: anx7625: Check for Type-C during panel registration

2022-11-24 Thread Pin-yen Lin
The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port

[PATCH v6 5/7] drm/bridge: anx7625: Register Type C mode switches

2022-11-24 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the crosspoint switch based on the entered alternate mode for a specific Type-C connector. Signed-off-by: Pin-yen Lin --- Changes in v6: - Squashed to a single patch

[PATCH v6 2/7] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2022-11-24 Thread Pin-yen Lin
From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as

[PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2022-11-24 Thread Pin-yen Lin
Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints.

[PATCH v6 1/7] device property: Add remote endpoint to devcon matcher

2022-11-24 Thread Pin-yen Lin
From: Prashant Malani When searching the device graph for device matches, check the remote-endpoint itself for a match. Some drivers register devices for individual endpoints. This allows the matcher code to evaluate those for a match too, instead of only looking at the remote parent devices.

[PATCH v6 0/7] Register Type-C mode-switch in DP bridge endpoints

2022-11-24 Thread Pin-yen Lin
This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. The first two patch modifies fwnode_graph_devcon_matches and cros_typec_init_ports to enable the registration of the

RE: [PATCH] swsmu/amdgpu_smu: Fix the wrong if-condition

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Yu > Songping > Sent: Thursday, November 24, 2022 9:53 AM > To: airl...@gmail.com; dan...@ffwll.ch > Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; linux- >

Re: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Christian König
That's not a patch but some binary file? Christian. Am 24.11.22 um 11:04 schrieb Quan, Evan: [AMD Official Use Only - General] Could the attached patch help? Evan -Original Message- From: amd-gfx On Behalf Of ??? Sent: Friday, November 18, 2022 5:25 PM To: Michel Dänzer ; Koenig,

RE: [PATCH] drm/amdgpu: add mb for si

2022-11-24 Thread Quan, Evan
[AMD Official Use Only - General] Could the attached patch help? Evan > -Original Message- > From: amd-gfx On Behalf Of ??? > Sent: Friday, November 18, 2022 5:25 PM > To: Michel Dänzer ; Koenig, Christian > ; Deucher, Alexander > > Cc: amd-...@lists.freedesktop.org; Pan, Xinhui ; >

[PATCH 3/3] drm/amdgpu: generally allow over-commit during BO allocation

2022-11-24 Thread Christian König
We already fallback to a dummy BO with no backing store when we allocate GDS,GWS and OA resources and to GTT when we allocate VRAM. Drop all those workarounds and generalize this for GTT as well. This fixes ENOMEM issues with runaway applications which try to allocate/free GTT in a loop and are

[PATCH 2/3] drm/ttm: use per BO cleanup workers

2022-11-24 Thread Christian König
Instead of a single worker going over the list of delete BOs in regular intervals use a per BO worker which blocks for the resv object and locking of the BO. This not only simplifies the handling massively, but also results in much better response time when cleaning up buffers. Signed-off-by:

[PATCH 1/3] drm/ttm: remove ttm_bo_(un)lock_delayed_workqueue

2022-11-24 Thread Christian König
Those functions never worked correctly since it is still perfectly possible that a buffer object is released and the background worker restarted even after calling them. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 +-

Re: [PATCH 1/6] ASoC: hdmi-codec: add PCM trigger operator

2022-11-24 Thread Tzung-Bi Shih
On Thu, Nov 24, 2022 at 1:52 PM Allen-KH Cheng (程冠勳) wrote: > We would want to confirm with you as we work on the hdmi-codec for the > mt8186. > > Do you have any plan to continue working on this series? We may take > over as well. No (from testing's perspective). Please take over it as you

Re: [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-24 Thread Janusz Krzysztofik
On Wednesday, 23 November 2022 13:57:26 CET Tvrtko Ursulin wrote: > > On 23/11/2022 09:28, Janusz Krzysztofik wrote: > > Hi Tvrtko, > > > > Thanks for your comments. > > > > On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote: > >> > >> On 21/11/2022 14:56, Janusz Krzysztofik wrote:

Re: [PATCH] drm/fourcc: Document open source user waiver

2022-11-24 Thread Daniel Stone
On Wed, 23 Nov 2022 at 19:24, Daniel Vetter wrote: > It's a bit a FAQ, and we really can't claim to be the authoritative > source for allocating these numbers used in many standard extensions > if we tell closed source or vendor stacks in general to go away. > > Iirc this was already clarified in

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: A collection of typo and documentation fixes

2022-11-24 Thread Christian König
Am 24.11.22 um 10:05 schrieb Daniel Vetter: On Thu, Nov 24, 2022 at 08:03:09AM +0100, Christian König wrote: Am 23.11.22 um 20:35 schrieb T.J. Mercier: I've been collecting these typo fixes for a while and it feels like time to send them in. Signed-off-by: T.J. Mercier Acked-by: Christian

Re: [PATCH v28 05/11] soc: mediatek: refine code to use mtk_mmsys_update_bits API

2022-11-24 Thread 林欣螢

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Nov 24, 2022 at 10:20 AM Thomas Zimmermann wrote: > Am 24.11.22 um 10:04 schrieb Daniel Vetter: > > On Thu, Nov 24, 2022 at 09:55:18AM +0100, Geert Uytterhoeven wrote: > >> Hi Thomas, > >> > >> On Thu, Nov 24, 2022 at 9:47 AM Thomas Zimmermann > >> wrote: > >>> Am 23.11.22

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Introduce guard pages to i915_vma

2022-11-24 Thread Andi Shyti
> > > @@ -768,6 +768,9 @@ i915_vma_insert(struct i915_vma *vma, struct > > > i915_gem_ww_ctx *ww, > > > GEM_BUG_ON(!IS_ALIGNED(alignment, I915_GTT_MIN_ALIGNMENT)); > > > GEM_BUG_ON(!is_power_of_2(alignment)); > > > + guard = vma->guard; /* retain guard across rebinds */ > > >

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Thomas Zimmermann
Hi Am 24.11.22 um 10:04 schrieb Daniel Vetter: On Thu, Nov 24, 2022 at 09:55:18AM +0100, Geert Uytterhoeven wrote: Hi Thomas, On Thu, Nov 24, 2022 at 9:47 AM Thomas Zimmermann wrote: Am 23.11.22 um 17:43 schrieb Geert Uytterhoeven: As of commit eae06120f1974e1a ("drm: refuse ADDFB2 ioctl

Re: [PATCH] dma-buf: A collection of typo and documentation fixes

2022-11-24 Thread Daniel Vetter
On Thu, Nov 24, 2022 at 08:03:09AM +0100, Christian König wrote: > Am 23.11.22 um 20:35 schrieb T.J. Mercier: > > I've been collecting these typo fixes for a while and it feels like > > time to send them in. > > > > Signed-off-by: T.J. Mercier > > Acked-by: Christian König Will you also push

Re: [PATCH 6/6] drm/gud: Use the shadow plane helper

2022-11-24 Thread Thomas Zimmermann
Hi Am 23.11.22 um 13:37 schrieb Noralf Trønnes: Den 23.11.2022 11.38, skrev Thomas Zimmermann: Hi Am 22.11.22 um 21:58 schrieb Noralf Trønnes via B4 Submission Endpoint: From: Noralf Trønnes Use the shadow plane helper to take care of preparing the framebuffer for CPU access. The

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Daniel Vetter
On Thu, Nov 24, 2022 at 09:55:18AM +0100, Geert Uytterhoeven wrote: > Hi Thomas, > > On Thu, Nov 24, 2022 at 9:47 AM Thomas Zimmermann wrote: > > Am 23.11.22 um 17:43 schrieb Geert Uytterhoeven: > > > As of commit eae06120f1974e1a ("drm: refuse ADDFB2 ioctl for broken > > > bigendian drivers"),

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Nov 24, 2022 at 9:47 AM Thomas Zimmermann wrote: > Am 23.11.22 um 17:43 schrieb Geert Uytterhoeven: > > As of commit eae06120f1974e1a ("drm: refuse ADDFB2 ioctl for broken > > bigendian drivers"), drivers must set the > > quirk_addfb_prefer_host_byte_order quirk to make the

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-24 Thread Pekka Paalanen
On Wed, 23 Nov 2022 15:27:04 -0800 Jessica Zhang wrote: > On 11/9/2022 1:18 AM, Pekka Paalanen wrote: > > On Tue, 8 Nov 2022 23:01:47 +0100 > > Sebastian Wick wrote: > > > >> On Tue, Nov 8, 2022 at 7:51 PM Simon Ser wrote: > >>> > >>> cc'ing Pekka and wayland-devel for userspace devs

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Thomas Zimmermann
Hi Am 23.11.22 um 17:43 schrieb Geert Uytterhoeven: As of commit eae06120f1974e1a ("drm: refuse ADDFB2 ioctl for broken bigendian drivers"), drivers must set the quirk_addfb_prefer_host_byte_order quirk to make the drm_mode_addfb() compat code work correctly on big-endian machines. While that

[PULL] drm-intel-fixes

2022-11-24 Thread Tvrtko Ursulin
Hi Dave, Daniel, A couple of fixes for 6.1-rc. One TTM backend fix, one display warning fixlet and a merge of two GVT patches which fix KVM reference count handling there. Regards, Tvrtko drm-intel-fixes-2022-11-24: - Fix GVT KVM reference count handling (Sean Christopherson) - Never purge

Re: [PATCH 00/23] Add Tegra20 parallel video input capture

2022-11-24 Thread Hans Verkuil
Hi Luca, On 09/11/2022 15:18, luca.ceres...@bootlin.com wrote: > From: Luca Ceresoli > > Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can > receive from either MIPI CSI-2 or parallel video (called respectively "CSI" > and "VIP" in the documentation). The kernel currently

Re: [PATCH 00/24] drm: Introduce Kunit Tests to VC4

2022-11-24 Thread David Gow
On Wed, Nov 23, 2022 at 11:28 PM Maxime Ripard wrote: > > Hi, > > This series introduce Kunit tests to the vc4 KMS driver, but unlike what we > have been doing so far in KMS, it actually tests the atomic modesetting code. > > In order to do so, I've had to improve a fair bit on the Kunit helpers

Re: [RFC v2 README 00/13] DRM scheduling cgroup controller

2022-11-24 Thread Shams Ahmad m Sami
Help

Re: [PATCH v4] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-11-24 Thread Randy Li
> On Nov 24, 2022, at 12:42 AM, Daniel Vetter wrote: > > On Wed, Nov 23, 2022 at 10:58:11PM +0800, Jisheng Zhang wrote: >>> On Wed, Nov 23, 2022 at 05:19:57PM +0800, Hsia-Jun Li wrote: >>> From: "Hsia-Jun(Randy) Li" >>> Memory Traffic Reduction(MTR) is a module in Synaptics >>> VideoSmart

[PATCH] swsmu/amdgpu_smu: Fix the wrong if-condition

2022-11-24 Thread Yu Songping
The logical operator '&&' will make smu->ppt_funcs->set_gfx_power_up_by_imu segment fault when smu->ppt_funcs is NULL. Signed-off-by: Yu Songping --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v4] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-11-24 Thread Randy Li
> On Nov 24, 2022, at 1:27 AM, Daniel Vetter wrote: > > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > >> On Thu, Nov 24, 2022 at 01:14:48AM +0800, Randy Li wrote: >> On Nov 24, 2022, at

Re: [PATCH] dt-bindings: display: bridge: renesas,rzg2l-mipi-dsi: Document RZ/V2L support

2022-11-24 Thread Geert Uytterhoeven
On Tue, Nov 22, 2022 at 8:54 PM Biju Das wrote: > Document RZ/V2L DSI bindings. RZ/V2L MIPI DSI is identical to one found on > the RZ/G2L SoC. No driver changes are required as generic compatible > string "renesas,rzg2l-mipi-dsi" will be used as a fallback. > > Signed-off-by: Biju Das

Re: [PATCH] dma-buf: A collection of typo and documentation fixes

2022-11-24 Thread Tommaso Merciai
Hi T.J, On Wed, Nov 23, 2022 at 07:35:18PM +, T.J. Mercier wrote: > I've been collecting these typo fixes for a while and it feels like > time to send them in. > > Signed-off-by: T.J. Mercier > --- > drivers/dma-buf/dma-buf.c | 14 +++--- > include/linux/dma-buf.h | 6 +++--- >

Re: [PATCH resend v2] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats

2022-11-24 Thread Geert Uytterhoeven
Hi Gerd, On Thu, Nov 24, 2022 at 8:29 AM Gerd Hoffmann wrote: > > > > +#ifdef __BIG_ENDIAN > > > > > > Why do we need the #ifdef here? Iirc some hw has big endian flags in the > > > scanout registers, so could supprt this unconditionally if there's no > > > #ifdef around the format defines. Some