Re: [PATCH V5 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-12 Thread Adam Ford
On Fri, May 12, 2023 at 4:02 PM Marek Szyprowski wrote: > > On 12.05.2023 22:00, Adam Ford wrote: > > On Fri, May 12, 2023 at 2:37 PM Lucas Stach wrote: > >> Am Samstag, dem 06.05.2023 um 14:24 -0500 schrieb Adam Ford: > >>> The DPHY timings are currently hard coded. Since the input > >>> clock

Re: [PATCH v2 5/8] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-05-12 Thread Teres Alexis, Alan Previn
On Fri, 2023-04-28 at 11:58 -0700, Ceraolo Spurio, Daniele wrote: > Before we add the second step of the MTL HuC auth (via GSC), we need to > have the ability to differentiate between them. To do so, the huc > authentication check is duplicated for GuC and GSC auth, with meu > binaries being

Re: [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

2023-05-12 Thread Dixit, Ashutosh
On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > rps_boost debugfs shows host turbo related info. This is not valid > when SLPC is enabled. A couple of thoughts about this. It appears people are know only about rps_boost_info and don't know about guc_slpc_info? So: a.

Re: [PATCH v2] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-12 Thread Teres Alexis, Alan Previn
On Tue, 2023-05-02 at 08:27 -0700, Ceraolo Spurio, Daniele wrote: > The new binaries that support the 2-step authentication have contain the > legacy-style binary, which we can use for loading the HuC via DMA. To > find out where this is located in the image, we need to parse the meu > manifest of

[PATCH] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-05-12 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems

[PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

2023-05-12 Thread Vinay Belgaumkar
rps_boost debugfs shows host turbo related info. This is not valid when SLPC is enabled. guc_slpc_info already shows the number of boosts. Add num_waiters there as well and disable rps_boost when SLPC is enabled. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632 Signed-off-by: Vinay

Re: [PATCH v7 4/4] drm/i915: Allow user to set cache at BO creation

2023-05-12 Thread Yang, Fei
> On 2023-05-10 15:14:16, Andi Shyti wrote: >> Hi, >> >> On Tue, May 09, 2023 at 09:59:42AM -0700, fei.y...@intel.com wrote: >>> From: Fei Yang >>> >>> To comply with the design that buffer objects shall have immutable >>> cache setting through out their life cycle, {set, get}_caching ioctl's >>>

[PATCH v8 2/2] drm/i915: Allow user to set cache at BO creation

2023-05-12 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[PATCH v8 0/2] drm/i915: Allow user to set cache at BO creation

2023-05-12 Thread fei . yang
From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has dependency on the pat_index refactor. This series is focusing on uAPI changes, 1. end support for set caching ioctl

[PATCH v8 1/2] drm/i915/mtl: end support for set caching ioctl

2023-05-12 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

Re: [RFC PATCH v2 05/13] drm/msm/dpu: get rid of struct dpu_rm_requirements

2023-05-12 Thread Abhinav Kumar
On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: The struct dpu_rm_requirements was used to wrap display topology and hw resources, which meant INTF indices. As of commit ef58e0ad3436 ("drm/msm/dpu: get INTF blocks directly rather than through RM") the hw resources struct was removed, leaving

Re: [RFC PATCH v2 03/13] drm/msm/dpu: encoder: simplify debugfs handling

2023-05-12 Thread Abhinav Kumar
On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: As the debugfs is fully cleared on drm device removal, drop the encoder-specific cleanup function, remove debugfs_root from dpu_encoder struct and also remove phys_encoder late_register() ops which has been unused since the driver being added.

Re: [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes

2023-05-12 Thread Abhinav Kumar
On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Take into account the plane rotation and flipping when calculating src positions for the wide plane parts. Signed-off-by: Dmitry Baryshkov Do we need to have a fixes tag for this? This means we dont consider rotation while calculating src

Re: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-12 Thread Conor Dooley
On Fri, May 12, 2023 at 03:11:35PM +0200, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI Glue > on the same Amlogic SoCs. > >

[PATCH v10 5/8] drm/msm/dpu: Use fixed DRM DSC helper for det_thresh_flatness

2023-05-12 Thread Jessica Zhang
The current dpu_hw_dsc calculation for det_thresh_flatness does not match the downstream calculation or the DSC spec. Use the DRM DSC helper for det_thresh_flatness to match downstream implementation and the DSC spec. Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Reviewed-by:

[PATCH v10 6/8] drm/msm/dpu: Fix slice_last_group_size calculation

2023-05-12 Thread Jessica Zhang
Correct the math for slice_last_group_size so that it matches the calculations downstream. Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 5

[PATCH v10 7/8] drm/msm/dsi: Use MSM and DRM DSC helper methods

2023-05-12 Thread Jessica Zhang
Use MSM and DRM DSC helper methods to configure DSC for DSI. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v10 8/8] drm/msm/dsi: update hdisplay calculation for dsi_timing_setup

2023-05-12 Thread Jessica Zhang
hdisplay for compressed images should be calculated as bytes_per_slice * slice_count. Thus, use MSM DSC helper to calculate hdisplay for dsi_timing_setup instead of directly using mode->hdisplay. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang ---

[PATCH v10 3/8] drm/msm/dsi: use DRM DSC helpers for DSC setup

2023-05-12 Thread Jessica Zhang
From: Dmitry Baryshkov Use new DRM DSC helpers to setup DSI DSC configuration. The initial_scale_value needs to be adjusted according to the standard, but this is a separate change. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Jessica Zhang ---

[PATCH v10 0/8] Introduce MSM-specific DSC helpers

2023-05-12 Thread Jessica Zhang
There are some overlap in calculations for MSM-specific DSC variables between DP and DSI. In addition, the calculations for initial_scale_value and det_thresh_flatness that are defined within the DSC 1.2 specifications, but aren't yet included in drm_dsc_helper.c. This series moves these

[PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-12 Thread Jessica Zhang
Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_dsc_helper.h | 65 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_dsc_helper.h

[PATCH v10 2/8] drm/display/dsc: add helper to set semi-const parameters

2023-05-12 Thread Jessica Zhang
From: Dmitry Baryshkov Add a helper setting config values which are typically constant across operating modes (table E-4 of the standard) and mux_word_size (which is a const according to 3.5.2). Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang ---

[PATCH v10 1/8] drm/display/dsc: Add flatness and initial scale value calculations

2023-05-12 Thread Jessica Zhang
Add helpers to calculate det_thresh_flatness and initial_scale_value as these calculations are defined within the DSC spec. Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang --- include/drm/display/drm_dsc_helper.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-05-12 Thread Gurchetan Singh
On Thu, May 11, 2023 at 7:33 PM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > On 5/12/23 03:17, Gurchetan Singh wrote: > ... > > Can we get one of the Mesa MRs reviewed first? There's currently no > > virtio-intel MR AFAICT, and the amdgpu one is marked as "Draft:". > > > > Even for

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 23:48, Kuogee Hsieh wrote: On 5/12/2023 11:19 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off"

Re: [PATCH V5 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-12 Thread Marek Szyprowski
On 12.05.2023 22:00, Adam Ford wrote: > On Fri, May 12, 2023 at 2:37 PM Lucas Stach wrote: >> Am Samstag, dem 06.05.2023 um 14:24 -0500 schrieb Adam Ford: >>> The DPHY timings are currently hard coded. Since the input >>> clock can be variable, the phy timings need to be variable >>> too. Add an

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Kuogee Hsieh
On 5/12/2023 11:19 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not     used at

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Dixit, Ashutosh
On Fri, 12 May 2023 02:33:33 -0700, Andi Shyti wrote: > Hi Andi, > > On Thu, May 11, 2023 at 10:43:30AM -0700, Dixit, Ashutosh wrote: > > On Wed, 10 May 2023 11:36:06 -0700, Ashutosh Dixit wrote: > > > > > > Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) > > > causes the

[PATCH v2] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Ashutosh Dixit
Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) causes the following warning: UBSAN: invalid-load in drivers/gpu/drm/i915/gt/uc/intel_uc.c:558:2 load of value 255 is not a valid value for type '_Bool' Call Trace: dump_stack_lvl+0x57/0x7d ubsan_epilogue+0x5/0x40

Re: [PATCH V5 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-12 Thread Adam Ford
On Fri, May 12, 2023 at 2:37 PM Lucas Stach wrote: > > Hi Adam, > > Am Samstag, dem 06.05.2023 um 14:24 -0500 schrieb Adam Ford: > > The DPHY timings are currently hard coded. Since the input > > clock can be variable, the phy timings need to be variable > > too. Add an additional variable to

Re: [PATCH v7 4/4] drm/i915: Allow user to set cache at BO creation

2023-05-12 Thread Jordan Justen
On 2023-05-10 15:14:16, Andi Shyti wrote: > Hi, > > On Tue, May 09, 2023 at 09:59:42AM -0700, fei.y...@intel.com wrote: > > From: Fei Yang > > > > To comply with the design that buffer objects shall have immutable > > cache setting through out their life cycle, {set, get}_caching ioctl's > >

Re: [PATCH V5 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-12 Thread Lucas Stach
Hi Adam, Am Samstag, dem 06.05.2023 um 14:24 -0500 schrieb Adam Ford: > The DPHY timings are currently hard coded. Since the input > clock can be variable, the phy timings need to be variable > too. Add an additional variable to the driver data to enable > this feature to prevent breaking boards

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Abhinav Kumar
On 5/12/2023 11:50 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:47, Abhinav Kumar wrote: On 5/12/2023 11:21 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:47, Abhinav Kumar wrote: On 5/12/2023 11:21 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Abhinav Kumar
On 5/12/2023 11:21 AM, Dmitry Baryshkov wrote: On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-12 Thread Dmitry Baryshkov
On Fri, 12 May 2023 at 21:03, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2023-05-11 17:54:19) > > On Fri, 12 May 2023 at 03:16, Kuogee Hsieh wrote: > > > 1) DP with GPIO: No downstream drm_bridge are connected, is_edp = false > > > and internal HPD-logic is in used (internal_hpd = true).

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:00, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:00, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes

Re: [PATCH v8 2/8] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit for DPU < 7.0.0

2023-05-12 Thread Dmitry Baryshkov
On 12/05/2023 21:00, Kuogee Hsieh wrote: DPU < 7.0.0 requires the PINGPONG block to be involved during DSC setting up. Since DPU >= 7.0.0, enabling and starting the DSC encoder engine was moved to INTF with the help of the flush mechanism. Add a DPU_PINGPONG_DSC feature bit to restrict the

Re: [PATCH] drm/msm/dp: add module parameter for PSR

2023-05-12 Thread Dmitry Baryshkov
On 28/04/2023 02:28, Abhinav Kumar wrote: On sc7280 where eDP is the primary display, PSR is causing IGT breakage even for basic test cases like kms_atomic and kms_atomic_transition. Most often the issue starts with below stack so providing that as reference Call trace:

Re: [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-05-11 17:54:19) > On Fri, 12 May 2023 at 03:16, Kuogee Hsieh wrote: > > 1) DP with GPIO: No downstream drm_bridge are connected, is_edp = false > > and internal HPD-logic is in used (internal_hpd = true). Power needs to > > be on at all times etc. > > > > 2) DP

[PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-12 Thread Kuogee Hsieh
From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different sub block address. changes in v4: --

[PATCH v8 8/8] drm/msm/dpu: tear down DSC data path when DSC disabled

2023-05-12 Thread Kuogee Hsieh
Unset DSC_ACTIVE bit at dpu_hw_ctl_reset_intf_cfg_v1(), dpu_encoder_unprep_dsc() and dpu_encoder_dsc_pipe_clr() functions to tear down DSC data path if DSC data path was setup previous. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c |

[PATCH v8 4/8] drm/msm/dpu: Introduce PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-12 Thread Kuogee Hsieh
Disabling the crossbar mux between DSC and PINGPONG currently requires a bogus enum dpu_pingpong value to be passed when calling dsc_bind_pingpong_blk() with enable=false, even though the register value written is independent of the current PINGPONG block. Replace that `bool enable` parameter

[PATCH v8 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG

2023-05-12 Thread Kuogee Hsieh
DPU < 7.0.0 has DPU_PINGPONG_DSC feature bit set to indicate it requires both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_{enable,disable}() to be executed to complete DSC configuration if DSC hardware block is present. Hence test DPU_PINGPONG_DSC feature bit and assign DSC related functions to the

[PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-12 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes in v4: -- delete DPU_DSC_HW_REV_1_1 -- delete

[PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-12 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush

[PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-12 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks but it is not declared at catalog. For completeness, this patch adds DSC blocks for platforms which missed them. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h

[PATCH v8 2/8] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit for DPU < 7.0.0

2023-05-12 Thread Kuogee Hsieh
DPU < 7.0.0 requires the PINGPONG block to be involved during DSC setting up. Since DPU >= 7.0.0, enabling and starting the DSC encoder engine was moved to INTF with the help of the flush mechanism. Add a DPU_PINGPONG_DSC feature bit to restrict the availability of dpu_hw_pp_setup_dsc() and

[PATCH v8 0/8] add DSC 1.2 dpu supports

2023-05-12 Thread Kuogee Hsieh
This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. This seriel is rebase on [1], [2] and catalog fixes from rev-4 of [3]. [1]:

Re: [PATCH v7 0/8] add DSC 1.2 dpu supports

2023-05-12 Thread Dmitry Baryshkov
On 11/05/2023 20:53, Kuogee Hsieh wrote: This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. This seriel is rebase on [1], [2] and catalog fixes

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Lucas De Marchi
On Fri, May 12, 2023 at 02:14:19PM +0300, Andy Shevchenko wrote: On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create masks for fixed-width types and also the corresponding BIT_U32(), BIT_U16() and BIT_U8(). Why?

Re: [Intel-gfx] [PATCH 07/11] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-12 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on 451e49cfbaa90720149e63f4fa9c7824013c783d] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-armada-Use-regular-fbdev-I-O-helpers/20230512-164432 base

Re: [PATCH] video/aperture: fix typos

2023-05-12 Thread Pavel Machek
Hi! > > Am 04.04.23 um 06:01 schrieb Sui Jingfeng: > >> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer > >> driver. > > > ... > I fixed that before applying, also removed the "are" in the sentence > above, since it sounded off and repharsed subject line as "Fix typos

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 --- Comment #4 from Jonny Mako (jhnmlkv...@gmail.com) --- Kernel version 6.3.1-arch2-1 #1 SMP PREEMPT_DYNAMIC Wed, 10 May 2023 08:54:47 + x86_64 GNU/Linux -- You may reply to this email to add a comment. You are receiving this mail

Re: (subset) [PATCH v2 0/7] Move dma-buf mmap() reservation locking down to exporters

2023-05-12 Thread Srinivas Kandagatla
On Thu, 06 Apr 2023 19:06:30 +0300, Dmitry Osipenko wrote: > This patchset makes dma-buf exporters responisble for taking care of > the reservation lock. I also included patch that moves drm-shmem to use > reservation lock, to let CI test the whole set. I'm going to take all > the patches via

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-12 Thread Thomas Zimmermann
Hi Am 12.05.23 um 15:20 schrieb Linus Walleij: Sorry for late regression detection but this patch regresses the Integrator AB IMPD-1 graphics, I bisected down to this patch. [...] This is the driver: drivers/gpu/drm/pl111/pl111_versatile.c with the pl110_impd1 variant, so these are the

Re: [PATCH] drm/amd/display: Simplify the calculation of variables

2023-05-12 Thread Hamza Mahfooz
On 5/12/23 03:04, Jiapeng Chong wrote: ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:586:37-39: WARNING !A || A && B is equivalent to !A || B. ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:595:37-39: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Link:

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- The patch was cc'ed to stable as well, so it should land there soon. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 Bagas Sanjaya (bagasdo...@gmail.com) changed: What|Removed |Added CC|

RE: [PATCH 04/11] drm/radeon: Use regular fbdev I/O helpers

2023-05-12 Thread Deucher, Alexander
[Public] > -Original Message- > From: Thomas Zimmermann > Sent: Friday, May 12, 2023 4:42 AM > To: dan...@ffwll.ch; airl...@gmail.com; maarten.lankho...@linux.intel.com; > mrip...@kernel.org; javi...@redhat.com > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org;

Re: [PATCH] drm/ssd130x: Fix include guard name

2023-05-12 Thread Sam Ravnborg
On Fri, May 12, 2023 at 02:02:31PM +0200, Javier Martinez Canillas wrote: > This is a leftover from an early iteration of the driver when it was still > named ssd1307 instead of ssd130x. Change it for consistency with the rest. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam

Re: [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Sam Ravnborg
Hi Thomas, > > > > Nice cleanup. > > > > From one of the patches: > > > > > +config DRM_ARMADA_FBDEV_EMULATION > > > + bool > > > + depends on DRM_ARMADA > > > + select FB_CFB_COPYAREA > > > + select FB_CFB_FILLRECT > > > + select FB_CFB_IMAGEBLIT > > > > This seems like a

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v2 09/10] udf: Replace license notice with SPDX identifier

2023-05-12 Thread Richard Fontana
On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya wrote: > diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h > index de17a97e866742..b2b5bca45758df 100644 > --- a/fs/udf/ecma_167.h > +++ b/fs/udf/ecma_167.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-2-Clause OR GPL-1.0+ */ > /* > *

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-12 Thread Linus Walleij
Sorry for late regression detection but this patch regresses the Integrator AB IMPD-1 graphics, I bisected down to this patch. On Mon, Jan 2, 2023 at 12:30 PM Thomas Zimmermann wrote: > Fix the color-format selection of the single-probe helper. Go > through all user-specified values and test

Re: [PATCH 09/10] udf: Replace license notice with SPDX identifier

2023-05-12 Thread Jan Kara
On Thu 11-05-23 20:34:05, Bagas Sanjaya wrote: > Except Kconfig and Makefile, all source files for UDF filesystem doesn't > bear SPDX license identifier. Add appropriate license identifier while > replacing boilerplates. > > Cc: Thomas Gleixner > Signed-off-by: Bagas Sanjaya > --- >

[PATCH v4 13/13] DONOTMERGE: arm64: meson: khadas-vim3l: add DSI panel

2023-05-12 Thread Neil Armstrong
This add nodes to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- .../boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 76 ++

[PATCH v4 12/13] arm64: meson: g12-common: add the MIPI DSI nodes

2023-05-12 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git

[PATCH v4 11/13] drm/panel: khadas-ts050: update timings to achieve 60Hz refresh rate

2023-05-12 Thread Neil Armstrong
This updates the panel timings to achieve a clean 60Hz refresh rate. Link: https://lore.kernel.org/r/20221025-ts050-timings-v1-1-5c824bbb2...@linaro.org Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-khadas-ts050.c | 16 1 file changed, 8 insertions(+), 8

[PATCH v4 09/13] drm/meson: add support for MIPI-DSI transceiver

2023-05-12 Thread Neil Armstrong
The Amlogic G12A/G12B/SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on other Amlogic SoCs. This adds support for the Glue managing the transceiver, mimicing the init flow provided by

[PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-12 Thread Neil Armstrong
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on the same Amlogic SoCs. Signed-off-by: Neil Armstrong Signed-off-by: Neil Armstrong ---

[PATCH v4 07/13] drm/meson: venc: add ENCL encoder setup for MIPI-DSI output

2023-05-12 Thread Neil Armstrong
This adds supports for the ENCL encoder connected to a MIPI-DSI transceiver on the Amlogic AXG, G12A, G12B & SM1 SoCs. Signed-off-by: Neil Armstrong Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 25 drivers/gpu/drm/meson/meson_venc.c | 211

[PATCH v4 10/13] phy: amlogic: phy-meson-g12a-mipi-dphy-analog: fix CNTL2_DIF_TX_CTL0 value

2023-05-12 Thread Neil Armstrong
Use the same CNTL2_DIF_TX_CTL0 value used by the vendor, it was reported fixing timings issues. Fixes: 2a56dc650e54 ("phy: amlogic: Add G12A Analog MIPI D-PHY driver") Signed-off-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v4 06/13] drm/meson: fix unbind path if HDMI fails to bind

2023-05-12 Thread Neil Armstrong
If the case the HDMI controller fails to bind, we try to unbind all components before calling drm_dev_put() which makes drm_bridge_detach() crash because unbinding the HDMI controller frees the bridge memory. The solution is the unbind all components at the end like in the remove path.

[PATCH v4 03/13] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-05-12 Thread Neil Armstrong
In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF. The nocache option is removed from following clocks: - vclk2_sel - vclk2_input - vclk2_div - vclk2 - vclk_div1 - vclk2_div2_en - vclk2_div4_en - vclk2_div6_en - vclk2_div12_en - vclk2_div2 - vclk2_div4

[PATCH v4 08/13] drm/meson: add DSI encoder

2023-05-12 Thread Neil Armstrong
This adds an encoder bridge designed to drive a MIPI-DSI display by using the ENCL encoder through the internal MIPI DSI transceiver connected to the output of the ENCL pixel encoder. Signed-off-by: Neil Armstrong Reviewed-by: Jagan Teki Signed-off-by: Neil Armstrong ---

[PATCH v4 05/13] dt-bindings: display: meson-vpu: add third DPI output port

2023-05-12 Thread Neil Armstrong
Add third port corresponding to the ENCL DPI encoder used to connect to DSI or LVDS transceivers. Signed-off-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Reviewed-by: Rob Herring Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml | 5

[PATCH v4 00/13] drm/meson: add support for MIPI DSI Display

2023-05-12 Thread Neil Armstrong
| 3 + 23 files changed, 1428 insertions(+), 35 deletions(-) --- base-commit: ac9a78681b921877518763ba0e89202254349d1b change-id: 20230512-amlogic-v6-4-upstream-dsi-ccf-vim3-b8e5217e1f4a Best regards, -- Neil Armstrong

[PATCH v4 02/13] clk: meson: g12a: add CTS_ENCL & CTS_ENCL_SEL clocks

2023-05-12 Thread Neil Armstrong
Add new CTS_ENCL & CTS_ENCL_SEL clocks for the G12A compatible SoCs, they are used to feed the VPU LCD Pixel encoder used for DSI display purposes. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.c | 40 drivers/clk/meson/g12a.h | 2 +- 2 files

[PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-12 Thread Neil Armstrong
Expose VCLK2_SEL clock id and add new ids for the CTS_ENCL and CTS_ENCL_SEL clocks on G12A compatible SoCs. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.h | 1 - include/dt-bindings/clock/g12a-clkc.h | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3 1/2] drm: Add fixed-point helper to get rounded integer values

2023-05-12 Thread Arthur Grillo Queiroz Cabral
On 12/05/23 07:40, Maíra Canal wrote: > Create a new fixed-point helper to allow us to return the rounded value > of our fixed point value. > > [v2]: > * Create the function drm_fixp2int_round() (Melissa Wen). > [v3]: > * Use drm_fixp2int() instead of shifting manually (Arthur Grillo).

Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Richard Fontana
On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya wrote: > > Replace GPL boilerplate notice on remaining files with appropriate SPDX > tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. > diff --git a/drivers/net/ethernet/8390/ne2k-pci.c > b/drivers/net/ethernet/8390/ne2k-pci.c >

Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
On 5/12/23 17:06, Bagas Sanjaya wrote: > diff --git a/drivers/watchdog/octeon-wdt-nmi.S > b/drivers/watchdog/octeon-wdt-nmi.S > index 97f6eb7b5a8e04..57bb0845de477d 100644 > --- a/drivers/watchdog/octeon-wdt-nmi.S > +++ b/drivers/watchdog/octeon-wdt-nmi.S > @@ -1,8 +1,5 @@ > +/*

Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Guenter Roeck
On Fri, May 12, 2023 at 05:06:19PM +0700, Bagas Sanjaya wrote: > Many watchdog drivers's source files has already SPDX license > identifier, while some remaining doesn't. > > Convert notices on remaining files to SPDX identifier. While at it, > also move SPDX identifier for

Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Richard Fontana
On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya wrote: > diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c > index 504be461f992a9..822bf8905bf3ce 100644 > --- a/drivers/watchdog/sb_wdog.c > +++ b/drivers/watchdog/sb_wdog.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier:

[PATCH] drm/ssd130x: Fix include guard name

2023-05-12 Thread Javier Martinez Canillas
This is a leftover from an early iteration of the driver when it was still named ssd1307 instead of ssd130x. Change it for consistency with the rest. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Thomas Zimmermann
Hi Sam Am 12.05.23 um 12:29 schrieb Sam Ravnborg: Hi Thomas, On Fri, May 12, 2023 at 10:41:41AM +0200, Thomas Zimmermann wrote: DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Andy Shevchenko wrote: > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: >> On Fri, 12 May 2023, Andy Shevchenko >> wrote: >> > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: >> >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to

Re: [PATCH v7 1/7] fbdev/hitfb: Cast I/O offset to address

2023-05-12 Thread Thomas Zimmermann
Hi Am 12.05.23 um 13:16 schrieb David Laight: From: Thomas Zimmermann Sent: 12 May 2023 11:25 Cast I/O offsets to pointers to use them with I/O functions. The I/O functions expect pointers of type 'volatile void __iomem *', but the offsets are plain integers. Build warnings are

[PATCH] drm/i915/gvt: fix typo in comment

2023-05-12 Thread Deming Wang
Spelling mistake (triple letters) in comment. Signed-off-by: Deming Wang --- drivers/gpu/drm/i915/gvt/gvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index 2d65800d8e93..c933e9a1c5ad 100644 ---

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Andy Shevchenko
On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: > On Fri, 12 May 2023, Andy Shevchenko > wrote: > > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > >> masks for fixed-width types and also the

Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Geert Uytterhoeven
Hi Bagas, On Fri, May 12, 2023 at 12:08 PM Bagas Sanjaya wrote: > Replace GPL boilerplate notice on remaining files with appropriate SPDX > tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. > > Cc: David A. Hinds > Cc: Donald Becker > Cc: Peter De Schrijver > Cc: Topi

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Andy Shevchenko wrote: > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create >> masks for fixed-width types and also the corresponding BIT_U32(), >> BIT_U16() and BIT_U8(). > > Why? The main

Re: [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes)

2023-05-12 Thread Greg Kroah-Hartman
On Fri, May 12, 2023 at 05:06:11PM +0700, Bagas Sanjaya wrote: > I trigger this patch series as a response to Didi's GPL full name fix > patches [1], for which all of them had been NAKed. In many cases, the > appropriate correction is to use SPDX license identifier instead. > > Often, when

RE: [PATCH v7 1/7] fbdev/hitfb: Cast I/O offset to address

2023-05-12 Thread David Laight
From: Thomas Zimmermann > Sent: 12 May 2023 11:25 > > Cast I/O offsets to pointers to use them with I/O functions. The I/O > functions expect pointers of type 'volatile void __iomem *', but the > offsets are plain integers. Build warnings are > > ../drivers/video/fbdev/hitfb.c: In function

Re: [PATCH v2 05/10] net: ethernet: i825xx: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Greg Kroah-Hartman
On Fri, May 12, 2023 at 05:06:16PM +0700, Bagas Sanjaya wrote: > Replace unversioned GPL boilerplate notice on remaining i825xx files > with appropriate SPDX identifier. For files that contains "extension to > Linux kernel", use GPL 2.0, otherwise GPL 1.0+. > > Cc: Donald Becker > Cc: Michael

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Andy Shevchenko
On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > masks for fixed-width types and also the corresponding BIT_U32(), > BIT_U16() and BIT_U8(). Why? > All of those depend on a new "U" suffix added to the integer

[PATCH v3 2/2] drm/vkms: Fix RGB565 pixel conversion

2023-05-12 Thread Maíra Canal
Currently, the pixel conversion isn't rounding the fixed-point values before assigning it to the RGB coefficients, which is causing the IGT pixel-format tests to fail. So, use the drm_fixp2int_round() fixed-point helper to round the values when assigning it to the RGB coefficients. Tested with

  1   2   >