Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace direct assignment with set_current_state()

2004-09-16 Thread Keith Whitwell
Nishanth Aravamudan wrote: Any comments would be appreciated. Description: Use set_current_state() instead of direct assignment of current-state. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/drm_os_linux.h 2004-09-09 23:05:38.0

Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace direct assignment with set_current_state()

2004-09-16 Thread Dave Airlie
I'll apply this to my tree and fix up the rest of them in the DRM, and push it to Linus.. Dave. On Wed, 15 Sep 2004, Nishanth Aravamudan wrote: Any comments would be appreciated. Description: Use set_current_state() instead of direct assignment of current-state. Signed-off-by: Nishanth

Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace direct assignment with set_current_state()

2004-09-16 Thread Alan Cox
On Iau, 2004-09-16 at 12:00, Dave Airlie wrote: I'll apply this to my tree and fix up the rest of them in the DRM, and push it to Linus.. Use __set_current_state() for these. set_current_state also includes a memory barrier (ie its designed to be safe for all uses) while the DRI code is already

Re: Savage DRI merged to xorg

2004-09-16 Thread Alex Deucher
On Thu, 16 Sep 2004 02:03:20 +0100, Sérgio Monteiro Basto [EMAIL PROTECTED] wrote: On Tue, 2004-09-14 at 14:43, Alex Deucher wrote: I'm working on a major rework of the savage driver to address Xv and several other features (dvi support, dualhead, etc.). Alex Cool when I can starting to

[PATCH 2.6.9-rc2 3/33] char/drm_os_linux: replace direct assignment with set_current_state()

2004-09-16 Thread Nishanth Aravamudan
Re-submission of patch incorporating Alan Cox's suggestion of using __set_current_state() and changing the other direct assignment in the macro. Thanks, Nish Description: Use set_current_state() instead of direct assignment of current-state. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED]

[PATCH 2.6.9-rc2 11/33] char/i830_irq: replace schedule_timeout() with msleep_interruptible()

2004-09-16 Thread Nishanth Aravamudan
Any comments would be appreciated. Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/i830_irq.c 2004-09-09 23:05:37.0 -0700

DRM dynamic minors patch

2004-09-16 Thread Jon Smirl
I just resubmitted the DRM dynamics minors patch to CVS. Can someone with a i810/830 see if it works? I think I have the code right but I don't own those chips to check. If glxgears runs that's enough to check the changes I made. Other cards should be ok, i810/830 does things differently than the

Re: DRM dynamic minors patch

2004-09-16 Thread Ian Romanick
Jon Smirl wrote: I just resubmitted the DRM dynamics minors patch to CVS. Can someone with a i810/830 see if it works? I think I have the code right but I don't own those chips to check. If glxgears runs that's enough to check the changes I made. Other cards should be ok, i810/830 does things

Permanent maps and hardware detection

2004-09-16 Thread Felix Kühling
Hi Jon, I'm going to start writing the code for permanent maps in the Savage driver now. I'm becoming aware of the practical problems now and I'd like to know if my understanding is correct so far. The first problem I have is that I need to find out the size of the video memory in order to

Re: [R300] card types

2004-09-16 Thread Adam K Kirchhoff
Vladimir Dergachev wrote: I have just committed code into r300_demo that will autodetect chip type and display width. I would ask everyone who tried out (or tried to try out) patches from r300.sourceforge.net to let me know whether they could run it successfully or not. The most recent source

Re: Permanent maps and hardware detection

2004-09-16 Thread Mike Mestnik
--- Felix Kühling [EMAIL PROTECTED] wrote: Hi Jon, I'm going to start writing the code for permanent maps in the Savage driver now. I'm becoming aware of the practical problems now and I'd like to know if my understanding is correct so far. The first problem I have is that I need to

Re: [R300] card types

2004-09-16 Thread Vladimir Dergachev
r300 from cvs now works on my R350 card (Radeon 9800)... If anyone is interested: Cool ! I'll add your card's id to the CVS as well as make a new patch for drm driver that includes all know R300, R350 and RV350 ids. best Vladimir Dergachev

Re: Savage DRI merged to xorg

2004-09-16 Thread Alex Deucher
On Thu, 16 Sep 2004 09:17:52 -0400, Alex Deucher [EMAIL PROTECTED] wrote: On Thu, 16 Sep 2004 02:03:20 +0100, Sérgio Monteiro Basto [EMAIL PROTECTED] wrote: On Tue, 2004-09-14 at 14:43, Alex Deucher wrote: I'm working on a major rework of the savage driver to address Xv and several

Re: Permanent maps and hardware detection

2004-09-16 Thread Jon Smirl
The plan here is to slowly get X out of the hardware initialization business. Anything that is playing with registers from user space needs to be migrated into the drivers. Another factor is the desire to slowly get X into a position where it doesn't need to run as root. As long as X plays with

Re: Savage DRI DDX to xorg merged

2004-09-16 Thread Ryan Underwood
On Tue, Sep 14, 2004 at 12:26:22AM -0400, Alex Deucher wrote: Savage dri works quite well (again) on xorg 6.8, except on xv video mode with some mpegs, as I reported at first time. I'm working on a major rework of the savage driver to address Xv and several other features (dvi support,

Re: Savage DRI DDX to xorg merged

2004-09-16 Thread Alex Deucher
On Thu, 16 Sep 2004 21:09:23 -0500, Ryan Underwood [EMAIL PROTECTED] wrote: On Tue, Sep 14, 2004 at 12:26:22AM -0400, Alex Deucher wrote: Savage dri works quite well (again) on xorg 6.8, except on xv video mode with some mpegs, as I reported at first time. I'm working on a major

DRM radeon i2c support and GPL

2004-09-16 Thread Jon Smirl
I just checked a small change into DRM CVS that adds sysfs i2c support to the linux radeon driver. The patch includes some GPL licensed code extracted from the Linux kernel. The GPL files are only in the drm/linux directory. No GPL code was added to drm/shared or drm/bsd so the BSD build does not

Re: DRM radeon i2c support and GPL

2004-09-16 Thread Jon Smirl
You need i2c and eeprom kernel modules loaded in order to see the EDID data. [EMAIL PROTECTED] 3-0050]$ hexdump -C /sys/class/drm/card0/device/i2c-3/3-0050/eeprom 00 ff ff ff ff ff ff 00 5a 63 47 55 01 01 01 01 |ZcGU| 0010 18 0b 01 03 08 1e 17 50 ea 6d 8c 98 59 50

Re: DRM dynamic minors patch

2004-09-16 Thread Jon Smirl
If it fails the problem will mostly likely be with the special case handing of the fops pointer in the i810/830 drivers. That should narrow down any debugging. On Thu, 16 Sep 2004 12:20:33 -0700, Ian Romanick [EMAIL PROTECTED] wrote: Jon Smirl wrote: I just resubmitted the DRM dynamics

Re: DRM radeon i2c support and GPL

2004-09-16 Thread Jon Smirl
The patch is also an example of using permanent maps and enabling MMIO from the driver. -- Jon Smirl [EMAIL PROTECTED] --- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE

Re: [PATCH 2.6.9-rc2 11/33] char/i830_irq: replace schedule_timeout() with msleep_interruptible()

2004-09-16 Thread Jon Smirl
schedule_timeout() is also used in DRM_WAIT_ON() in drm_os_linux.h Does it need to be adjusted too? #define DRM_WAIT_ON( ret, queue, timeout, condition ) \ do {\ DECLARE_WAITQUEUE(entry, current);