the patch somehow
3) replace the origianl patch in the (saved) mail
4) git reset --hard (or patch -p1 -R < saved-mail)
5) git am
There must be easier ways to do so I think.
But the above is what my fingers know to do so I do it
routinely.
Sam
-
On Mon, Dec 15, 2008 at 10:26:27PM +0100, Thomas Hellström wrote:
> Hi!
>
> Sam Ravnborg wrote:
> >On Sun, Dec 14, 2008 at 04:57:34PM +0100, Thomas Hellström wrote:
> >
> >>Hi!
> >>
> >>The intention is for via_drm.h to be self-containing when
-existing file I suggest
that we get this fixed in some way soon.
Sam
--
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to h
Hi David et al.
After improving the headers_check.pl script to do a
check for files included with:
#include "foo.h"
it reported the following error:
/home/sam/kernel/knext.git/usr/include/drm/via_drm.h:34: included file
'/home/sam/kernel/knext.git/usr/include/drm/via_
ct that a lot of these files are
> shared with other OSes upstream and I'd rather not diverge too far but
> maybe later.
Understood.
To be sure you did not miss it...
At least change EXTRA_CFLAGS to ccflags-y.
Sam
--
On Thu, May 29, 2008 at 10:46:22AM +1000, Dave Airlie wrote:
> Hi,
>
> So I've been growing more annoyed with the current layout of the drm
> tree in the kernel,
>
> a) it lives under char.
> b) everything in one directory.
> c) header files in one directory.
> d) no header files exposed to users
t a big deal to maintain - only a small diff to latest kernel tree.
Sam
---
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://
t; basically what the DRM does, but we have the evil macros (no, I don't
> like them either) to prevent the symbol conflicts.
Took a closer look on libata - I was wrong.
libata does indeed use a layered module approch as you hinted.
Sorry for the noise - but thanks for the clarific
On Wed, Sep 01, 2004 at 01:42:17PM -0700, Ian Romanick wrote:
> Sam Ravnborg wrote:
> >On Wed, Sep 01, 2004 at 09:33:05AM -0700, Ian Romanick wrote:
> >>Jon Smirl wrote:
> >>
> >>>Why don't we just address the real problem and split DRM into
> >&g
ailed description of a show-stopper problem with the separate
> library idea. Until somebody can post a solution to that problem,
> PLEASE STOP SUGGESTING IT.
I'm just so stupid I cannot see why DRM is special compared to sata :-(
Sam
's how the main
> kernel folks would want it done, though.
I have not looked into this in detail.
But I fail to see how DRM are different than for example lib-sata,
that do not play all these tricks.
Sam
---
This SF.Net emai
On Sat, Aug 28, 2004 at 04:17:32PM -0700, Jon Smirl wrote:
> I'm just starting to look at the bug, but the code involved has been
> rewritten in a patch that isn't checked in yet. You might want to give
> the new code a try.
Hi Jon - a few comments.
Sam
> -
>
On Fri, Aug 20, 2004 at 07:48:44PM +0100, Keith Whitwell wrote:
> Sam Ravnborg wrote:
> >On Thu, Aug 19, 2004 at 03:26:07PM -0700, Erdi Chen wrote:
> >
> >>This patch adds two new ioctl's to the VIA Unichrome/Pro DRM driver:
> >>DRM_IOCTL_VIA_DM
> code) to pad the buffer to meet alignment requirement.
Maybe include/linux/kernel-h - ALIGN is usefull here?
Sam
---
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk
used in several places.
11) via_drm.h
- Drop typedef of drm_via_dma_init
- Linux style is to _not_ hide when you work with a struct
- Same for drm_via_cmdbuffer_t
12) Comment about typedef is also valid for via_drv.h
13) unsigned int dmaLow
han one place.
> >
> I might do something like that alright.. looks nicer...
>
> > 4) Use #ifdef, not #if defined()
> > 5) Why not post the diff, makes it _much_ easier to reply wtih code comments.
>
> I'll probably start doing t
return (feature & DRIVER_USE_MTRR) != 0;
}
#else
static inline int driver_has_mtrr(...)
{
return 0;
}
#endif
This check seems to be used more than one place.
4) Use #ifdef, not #if defined()
5) Why not post the diff, makes it _much_ easier to reply wtih code comments.
Sam
ymbol conflicts when the OS exports
> >all symbols?
>
> Is that even the case if multiple DRM drivers are built into the kernel?
Functions that is not exported shall be declared static.
static seems not to be overused ATM...
Sam
-
i got this warning
in /var/log/XFree86.0.log:--(WW) RADEON(0): [dri] RADEONDRITransitionTo2d: kernel failed to unflip
buffers.--But if i
use the system close button, everything is going fine, but is this error is
harmless or not ?
Thanks for any help.
Sam._
19 matches
Mail list logo
