On Sat, Aug 28, 2004 at 04:17:32PM -0700, Jon Smirl wrote: > I'm just starting to look at the bug, but the code involved has been > rewritten in a patch that isn't checked in yet. You might want to give > the new code a try.
Hi Jon - a few comments. Sam > - > #ifndef MODULE > /** Use an additional macro to avoid preprocessor troubles */ > #define DRM_OPTIONS_FUNC DRM(options) > @@ -93,9 +82,6 @@ > #undef DRM_OPTIONS_FUNC > #endif As a general rule - if you need to check for MODULE you are usually doing something wrong... > static struct pci_driver drm_driver = { > .name = DRIVER_NAME, > .id_table = DRM(pciidlist), > - .probe = drm_probe, > + .probe = DRM(probe), > .remove = __devexit_p(drm_cleanup_pci), > }; Introduces use of DRM()? > > +#ifdef MODULE > +static char *drm_opts = NULL; > +#endif > +MODULE_PARM( drm_opts, "s" ); > + You are better off using module_param() here. > /** > * Module initialization. Called via init_module at module load time, or via > * linux/init/main.c (this is not currently supported). > @@ -641,7 +601,7 @@ > /* pass back in pdev to account for multiple identical cards */ > while ((pdev = pci_get_subsys(pid->vendor, pid->device, > pid->subvendor, pid->subdevice, pdev))) { > /* stealth mode requires a manual probe */ > - drm_probe(pdev, &DRM(pciidlist[i])); > + DRM(probe)(pdev, &DRM(pciidlist[i])); Introducing DRM() again? > #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,0) > -static int drm_hotplug (struct class_device *dev, char **envp, int num_envp, > +static int drm_hotplug (struct class_device *cdev, char **envp, int num_envp, > char *buffer, int buffer_size) > { Get rid of space after hotplug. ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel