Re: R300 cleanup questions

2007-05-15 Thread Keith Whitwell
Keith Whitwell wrote: > Oliver McFadden wrote: >> I'd like some input on the VBO stuff in r300. In r300_context.h we have the >> following. >> >> /* KW: Disable this code. Driver should hook into vbo module >> * directly, see i965 driver for example. >> */ >> /* #define RADEON_VTXFMT_A */ >> #if

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Done. On 5/9/07, Brian Paul <[EMAIL PROTECTED]> wrote: > If it's just dead code removal, go ahead. > > -Brian > > Oliver McFadden wrote: > > Well both Keith and Jerome are okay with me removing the VTXFMT code, so > > I'll go > > ahead and do that. > > > > I don't think there is any serious risk a

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
If it's just dead code removal, go ahead. -Brian Oliver McFadden wrote: > Well both Keith and Jerome are okay with me removing the VTXFMT code, so > I'll go > ahead and do that. > > I don't think there is any serious risk as I'm only removing code that is > already disabled. :) Brian, let me kn

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Well both Keith and Jerome are okay with me removing the VTXFMT code, so I'll go ahead and do that. I don't think there is any serious risk as I'm only removing code that is already disabled. :) Brian, let me know if you want to make a branch so I know when I can push. On 5/9/07, Brian Paul <[EM

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
Oliver McFadden wrote: > I also think we might need to add _dri_warning/_dri_error because the _mesa > versions output "Mesa warning: %s" which implies to the user this is a Mesa > problem, not a DRI driver problem. > > I could add r300Warning and r300Error, but probably all DRI drivers need > wa

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
Oliver McFadden wrote: > I'd like some input on the VBO stuff in r300. In r300_context.h we have the > following. > > /* KW: Disable this code. Driver should hook into vbo module > * directly, see i965 driver for example. > */ > /* #define RADEON_VTXFMT_A */ > #ifdef RADEON_VTXFMT_A > #define HW_

Re: R300 cleanup questions

2007-05-09 Thread Keith Whitwell
Oliver McFadden wrote: > I'd like some input on the VBO stuff in r300. In r300_context.h we have the > following. > > /* KW: Disable this code. Driver should hook into vbo module > * directly, see i965 driver for example. > */ > /* #define RADEON_VTXFMT_A */ > #ifdef RADEON_VTXFMT_A > #define H

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Here is the patch. On 5/9/07, Oliver McFadden <[EMAIL PROTECTED]> wrote: I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A */ #ifdef RADEON_VTXFMT_A #define HW_VBOS #endif So the VTXFMT (radeon_vtxf

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
I also think we might need to add _dri_warning/_dri_error because the _mesa versions output "Mesa warning: %s" which implies to the user this is a Mesa problem, not a DRI driver problem. I could add r300Warning and r300Error, but probably all DRI drivers need warning and error functions... So mayb

Re: R300 cleanup questions

2007-05-09 Thread Oliver McFadden
Hi, I added the "not implemented yet" comment back, although there are other places that use 65535 so it could be some kind of hardware limit... The only reason that I went with "camel case" r300FooBar names is because that's what 90% of the driver uses; it's easier to change a few r300_foo_bar t

Re: R300 cleanup questions

2007-05-09 Thread Brian Paul
Jerome Glisse wrote: > On 5/8/07, Christoph Brill <[EMAIL PROTECTED]> wrote: >> I reviewed the cleanup done by Olliver McFadden and had the following >> questions: >> >> -int r300_get_num_verts(r300ContextPtr rmesa, int num_verts, int prim) >> +static int r300NumVerts(r300ContextPtr rmesa, int num_

Re: R300 cleanup questions

2007-05-09 Thread Jerome Glisse
On 5/8/07, Christoph Brill <[EMAIL PROTECTED]> wrote: > I reviewed the cleanup done by Olliver McFadden and had the following > questions: > > -int r300_get_num_verts(r300ContextPtr rmesa, int num_verts, int prim) > +static int r300NumVerts(r300ContextPtr rmesa, int num_verts, int prim) > > Is it n

R300 cleanup questions

2007-05-08 Thread Christoph Brill
I reviewed the cleanup done by Olliver McFadden and had the following questions: -int r300_get_num_verts(r300ContextPtr rmesa, int num_verts, int prim) +static int r300NumVerts(r300ContextPtr rmesa, int num_verts, int prim) Is it necessary/usefull that the function is static? -/* Immediate impl